c545350633
Reland: [promises] Compression filter conversion ( #31686 )
...
* Revert "Revert "[promises] Compression filter conversion (#31204 )" (#31682 )"
This reverts commit fa31b36cb1
2022-11-17 14:08:43 -08:00
fa31b36cb1
Revert "[promises] Compression filter conversion ( #31204 )" ( #31682 )
...
This reverts commit a8c983528a
2022-11-16 17:01:11 -08:00
a8c983528a
[promises] Compression filter conversion ( #31204 )
...
* Convert compress filter
* decompress sketch
* Automated change: Fix sanity tests
* progress
* progress
* got the new filter impls compiling
* Automated change: Fix sanity tests
* declare the bits
* allocate control types
* stub in pipe accessors
* init pipes
* send-path
* working through the state machines
* [arena] pool allocator
* add tests
* Automated change: Fix sanity tests
* better sizes
* iwyu
* Automated change: Fix sanity tests
* first pass cut fragments
* fix1
* fix
* Automated change: Fix sanity tests
* fix
* iwyu
* build-deps
* fix for windows
* fix
* fixes
* better-logs
* better-logs
* callpushpush-->tryconcurrently
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* logging improvements
* logging improvements
* fixes
* Automated change: Fix sanity tests
* respect flag
* handle eos
* cancel_after_client_done
* handle failed sends
* more error handling
* Automated change: Fix sanity tests
* more stuff
* remove unnecessary conversion
* hackity hack hack
* fixes
* progress
* Automated change: Fix sanity tests
* capture metadata from promise to recieve up
* spacing
* debug,fix
* not-used
* fix
* fix
* tune
* unify compress/decompress
* fixes
* send_message/send_trailing_metadata ordering
* cleanup loop
* remove minimal stack bits
* better error generation
* fix-build
* Automated change: Fix sanity tests
* cancellation of recv message for forwarded receives
* fix
* compile fix
* fix clobbering
* fix test, convert to gtest
* fix
* Automated change: Fix sanity tests
* cleanup
* fixes
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* add test
* Automated change: Fix sanity tests
* fix
* fix
* fix
* no need to store message per filter
* Automated change: Fix sanity tests
* danke yash
* iwyu
* clang-tidy
* Automated change: Fix sanity tests
* fix
* [promise] CallPushPull -> more general TryConcurrently
* Automated change: Fix sanity tests
* [promise] Introduce map_pipe, cleanup factories
* [promise] Promise based filter changes for messages
* [log] Longer space for filenames
* [test] Add some debugability affordances to async_end2end_test
* add comment
* Automated change: Fix sanity tests
* fix-merge
* fix-merge
* fix
* [chttp2] Fix a bug whereby trailers-only is not reported
We don't report trailers-only if the trailers are parsed prior to executing recv_initial_metadata
* comments
* fix for ruby
* review feedback
* merge
* fix
* Automated change: Fix sanity tests
* fix bm?
* re-add dropped flag
* turn on some traces to try and debug ruby
* debug for ruby problem
* proposed chttp2 fix
* Revert "turn on some traces to try and debug ruby"
This reverts commit 1bf3cfd552
2022-11-15 20:16:18 -08:00
3ef817b3bf
Clean up the TODO item in build target `grpc_base` -- part `slice` ( #31003 )
...
* Clean up the TODO item in build target `grpc_base` part `slice`
* Automated change: Fix sanity tests
2022-11-15 13:47:27 -05:00
47b9a57de9
Remove `g_glip` and `class GrpcLibraryInterface` ( #30414 )
...
* Remove `g_glip` and `class GrpcLibraryInterface`
* Update
* Update
* Update
* Automated change: Fix sanity tests (#20 )
* Update
* Update
* Update
* Test
* Fix
* Revert "Test"
This reverts commit 2f5c77e98d1ee3ae4da11fc234896b851393c0e6ed342a51d0286ad8e639
2022-11-14 15:30:09 -05:00
250f9fc026
Revived google-readability-casting ( #31607 )
...
* Added google-readability-casting
* Fix
* Use brace init for constants
* more
* Fix
* Fix 2
* More fix
* Fixf
2022-11-11 16:44:37 -08:00
cbbadf5714
Relax the benchmarks' default minimum execution time ( #31479 )
2022-10-27 10:41:16 -07:00
05ab5c08a4
Reland "Precondition ChannelArgs with EventEngines ( #31166 )" ( #31469 )
...
This reverts commit a63c81135c
2022-10-26 14:52:59 -07:00
a63c81135c
Revert "Precondition ChannelArgs with EventEngines ( #31166 )" ( #31462 )
...
This reverts commit 23c7e48779
2022-10-25 16:41:48 -07:00
23c7e48779
Precondition ChannelArgs with EventEngines ( #31166 )
...
* Precondition ChannelArgs with EventEngines
If an EventEngine is not explicitly provided to ChannelArgs, the default
EventEngine will be set when ChannelArgs are preconditioned.
* channel_idle_filter: EE from channel_args
* grpclb: EE from channel_args
* weighted_target: ee from channel_args
* sanitize
* xds cluster manager
* posix native resolver: own an EE ref from iomgr initialization
* reviewer feedback
* reviewer feedback
* iwyu
* iwyu
* change ownership and remove unneeded methods
* clang_format and use consistent engine naming
* store EE ref in channel_stack and use it in channel idle filter
* don't store a separate shared_ptr in NativeDNSResolver
* add GetEventEngine() method to LB policy helper interface
* stop holding refs to the EE instance in LB policies
* clang-format
* change channel stack to get EE instance from channel args
* update XdsWrrLocalityLb
* fix lb_policy_test
* precondition channel_args in ServerBuilder and microbenchmark fixtures
* add required engine to channel_stack test
* sanitize
* dep fix
* add EE to filter fuzzer
* precondition BM_IsolatedFilter channelargs
* fix
* remove unused using statement
* iwyu again??
* remove preconditioning from C++ surface API
* fix bm_call_create
* Automated change: Fix sanity tests
* iwyu
* rm this->
* rm unused deps
* add internal EE arg macro
* precondition filter_fuzzer
* Automated change: Fix sanity tests
* iwyu
* ChannelStackBuilder requires preconditioned ChannelArgs
* iwyu
* iwyu again?
* rm build.SetChannelArgs; rm unused declaration
* fix nullptr string creation
Co-authored-by: Mark D. Roth <roth@google.com>
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-10-25 14:49:59 -07:00
99aa924a5c
Use minimal benchmark time for bm_event_engine_run in CI ( #31440 )
2022-10-24 11:15:44 -07:00
8b4c4fc47d
ThreadPool benchmarks ( #31419 )
...
* ThreadPool benchmarks
These are nearly identical to the EventEngine benchmarks at the moment. We can consider removing the redundant tests from the EventEngine code and focusing on EventEngine-specific things (e.g., timer cancellation)
* rm unused header
* rm leak
* fix: moved dependencies
2022-10-21 10:56:09 -07:00
5f6c357e74
Move some targets from //: to //src/core: ( #31402 )
...
* temp
* temp
* temp
* top BUILD builds
* everything builds
* buildify
* temp fix_build_deps change
* fix gpr_atm
* additional changes
* fix build files
* nofixdeps
* Generate projects
* json_args
* fix context
* Generate projects
* Sprinkle some avoid_dep tags
* Run fix_build_deps
* Remove additional avoid_dep
* Revert some targets
* grpc_mock_cel
2022-10-20 20:12:53 -07:00
e8c30b487f
Invoking Poller::Work in posix event engine constructor ( #31128 )
...
* adding Poller::Work to event engine constructor
* iwyu
* iwyu
* cleanup
* regenerate projects
* fix
* comments
* add experiments flag
* fix
* newline
* newline
* iwyu
* remove some ifdefs
* fix tsan issue in bm_event_engine_run
* Add a quiesce to threadpool
* fix
* Automated change: Fix sanity tests
* disable posix_event_engine_test on windows
Co-authored-by: Craig Tiller <ctiller@google.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-10-19 23:25:04 -07:00
d1bce5c868
reduce test size ( #31345 )
2022-10-13 11:58:55 -07:00
20d1efc38a
[stats] Move core stats to C++ ( #30936 )
...
* begin c++
* Automated change: Fix sanity tests
* progress
* progress
* missing-files
* Automated change: Fix sanity tests
* moved-from-stats
* remove old benchmark cruft, get tests compiling
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* add needed constructor
* Automated change: Fix sanity tests
* iwyu
* fix
* fix?
* fix
* fix
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* add visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: AJ Heller <hork@google.com>
2022-10-09 21:22:08 -07:00
afa3a6c890
[event_engine] Fix for the EE/iomgr shutdown ordering problem ( #31265 )
...
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* init/shutdown in event engine for now
* fix
* fix
* fix windows deadlock
* Automated change: Fix sanity tests
* fix
* better windows fix
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-10-07 21:35:49 -07:00
2d00d50c59
[event_engine] Improve scaling in threadpool ( #31234 )
...
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fixes
* fixes
* fix
* fix-win
* fix iwyu
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-10-05 00:17:23 -07:00
4bd27c524a
More changes ( #31194 )
2022-09-30 17:10:01 -07:00
a23eae84c9
Revert "[flakes] Update flakiness ( #31121 )" ( #31173 )
...
This reverts commit bdc799af73
2022-09-29 14:06:44 -07:00
bdc799af73
[flakes] Update flakiness ( #31121 )
...
* update
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-29 11:04:22 -07:00
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2022-09-28 08:39:56 -07:00
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2022-09-27 23:17:39 -07:00
a874b8f6ca
EventEngine::Run microbenchmarks ( #30769 )
...
* [WIP] EventEngine::Run microbenchmarks
* Add fanout impl and fix tracking of time spent doing work in threads
* tune down benchmarks; fix fanout counting logic.
* tune down closure fanout tests
* format
* odr
* reviewer feedback
* unify some fanout logic; add a large-AnyInvocable test
lambdas that take an allocation are about 10x slower
* reviewer feedback
* fix invalid vector access
* rm DNS
* format
* copy params for each lambda callback
This fixes segfaults when we cannot ensure all callbacks are complete
before exiting the test.
* s/promise/Notification/g bm_exec_ctx
* ODR and leak
* fix division by zero
* fix
2022-09-27 14:57:36 -07:00
ba8af0157b
Removing GRPC_ERROR_[REF|UNREF|IS_NONE] ( #31089 )
...
* Removing GRPC_ERROR_[REF|UNREF|IS_NONE]
* Clean up unnecessary error
* Fix
* Fix2
* Remove unnecessary else
2022-09-26 15:41:12 -07:00
ebc4f236b6
[slice] Remove _internal variants of APIs ( #30953 )
...
* [slice] Remove _internal variants of APIs
* Automated change: Fix sanity tests
* fix
* reduce bloat
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-24 13:34:00 -07:00
32b43f0168
[channel_args] Make channel_stack_init take new type ( #30841 )
...
* [channel_args] Make channel_stack_init take new type
* fix
* fix
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-23 11:31:03 -07:00
fb14fdf0e0
Performant thread-safe Work Queue ( #30821 )
...
* WorkQueue
* weaken the large obj stress test for Windows; documentation
* update comment
* Add WorkQueue microbenchmark. Results below ...
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_WorkQueueIntptrPopFront/1 297 ns 297 ns 2343500 items_per_second=3.3679M/s
BM_WorkQueueIntptrPopFront/8 7022 ns 7020 ns 99356 items_per_second=1.13956M/s
BM_WorkQueueIntptrPopFront/64 59606 ns 59590 ns 11770 items_per_second=1074k/s
BM_WorkQueueIntptrPopFront/512 477867 ns 477748 ns 1469 items_per_second=1071.7k/s
BM_WorkQueueIntptrPopFront/4096 3815786 ns 3814925 ns 184 items_per_second=1073.68k/s
I0902 19:05:22.138022069 12 test_config.cc:194] TestEnvironment ends
================================================================================
* use int64_t for times. 0 performance change
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_WorkQueueIntptrPopFront/1 277 ns 277 ns 2450292 items_per_second=3.60967M/s
BM_WorkQueueIntptrPopFront/8 6718 ns 6716 ns 105497 items_per_second=1.19126M/s
BM_WorkQueueIntptrPopFront/64 56428 ns 56401 ns 12268 items_per_second=1.13474M/s
BM_WorkQueueIntptrPopFront/512 458953 ns 458817 ns 1550 items_per_second=1.11591M/s
BM_WorkQueueIntptrPopFront/4096 3686357 ns 3685120 ns 191 items_per_second=1.1115M/s
I0902 19:25:31.549382949 12 test_config.cc:194] TestEnvironment ends
================================================================================
* add PopBack tests: same performance profile exactly
* use Mutex instead of Spinlock
It's safer, and so far equally performant in benchmarks of opt builds
* add deque test for comparison. It is faster on all tests.
* Add sparsely-populated multi-threaded benchmarks.
* fix
* fix
* refactor to help thread safety analysis
* Specialize WorkQueue for Closure*s and AnyInvocables
* remove unused callback storage
* add single-threaded benchmark for closure vs invocable
* sanitize
* missing include
* move bm_work_queue to microbenchmarks so it isn't exported
* s/workqueue/work_queue/g
* use nullptr instead of optionals for popped closures
* reviewer test suggestion
* private things are private
* add a work_queue fuzzer
Ran for 10 minutes @ 42 jobs @ 42 workers. Zero failures.
Checked in a selection of 100 good seeds after merging the thousands of
results.
* fix
* fix header guards
* nuke the corpora
* feedback
* sanitize
* Timestamp::Now
* fix
* fuzzers do not work on windows
* windows does not like multithreaded benchmark tests
2022-09-23 09:10:42 -07:00
1ad4bbe78e
Revert "fix ( #31018 )" ( #31021 )
...
This reverts commit 2e6f268dfc
2022-09-21 09:28:28 -07:00
2e6f268dfc
fix ( #31018 )
2022-09-16 12:41:08 -07:00
96f5cddb5f
[time] Introduce time sources ( #30815 )
...
* [time] Introduce time sources
* make import trivial
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* review feedback
* fix
* Automated change: Fix sanity tests
* ios fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-15 21:41:04 -07:00
92f58c18a8
Revert "Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )" ( #30962 )
...
This reverts commit bfea47093f
2022-09-13 13:16:55 -07:00
bfea47093f
Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )
...
This reverts commit 6c7f921f5f
2022-09-13 12:25:00 -07:00
6c7f921f5f
[chttp2] Improve huffman decode efficiency ( #30479 )
...
* first pass
* refinement #1
* fix
* opt
* 8
* 5
* 12
* 10
* 7
* 15
* 8n
* 15n
* 8a
* 16a
* 15a
* 5a
* 10a
* 7a
* 9a
* 12a
* 11a
* 11b
* 11b
* 7b
* 15b
* 14b
* 15i
* 12i
* 9i
* 10i
* finalizing
* fix
* tweak
* 10f
* 10r
* 7r
* 8r
* 9r
* more
* rething
* 8s
* 9s
* 12s
* 7s
* 10s
* 15snr
* 12snr
* 14snr
* 13snr
* 11snr
* 20snr
* 15snr
* 18snr
* 7snr
* 7snr
* 12-2stp
* 13-2stp
* 14-2stp
* 11-2stp
* 10-2stp
* 9-3stp
* 8-3stp
* 7-3stp
* 8-2stp
* auto-tune1
* max-depth-2
* max-depth-3
* max-depth-2
* abbreviate
* working version
* add benchmark
* fix
* fix
* fix
* ditch define
* better code layout
* static fns
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix build
* cleanup and comment
* fmt
* fix
* test
* tag
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* progress
* progress
* progress
* fixes
* cleanup
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fmt
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* add encode/decode fuzzer
* Automated change: Fix sanity tests
* fix
* fix
* fix
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-13 11:24:35 -07:00
622dd886e6
Update flaky tests list ( #30771 )
...
* Update flaky tests list
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-30 21:42:59 -07:00
6746f670c1
[cleanup] Remove low level counters ( #30611 )
...
* [cleanup] Remove low level counters
* clean up code
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-30 21:13:15 -07:00
004788af3d
[cleanup] Remove profiling timers ( #30779 )
...
* [cleanup] Remove profiling timers
- nobody has used this system in years
- if we needed it, we'd probably rewrite it at this point to be something more modern
- let's remove it until that need arises
* fix
* fixes
2022-08-30 13:40:08 -07:00
5b6dac02ac
[stats] Cleanup & re-enable stats system ( #30610 )
...
* [stats] Cleanup stats system
* clear out optionality
* fix
* might as well...
* Automated change: Fix sanity tests
* clean out more unused stuff
* clean out more unused stuff
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-26 10:18:06 -07:00
93fb6add2a
[fixit] Reduce the size of this benchmark under expensive sanitizers ( #30715 )
2022-08-23 13:48:05 -07:00
f573fd44f9
[test] Semi-automatic flaky test tracking ( #30638 )
...
* [test] Semi-automatic flaky test tracking
* fix
* Automated change: Fix sanity tests
* Update update_flakes.py
* fix formatting
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-19 16:22:31 -07:00
05e6bf2e4a
[build] Add test/core/util, test/core/event_engine to auto build deps ( #30364 )
...
* [build] Add test/core/util, test/core/event_engine to auto build deps
* deal with suppressions
* fix suppressions
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* progress
* Automated change: Fix sanity tests
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-25 21:59:25 -07:00
f5bb60d8e8
[channel_args] Improve comparison performance ( #30322 )
...
* [channel_args] Improve comparison performance
* fix
* Automated change: Fix sanity tests
* faster still
* fix
* fix
* some no cost boosts if they get hit
* fix
* final tweak for pointers
* check
* fix
* Automated change: Fix sanity tests
* fix
* ugh
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-19 15:40:09 -07:00
d7e6878ec4
[chttp2] use new channel args type ( #30252 )
...
* x
* x
* Automated change: Fix sanity tests
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-10 22:43:44 -07:00
1b5295a4a2
[iomgr] Remove executor/...
...
I've tried this before in #27445 and we found some internal usage of this code. Today I can find no such usage, so let's try again.
2022-07-08 12:07:36 -07:00
d304712f64
[channel_args] Spread grpc_core::ChannelArgs through client channel code ( #30008 )
...
* [channel_args] Spread grpc_core::ChannelArgs through client channel code
* progress
* progress
* grpc compiles
* uniqueptr+compiles
* fix
* fix
* fix
* fix
* fix
* fix
* fixes
* fix
* fix
* fixes
* fix-lb
* fix
* fix up arg construction
* fix
* fix
* fix
* fix
* move to const& to save bytes
* fix
* fix
* progress
* review feedback
* fix
* fix
* fixes
* fixes
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* debug-helper
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-07 19:19:11 -07:00
eb5ae61470
Reland (again) bytestream removal ( #29987 )
...
* Revert "Revert "Reland bytestream removal (#29911 )" (#29964 )"
This reverts commit e6c6840db3
2022-06-27 21:21:23 -07:00
03dcd61068
[iomgr] Second take for iomgr shutdown ( #30101 )
...
* better api for ee up/down
* fixes
* mac fix
* review feedback
* nuke bm_cq_multiple_threads
* Revert "nuke bm_cq_multiple_threads"
This reverts commit dcda194a42
2022-06-24 13:36:59 -07:00
e6c6840db3
Revert "Reland bytestream removal ( #29911 )" ( #29964 )
...
* Revert "Reland bytestream removal (#29911 )"
This reverts commit 98dcba2807
2022-06-09 08:51:06 -07:00
c6ebbb5482
Added GRPC_ERROR_IS_NONE ( #29937 )
...
* Added GRPC_ERROR_IS_NONE
* Convert
* Fix
2022-06-08 11:24:20 -07:00
98dcba2807
Reland bytestream removal ( #29911 )
...
* Revert "Revert "Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )" (#29894 )" (#29910 )"
This reverts commit 713a1581d5
2022-06-05 18:42:28 -07:00
713a1581d5
Revert "Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )" ( #29910 )
...
This reverts commit 93cdc8b77e
2022-06-05 11:01:48 -07:00
93cdc8b77e
Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )
...
* Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )"
This reverts commit d53986657f
2022-06-04 15:51:16 -07:00
d53986657f
Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )
...
This reverts commit aacf0e252b
2022-06-02 19:34:49 -07:00
aacf0e252b
[transport] Remove ByteStream ( #29637 )
...
* A starter SliceBuffer implementation
* Add comments and fix sanity checks
* Minor fixes
* more minor fixes
* Addressing review comments and adding a slice_buffer_test
* fix sanity checks
* regenerate projects
* fixing undefined function error
* reverting changes from memory_allocator.cc and adding them to src/core/lib/slice/slice_buffer.cc to allow memory allocator lib to build correctly
* fix sanity checks
* adding an open source slice definition
* regnerate projects
* fix asan error
* Automated change: Fix sanity tests
* addressing review comments
* fix sanity checks
* regenerate projects
* update
* fix sanity checks
* Converting slice buffer to retarin ownership of the underlying ctype
* [slice_buffer] Introduce grpc_core::SliceBuffer
* add test
* Automated change: Fix sanity tests
* [byte-stream] Delete ByteStream
* progress
* progress
* missing files
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* sanity
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* iwyu
* fix
* progress
* fix
* fix
* progress
* code compiles
* fix?
* bogus assert
* Automated change: Fix sanity tests
* fix
* fix
* fix?
* fix
* fix
* better expression of function
* fix?
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add fullstack test without retry filter
* debug
* missing files
* gc
* fix h2_full_no_retry
* remove headers
* fixes
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* progress
* x
* tear apart flow control
* continue itnegration
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* cleanup
* Automated change: Fix sanity tests
* fix
* x
* x
* Revert "debug"
This reverts commit 0120a944925fe05120776df476b22f
2022-06-02 16:04:32 -07:00
0f9d024fec
[iwyu] c++ ( #29721 )
...
* Revert "Revert "[iwyu] grpc++ (#29610 )" (#29720 )"
This reverts commit 0642bc213d
2022-05-19 07:34:48 -07:00
0642bc213d
Revert "[iwyu] grpc++ ( #29610 )" ( #29720 )
...
This reverts commit c8159eabdf
2022-05-18 09:58:08 -07:00
c8159eabdf
[iwyu] grpc++ ( #29610 )
...
* [iwyu] grpc++
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* [iwyu] Better script
* eliminate race
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-18 07:16:53 -07:00
717732c044
[promises] Convert http server filter ( #29273 )
...
* Begin adding abstractions for capturing batches
* code written
* fixes
* fix
* fmt
* placate clang-tidy
* simplify
* fixes
* Automated change: Fix sanity tests
* annotate unrefs
* fix tsan
* fix
* Update subchannel.cc
* Update BUILD
* Update generate_tests.bzl
* Update BUILD
* Automated change: Fix sanity tests
* Promiseize
* Move server promise based filter to Flusher
* review feedback
* compiles!
* fix
* fix
* start server initial metadata emulation
* comment
* comment
* fix
* refactoring-to-fix-the-bugs
* fixfixfix
* fix
* support cancellation
* fuzzer
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-04 07:55:50 -07:00
18bec00b58
[channel-stack] Eliminate post-init in channel stack builder ( #29514 )
...
* Eliminate post-init in channel stack builder
We've had a post init function on channel stack builder for a very long
time, an it serves to run some code after initialization completes.
We need the functionality for a few things, but the function passed in
is intimately tied to the filter in use - we never vary it between
multiple functions for the same filter... which means it makes more
sense to locate this functionality as part of the filter interface.
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-03 13:06:51 -07:00
b92f885756
Adding a max_frame_size argument to grpc_endpoint_write API to allow a sender to control frame sizes ( #29526 )
...
* adding a max_frame_size argument to grpc_endpoint_write API
* fix syntax error
* fix typo
2022-05-02 12:32:18 -07:00
53e382729f
Adding a min progress size argument to grpc_endpoint_read to allow gRPC to use TCP optimizations on the read path ( #29503 )
...
* adding a min progress size argument to grpc_endpoint_read
* fix missing argument error
* adding a static_cast
* reverting changes in tcp_posix.cc
* add missing changes to CFStreamEndpointTests.mm
2022-04-28 13:23:09 -07:00
8bb45aa3a6
Convert grpc_channel to C++ ( #29266 )
...
* begin
* tests
* fix
* http
* Filter fuzzer
* progress
* basics
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
2022-04-20 20:55:15 -07:00
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
e122c64000
Revert "Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )" ( #29182 )
...
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
2022-03-30 10:04:42 -07:00
6ee276f672
Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )
...
This reverts commit 41debbf1a7
2022-03-22 17:51:03 +01:00
41debbf1a7
HTTP Client Filter --> promises ( #29031 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* roughing out
* push/pull impl
* comment
* prove out new combinator
* Simplify naming
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* builds
* Automated change: Fix sanity tests
* progress
* tweak
* merge
* progress
* fix
* first test passes
* progress
* fix
* repair name
* fix
* small fix
* small fix
* properly stop call combiner
* fix allocation in this benchmark
* fix
* fix
* fix merge
* fix bad merge
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-21 13:11:05 -07:00
0ea1eeb4e7
Expose channel stack type to builder ( #29088 )
...
* split builder
* expose channel stack type to builder
* Automated change: Fix sanity tests
* Update channel_stack_builder_impl.h
* Update channel_init.h
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-15 21:33:32 -07:00
674e938de5
More tests prep for graceful goaway ( #29076 )
...
* More tests prep for graceful goaway
* clang-tidy
2022-03-10 16:55:09 -08:00
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-01 11:34:05 -08:00
ff87ca02b2
Revive test/core/memory_usage ( #28931 )
...
* Revert "Deprecate gpr_get/set_allocation_functions"
This reverts commit 81df105ac8
2022-02-22 15:39:40 -08:00
05056e149a
eliminate bm_error ( #28944 )
2022-02-22 15:39:05 -08:00
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
2022-02-17 17:56:19 -08:00
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
b458db9246
Eliminate gRPC insecure build ( #25586 )
...
* force submit
* fix test error
* remove is_client from local tsi and its callsites
* fix too_many_pings_test
* add missing dep
2022-02-10 11:17:18 -08:00
4169f24dcc
Revert "Revert "Transport channel arg ( #28802 )" ( #28818 )" ( #28820 )
...
This reverts commit 2532cf5321
2022-02-09 11:14:47 -08:00
2532cf5321
Revert "Transport channel arg ( #28802 )" ( #28818 )
...
This reverts commit 99e339136d
2022-02-08 15:18:44 -08:00
99e339136d
Transport channel arg ( #28802 )
...
Instead of passing transport optionally as an argument adjacent to channel args, pass it as a channel arg directly.
Doing so does not affect semantics, but does allow a cleaner API for channel creation which will become increasingly important as we move towards promises.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-02-08 14:11:07 -08:00
e4107caf26
c++-ize channel stack builder ( #28660 )
...
* c++-ize channel stack builder
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* comment
* move functions out of line
* Automated change: Fix sanity tests
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-24 15:28:08 -08:00
17c6a486cd
Expose promise-ness to filter proper ( #28658 )
...
* Expose promise-ness to filter proper
* Make transports able to export promises too
* Add make promise op to transport
2022-01-24 09:05:32 -08:00
2bdd5bd8e6
Add a trace to list which filters are contained in a channel stack ( #28530 )
...
* Add a trace to emit what a channel stack looks like
* Add a trace to emit what a channel stack looks like
* x
2022-01-11 13:54:23 -08:00
4b881c5947
Remove grpc_mdelem ( #28267 )
...
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2022-01-07 09:42:27 -08:00
264c321d83
Move compression related metadata to the new system ( #28223 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* initial refactoring
* optimize status encoding
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-12-15 15:47:56 -08:00
0deb64d1f6
Move content-type, colon prefixed metadata to new system ( #28204 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* initial refactoring
* optimize status encoding
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-12-13 12:11:45 -08:00
b95ed96b96
Revert "Revert "Move arena into resource quota ( #28008 )" ( #28292 )" ( #28293 )
...
This reverts commit 91edf92ce0
2021-12-06 21:41:06 -08:00
91edf92ce0
Revert "Move arena into resource quota ( #28008 )" ( #28292 )
...
This reverts commit ad424a2ebf
2021-12-06 12:59:28 -08:00
ad424a2ebf
Move arena into resource quota ( #28008 )
...
* new resource quota integration
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fix
* fixes
* windows-fix
* fixes
* fixes
* fix
* fix-asan
* banned
* banned
* fixes
* clang-tidy-fix
* Automated change: Fix sanity tests
* fix-cronet
* review feedback
* review feedback
* Automated change: Fix sanity tests
* fixes
* bug fix
* fixes
* compile fix
* exclude megabyte size payloads from 1byte tests
* windows fix
* start moving ios
* keep moving windows
* Get windows compilation working.
* Automated change: Fix sanity tests
* better
* fixes
* remove slice buffer from memory_allocator.h
* Revert "remove slice buffer from memory_allocator.h"
This reverts commit 234a63b6e3
2021-12-06 08:43:56 -08:00
e21505858f
Move some integer based metadata to the new system ( #28198 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* initial refactoring
* optimize status encoding
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-12-02 22:02:56 -08:00
2eadef9a82
Remove bm_metadata ( #28219 )
2021-11-29 13:40:26 -08:00
220cf641fa
Reland slice metadata conversion ( #28210 )
...
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-11-29 13:38:40 -08:00
7717587063
Revert "Move a bunch of slice typed metadata to new system ( #28107 )" ( #28208 )
...
This reverts commit 4d432aefc1
2021-11-24 15:41:36 -08:00
4d432aefc1
Move a bunch of slice typed metadata to new system ( #28107 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-24 11:42:37 -08:00
672f31c6ac
Channel args preconditioning ( #28132 )
...
* Channel args preconditioning
* docs
* fixes
* Automated change: Fix sanity tests
* fix
* fix this again after merge error
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-22 15:24:39 -08:00
0bdb4d650b
Revert "Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )" ( #28144 )
...
This reverts commit eec0ca98c1
2021-11-19 09:15:04 -08:00
eec0ca98c1
Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )
...
This reverts commit 2ea8e50c3a
2021-11-18 14:50:39 -08:00
2ea8e50c3a
use CppImplOf for grpc_server ( #28112 )
...
* use CppImplOf for grpc_server
* fix build
* fix sanity
2021-11-17 07:46:53 -08:00
a629c9a03e
Reland resource quota work ( #28017 )
...
* Check if memory owner available prior to polling it
The transport may drop the memory owner during its destruction sequence
* tcp_fix
* Revert "Revert "New resource quota integration (#27643 )" (#28014 )"
This reverts commit 0ea2c37263
2021-11-15 08:23:51 -08:00
0ea2c37263
Revert "New resource quota integration ( #27643 )" ( #28014 )
...
This reverts commit 39f0877d25
2021-11-11 14:26:19 -08:00
39f0877d25
New resource quota integration ( #27643 )
...
* new resource quota integration
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fix
* fixes
* windows-fix
* fixes
* fixes
* fix
* fix-asan
* banned
* banned
* fixes
* clang-tidy-fix
* Automated change: Fix sanity tests
* fix-cronet
* review feedback
* review feedback
* Automated change: Fix sanity tests
* fixes
* bug fix
* fixes
* compile fix
* exclude megabyte size payloads from 1byte tests
* windows fix
* start moving ios
* keep moving windows
* Get windows compilation working.
* Automated change: Fix sanity tests
* better
* fixes
* remove slice buffer from memory_allocator.h
* Revert "remove slice buffer from memory_allocator.h"
This reverts commit 234a63b6e3
2021-11-10 22:53:04 -08:00
75a54f55e3
Remove trickle benchmarks ( #28000 )
...
* Remove trickle benchmarks
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-10 18:21:13 -08:00
Craig Tiller