d61433ecb2
cds LB: handle loops in aggregate cluster graph ( #29382 )
...
* cds LB: handle loops in aggregate cluster graph
* clang-format
2022-04-12 14:45:35 -07:00
3a4058c07a
xds_end2end_test: move test framework to its own library ( #29279 )
...
* move some code around
* remove num_backends parameter from XdsEnd2endTest
* remove use_xds_enabled_server param from XdsEnd2endTest
* remove xds_resource_does_not_exist_timeout_ms param from XdsEnd2endTest
* remove client_load_reporting_interval_seconds param from XdsEnd2endTest
* start moving CreateAndStartBackends() into individual tests
* finish moving CreateAndStartBackends() into individual tests
* remove unused variable
* remove SetEdsResourceWithDelay
* fix test flake
* clang-tidy
* clang-format
* move test framework to its own library
* fix build
* clang-format
* fix windows build
* rename TestType to XdsTestType
* move BackendServiceImpl inside of BackendServerThread
* clang-format
* move AdminServerThread to CSDS test suite
* remove unnecessary deps
2022-04-12 13:42:58 -07:00
94c538cd55
Second attempt: Adding is_optional case to RLS ( #29378 )
...
* Revert "Revert "Adding is_optional case to RLS (#29259 )" (#29299 )"
This reverts commit a6419dde06
2022-04-12 11:21:44 -07:00
61b34dfaee
Improve logging in interop soak test and add a flag to limit QPS ( #29357 )
...
* Improve logging in interop soak test and add a flag to limit QPS
2022-04-08 21:16:23 -07:00
60c56f7d01
Second attempt: implement ORCA RPC service for OOB backend metric reporting ( #29352 )
...
* Revert "Revert "ORCA: implement ORCA RPC service for OOB backend metric reporting (#29215 )" (#29351 )"
This reverts commit 71b355624f
2022-04-08 11:12:18 -07:00
71b355624f
Revert "ORCA: implement ORCA RPC service for OOB backend metric reporting ( #29215 )" ( #29351 )
...
This reverts commit 6d6380de58
2022-04-07 16:15:49 -07:00
0b79940496
connection delay injector: cap delay by deadline ( #29349 )
2022-04-07 15:12:59 -07:00
6d6380de58
ORCA: implement ORCA RPC service for OOB backend metric reporting ( #29215 )
...
* ORCA: implement ORCA RPC service for OOB backend metric reporting
* fix unused parameter error
* gen_upb_api
* add missing build deps
* increase test timing fudge factor
* add missing copyright header
* buildifier
* don't register as a generic service
* report interval defaults to min interval
* don't regenerate the response proto unless something changed
* use INTERNAL for proto parsing failure
* use absl::Duration in public API
2022-04-07 07:58:58 -07:00
1fd3850502
client_lb_end2end_test: refactor connection delay injection into its own library ( #29320 )
...
* refactor connection delay injection from client_lb_end2end_test
* fix build
* fix build on older compilers
* clang-format
* buildifier
2022-04-06 15:23:41 -07:00
96c19e8c98
weighted_target and xds_cluster_manager: don't update picker while update is in flight ( #29313 )
...
* weighted_target and xds_cluster_manager: don't update picker while update is in flight
* include deactivation and new child creation
* add test
2022-04-06 15:00:07 -07:00
e145c068f2
xds_cluster_resolver LB: don't reuse child numbers that might still be deactivated ( #29316 )
...
* xds_cluster_resolver LB: don't reuse child numbers that might still be deactivated
* clang-format
2022-04-06 06:43:39 -07:00
caacc7e3aa
xds_end2end_test: fix env var name in RLS tests ( #29291 )
...
* xds_end2end_test: fix env var name in RLS tests
* add ScopedExperimentalEnvVar to ensure env vars get unset after tests
* clang-format
2022-04-04 14:27:17 -07:00
a6419dde06
Revert "Adding is_optional case to RLS ( #29259 )" ( #29299 )
...
This reverts commit 2fd632a4c1
2022-04-02 20:27:01 -07:00
217ab2a793
xds_end2end_test: make each individual test start the number of backends it needs ( #29271 )
...
* move some code around
* remove num_backends parameter from XdsEnd2endTest
* remove use_xds_enabled_server param from XdsEnd2endTest
* remove xds_resource_does_not_exist_timeout_ms param from XdsEnd2endTest
* remove client_load_reporting_interval_seconds param from XdsEnd2endTest
* start moving CreateAndStartBackends() into individual tests
* finish moving CreateAndStartBackends() into individual tests
* remove unused variable
* fix test flake
* clang-tidy
* clang-format
2022-04-02 09:26:57 -07:00
2fd632a4c1
Adding is_optional case to RLS ( #29259 )
...
* Adding is_optional case to RLS
* integrated with the updated envoy data-plane
* Fixing an old bug and adding test
* Use the same plugin map for ignore
* Remove ignore set
* Fixed another test.
* addressing code review comments.
* clean up!
2022-04-01 12:33:39 -07:00
775362a2ce
client_lb_end2end_test: fix internal build problem ( #29265 )
2022-03-30 18:33:29 -07:00
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
e122c64000
Revert "Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )" ( #29182 )
...
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
2022-03-30 10:04:42 -07:00
3c4441fcdc
xds: add node ID to status messages generated by XdsClient ( #29253 )
...
* eliminate unnecessary templates
* add xDS node ID to error messages generated by XdsClient
* change test to verify that node ID is present in status message
* clang-format
2022-03-30 09:29:00 -07:00
d2aafef157
Make scenario results to include start and end time for a test scenario. ( #29207 )
...
This commit update the scenario results to include the start_timestamp
and end_timestamp. These two fields are used in prometheus range queries
to indicate the period we are pulling data for.
2022-03-29 19:16:12 -07:00
ac8f0b690e
xds: NACK EDS resources with duplicate localities in the same priority ( #29231 )
2022-03-29 11:56:10 -07:00
44167bdfd3
Convert server load reporting to promises ( #28927 )
...
* Call finalization for promises
* Convert filter to a promise
* Call finalization for promises
* comment
* split out and test
* dont use promise_detail:: directly
* fix
* Automated change: Fix sanity tests
* fix
* ?
* fix
* finish it
* modernize
* fix-test
* fix
* Review feedback
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-29 08:11:36 -07:00
23c4541392
xds_cluster_resolver: fix bug that caused us to incorrectly reuse priority child names ( #29174 )
...
* xds_cluster_resolver: fix bug that caused us to incorrectly reuse priority child names
* add debug logging
* assign child policy names within each discovery mechanism, not across all mechanisms
* clang-format
* add tests
* don't need EDS service name or LOGICAL_DNS hostname in child name
* remove unnecessary code
2022-03-24 14:27:47 -07:00
eded3b6bc3
client channel: record call completion even if recv_trailing_metadata was not started ( #29198 )
...
* client channel: record call completion even if recv_trailing_metadata was not started
* add test
* add test for opencensus filter
* remove unnecessary code
2022-03-24 14:22:16 -07:00
6989129db5
xDS RLS implementation ( #29200 )
...
* Revert "Revert "Initial structure for RLS (#28750 )" (#29189 )"
This reverts commit 7ece810843
2022-03-23 21:23:34 -07:00
7ece810843
Revert "Initial structure for RLS ( #28750 )" ( #29189 )
...
This reverts commit 362e0b8706
2022-03-22 13:41:21 -07:00
362e0b8706
Initial structure for RLS ( #28750 )
...
* Initial structure for RLS
* Adding and building the proto to parse the Any proto for the plugins
* re-org
* Parsing the plugin
* Parsing more into json
* Parsed proto to json
* small cleanup
* Adding prefix
* Added new rls_experimental policy
* build files
* Fixing according to code review comments
* code review comments
* Adding sym changes
* adding action name check
* fixing code review comments.
* fixing unused var error
* clean up
* fixing code review comments
* fixing code review comments
* fixing according to code review comments.
* Remove unnecessary include
* small fix
* generate more, hard-code less
* Moving to using absl::variant
* absl::string_view and absl::variant of vector of std::string are not
playing nice together.
* fixed variant
* Using absl::variant now
* Checkint used plugins
* Refactor Parsing code and separating out Parsing of the plugin
* Fixing code review comments
* code review comments
* fixing code review comments.
* Addressing code review comments
* First end-to-end test
* generated build files
* commit generated files via tools/codegen/core/gen_upb_api.sh
* Fixing rls policy parsing tests
* Restore checks for the test server
* Refactor rls_server
* added keys to rls request
* fixing small logic error
* Complete the test using all the keys
* Separating out RLS test and rls_server thread
* sanity errors
* generated build files
* Complete the rest of the tests and sanity cleanup
* fixing code review comments: using upb_JsonEncode now!
* fixing code review comments
* fixing code review comments
* Fixing code review comments
* misisng fix
* simplifying tests
* simplify tests 2
* Linking in the correct proto for rls_config
* restore metadata check
* Add disable test
* Fixing RLS test and removing environment var that is no longer necessary
* Fixing "Wrong type" type of tests after json parsing change to accept
STRING for number
* adding json_encode.h/c to src/upb/gen_build_yaml.py and generate
necessary files.
* Fixing un-used var error
* fixing sanity errors
* Fixing the upb encoding buffer
* Fixing code review comments.
* Adding nack test for unkonwn plugin proto
* Last bit of code review comments
* fixing unused variable
2022-03-22 11:29:52 -07:00
6ee276f672
Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )
...
This reverts commit 41debbf1a7
2022-03-22 17:51:03 +01:00
41debbf1a7
HTTP Client Filter --> promises ( #29031 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* roughing out
* push/pull impl
* comment
* prove out new combinator
* Simplify naming
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* builds
* Automated change: Fix sanity tests
* progress
* tweak
* merge
* progress
* fix
* first test passes
* progress
* fix
* repair name
* fix
* small fix
* small fix
* properly stop call combiner
* fix allocation in this benchmark
* fix
* fix
* fix merge
* fix bad merge
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-21 13:11:05 -07:00
99cbd49ef8
Simplify fallback test client and parameterize fallback deadline ( #29126 )
...
Simplify fallback test client and parameterize fallback deadline
2022-03-18 19:52:03 -07:00
7b4a5fcba5
xds: accept resources wrapped in a Resource message ( #29090 )
...
* xds: accept resources wrapped in a Resource message
* fix v2 proto name
2022-03-18 14:16:22 -07:00
1f03bbab39
Small cleanup ( #29125 )
...
The std::moves of temporaries prevented copy elision, and the functions
were unused (one with a TODO to re-enable later)
2022-03-16 18:26:41 -07:00
01f333a1c1
TlsCredentials: Comparator implementation ( #28940 )
...
* TlsCredentials: Comparator implementation
* Update tests
* Redundant namespace qualifiers
* clang-tidy
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Add generator for grpc_tls_credentials_options.h
* Generator script modifications for tests
* Sanity
* Reviewer comments
* Reviewer comments
* Add a common place to look-up known types
* Formatting
* Script fix
* Reviewer comments
* Add test mode to script
* Add to sanitize.sh
* clang-tidy
* Fix
* Fix
* Reviewer comments
* Clang-format
2022-03-16 17:11:07 -07:00
f86723d9db
Revert "Update the scenario results to include start and end time for a test scenario. ( #29034 )" ( #29122 )
...
This reverts commit 84edc034aa
2022-03-16 11:52:29 -07:00
84edc034aa
Update the scenario results to include start and end time for a test scenario. ( #29034 )
...
This commit add start and end timestamp to the existing scenario results.
2022-03-16 09:39:18 -07:00
0ea1eeb4e7
Expose channel stack type to builder ( #29088 )
...
* split builder
* expose channel stack type to builder
* Automated change: Fix sanity tests
* Update channel_stack_builder_impl.h
* Update channel_init.h
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-15 21:33:32 -07:00
138c4667c9
Change main argument of call promise to be a struct ( #29019 )
...
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* Simplify naming
* tweak
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-14 10:05:01 -07:00
674e938de5
More tests prep for graceful goaway ( #29076 )
...
* More tests prep for graceful goaway
* clang-tidy
2022-03-10 16:55:09 -08:00
c9946c2183
Channelz Service Test Shutdown ( #29068 )
2022-03-09 17:04:39 -08:00
68d721058c
Prepare async_end2end_test for graceful goaway ( #29054 )
2022-03-09 16:06:05 -08:00
00d587dc56
Include ADS stream error in XDS error updates ( #29014 )
...
* include ADS stream error in XDS error updates
* Re-package XDS client errors into unavailable rather than unknown, in XDS resolver
2022-03-07 10:32:36 -08:00
fe913387da
Remove idempotent/cacheable requests ( #28922 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* Modify XdsRbacTests
Co-authored-by: Yash Tibrewal <yashkt@google.com>
2022-03-04 14:42:59 -08:00
87acbadba1
Third attempt: Convert client_auth_filter to promises ( #28968 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* Revert "Revert "Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )" (#28952 )" (#28967 )"
This reverts commit 0f73576b17
2022-03-01 12:45:19 -08:00
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-01 11:34:05 -08:00
c08eb4fc41
Attempt to upgrade upb to the latest ( #28685 )
...
* Update upb to 85e5c76cb7098d3ae35e575d652a40568013a149
* Update grpc_deps.bzl
* Run gen_upb_api.sh
* Run run_sed.sh
* Update gen_build_yaml.py
* Regen projects
* Reformat
* Update third_party/upb to 950cdab42fe4c83f06a2be46eeb46a068e486eed
* Update third_party/upb to c9c31241bc39922b092a81d192badd50cccaaa81
* Update src/upb/gen_build_yaml.py
* Generated projects
* Update third_party/upb to a02d92e0257a35f11d4a58b6a932506cbdbb2f29
* Patching in https://github.com/protocolbuffers/upb/pull/524
* Sed script went too far.
Co-authored-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
2022-02-28 09:26:31 -08:00
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
2022-02-24 10:07:13 -08:00
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-02-23 20:50:03 -08:00
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
2022-02-23 15:00:34 -08:00
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
2022-02-23 08:17:37 -08:00
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
2022-02-23 07:36:19 -08:00
Mark D. Roth