Commit Graph

632 Commits

Author SHA1 Message Date
Richard Belleville 468768865b
Make Buildifier Sanity Test Strict (#27807)
* Fix all lint errors in repo.

* Use strict buildifier by default

* Whoops. That file does not exist

* Attempt fix to buildifier invocation

* Add missing copyright
2021-11-03 14:57:04 -07:00
Vy Nguyen 70b26a1c7c
Upgrade benchmark to 1.6.0 and remove previous hacks. (#27778)
* Upgrade benchmark to 1.6.0 and remove hacks.

Details:
 - GRPC currently uses an old version of benchmark (from Sept 2020). It should probably upgrade because downstream, in google3, everyone is already using 1.6.0)
 - Removed the hack added in PR/27629 to allow benchmarks in GRPC to continue to work with both pre-1.6.0 and 1.6.0 benchmarks.
   (This was needed to allow importing benchmarks 1.6.0 into google3 without breaking GRPC)

* fix typo

* update third_party/benchmark and check_submodules.sh

* Upmerge from v1.41.x (#27821)

* Bump version to v1.41.0-pre1 (#27371)

* Bump version to v1.41.0-pre1

* Regenerate projects

* [Backport #27373] add testing_version flag (#27385)

* Bump version to v1.41.0-pre2 (#27390)

* Bump version to v1.41.0-pre2

* Regenerate projects

* Core 19: bump core version from 18.0.0 to 19.0.0 (#27394)

* Bump core version to 19.0.0

* Regenerate projects

* fix use-after-free metadata corruption in C# when receiving response headers for streaming response calls (#27398)

* Final release: bump up version to 1.41.0 (#27476)

* Bump version to 1.41.0

* Regenerate projects

* xds_k8s_test: increase timeout to 3 hours due to recent timeout failure (#27580)

* Revert "xds_k8s_test: increase timeout to 3 hours due to recent timeout failure (#27580)" (#27590)

This reverts commit da0c7d680f.

* Update root pem certs (backport of #27539) (#27619)

* Update boringssl to the latest (#27606) (#27625)

* Change boringssl branch name

* update submodule boringssl-with-bazel with origin/main-with-bazel

* update boringssl dependency to main-with-bazel commit SHA

* regenerate files

* Increment podspec version

* generate boringssl prefix headers

* Bumping up version to v1.41.1 (#27699)

* Bump version to v1.41.1

* Regenerate projects

* [Backport][v1.41.x] xds-k8s tests: Use test driver from master branch (#27695)

Backports sourcing the test driver install script from master.

This is a backport of #27389, #27462 and #27658:


* Add missing quatation marks.

These were missed when  creating the Python virtual env.

* xds-k8s tests: Use test driver from master branch (#27462)

Instead of directly sourcing the test driver provisioning script from the same branch, the script is downloaded (with curl) and sourced from the master branch.

This allows changes made to the test driver to be reflected in all future release branches. A separate PR will backport this change to existing release branches.

All cluster definitions are also moved to the install script, allowing any cluster changes to be done in one place in the master branch.

* xds_k8s tests: Fix xlang install script sourcing. (#27658)

This change sources the test driver install script correctly for the xlang tests.
This fixes a mistake in #27462 where this was missed.

* Fix Python Interop (#27620) (#27703)

* WIP. Attempt to fix interop

* Yapf

* Switch Python xDS Example Server to Listen on IPV4 Only (#27679)

* Switch to IPV4

* Update to all hosts

* Fix rvm ruby install failure (#27769)

Co-authored-by: donnadionne <donnadionne@google.com>
Co-authored-by: Lidi Zheng <lidiz@google.com>
Co-authored-by: Jan Tattermusch <jtattermusch@users.noreply.github.com>
Co-authored-by: sanjaypujare <sanjaypujare@users.noreply.github.com>
Co-authored-by: Sergii Tkachenko <sergiitk@google.com>
Co-authored-by: Esun Kim <veblush@google.com>
Co-authored-by: Terry Wilson <terrymwilson@gmail.com>
Co-authored-by: Richard Belleville <rbellevi@google.com>

* added perf_counters.cc manually since the script didn't work

Co-authored-by: Mark D. Roth <roth@google.com>
Co-authored-by: donnadionne <donnadionne@google.com>
Co-authored-by: Lidi Zheng <lidiz@google.com>
Co-authored-by: Jan Tattermusch <jtattermusch@users.noreply.github.com>
Co-authored-by: sanjaypujare <sanjaypujare@users.noreply.github.com>
Co-authored-by: Sergii Tkachenko <sergiitk@google.com>
Co-authored-by: Esun Kim <veblush@google.com>
Co-authored-by: Terry Wilson <terrymwilson@gmail.com>
Co-authored-by: Richard Belleville <rbellevi@google.com>
2021-10-27 08:55:42 -07:00
Craig Tiller 1df153f46e
Revert "Revert "Move metadata setting into HPackParser (#27545)" (#27686)" (#27688)
This reverts commit 0e6ced8800.
2021-10-13 08:44:57 -07:00
Craig Tiller 0e6ced8800
Revert "Move metadata setting into HPackParser (#27545)" (#27686)
This reverts commit f57a1f7d8c.
2021-10-12 08:37:00 -07:00
Craig Tiller f57a1f7d8c
Move metadata setting into HPackParser (#27545)
* forward work to get append, limit check into parser

* further cleanup

* Remove chttp2_incoming_metadata_buffer

* Automated change: Fix sanity tests

* test fixes

* fix cronet

* wip

* first pass mementofication of parsing - libgrpc compiles

* further progress

* fixes

* fixes

* fix leak

* Automated change: Fix sanity tests

* fix leak

* fixes

* x

* improve fuzzer

* init ordering fix

* Update hpack_parser_table.h

* Update hpack_parser.cc

* Update hpack_parser_test.cc

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests

* i mustache myself why

* fix use after free

* Automated change: Fix sanity tests

* fixes

* eliminate second pass metadata - this is an illegal frame and fails the new parser

* handle mementos with size > sizeof(intptr_t)

* fix

* add parsed metadata header, test

* Automated change: Fix sanity tests

* fix includes

* phase1

* phase2

* Update parsed_metadata.h

* fix

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-10-11 20:02:29 -07:00
Vy Nguyen a145013d6d
Temporarily disable benchmarks (#27629)
benchmark 1.6.0 introduced API breaking changes so we temporarily disabled the benchmarks that are using the old API to avoid breaking.
2021-10-07 14:29:19 -07:00
Craig Tiller d1e01ac139
Add a test for a (now-illegal) build file construct (#27602)
* Add a test for a (now-illegal) build file construct

* add to test suite!

* fix

* fix

* fix syntax
2021-10-06 07:43:59 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Craig Tiller b062fcd5c6
Ensure consistency of include style for <grpc.* headers (#27233)
* Add a tool to ensure consistency in how grpc public headers are included

* Apply tool

* add to test suite

* isort
2021-09-02 11:42:33 -07:00
AJ Heller 58f8f5ced3
Add macro to define gtest death_test_style using an older syntax (#27042)
This temporarily unblocks a related gtest upgrade. The ultimate goal is
to upgraade our gtest dependencies, but I don't have the cycles to
manage a potentially messy migration until at least next week. This PR
is coordinated with an internal change.
2021-08-17 17:12:28 -07:00
Esun Kim a99ead4bf4
Added new method to ByteBuffer & Slice (#26014) 2021-05-27 11:18:18 -07:00
Vijay Pai 153bc67f45
Revert "Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)" (#26379)
This reverts commit 259a74c0e6.
2021-05-27 09:16:05 -07:00
Yash Tibrewal 259a74c0e6
Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)
This reverts commit 66253c521a.
2021-05-26 22:20:23 -07:00
Vijay Pai 66253c521a
Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)
* Revert "Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)"

This reverts commit 05c3b30ea0.

* Move the trailers_only check from ClientContext to ClientReactor

* Remove unneeded change in client_context.cc
2021-05-25 17:43:21 -07:00
Yash Tibrewal 05c3b30ea0
Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)
This reverts commit 393bae7e88.
2021-05-25 13:44:10 -07:00
Vijay Pai 393bae7e88
Expose trailers-only response status through C++ callback API (#26249)
* Expose trailers-only response status through callback API

* Fix change-detector test

* Address reviewer comment about trailers_only headers

* Add TODO requested by markdroth

* Move variable in struct to improve space efficiency

* Don't instantiate ExecCtx in channel_args destructor unless needed
2021-05-21 14:42:41 -07:00
Esun Kim 460898f11c
Migrated from grpc_error_string to grpc_error_std_string (#26068)
* Added grpc_error_std_string
* Migrated to grpc_error_std_string
2021-04-23 16:31:54 -07:00
Esun Kim ca945a58e9
Introduced grpc_error_handle (#25902)
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
2021-04-22 12:00:28 -07:00
Yonathan Randolph a985978d82
grpc_cli: allow multiple colon-separated paths in --proto_path (#24187)
Co-authored-by: Yash Tibrewal <yashkt@google.com>
Co-authored-by: AJ Heller <hork@google.com>
2021-03-12 16:52:48 -08:00
Esun Kim a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr (#25628) 2021-03-09 21:30:35 -08:00
Yash Tibrewal f4e55b85bc Replace disrespectful term 2021-02-08 15:29:53 -08:00
Esun Kim 9eabb96f1c Added no_test_ios to error_details_test 2021-01-21 15:01:36 -08:00
Esun Kim a1ae48db20
Merge pull request #25196 from devjgm/error-details-template
refactor!: change error_details functions to templates
2021-01-21 11:26:33 -08:00
Greg Miller 7d4d516511 wip: change error_details functions to templates 2021-01-20 09:48:22 -05:00
Esun Kim 9bd7c4917a Fix unused-parameter warning 2021-01-19 18:18:09 -08:00
Esun Kim 53ab235fb8 Fix google-explicit-constructor 2020-12-03 15:03:39 -08:00
Esun Kim e0d8c498a6 C++ cast for others 2020-11-30 17:36:21 -08:00
Esun Kim 2ff84ed8c2 C++ cast for void* 2020-11-30 17:29:15 -08:00
Esun Kim ec0b88a5d7 Fix google-readability-casting 2020-11-30 17:27:51 -08:00
capstan 27c0b32668 Retire flags 2020-11-06 18:35:55 +01:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Parveen Kumar ec08d77474 Specify a large value for max metadata size in grpc_cli client channel.
This is useful in cases where server sends back large stacktrace and
default value of 8192 isn't enough.
2020-10-29 13:36:46 -07:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim 004480e706
Merge pull request #24482 from veblush/tidy-readability-string-compare
[Clang-Tidy] readability-string-compare
2020-10-21 13:42:17 -07:00
Esun Kim aae4f4cf18 Fix by misc-unused-using-decls 2020-10-19 18:12:11 -07:00
Esun Kim 738bdfb9fd Fix by readability-string-compare 2020-10-19 17:08:00 -07:00
Esun Kim bba8facb4a
Merge pull request #24456 from veblush/tidy-readability-redundant-smartptr-get
[Clang-Tidy] readability-redundant-smartptr-get
2020-10-19 09:54:15 -07:00
Esun Kim a62a70207c
Merge pull request #24448 from veblush/clang-format-8
Upgrade clang-format 8
2020-10-19 09:29:35 -07:00
Esun Kim 84df61b31a
Merge pull request #24453 from veblush/tidy-modernize-make-unique
[Clang-Tidy] Enable modernize-make-unique
2020-10-16 16:35:08 -07:00
Esun Kim 3fef4e7435 Fix by readability-redundant-smartptr-get 2020-10-16 14:16:42 -07:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Esun Kim 6ae8463500 Fix by modernize-make-unique 2020-10-16 13:30:56 -07:00
Esun Kim 34789b2d83 Fix by clang-format-8. 2020-10-16 11:37:18 -07:00
Esun Kim ece76ee1e8 Fix code by readability-container-size-empty 2020-10-16 09:48:20 -07:00
Esun Kim 6d6648c7e1 Fix clang-tidy errors 2020-10-13 09:51:31 -07:00
Alisha Nanda 91627677fd
Added timeout flag to grpc cli. 2020-09-14 17:00:45 +00:00
“Mohan 8cfe62155f removed unused decl for ClangTidy 2020-09-10 10:58:09 -07:00
“Mohan 876021f313 Fix two bugs for channelz_sampler_test 2020-09-10 10:17:50 -07:00
Alisha Nanda a3ef19c1f0
Revert "Add timeout flag to gRPC cli" 2020-09-09 18:32:27 -07:00
mohanli-ml 2ec0868ebf
Merge pull request #23860 from mohanli-ml/channelz-sampler-work
Channelz sampler
2020-09-09 14:07:01 -07:00
“Mohan 35a4133e4b Solve the sanity check problem for Json 2020-09-08 22:44:54 -07:00
“Mohan dee219a28f Make entity description type as Json instead of string 2020-09-08 21:41:25 -07:00
“Mohan f85569e5a7 Address cooments including channel_creds checking, UNIMPLEMENTED checking 2020-09-08 11:30:11 -07:00
“Mohan 4039a8d405 Make minor changes to pass github check 2020-09-08 11:29:23 -07:00
Alisha Nanda 94a72c151b
Changed timeout to ns rather than us. 2020-09-03 16:50:42 +00:00
Alisha Nanda 4282e968c4
Re-add in all changes, fix check failures. 2020-09-03 04:01:22 +00:00
Alisha Nanda a4eedc1510 Revert "Merge branch 'master' of https://github.com/ananda1066/grpc"
This reverts commit 35e0e96b09, reversing
changes made to b78bc85185.
2020-09-03 01:57:03 +00:00
Alisha Nanda 88d99b4603 Add timeout flag to gRPC cli
Signed-off-by: Alisha Nanda <alishananda@google.com>
2020-09-01 22:10:35 +00:00
Karthik Ravi Shankar 751b9c105f Move ClientContext from ::grpc_impl to ::grpc
Reverts: https://github.com/grpc/grpc/pull/19261
2020-08-11 16:28:50 -07:00
Karthik Ravi Shankar 15cce00f52
Revert "Revert "Fold Channel and CompletionQueue from grpc_impl to grpc"" 2020-08-06 20:42:54 -07:00
Karthik Ravi Shankar f3f9e8941a
Revert "Fold Channel and CompletionQueue from grpc_impl to grpc" 2020-08-06 15:56:09 -07:00
Karthik Ravi Shankar 390132c87f Merge branch 'master' into channel 2020-08-04 11:48:10 -07:00
Karthik Ravi Shankar 3c2f4b40e3 Fold Channel and CompletionQueue from grpc_impl to grpc
Reverts: https://github.com/grpc/grpc/pull/19067
2020-07-30 16:45:28 -07:00
Esun Kim 9494b834b1 Add TestEnvironment to tests 2020-07-30 13:58:01 -07:00
Alexander Polcyn f57879ac56 Flag protect new logs 2020-07-22 21:22:05 -07:00
Alexander Polcyn 4bdbd4caef Log the peer address of grpc_cli CallMethod RPCs to stderr 2020-07-20 18:18:42 -07:00
Esun Kim c736cf073c Added call to grpc::testing::TestEnvironment in more tests 2020-07-01 13:27:08 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
apolcyn 30cfd114b3
Merge pull request #23110 from apolcyn/fix_grpc_cli
Allow configuring default service configs in grpc_cli via --default_service_config
2020-06-02 12:41:30 -07:00
Alexander Polcyn 0a452b9d19 Allow configuring default service configs in grpc_cli 2020-06-02 10:51:29 -07:00
yihuaz ba0c9d6924 fix clang-format issue 2020-05-25 15:07:27 -07:00
yihuaz 1d69b7d676 add local creds to grpc_cli 2020-05-24 15:01:14 -07:00
Thomas Etter f5c9fd94a5 do not write unnecessary new lines in the grpc_cli as the formatters already write them 2020-05-09 13:34:03 +02:00
ZhenLian d75de51e43 [10/n] remove hard-coded credential paths and rebuild the project 2020-04-29 10:51:56 -07:00
Jan Tattermusch a960546ff9
Revert "[7/n] Avoid using hardcoded test credentials" 2020-04-28 17:41:24 +02:00
ZhenLian cd7e22c6a4
Merge pull request #22695 from grpc/zhen_core_test_improvement_8
[7/n] Avoid using hardcoded test credentials
2020-04-27 15:42:11 -07:00
ZhenLian c13f3c5a50 test using ReadFile 2020-04-25 11:49:51 -07:00
ZhenLian 2c84dec7da try adding extern 2020-04-21 10:08:34 -07:00
ZhenLian dd44231a32 [No Review] Test 2020-04-19 16:04:41 -07:00
ZhenLian 7cb9d43da2
Merge pull request #22689 from grpc/zhen_core_test_improvement_7
[6/n] Avoid using hardcoded test credentials
2020-04-17 18:22:32 -07:00
ZhenLian f64554b698 [NO Review] grpc_tool_test.cc 2020-04-17 16:47:44 -07:00
Donna Dionne 6ec6c24dc1 Fixing code review comments. 2020-04-13 22:16:42 -07:00
Donna Dionne d76fc080c4 Fixing build warnings getting ready for merge. 2020-04-13 10:32:23 -07:00
Donna Dionne ddb98d6b52 Fixing code review comments:
- added more tests and improved structuring of backend service
- fixing grpc_tool tests (due to adding of new test serices/methods
2020-04-12 16:28:39 -07:00
Alexander Polcyn 962a8f28f9 Add a flag to set a grpclb+pick_first service config in
CreateTestChannel; use CreateTestChannel in qps_json_driver
2020-04-03 12:28:55 -07:00
Esun Kim b308241343 Fix clang-tidy issues 2020-03-03 12:27:41 -08:00
Mark D. Roth bc5e3fb661 Convert channelz code to use new JSON API 2020-01-30 10:57:53 -08:00
Lidi Zheng c34bef4ca4 Format all Bazel files with buildifier 2019-11-05 14:03:52 -08:00
Vijay Pai e35c869aaf Remove unused-parameter warnings, round 2 (19 of 19) 2019-10-21 09:16:35 -07:00
Vijay Pai 47f2b461ef clang-format 2019-10-17 09:08:55 -07:00
Vijay Pai 53e19e8de2 Remove unused parameter warning (20 of 20) 2019-10-17 08:52:15 -07:00
Lidi Zheng f12df974ae
Merge pull request #20401 from tanjunchen/clean-up
Fix spelling in comments
2019-10-01 17:49:55 -07:00
chentanjun 4ecc1fe6a4 fix the wrong word 2019-10-01 05:13:33 +08:00
Jan Tattermusch 5cc45de443 disable some broken test on windows RBE 2019-09-30 13:28:02 +02:00
Jan Tattermusch 6ebc1c616f set uses_polling=False for some bazel tests 2019-09-24 09:50:00 +02:00
Prashant Jaikumar 141c2d24d1 Add support for running C++ tests on iOS 2019-08-14 20:44:22 -07:00
Andrew Scherkus 4bf0048194 Document --noremotedb flag for grpc_cli.
It's surprising that grpc_cli always attempts to use the reflection
service even when providing local proto files. Document the
existence of a flag that surpresses this behavior.
2019-07-16 13:14:28 -04:00
rmstar ce282e7d7e
Merge pull request #19395 from rmstar/c++_on_ios
Fix C++ tests to run on iOS
2019-06-28 11:03:22 -07:00
Moiz Haidry fbd5957ee8 Sanity and build fixes 2019-06-21 12:28:55 -07:00