AJ Heller
8f6ae3599f
[revert] Revert "Revert "[EventEngine] Implement the EventEngine-driven client channel resolver" ( #32768 )" ( #32772 )
...
This is a clean, OSS-only revert of
https://github.com/grpc/grpc/pull/32632 , but depends on
https://github.com/grpc/grpc/pull/32771 landing first, which requires a
cherrypick.
2023-04-12 16:30:01 -07:00
Craig Tiller
b5a2e90fbf
Revert "[EventEngine] Implement the EventEngine-driven client channel resolver." ( #32768 )
...
Reverts grpc/grpc#32632
Needs to be rolled back for #32767 to land
2023-03-31 21:31:27 -07:00
AJ Heller
7dec55de5a
[EventEngine] Implement the EventEngine-driven client channel resolver. ( #32632 )
...
This PR also centralizes the client channel resolver selection. Resolver
selection is still done using the plugin system, but when the Ares and
native client channel resolvers go away, we can consider bootstrapping
this differently.
2023-03-31 13:52:06 -07:00
Craig Tiller
67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); ( #31757 )
...
* crash function
* progress
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* fix
* use cpp attr
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* add exclusion
* fix
* typo
* fix
* fmt
* Update tcp_socket_utils.cc
* Automated change: Fix sanity tests
* fix
* revert php changes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-11 08:50:32 -08:00
Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Cheng-Yu Chung
9a7e77318b
[cleanups] Remove `include/grpc/impl/codegen/grpc_types.h` ( #31835 )
...
* Remove `include/grpc/impl/codegen/grpc_types.h`
* Automated change: Fix sanity tests
* Fix typo
* Automated change: Fix sanity tests
2022-12-14 02:29:17 +08:00
Yijie Ma
6b79989d86
EventEngine::RunAfter: PollingResolver ( #31717 )
...
* EventEngine::RunAfter: polling_resolver
initial draft
* restore some iwyu change
* fix: get rid of OnNextResolution
* fix some test crashes
* fix more tests
* clang-tidy
* review
* clang-tidy
* fix
* review
* review
* review
* fix use-after-move
* revert
* review
2022-12-05 17:05:00 -08:00
apolcyn
e5f7b1b8cd
c-ares DNS resolver: fix logical race between resolution timeout/cancellation and fd readability ( #31443 )
...
* Fix race between c-ares resolution timeout and fd readability
2022-10-27 22:25:17 -07:00
Craig Tiller
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2022-09-29 06:45:17 -07:00
Esun Kim
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2022-09-27 23:17:39 -07:00
Mark D. Roth
4491ed26aa
BUILD: move work_serializer to its own build target ( #30255 )
...
* BUILD: move work_serializer to its own build target
* add autodeps tag
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-13 13:21:07 -07:00
Craig Tiller
d304712f64
[channel_args] Spread grpc_core::ChannelArgs through client channel code ( #30008 )
...
* [channel_args] Spread grpc_core::ChannelArgs through client channel code
* progress
* progress
* grpc compiles
* uniqueptr+compiles
* fix
* fix
* fix
* fix
* fix
* fix
* fixes
* fix
* fix
* fixes
* fix-lb
* fix
* fix up arg construction
* fix
* fix
* fix
* fix
* move to const& to save bytes
* fix
* fix
* progress
* review feedback
* fix
* fix
* fixes
* fixes
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* debug-helper
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-07 19:19:11 -07:00
Yousuk Seung
371d231b53
Support unix socket in grpc_sockaddr_to_string ( #29169 )
...
* Support unix socket in grpc_sockaddr_to_string
* make it return statusor
* clang fix
* made grpc_sockaddr_to_string() to return statusor
* Let Chttp2ServerListener::Start crash
* test failure fixed
* api_fuzzer fixed
* comments addressed.
* more comments addressed
* comments addressed
* fix other broken builds
2022-04-15 14:56:15 -07:00
AJ Heller
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
Craig Tiller
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-01 11:34:05 -08:00
Craig Tiller
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-02-23 20:50:03 -08:00
Craig Tiller
dd76a04b8c
Move resolver to core configuration ( #28881 )
...
* Move resolver to core configuration
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* resolver: clean up and modernize registry
* fix race
* update visibility
* fix internal error
* review feedback
* resolve backref issues
* windows
* x
* fix sockaddrs on windows?
* fix sockaddrs on windows?
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
2022-02-23 00:09:04 -08:00
Craig Tiller
55b365f287
Move resolver code around a little ( #27846 )
...
* move service config
* service config should not depend on grpc_base
* move resolver, deal with fallout
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* review feedback
* review feedback
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix vis
* fix
* fixes
* Automated change: Fix sanity tests
* visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-06 10:53:40 -08:00
apolcyn
2a4b7f25e6
testing: add a fake TCP and UDP server to test/core/util (extracted from #27883 ) ( #28332 )
...
* add a fake TCP and UDP server to test/core/util
2021-12-14 08:50:17 -08:00
Mark D. Roth
ac70281e74
improve RPC status messages when name resolution fails ( #28091 )
...
* improve RPC status messages when name resolution fails
* fix tests
* clang-format
* fix rls_end2end_test
* fix build
* fix service_config_end2end_test
* fix too_many_pings_test
* fix tests
* fix client_channel to propagate resolution_note to LB policy
* improve comment
2021-12-07 09:05:38 -08:00
Craig Tiller
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Mark D. Roth
4c40ee3f78
move parse_address and sockaddr_utils out of iomgr directory ( #26077 )
...
* move parse_address and sockaddr_utils out of iomgr directory
* clang-format
* fix python
* fix for import
* fix build file for import
2021-04-30 08:21:58 -07:00
Esun Kim
460898f11c
Migrated from grpc_error_string to grpc_error_std_string ( #26068 )
...
* Added grpc_error_std_string
* Migrated to grpc_error_std_string
2021-04-23 16:31:54 -07:00
Esun Kim
ca945a58e9
Introduced grpc_error_handle ( #25902 )
...
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
2021-04-22 12:00:28 -07:00
apolcyn
a98819007d
Revert "Convert grpc_ares_wrapper to C++ ( #25108 )" ( #25761 )
...
This reverts commit 2ee70175bd .
2021-03-18 21:55:14 -07:00
apolcyn
2ee70175bd
Convert grpc_ares_wrapper to C++ ( #25108 )
2021-03-17 13:47:29 -07:00
Yash Tibrewal
f4e55b85bc
Replace disrespectful term
2021-02-08 15:29:53 -08:00
Alexander Polcyn
8215b21dc1
move grpc_ares_ev_driver and fd_node definitions into grpc_ares_wrapper.cc
2020-12-28 11:51:16 -08:00
Esun Kim
2ff84ed8c2
C++ cast for void*
2020-11-30 17:29:15 -08:00
Esun Kim
ec0b88a5d7
Fix google-readability-casting
2020-11-30 17:27:51 -08:00
Esun Kim
75e3e660fd
Fix google-readability-todo
2020-11-25 10:09:42 -08:00
capstan
131579d52d
Roll forward of commit 7883b51: Use abseil's flags in tests.
...
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493 .
This reverts commit da66b7d14e .
NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440 .
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Nathan Herring
da66b7d14e
Revert "Abseil Flags"
2020-10-24 15:19:55 -07:00
capstan
7883b5133d
Use abseil's flags in tests.
...
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493 .
2020-10-23 19:36:33 +02:00
Esun Kim
aae4f4cf18
Fix by misc-unused-using-decls
2020-10-19 18:12:11 -07:00
Esun Kim
6ae8463500
Fix by modernize-make-unique
2020-10-16 13:30:56 -07:00
Esun Kim
ece76ee1e8
Fix code by readability-container-size-empty
2020-10-16 09:48:20 -07:00
Esun Kim
c08f33c437
Fix clang-tidy errors
2020-10-15 16:07:25 -07:00
Mark D. Roth
bd73844208
Move parse_address library from client_channel to iomgr.
2020-08-18 11:23:06 -07:00
Mark D. Roth
9404f66f70
Replace most uses of gpr_asprintf() with absl calls.
2020-07-07 12:01:02 -07:00
Alexander Polcyn
2c133c562d
Fix sorting of gRPCLB addresses when resolved via DNS
2020-05-29 10:43:45 -07:00
Mark D. Roth
c769951764
Remove deprecated variant of JoinHostPort().
2020-05-08 09:13:26 -07:00
Mark D. Roth
d74548e611
Remove StringViewToCString() and src/core/lib/gprpp/string_view.h
2020-04-27 12:28:28 -07:00
Yash Tibrewal
00458b3851
Merge branch 'master' into uselogicalthread and address reviewer
...
comments
2020-04-13 23:26:14 -07:00
Mark D. Roth
03411d7be7
Second attempt: grpclb stabilization
2020-03-31 07:52:44 -07:00
Yash Tibrewal
9ca286a48f
Replace LogicalThread with WorkSerializer
2020-02-07 16:14:33 -08:00
Yash Tibrewal
957f0390df
Reviewer comments
2020-02-06 15:28:13 -08:00
Yash Tibrewal
57638e0677
Merge branch 'master' into uselogicalthread
2020-02-04 16:20:08 -08:00
Mark D. Roth
283574e3b7
Convert service config code to use new JSON API
2020-02-04 07:42:31 -08:00
Jan Tattermusch
3f3cf8b62a
Revert "grpclb stabilization"
2020-01-20 14:11:16 +01:00