Commit Graph

2358 Commits

Author SHA1 Message Date
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Esun Kim 38472186b1 Disable XdsRoutingApplyXdsTimeout under Asan too 2020-10-29 12:00:36 -07:00
Richard Belleville 2ad3c0a041 Revert "Merge pull request #24568 from veblush/test-xds-abseil"
This reverts commit 9083de5017, reversing
changes made to 913760a6a9.
2020-10-28 15:22:20 -07:00
Richard Belleville acb198b961
Merge pull request #24585 from gnossen/fix_unused_return_value
Avoid internal build failure
2020-10-28 10:11:34 -07:00
Esun Kim dc9ef8fc39 Enable XdsRoutingApplyXdsTimeout again under TSAN 2020-10-27 19:48:48 -07:00
Richard Belleville 6ec512d0f1 Avoid internal build failure 2020-10-27 16:08:11 -07:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
Esun Kim 3528a40fe5
Merge pull request #24506 from Capstan/absl-flags
Abseil Flags
2020-10-23 21:07:21 -07:00
Yang Gao 01596014af
Merge pull request #24521 from yang-g/ip46
Check localhost is resolved to ipv4 or ipv6 and update test accordingly.
2020-10-23 16:30:17 -07:00
yang-g 8456e2138a Check localhost is resolved to ipv4 or ipv6 and update test accordingly. 2020-10-23 14:38:36 -07:00
Esun Kim 2089785b62 Disable XdsRoutingApplyXdsTimeout test under TSAN 2020-10-23 13:50:20 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Mark D. Roth ededb8e173
Merge pull request #24516 from markdroth/xds_nack_status
xds: Set status code to INVALID_ARGUMENT when NACKing.
2020-10-22 13:46:02 -07:00
Mark D. Roth 1f95593de7 xds: Set status code to INVALID_ARGUMENT when NACKing. 2020-10-21 14:09:50 -07:00
Yash Tibrewal 02ca015b13 Experimental support and tests for CreateCustomInsecureChannelWithInterceptorsFromFd 2020-10-21 13:34:26 -07:00
Mark D. Roth 8e84e63a83
Merge pull request #24481 from markdroth/xds_circuit_breaking_global_atomic
Use a global atomic for circuit breaking call counter.
2020-10-20 14:22:54 -07:00
Esun Kim aae4f4cf18 Fix by misc-unused-using-decls 2020-10-19 18:12:11 -07:00
Mark D. Roth b607080400 Use a global atomic for circuit breaking call counter. 2020-10-19 15:15:32 -07:00
Esun Kim bba8facb4a
Merge pull request #24456 from veblush/tidy-readability-redundant-smartptr-get
[Clang-Tidy] readability-redundant-smartptr-get
2020-10-19 09:54:15 -07:00
Mark D. Roth 1bb28c90b2
Merge pull request #24436 from markdroth/xds_resource_version
Fix xDS resource type version to persist across stream restarts.
2020-10-19 08:41:50 -07:00
Esun Kim 84df61b31a
Merge pull request #24453 from veblush/tidy-modernize-make-unique
[Clang-Tidy] Enable modernize-make-unique
2020-10-16 16:35:08 -07:00
Esun Kim 946ed32bac
Merge pull request #24454 from veblush/tidy-modernize-use-override
[Clang-Tidy] modernize-use-override
2020-10-16 16:33:29 -07:00
Mark D. Roth bce7bc78ab Fix xDS resource type version to persist across stream restarts. 2020-10-16 14:55:28 -07:00
Mark D. Roth dbe76ce6fd
Merge pull request #24434 from markdroth/xds_resource_version_test
Fix ADS server resource type version logic and refactor code.
2020-10-16 14:52:42 -07:00
Esun Kim 3fef4e7435 Fix by readability-redundant-smartptr-get 2020-10-16 14:16:42 -07:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
donnadionne ad66015c85
Merge pull request #24328 from donnadionne/timeout
Setting timeout in method config.
2020-10-16 13:43:25 -07:00
Esun Kim 6ae8463500 Fix by modernize-make-unique 2020-10-16 13:30:56 -07:00
Esun Kim f3cedfd357
Merge pull request #24437 from veblush/clang-tidy-abseil
[Clang-Tidy] Enable abseil-*
2020-10-16 12:21:51 -07:00
Donna Dionne a3ce1f745a Setting timeout in method config. 2020-10-16 11:37:52 -07:00
Mark D. Roth 63546c0faf Fix ADS server resource type version logic and refactor code. 2020-10-16 11:18:49 -07:00
Esun Kim ece76ee1e8 Fix code by readability-container-size-empty 2020-10-16 09:48:20 -07:00
Esun Kim a51fe3e675 Fix abseil-* clang-tidy errors 2020-10-16 09:39:41 -07:00
Esun Kim 09ace01cc1
Merge pull request #24193 from veblush/clang-tidy
Improve clang tidy to use compilation DB
2020-10-15 15:46:13 -07:00
Donna Dionne 5a25a427b5 Protecting the circuit breaking (drop action) using environment
variable. All the logic of refcounting are left but will not result in
any actions.  Test added to test protected case.
2020-10-13 10:04:13 -07:00
Esun Kim 6d6648c7e1 Fix clang-tidy errors 2020-10-13 09:51:31 -07:00
Mark D. Roth 50ed78d1f9
Merge pull request #24395 from markdroth/xds_load_stats_refs
Use a single instance of the drop and locality stats objects.
2020-10-12 16:47:06 -07:00
Mark D. Roth a6954fe39e Use a single instance of the drop and locality stats objects. 2020-10-12 14:14:52 -07:00
Mark D. Roth caf798e9ab xds: Add support for case_sensitive option in RouteMatch. 2020-10-09 14:49:23 -07:00
Yash Tibrewal 4013fd9dc9
Merge pull request #24313 from yashykt/xdscredscpp
C++ API to create Xds channel credentials
2020-10-08 22:27:21 -07:00
Yash Tibrewal c52cb09f47 Add experimental XdsCredentials with support for insecure channel_credentials and security_connector 2020-10-08 20:37:47 -07:00
Esun Kim 8e9e895ffc Replace grpc_shutdown_blocking with grpc_shutdown 2020-10-08 10:57:05 -07:00
Vijay Pai 37a09aaae3 Remove unused experimental stub format 2020-10-06 17:41:20 -07:00
Mark D. Roth 799e805e8a Move locality load reporting to EDS policy. 2020-10-02 11:16:01 -07:00
Mark D. Roth 8c142a1d8c
Merge pull request #24299 from markdroth/xds_test_crash_fix
Don't try to use global xds channel args after they've been destroyed.
2020-10-01 09:59:17 -07:00
Mark D. Roth dcc94158ac Don't try to use global xds channel args after they've been destroyed. 2020-10-01 07:10:32 -07:00
Donna Dionne ea4cb41bd2 Remove unused variable. 2020-09-30 10:08:56 -07:00
Mark D. Roth 537467eb0e
Merge pull request #24258 from markdroth/service_config_parser_channel_args
Allow channel args to modify service config parsing behavior.
2020-09-30 08:17:46 -07:00
Donna Dionne e7d7b7de86 xDS circuit breaking support 2020-09-29 14:47:39 -07:00
Mark D. Roth b62d5c7eaa Allow channel args to modify service config parsing behavior. 2020-09-29 13:13:26 -07:00
Mark D. Roth efb38591ac
Merge pull request #24239 from markdroth/xds_client_shared
Share XdsClient between channels
2020-09-28 08:07:02 -07:00
Mark D. Roth 1ba51dcb1a Share XdsClient between channels. 2020-09-27 15:26:28 -07:00
Mark D. Roth 2fe1a5cd0a Add missing const_cast<>. 2020-09-25 10:00:32 -07:00
Mark D. Roth 5e30156069
Merge pull request #24201 from markdroth/xds_client_no_parent_channel_args
Stop propagating parent channel args into xDS channel.
2020-09-25 07:49:25 -07:00
Esun Kim 1c7d5b5299 Fix MSAN adjustment 2020-09-23 18:22:10 -07:00
Mark D. Roth 7baf55e473 Stop propagating parent channel args into xDS channel. 2020-09-23 15:09:07 -07:00
Mark D. Roth 6ea7e4dd16 Fix channel to apply new ConfigSelector even if ServiceConfig hasn't changed. 2020-09-18 18:05:37 -07:00
Mark D. Roth f7a72b040d Pass address to CreateSubchannel() and expose attributes in SubchannelInterface. 2020-09-17 14:51:25 -07:00
Mark D. Roth a11e4df082
Merge pull request #24114 from markdroth/config_selector_error_handling2
Simplify service config processing and fix config selector handling.
2020-09-16 15:04:59 -07:00
Mark D. Roth 4bb00c25c0 Fix cut-and-paste error and change test to catch this kind of bug. 2020-09-16 10:12:12 -07:00
Mark D. Roth 84c8f7051a Simplify service config processing and fix config selector handling. 2020-09-15 16:49:52 -07:00
Mark D. Roth 5107e65a93 Stop setting PROXYLESS_CLIENT_HOSTNAME node metadata in LRS request. 2020-09-15 14:55:17 -07:00
Donna Dionne fa4f131a85 Increasing failover time to avoid errors like
I0914 19:15:38.606657832 40 priority.cc:658] [priority_lb 0x611000009b40] child child2 (0x613001702bc0): failover timer fired, reporting TRANSIENT_FAILURE

Should prevent flakes in InitialUnavailable tests

Note: test had to be modified to reproduce more easily, will monitor the
test after this fix to ensure problem does not appear again.
2020-09-15 10:47:54 -07:00
Mark D. Roth ae0cc5052b
Merge pull request #24150 from markdroth/xds_eds_duplicate_update_fix
Fix EDS update equality check.
2020-09-15 07:32:52 -07:00
Mark D. Roth 414405d6ae Fix EDS update equality check. 2020-09-14 16:40:56 -07:00
Donna Dionne 5c242f0577 Fixing flake in DeadUpdate
It is observed that ADS is shutdown, but it's possible that
a request still comes in.

This request should not update the ADS resource_type_response_state_ as
they were cleared by the shutdown.

This fix ensures this.
2020-09-13 12:51:37 -07:00
Donna Dionne ffb560090a Moving XDS Routing functionalities from LB policy into XdsConfigSelector 2020-09-11 15:44:10 -07:00
Donna Dionne 2d10cd4d26 Ensure SendRpc is not called without checking return value; use
CheckRpcSendOk to wrap it.
2020-09-09 17:37:00 -07:00
Donna Dionne 1b1a41df5d New Tests to guard against regression when routing and weighted target
logic are moved from policies to XdsConfigSelector:

1. Cluster update test: we never had a test that explicitly updated
clusters multiple times.
2. A cluster update test that includes long running RPCs, in particular,
RPCs not yet committed.
2020-09-08 12:20:56 -07:00
Mark D. Roth 5adf794eec Increase polling timeout for NoMatchedDomain test. 2020-08-25 07:18:52 -07:00
Mark D. Roth 91b698d232 Revert "Merge pull request #23969 from grpc/revert-23918-xds_virtual_host_validation"
This reverts commit 13b5f0b625, reversing
changes made to 9ea2d7c89d.
2020-08-25 07:03:28 -07:00
donnadionne 4cb21ff819
Revert "xds: Don't identify the needed VirtualHost at validation time." 2020-08-24 21:46:00 -07:00
Mark D. Roth b0a8b4606c xds: Don't identify the needed VirtualHost at validation time. 2020-08-21 11:39:35 -07:00
Mark D. Roth 9a39f172a6 xds: NACK if response includes duplicate resource names. 2020-08-20 16:17:57 -07:00
Jan Tattermusch afda101854 cleanup bazel commands in test scripts (for non-RBE invocations) 2020-08-20 12:22:09 +02:00
Donna Dionne dc7f926b9e Fixing the transient failure that occurs during the case
where CDS response missing a resource that we have newly requested
(the resource will likely be contained in subsequent responses).
2020-08-19 10:25:02 -07:00
Mark D. Roth bd73844208 Move parse_address library from client_channel to iomgr. 2020-08-18 11:23:06 -07:00
Yash Tibrewal bef69db1a6 A bit of cleanup 2020-08-17 16:24:40 -07:00
Vijay Pai c2d2220ba5 Make MaybeExpect guarantee at-most-once and allow Verify reuse 2020-08-14 10:30:48 -07:00
Karthik Ravi Shankar cfd1069ae0 Fix formatting 2020-08-13 14:25:43 -07:00
Karthik Ravi Shankar 242b1b87f8 Merge branch 'master' into flaky-fix 2020-08-13 14:25:27 -07:00
Vijay Pai 6040d621bd Fix destruction order bug in nested lock test 2020-08-12 09:44:49 -07:00
Karthik Ravi Shankar 218c5fd235 Mark client_crash_test as flaky
This test fails under asan.
2020-08-11 16:00:13 -07:00
Mark D. Roth d926e1ca47 Move XdsClient code out of client_channel tree. 2020-08-07 08:21:09 -07:00
Yash Tibrewal d35c1c13cd
Merge pull request #23636 from yashykt/settingsdeadline
Receive SETTINGS frame on clients before declaring subchannel READY
2020-08-03 14:04:02 -07:00
Yash Tibrewal e310d4366c Receive SETTINGS frame on clients before declaring subchannel READY 2020-07-31 02:01:40 -07:00
ashithasantosh cd9a127502
Merge pull request #23489 from michaelywg/endpoint_local_accessor
modified grpc_endpoint vtable and implementations
2020-07-30 13:54:16 -07:00
Esun Kim 79adbe59d5
Merge pull request #23673 from veblush/msan-fix
Add TestEnvironment to tests
2020-07-29 21:20:59 -07:00
Esun Kim f2374fb591 Add TestEnvironment to tests 2020-07-29 19:29:55 -07:00
Donna Dionne 33c128e99e Fixing a flaky test in ClientLoadReportingWithDropTest 2020-07-29 17:27:23 -07:00
Mark D. Roth 60283a1085
Merge pull request #23582 from markdroth/grpclb_authority
Remove TargetAuthorityTable in favor of a per-address channel arg.
2020-07-29 15:18:13 -07:00
Michael Wang c6586f087f implemented get_local_address accessor for grpc_endpoint 2020-07-29 19:39:22 +00:00
Vijay Pai 5488e7b5cd
Merge pull request #23478 from grpc/vjpai-patch-1-1
Avoid unused variables
2020-07-28 12:51:49 -07:00
Vijay Pai 9c5a39c6db Revert "Merge pull request #23361 from vjpai/em_agnostic_core_callback_cq"
This reverts commit a46cb5e86a, reversing
changes made to b5d42e75fb.
2020-07-28 09:55:43 -07:00
Vijay Pai bcb6530717 Revert "Merge pull request #23430 from vjpai/remove_do_not_test"
This reverts commit 08d737abf8, reversing
changes made to 6dc44b33c7.
2020-07-28 09:55:17 -07:00
Mark D. Roth 181781387d xDS v3 support 2020-07-23 10:20:55 -07:00
Mark D. Roth c35a37d6c2 Remove TargetAuthorityTable in favor of a per-address channel arg. 2020-07-23 08:23:05 -07:00
Donna Dionne 0d6ee9b309 Implement fake and ignored headers.
Take care to ensure we use fake headers in testing so we don't
conflict with headers used by census.
2020-07-20 12:34:02 -07:00
Mark D. Roth e681f37054 Remove env var protection of new xds routing code. 2020-07-20 07:59:07 -07:00
Karthik Ravi Shankar d7565c37a8 Revert "Adding Fake headers for header matching."
This reverts commit 8c013bfcdc.
2020-07-17 16:39:05 -07:00
Mark D. Roth fc5bd60f16 Concatenate duplicate header keys for matching. 2020-07-15 15:48:32 -07:00
Donna Dionne 8c013bfcdc Adding Fake headers for header matching. 2020-07-15 13:14:19 -07:00
Vijay Pai 612a3dfa10
clang-format 2020-07-14 14:10:54 -07:00
Vijay Pai bec17c1dd3
Avoid unused variables 2020-07-14 14:09:09 -07:00
Vijay Pai d03daab509
Remove unused variable (fixes builder error) 2020-07-09 16:28:14 -07:00
Vijay Pai 08d737abf8
Merge pull request #23430 from vjpai/remove_do_not_test
Remove references to skipping callback API tests
2020-07-09 15:57:35 -07:00
Muxi Yan 3b2e473548
Merge pull request #22345 from muxi/grpclb-name-config
Update grpclb configuration with field "service_name"
2020-07-09 13:32:55 -07:00
Vijay Pai e1a45fb237 Remove references to skipping callback API tests 2020-07-09 11:45:01 -07:00
Muxi Yan 232756e7bf Remove unnecessary RPC 2020-07-09 09:37:05 -07:00
Vijay Pai a46cb5e86a
Merge pull request #23361 from vjpai/em_agnostic_core_callback_cq
EM-agnostic core callback CQ
2020-07-09 09:35:49 -07:00
Vijay Pai 407fdc3a36 Fix data race in RpcWithEarlyFreeRequest by using atomics 2020-07-08 22:18:40 -07:00
Vijay Pai c6c05910c2 Fix data race in RpcWithEarlyFreeRequest by using atomics 2020-07-08 22:17:54 -07:00
Muxi Yan fa28bab456 Address comments 2020-07-08 16:56:21 -07:00
Vijay Pai 7ee2bc6db5 EM-agnostic callback completion queue 2020-07-08 16:12:23 -07:00
Mark D. Roth a5120b90ba
Merge pull request #23417 from markdroth/lb_policy_path
Make request path more easily visible to LB policies.
2020-07-08 14:57:29 -07:00
Vijay Pai 17b4879677
Merge pull request #23416 from vjpai/ccet
Make sure that some test ops don't start concurrently with Finish
2020-07-08 13:39:01 -07:00
Mark D. Roth 7c3fefea3f Make request path more easily visible to LB policies. 2020-07-08 12:12:30 -07:00
Vijay Pai fe2e9d6803 Properly count messages sent 2020-07-08 09:06:47 -07:00
Mark D. Roth 3201d7f7bf
Merge pull request #23157 from markdroth/gpr_asprintf
Replace most uses of gpr_asprintf() with absl calls.
2020-07-07 16:01:48 -07:00
Vijay Pai 0ab6db4fe8 Make sure that some ops don't start concurrently with Finish 2020-07-07 14:48:12 -07:00
Donna Dionne 8dd0cb4712 Add support for xDS regex matchers. 2020-07-07 13:17:25 -07:00
Muxi Yan ec2cd96426 Address comments 2020-07-07 13:13:38 -07:00
Muxi Yan 3f684093d7 Add test for the new config field 2020-07-07 13:13:37 -07:00
Mark D. Roth 9404f66f70 Replace most uses of gpr_asprintf() with absl calls. 2020-07-07 12:01:02 -07:00
Donna Dionne 459b58ae3d Merge remote-tracking branch 'upstream/master' into matcher_new 2020-07-06 12:54:56 -07:00
Esun Kim 8d0e703393
Merge pull request #22813 from mehrdada/fix-static-initialization-crap
Fix channelz plugin initializer
2020-07-06 11:19:05 -07:00
Donna Dionne 60b878d3a5 New Matchers Implementation
- All except for Regex (which will be submitted with RE2 import PR)
2020-07-06 10:54:22 -07:00
yang-g 162fca110c Fix message_allocator_e2e_test 2020-07-01 09:39:14 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Vijay Pai 84cf666014
Merge pull request #23229 from grpc/revert-23116-revert-23005-asyncwrite
Roll-forward: Fix StartCall: make corking work and allow concurrent Start*
2020-06-17 00:31:56 -07:00
Vijay Pai 7eebba3781 Fixes needed to make roll-forward of StartCall and corking work 2020-06-16 13:06:16 -07:00
Vijay Pai 278671072f
Revert "Revert "Fix StartCall: make corking work and allow concurrent Start*"" 2020-06-16 12:20:19 -07:00
Donna Dionne 97904d77a4 Adding the printing of error message when unexpected status returns. 2020-06-16 11:03:12 -07:00
Vijay Pai a379951943
Merge pull request #23202 from vjpai/flaky
Fix flaky_network_test
2020-06-13 01:12:06 -07:00
Vijay Pai 5a2f60d137 Allow skipping canceled check 2020-06-12 15:29:49 -07:00
Donna Dionne b35b463a08 reject RouteConfiguration with a case-insensitive RouteMatch 2020-06-12 15:19:32 -07:00
Vijay Pai 8c27a5e37e
Merge pull request #23187 from vjpai/end2end
Increase reconnect sleep time in end2end_test to 5x poller interval
2020-06-11 16:37:40 -07:00
Vijay Pai fa1c66852b Increase reconnect sleep time to 5x poller interval 2020-06-11 14:47:53 -07:00
Vijay Pai b269fdbf8b Don't mark server RPC canceled if finished with non-OK status 2020-06-11 10:15:05 -07:00
Mark D. Roth 3f0eb8ae77
Merge pull request #23117 from markdroth/xds_resource_removal_crash_fix
Fix use-after-free bug for ResourceState of unsubscribed RDS resource.
2020-06-03 07:15:17 -07:00
Mark D. Roth 21ee2335d2 Fix use-after-free bug for ResourceState of unsubscribed RDS resource. 2020-06-02 14:01:04 -07:00
Karthik Ravi Shankar 11c54ada0d
Revert "Fix StartCall: make corking work and allow concurrent Start*" 2020-06-02 11:11:06 -07:00
Mark D. Roth c566b0f7af
Merge pull request #23105 from markdroth/xds_uri_scheme
Support xDS via both "xds" and "xds-experimental" URI schemes.
2020-06-02 09:26:21 -07:00
Mark D. Roth d2646941b0 Fix xds_end2end_test to not set the response state back to SENT. 2020-06-01 15:03:22 -07:00
Mark D. Roth d674fa3e37 Support xDS via both "xds" and "xds-experimental" URI schemes. 2020-06-01 14:39:37 -07:00
Donna Dionne 44eb8a6def Putting in a temp fix for flaky tests.
Temporiarly increase tolerance for small load of RPCs
2020-05-29 13:19:29 -07:00
Mark D. Roth 832da8bd26
Merge pull request #22926 from markdroth/xds_cds_resource_does_not_exist
xds: Put channel in TRANSIENT_FAILURE when CDS resource is removed.
2020-05-26 08:28:36 -07:00
donnadionne 260b0528ba
Merge pull request #22983 from donnadionne/ignore
Default Route matcher checking:
2020-05-21 10:24:19 -07:00
Vijay Pai cf0727665d
Merge pull request #23005 from vjpai/asyncwrite
Fix StartCall: make corking work and allow concurrent Start*
2020-05-20 13:50:08 -07:00
Donna Dionne 12821db7f8 Merge remote-tracking branch 'upstream/master' into ignore 2020-05-20 11:21:35 -07:00
donnadionne efb83983b8
Merge pull request #22934 from donnadionne/features
Allowing the default route to be weighted_clusters; this support is
2020-05-20 10:54:37 -07:00
Vijay Pai 899cbcab96 Fix StartCall: make corking work and allow concurrent Start* 2020-05-20 10:02:22 -07:00
Donna Dionne 2ec96be5db Default Route matcher checking:
- if xds routing is disabled: only allow matcher to be empty or single
slash( same behaviour as 1.28)
- if xds routing is enabled: ignore all supported path matchers and reject
all unsupported path matchers
2020-05-18 14:55:44 -07:00
Mark D. Roth 2ba3f8e7f9 Trigger xds routing support via env var instead of channel arg. 2020-05-15 09:11:34 -07:00
Donna Dionne ec5f805e34 Allowing the default route to be weighted_clusters; this support is
already there, adding a test to prove that it's working.
2020-05-12 15:55:56 -07:00
Donna Dionne 9ad561c436 Integrating weighted target policy into xds routing policy 2020-05-12 13:52:10 -07:00
Mark D. Roth 0db28f7eaf xds: Put channel in TRANSIENT_FAILURE when CDS resource is removed. 2020-05-11 14:45:40 -07:00
Mark D. Roth 581751b65b xds: When listener does not exist, put channel in TRANSIENT_FAILURE. 2020-05-08 11:46:53 -07:00
Vijay Pai 29151efd34
Merge pull request #22837 from vjpai/channel_acec
Fixes on ApplicationCallbackExecCtx
2020-05-07 17:06:28 -07:00
Vijay Pai 611dccb492 Add a test without WritesDone and reorder destruction 2020-05-07 13:10:51 -07:00
Vijay Pai 113c7fcb7c
Mark override on service method 2020-05-07 08:35:24 -07:00
Donna Dionne 7fe44d8b1e Fixing a build error
A parameter has been removed, but the next PR merged cleanly while still
using the removed parameter.
2020-05-06 17:05:13 -07:00
Mark D. Roth 7b3590d543
Merge pull request #22854 from markdroth/xds_lrs_send_all_clusters
xds: Add support for send_all_clusters field in LRS.
2020-05-06 09:33:41 -07:00
Donna Dionne ac50289274 Modify the signature of all SetXdsResource methods to avoid un-necessary
parameter "name".
2020-05-04 17:14:54 -07:00
Mark D. Roth b95843c1b7 xds: Add support for send_all_clusters field in LRS. 2020-05-04 11:16:52 -07:00
Yash Tibrewal e291ef8bf9
Merge pull request #22746 from yashykt/fixfailsendmsg
Fix interceptor batch method FailHijackedRecvMessage for async APIs
2020-05-01 10:45:57 -07:00
Mark D. Roth 72a42151ed xds: Check RDS ConfigSource in LDS response. 2020-05-01 07:27:02 -07:00
Donna Dionne 092932b4dd Squash the last 2 commits. 2020-04-30 14:57:29 -07:00
Mark D. Roth d29865bb44
Merge pull request #22833 from markdroth/grpclb_status_fix
grpclb: Add test showing that backend status is returned to client.
2020-04-30 13:09:17 -07:00
Donna Dionne 9793af2b09 Consolidating LDS and RDS tests together
And refactoring the code to be able to reuse the same helper methods.

Updating all tests to use helper methods.
2020-04-30 11:55:02 -07:00
Mark D. Roth 0324afa89e grpclb: Add test showing that backend status is returned to client. 2020-04-30 10:28:17 -07:00
Mark D. Roth 1e9dc62db8 weighted_target: Create all children before updating any of them. 2020-04-30 07:34:50 -07:00
Mehrdad Afshari d9e3a49fe1 Fix server_builder_plugin_test 2020-04-28 20:18:01 -07:00
Muxi Yan eaadbd40bb
Merge pull request #22801 from grpc/revert-22794-revert-22778-fix-client-lb-end2end-tests
Revert "Revert "Fix client_lb_end2end_test flake""
2020-04-27 21:28:58 -07:00
Muxi Yan 2ade1dbe89 Fix client_lb_end2end_test flake 2020-04-27 16:38:41 -07:00
Mark D. Roth 8a14958980
Merge pull request #22729 from markdroth/absl_string_view_host_port
Remove StringViewToCString() and src/core/lib/gprpp/string_view.h
2020-04-27 14:21:09 -07:00
Mark D. Roth d74548e611 Remove StringViewToCString() and src/core/lib/gprpp/string_view.h 2020-04-27 12:28:28 -07:00
Muxi Yan 23c8cfcfda
Merge pull request #22794 from grpc/revert-22778-fix-client-lb-end2end-tests
Revert "Fix client_lb_end2end_test flake"
2020-04-27 12:23:50 -07:00
Mark D. Roth f0e2a43b1a
Merge pull request #22708 from markdroth/absl_string_view
Remove grpc_core::StringView.
2020-04-27 12:15:22 -07:00
donnadionne 7846840841
Merge pull request #22787 from donnadionne/policy_name
Ensuring each action is only generated once in service config, even
2020-04-27 09:33:36 -07:00
Mark D. Roth fc6f26c89b Remove grpc_core::StringView. 2020-04-27 07:46:13 -07:00
Jan Tattermusch f091a66999
Revert "Fix client_lb_end2end_test flake" 2020-04-27 13:02:37 +02:00
Donna Dionne 326a81bf87 Ensuring each action is only generated once in service config, even
if the same one is referred to multiple times by routes.

Added this test case in existing test case.
2020-04-25 23:04:35 -07:00
Donna Dionne 0ce79a560b Revert a change to XdsTest/ClientLoadReportingWithDropTest
This test was a bit flaky, but after the change, the msan runs are
failing more often.

Reverting the change while investigating futher
2020-04-25 20:54:05 -07:00
Muxi Yan 4f9425086b Fix client_lb_end2end_test flake 2020-04-24 16:15:43 -07:00
Mark D. Roth d39c981d4f
Revert "Remove StringLess and src/core/lib/gprpp/map.h" 2020-04-24 10:32:15 -07:00
donnadionne 56a3af5927
Merge pull request #22761 from donnadionne/vanilla
Fixing xds_end2end_test.cc: ClientLoadReporting Vanilla tests
2020-04-24 09:24:55 -07:00
Donna Dionne 0452c2a0cb Fixing xds_end2end_test.cc: ClientLoadReporting Vanilla tests
1. sometimes the StreamLoadStats service (in a separate thread) is not
    ready when we check to see if it has received and responded to request;
    moving the check to a bit later after we know that it has processed a
    report.
    2. Drop test numbers can fall out of range by little bit: 366 > 360.6;
    increasing traffic to smooth the result (this fix has been effective for
    other similar flakes)
2020-04-23 15:43:30 -07:00
Mark D. Roth c0f82fc595 Remove StringLess and src/core/lib/gprpp/map.h 2020-04-23 14:45:54 -07:00
Donna Dionne a7d9865961 Fixing xds_end2endtest.cc BackendsRestart flake test
Increase the number of RPCs after shutdown to ensure all
backends are down before restarting.
2020-04-23 10:10:07 -07:00
Yash Tibrewal edbae5d8e6 Fix interceptor batch method FailHijackedRecvMessage for async APIs 2020-04-22 23:05:57 -07:00
Yash Tibrewal c3f5c02276 Merge branch 'master' into uselogicalthread 2020-04-21 01:11:39 -07:00
Vijay Pai 5085805063
Remove some excessive logs 2020-04-17 13:22:11 -07:00
Donna Dionne 7db619ba95 Code review comments. 2020-04-17 11:19:19 -07:00
Donna Dionne 424e81eaec Code Review comments 2020-04-16 15:47:26 -07:00
Donna Dionne 584b35055e Merge remote-tracking branch 'upstream/master' into route_response 2020-04-16 13:10:15 -07:00
Donna Dionne 8bab28db08 Rearrange test_service_impl.h/cc to fix build failures. 2020-04-16 12:20:57 -07:00
Donna Dionne 63573b0515 Fixing a flaky test. 2020-04-15 17:33:31 -07:00
Yash Tibrewal fdd4496117 Merge branch 'master' into uselogicalthread 2020-04-15 15:44:58 -07:00
Donna Dionne 71aef940c3 Code review comments: added invalid config tests and restructured
testing code.
2020-04-15 13:09:03 -07:00
Mark D. Roth bf6e534714 Accept either "" or "/" as the prefix for the default route. 2020-04-15 09:24:55 -07:00
Donna Dionne 84b2b98af2 clang fix 2020-04-14 13:07:23 -07:00
Donna Dionne 3135d9751a Fixing a test after merge 2020-04-14 13:06:16 -07:00
Donna Dionne a70abab157 Merge remote-tracking branch 'upstream/master' into route_response 2020-04-14 12:53:18 -07:00
Donna Dionne b39feead62 Fixing code review comments. 2020-04-14 12:42:17 -07:00
Mark D. Roth cbf18222af
Merge pull request #22648 from markdroth/xds_remove_old_flow
xds: Remove fallback code and support for old xds LB configs.
2020-04-14 11:45:12 -07:00
Donna Dionne 921147d1aa clang change 2020-04-14 01:02:57 -07:00
Donna Dionne 9417b28bca Fixing build issues. 2020-04-14 00:44:47 -07:00
Donna Dionne 019b206926 Fixing CR comments and build errors. 2020-04-14 00:04:31 -07:00
Yash Tibrewal 00458b3851 Merge branch 'master' into uselogicalthread and address reviewer
comments
2020-04-13 23:26:14 -07:00
Donna Dionne 6ec6c24dc1 Fixing code review comments. 2020-04-13 22:16:42 -07:00
Muxi Yan 317a55dd7e
Use correct status code type 2020-04-13 11:47:15 -07:00
Mark D. Roth dc976d2a77 xds: Remove fallback code and support for old xds LB configs. 2020-04-13 11:09:36 -07:00
Donna Dionne ddb98d6b52 Fixing code review comments:
- added more tests and improved structuring of backend service
- fixing grpc_tool tests (due to adding of new test serices/methods
2020-04-12 16:28:39 -07:00
Donna Dionne 1ae804c8c0 Fixing code review comments:
- Fixing for comments in all except for test file
- Multi-purpose test_service_impl.h as oppose
to creating new files.
2020-04-11 21:39:40 -07:00
Donna Dionne 0a7b9dac06 Fixing code review comments. 2020-04-10 03:15:09 -07:00
Donna Dionne 8a8ca5436b Added grpc arg to enable xds routing and restore old tests. 2020-04-10 01:26:05 -07:00
Donna Dionne c4d4541af5 Added TestMultipleServiceImpl.h: a templated test service to allow
multiple RPC services to be used in test.
2020-04-09 22:49:57 -07:00
Donna Dionne f5fd631a9c Merge remote-tracking branch 'upstream/master' into route_response 2020-04-09 11:10:28 -07:00
Donna Dionne d9611cf1ca Fixed AllServerUnavailableFailFast test to return UNAVAILBLE instead
UNKNOWN.
2020-04-08 16:20:16 -07:00
Mark D. Roth c3fc65c9e0 Don't NACK EDS updates with no localities, but report TRANSIENT_FAILURE. 2020-04-08 07:29:45 -07:00
Donna Dionne 0c2f9565f4 Fixing code review comments 2020-04-07 22:08:54 -07:00
Mark D. Roth f8f6034d1a Refactor xds LB policy 2020-04-07 14:03:01 -07:00
Donna Dionne f3f11cc21c Added new RPC methods to test routing different RPCs to different
backends.
2020-04-06 23:21:02 -07:00
Donna Dionne c0c7f1dae3 Fix build and test failures
Including the following
All all needed BUILD changes to include new xdsRouting
Fixed TSAN errors
AllServerUnavailableFailFast may return UNKNOWN as oppose UNAVAILABLE
ChooseLastRoute modified into 2 tests
2020-04-06 16:05:04 -07:00
Mark D. Roth e3b1c4335d
Merge pull request #22536 from markdroth/grpclb_load_reporting_test_flake
Fix flakiness in grpclb SingleBalancerWithClientLoadReportingTest.Vanilla test.
2020-04-01 13:21:10 -07:00
Mark D. Roth bac25901d7 Fix flakiness in grpclb SingleBalancerWithClientLoadReportingTest.Vanilla test. 2020-04-01 10:48:17 -07:00
Mark D. Roth 5b087c9d8b
Merge pull request #22535 from markdroth/grpclb_end2end_test_flake
Fix flakiness in grpclb_end2end_test ReresolveDeadBalancer test case.
2020-04-01 10:42:46 -07:00
Mark D. Roth 85571e4c77
Merge pull request #22525 from markdroth/xds_lrs_fix
Report RPC failures to LB recv_trailing_metadata callbacks.
2020-04-01 07:58:56 -07:00
Mark D. Roth dcdd04fcaa Fix flakiness in grpclb_end2end_test ReresolveDeadBalancer test case. 2020-04-01 07:49:52 -07:00
Donna Dionne 0306829596 Merge remote-tracking branch 'upstream/master' into route_response 2020-03-31 17:38:16 -07:00
Mark D. Roth df27e42372 Report RPC failures to LB recv_trailing_metadata callbacks. 2020-03-31 14:44:45 -07:00
Mark D. Roth 03411d7be7 Second attempt: grpclb stabilization 2020-03-31 07:52:44 -07:00
Donna Dionne f487d1be61 Addressing code review comments. 2020-03-30 23:31:54 -07:00
Mark D. Roth 0c1414f1c9
Merge pull request #22502 from markdroth/xds_drop_all_fix
xds: don't report TRANSIENT_FAILURE when we're told to drop all
2020-03-30 08:02:58 -07:00
Mark D. Roth 0e1c63a7a1 xds: don't report TRANSIENT_FAILURE when we're told to drop all 2020-03-27 15:05:07 -07:00
Vijay Pai 32a33ae2b1 Properly set thread-local variable indicating nonblocking test 2020-03-27 13:14:36 -07:00
Mark D. Roth fcd8bbd34c minor cleanups in xds_end2end_test 2020-03-27 09:07:24 -07:00
Mark D. Roth f33570f576
Merge pull request #22493 from markdroth/xds_eds_empty_locality
xds: Add tests showing that we do not use localities with no endpoints.
2020-03-27 07:16:50 -07:00
Mark D. Roth 652b5a8673 xds: Add tests showing that we do not use localities with no endpoints. 2020-03-26 15:48:55 -07:00
Yash Tibrewal a2df32e657 Merge branch 'master' into uselogicalthread 2020-03-25 20:57:31 -07:00
Mark D. Roth 38f02d8e2b xds: NACK EDS update with sparse priorities 2020-03-25 09:31:47 -07:00
Donna Dionne ac79383583 Debugging xds_end2endtest DropTest Update by sending more initial
traffic.
2020-03-23 11:35:55 -07:00
Mark D. Roth 343b5403df xds: Send RDS request when retrying ADS call. 2020-03-23 07:55:18 -07:00
Donna Dionne 70ac4b6418 Basic Parsing, building service config, and Picking are all exercised
with basic tests.
2020-03-23 00:34:14 -07:00
donnadionne 241277ca5b
Merge pull request #22425 from donnadionne/err_msg
Debugging xds_end2endtest LocalityMap UpdateMap by sending more traffic
2020-03-19 16:56:33 -07:00
Donna Dionne d8fc6bd4c6 Addressing code review comments. 2020-03-19 14:31:37 -07:00
Donna Dionne f9f59ba222 Debugging xds_end2endtest LocalityMap UpdateMap by sending more traffic
The test is failing due to the backend not getting the expected amount
of traffic by a small margin.

Increasing traffic and adding debugs.
2020-03-19 14:12:28 -07:00
Mark D. Roth 611cf644bc Use wait_for_ready for xds calls. 2020-03-18 12:12:34 -07:00
Mark D. Roth 5927f9b625 Gracefully switch xds policy instances when cluster name changes, and other LRS-related fixes. 2020-03-18 07:42:32 -07:00
Jan Tattermusch bccdd0cb29
Merge pull request #22356 from jtattermusch/more_flakes
Mark client_lb_end2end_test as flaky
2020-03-17 17:51:13 +01:00
Jan Tattermusch 2e266a82d9 mark end2end test as flaky 2020-03-17 06:24:25 -04:00
Jan Tattermusch bda2519eeb mark client_lb_end2end_test as flaky 2020-03-16 03:14:00 -04:00
Donna Dionne 50a04f99e7 Merge remote-tracking branch 'upstream/master' into route_response 2020-03-15 15:57:38 -07:00
Mark D. Roth be7da6b149
Merge pull request #22330 from markdroth/xds_locality_map_update_fix
If an EDS update replaces all localities in a priority, go into CONNECTING
2020-03-13 08:07:12 -07:00
donnadionne 7afdaf818b
Merge pull request #22298 from donnadionne/flakes
Fix flake in LocalityMapTest.UpdateMap test
2020-03-12 14:38:53 -07:00
Mark D. Roth 4c200b4300 If an EDS update replaces all localities in a priority, go into CONNECTING. 2020-03-12 13:49:30 -07:00
Donna Dionne a61c6c36ba LocalityMapTest.UpdateMap is rewritten
to set the second EDS update more deterministically instead of using
a delay.

This test popped up as a flake after the refactoring of the xds_end2end
test and it can now be rewritten to be more determinsitic.
2020-03-10 18:39:04 -07:00
Mark D. Roth 86cbef7f72 clang-format 2020-03-10 15:59:28 -07:00
Mark D. Roth 6b315db2ba add test for removed cluster resource 2020-03-10 15:57:08 -07:00
Mark D. Roth 027492ff86 add missing comment 2020-03-10 15:28:32 -07:00
Mark D. Roth 46b4414655 change logic to send empty response when resources go away 2020-03-10 11:44:39 -07:00
Mark D. Roth c306d7940f add test for changing clusters 2020-03-10 10:53:39 -07:00
Mark D. Roth b4d5901b5e clean up test code 2020-03-10 10:49:24 -07:00
Donna Dionne 7a146722db Harded coded a service config to point to xds_routing_experimental
With just 1 action, which has 1 child policy: cds_experimental

Basically wrapping the previous cds_experimental config inside the new
xds_routing_experimental

Tested to make sure all current tests still pass.

This is just a skeleton code to allow new parsing code to be added and
tested.
2020-03-09 16:47:24 -07:00
Donna Dionne e2178cc1ff Merged and addressed code review comments. 2020-03-04 17:03:39 -08:00
Donna Dionne 854ebff0c3 Making ClingTidy changes
https://critique-ng.corp.google.com/cl/298652594/analysis
2020-03-03 19:31:32 -08:00
Esun Kim 30f88e8b76
Merge pull request #22210 from veblush/docker-for-sanity
Docker for sanity
2020-03-03 14:22:07 -08:00
Esun Kim b308241343 Fix clang-tidy issues 2020-03-03 12:27:41 -08:00
Esun Kim 415d41f9e8 Rerun clang-formatter-7 2020-03-03 10:46:55 -08:00
Donna Dionne d5689c37ed Converting AdsServiceImpl to a Fake
- Allow Resources to be set
- Allow clients to subscribe/unsubscribe to resources
- Managing, storing, and versioning resources correctly based on updates
- Correct ACK/NACK according to XDS protocol
- Started a separate blocking thread to be used for stream read
- Handling both requests from clients and updates from tests and respond
with the correct version of resource
- Consolidated all 4 resources (LDS, CDS, EDS, RDS) to share common code
- Updated all tests to use the fake properly
- Fixed potential crash cases in the subchannel thread for clean TSAN,
UBSAN runs
2020-03-03 09:10:53 -08:00
Yash Tibrewal 874b89dcfc Merge branch 'master' into uselogicalthread 2020-03-02 11:26:24 -08:00
Yash Tibrewal 2cdab491a3 Cleanup 2020-03-02 11:19:21 -08:00
Jan Tattermusch e00bec7bbb mark grpclb_end2end_test as flaky 2020-03-01 22:29:27 -05:00
Jan Tattermusch cbb0ef2717 try marking some offenders as flaky 2020-02-27 22:37:32 -05:00
Mark D. Roth 144adbc194
Merge pull request #22147 from markdroth/xds_overprovisioning_capability
xds: send no-overprovisioning client capability and populate user_agent fields
2020-02-27 15:02:53 -08:00
Yash Tibrewal 35697a8f4d Merge branch 'master' into testingws2 2020-02-27 11:29:09 -08:00
Yash Tibrewal c6fa7eefb9 testing with locks in ws
Remove no_logging and add missing mu locks
2020-02-27 11:22:14 -08:00
Moiz Haidry 1d47046807 Merge from HEAD 2020-02-27 11:00:28 -08:00
Vijay Pai fe72304e54 Switch registered calls to a map and check the map before inserting 2020-02-27 09:13:42 -08:00
Moiz Haidry 4c5ee108da Addressed Yang's comments, I have removed usage of const throughout for consistency 2020-02-26 14:14:33 -08:00
Mark D. Roth b68f813e54 xds: send envoy.lb.does_not_support_overprovisioning client capability 2020-02-26 08:23:27 -08:00
Moiz Haidry 67565b767d CallCredentials debug string API 2020-02-25 16:09:03 -08:00
Mark D. Roth 2a67b2d55a
Merge pull request #22063 from markdroth/xds_lrs_metadata
Update LRS to use "PROXYLESS_CLIENT_HOSTNAME" metadata instead of cluster field.
2020-02-20 10:46:56 -08:00
Vijay Pai 3620abf059 Properly follow precise conditions for callback inlining 2020-02-20 01:34:30 +00:00
Mark D. Roth 06e34a1d4f Update LRS to use "PROXYLESS_CLIENT_HOSTNAME" metadata instead of cluster field. 2020-02-18 14:29:15 -08:00
Mark D. Roth cf032b300e xds: Fix crash when moving all localities from a priority to a higher priority. 2020-02-05 07:51:36 -08:00
Mark D. Roth 283574e3b7 Convert service config code to use new JSON API 2020-02-04 07:42:31 -08:00
Jan Tattermusch b8aa71ded7
Merge pull request #21833 from jtattermusch/reintroduce_again_21527
Reintroduce #21527 (boringssl submodule unification - take two)
2020-01-31 16:57:22 +01:00
Vijay Pai c34999ae2c Remove unneeded curly braces 2020-01-30 00:20:17 -08:00
Jan Tattermusch f098606c4a Revert "Revert "Reintroduce #21527 (boringssl submodule unification)""
This reverts commit cca892022b.
2020-01-29 09:18:51 -05:00
Vijay Pai d173d3fde8 Fix cancellation to make it easier to follow 2020-01-29 00:39:49 -08:00
Vijay Pai e695974375 Merge branch 'master' into synced_alarm 2020-01-28 23:59:12 -08:00
Mark D. Roth cb6168667c remove unused "using" declaration 2020-01-28 13:29:52 -08:00
Mark D. Roth 1490b5a24e Fix unused-result errors on import. 2020-01-28 12:47:37 -08:00
hcaseyal 5631724539
Merge pull request #21805 from grpc/revert-21797-reintroduce_21527
Revert "Reintroduce #21527 (boringssl submodule unification)"
2020-01-28 10:41:33 -08:00
Mark D. Roth 404d235153
Merge pull request #21775 from markdroth/xds_timeout
Support xds request timeouts.
2020-01-27 15:50:46 -08:00
hcaseyal cca892022b
Revert "Reintroduce #21527 (boringssl submodule unification)" 2020-01-27 13:46:10 -08:00
Mark D. Roth d7a91d59bb Support xds request timeouts. 2020-01-27 11:27:44 -08:00
Jan Tattermusch f91a1c5a69 avoid async_end2end_test timeout on msan 2020-01-27 05:27:55 -05:00
Mark D. Roth ac7c1d20ed Add LDS/RDS into XdsClient 2020-01-24 08:05:02 -08:00
Vijay Pai 3ade3e84a9 Make use of alarm in test service more robust 2020-01-22 10:31:25 -08:00
Jan Tattermusch 3f3cf8b62a
Revert "grpclb stabilization" 2020-01-20 14:11:16 +01:00
Yash Tibrewal 48139ebe2e Fix 21686 to use the correct status 2020-01-17 13:29:30 -08:00
Yash Tibrewal ccf20e254f Fix xds_end2end_test 2020-01-16 16:08:54 -08:00
Juanli Shen a0b812c30f Add CDS to xds client 2020-01-15 19:38:54 -08:00
Yang Gao 56972ae715
Merge pull request #21648 from yang-g/init_first
InitGoogleTest before grpc_init
2020-01-14 15:07:37 -08:00
yang-g 5bc57b64fe InitGoogleTest before grpc_init 2020-01-14 13:29:15 -08:00
Mark D. Roth 118fe7405f Increase test timeout to avoid flakiness. 2020-01-13 12:47:06 -08:00
Mark D. Roth 7388c47c91
Merge pull request #20803 from markdroth/grpclb_stabilization
grpclb stabilization
2020-01-10 10:47:46 -08:00
Mark D. Roth 5b18402914 grpclb stabilization 2020-01-10 09:13:10 -08:00
Esun Kim 9ae81e1d3f Make test code use TestEnvironment 2020-01-09 14:14:16 -08:00
Vijay Pai 027eb3b05b
Merge pull request #21532 from vjpai/deadline
Properly set up deadline for generic callback requests
2019-12-19 23:03:09 -08:00
Vijay Pai 9ccc6b0e38 Properly set up deadline for generic requests 2019-12-19 18:54:35 -08:00
Lidi Zheng d5d6914751 Make buildifier sanity test fail-able 2019-12-18 16:16:49 -08:00
Vijay Pai e522302e33
Merge pull request #21465 from vjpai/fix_cancel_delayed_rpc
Make CancelDelayedRpc test not use sleeps for client-server sync
2019-12-13 17:38:35 -08:00
Vijay Pai 24483d2afd Address reviewer comments 2019-12-13 15:17:34 -08:00
Mark D. Roth 31773d2c6a grpclb: Add support for balancer telling client to enter fallback mode. 2019-12-13 09:11:22 -08:00
Vijay Pai 9be35f74c0 Make CancelDelayedRpc test not use sleeps for client-server sync 2019-12-12 11:19:00 -08:00
Vijay Pai 7c46d37442
Merge pull request #21380 from vjpai/implement_generic_unary_reactor
Actually implement the generic reactor-based unary call
2019-12-05 15:18:17 -08:00
Mark D. Roth 866cb72063
Merge pull request #21374 from markdroth/xds_bootstrap_server
Support multiple xds servers in bootstrap file.
2019-12-05 07:42:32 -08:00
Mark D. Roth 408ec6e867 fix xds_end2end_test 2019-12-04 13:20:15 -08:00
Vijay Pai 88874094be Actually implement the generic reactor-based unary call. 2019-12-04 11:41:47 -08:00
Vijay Pai 526fcb5c7d
Merge pull request #21257 from vjpai/no_pthread
Prevent use of pthread header
2019-12-04 10:54:40 -08:00
Vijay Pai 2c87eaabd4 De-experimentalize generic features of callback API under an ifdef 2019-12-03 12:24:13 -08:00
Jan Tattermusch aa40b1c8b8
Merge pull request #20510 from jtattermusch/bazel_test_on_mac
Start running bazel C/C++ tests on mac
2019-11-27 12:09:43 +01:00
Jan Tattermusch 674b1f6f52 use more reasonable timeouts for sanitizer tests 2019-11-26 13:03:40 -05:00
Prashant Jaikumar 2526dfade5 WIP: Make core and C++ tests work with bazel on Mac OS 2019-11-25 13:35:26 +01:00
Jan Tattermusch 78888d7861 avoid thread local unitialized problem under GRPC_PTHREAD_TLS 2019-11-25 13:35:26 +01:00
Mark D. Roth 6950e15882
Merge pull request #21274 from markdroth/xds_test_sharding
Shard xds_end2end_test.
2019-11-22 12:56:13 -08:00
Mark D. Roth 3d3b6d8a8a shard xds_end2end_test 2019-11-22 10:36:10 -08:00
Vijay Pai be6979202b Revamp server-side C++ callback API, message allocator, and mocking 2019-11-20 16:56:18 -08:00
Jan Tattermusch 091f802554
Merge pull request #21218 from jtattermusch/bazel_timeout_cleanup
bazel: prefer using "size" over "timeout" for bazel tests
2019-11-20 19:53:56 +01:00
Vijay Pai 9cbd685304 Prevent use of pthread header 2019-11-19 15:26:55 -08:00
Vijay Pai 015a3e5811
Merge pull request #21239 from vjpai/server_shutdown_reorder
Fix server shutdown ordering bug
2019-11-19 12:33:41 -08:00
Vijay Pai 73de768139 Test server destruction without explicit Shutdown 2019-11-18 23:17:55 -08:00
Esun Kim 88527cc393 Add missing #include condition_variable 2019-11-18 15:06:56 -08:00
Esun Kim f40a702441 Clean up headers 2019-11-15 09:38:31 -08:00
Prashant Jaikumar c9117fa198 Fix C++ tests to enable running on android 2019-11-14 16:20:33 -08:00
Vijay Pai 334fffc8c7 Repeat changes of #20968 which were accidentally reverted 2019-11-14 08:38:35 -08:00
Jan Tattermusch 986070d280 use test size instead of timeout 2019-11-14 11:17:31 -05:00
Esun Kim e45b60d1fe Fix unique_ptr<char> memory allocation mismatch 2019-11-07 17:53:59 -08:00
Esun Kim b2b7fc9af8 Replaced grpc_core::UniquePtr with std::unique_ptr 2019-11-07 13:05:39 -08:00
Vijay Pai 3928a20bdf Fix outdated thread invocation that now causes Windows breakage 2019-11-07 01:48:33 -08:00
Esun Kim de81f120b2 Abseilify StringView 2019-11-06 10:58:03 -08:00
Lidi Zheng c34bef4ca4 Format all Bazel files with buildifier 2019-11-05 14:03:52 -08:00
Mark D. Roth 7ccdc85fa0 CDS LB policy 2019-10-29 12:00:12 -07:00
Mark D. Roth bc7c655e37 Revert "Merge pull request #20745 from grpc/revert-20679-eds_health_status"
This reverts commit 9647a1ed99, reversing
changes made to 61059132fa.
2019-10-25 10:23:23 -07:00
Mark D. Roth d942e69eac Add new fields to xds policy config. 2019-10-25 07:43:34 -07:00
Mark D. Roth d0c62504df Reuse the same ports for each test. 2019-10-24 10:57:34 -07:00
Mark D. Roth ea3e369649 Revert "Merge pull request #20772 from nanahpang/fix-xds-test-suite"
This reverts commit 100006d4cf, reversing
changes made to 47b873078f.
2019-10-24 10:40:42 -07:00
Jan Tattermusch b00a23e43b
Merge pull request #20766 from rmstar/xds_e2e_test_ios
Don't run xds_end2end_test on iOS
2019-10-24 09:45:31 +02:00
Na-Na Pang e925081c5b clang format 2019-10-23 17:42:54 -07:00
Na-Na Pang f7e47948b6 Comment out the test suites that has oversize port pool 2019-10-23 16:25:58 -07:00
Na-Na Pang 1a4fddf9a4 Comment out the test suites that has oversize port pool 2019-10-23 16:06:46 -07:00
Na-Na Pang ca6ba44c55 Comment out the test suites that has oversize port pool 2019-10-23 15:34:21 -07:00
nanahpang 2b06d76cc0
Merge pull request #20742 from grpc/revert-20526-xds_policy_config_additions
Revert "Add new fields to xds policy config."
2019-10-23 13:02:17 -07:00
Prashant Jaikumar 78e1b58402 Don't run xds_end2end_test on iOS 2019-10-23 11:35:40 -07:00
nanahpang 9647a1ed99
Merge pull request #20745 from grpc/revert-20679-eds_health_status
Revert "Ignore EDS endpoints that are unhealthy."
2019-10-23 10:11:31 -07:00
Vijay Pai 10b9e8ee4f
Merge pull request #20697 from vjpai/more_cpp_warning_removals_201910210916_19
Remove unused-parameter warnings, round 2 (19 of 19)
2019-10-23 00:23:00 -07:00
nanahpang 8574ccc57b
Revert "Add new fields to xds policy config." 2019-10-22 14:49:59 -07:00
nanahpang a925f2c928
Revert "Ignore EDS endpoints that are unhealthy." 2019-10-22 14:34:13 -07:00
Mark D. Roth 334c826e8c
Merge pull request #20701 from markdroth/xds_bootstrap_test_fix
Change xds_end2end_test to write out its own bootstrap files.
2019-10-21 12:26:03 -07:00
Mark D. Roth 4bdb034162 Change xds_end2end_test to write out its own bootstrap files. 2019-10-21 10:25:01 -07:00
Vijay Pai e35c869aaf Remove unused-parameter warnings, round 2 (19 of 19) 2019-10-21 09:16:35 -07:00
Mark D. Roth 2db50beaf5 Ignore EDS endpoints that are unhealthy. 2019-10-21 07:39:50 -07:00
Yash Tibrewal 9f9288fbb9
Merge pull request #20246 from yashykt/credentials_expose
Experimental method to get a debugging only view into credentials
2019-10-18 15:24:54 -07:00
Mark D. Roth ff2e7ab445
Merge pull request #20526 from markdroth/xds_policy_config_additions
Add new fields to xds policy config.
2019-10-18 14:59:51 -07:00
Mark D. Roth 16286cdbec Add new fields to xds policy config. 2019-10-18 13:52:40 -07:00
Vijay Pai b484e40e08
TYPED_TEST_CASE (deprecated) -> TYPED_TEST_SUITE 2019-10-17 17:18:14 -07:00
Vijay Pai d29d0d71e4
Merge pull request #20645 from vjpai/remove_warn_16
Remove unused parameter warnings (16 of 20)
2019-10-17 15:09:34 -07:00
Vijay Pai b36f7ab747
Merge pull request #20646 from vjpai/remove_warn_15
Remove unused parameter warnings (15 of 20)
2019-10-17 13:59:16 -07:00
Vijay Pai d90eb45780
Merge branch 'master' into remove_warn_16 2019-10-17 12:15:26 -07:00
Vijay Pai fbfaffaf5a clang-format 2019-10-17 09:07:46 -07:00
Vijay Pai 50d337b74d clang-format 2019-10-17 09:07:29 -07:00
Vijay Pai 30f1230c10 Remove unused parameter warning (16 of 20) 2019-10-17 08:51:55 -07:00
Vijay Pai 176dfc2289 Remove unused parameter warning (15 of 20) 2019-10-17 08:51:50 -07:00
Mark D. Roth 1564207245 Move XdsClient instantiation into xds resolver. 2019-10-17 07:25:03 -07:00
Mark D. Roth 9a276c07fa Revert "Merge pull request #20593 from grpc/revert-20380-xds_client_bootstrap"
This reverts commit 0bd5efa55f, reversing
changes made to f92c283a5d.
2019-10-15 07:33:53 -07:00
Jan Tattermusch 13abbd9a75
Revert "xds client bootstrap file" 2019-10-14 16:51:32 +02:00
Mark D. Roth 2afaec231d xds client bootstrap file 2019-10-09 14:06:48 -07:00
Juanli Shen 2dc42a1e02 Use ADS 2019-10-04 17:02:52 -07:00
Mark D. Roth 85a500c13a
Merge pull request #20368 from markdroth/xds_client
Refactor EDS and LRS code from xds LB policy into new XdsClient API.
2019-10-04 14:16:25 -07:00
Juanli Shen e130018bf5
Merge pull request #20432 from AspirinSJL/tune_xds
Tune xds test
2019-10-04 12:10:24 -07:00
Mark D. Roth b01072586d Refactor EDS and LRS code from xds LB policy into new XdsClient API. 2019-10-04 11:41:13 -07:00
Mark D. Roth 9fc4adae63
Merge pull request #20397 from markdroth/subchannel_health_check_connectivity
Change HealthCheckClient to use new connectivity state API.
2019-10-02 07:49:39 -07:00
Juanli Shen 46cff659e2 Tune xds test 2019-10-01 17:42:58 -07:00
Mark D. Roth f281c343b9 Change HealthCheckClient to use new connectivity state API. 2019-10-01 14:53:12 -07:00
Jan Tattermusch 5cc45de443 disable some broken test on windows RBE 2019-09-30 13:28:02 +02:00
Jan Tattermusch 3ce50ae754 disable some test on windows based on build.yaml 2019-09-30 13:28:01 +02:00
Juanli Shen 6ced125bb3 xds failover locality handling 2019-09-26 17:20:44 -07:00
Vijay Pai 5d7e4bb301 Stop using deprecated gtest macros 2019-09-24 14:56:41 -07:00
Mark D. Roth b0e428c28a
Merge pull request #20245 from markdroth/rr_connectivity_state
Change RR to consider a subchannel in TF if it has failed since it was READY.
2019-09-19 08:37:24 -07:00
Juanli Shen b1a56e0527
Merge pull request #20270 from AspirinSJL/mv_proto_2
Move xds protos to testing/
2019-09-18 20:07:05 -07:00
Juanli Shen 40c0519ad0 Move xds protos to testing/ 2019-09-18 10:20:58 -07:00
Juanli Shen b4277d191c
Merge pull request #20269 from AspirinSJL/tune
Tune xds test
2019-09-16 16:10:53 -07:00
Juanli Shen 7be5d098cf Tune xds test 2019-09-16 13:42:12 -07:00
Mark D. Roth 01eeec72c6 Change RR to consider a subchannel in TF if it has failed since it was READY. 2019-09-16 09:41:01 -07:00
Yash Tibrewal a4cf948b2f Experimental method to get a debugging only view into credentials 2019-09-12 12:31:29 -07:00
Yash Tibrewal f3cd878e0b
Merge pull request #20188 from yashykt/creds_interception
Allow call credentials interception at PRE_SEND_INITIAL_METADATA
2019-09-09 18:42:11 -07:00
Yash Tibrewal aa84ceb38e Add another test for when the credentials were previously set 2019-09-09 15:59:59 -07:00
Yash Tibrewal 361a902262 Reviewer comments 2019-09-06 14:20:39 -07:00
Yash Tibrewal 97f1f57dab Allow call credentials to be set even after the call is created but before initial metadata is sent 2019-09-05 18:13:59 -07:00
Prashant Jaikumar 9f02fc7f91 Enable end2end C++ tests on iOS.
Some e2e tests were disabled on iOS because they hit the Apple CFStream bug.
This commit enables e2e tests and works around the Apple bug by disabling CFStream.
2019-09-05 13:43:45 -07:00
Juanli Shen 91274b0430
Merge pull request #20152 from AspirinSJL/group_test
Organize test cases for xds test
2019-09-04 13:41:33 -07:00
Juanli Shen c831a28dbd Organize test cases for xds test 2019-09-03 16:47:25 -07:00
Vijay Pai 65eb9c9ddb
Revert "Test message size of 100MB" 2019-08-30 08:14:44 -07:00
Juanli Shen be4318810c
Merge pull request #16452 from AspirinSJL/add_msg_size_test
Test message size of 100MB
2019-08-29 08:59:40 -07:00
Mark D. Roth fbd7ab53c7
Merge pull request #19036 from markdroth/lb_policy_per_rpc_backend_metric_api
Add API for accessing per-call backend metric data in LB policies.
2019-08-29 07:40:45 -07:00
Mark D. Roth d810671d93
Merge pull request #20039 from markdroth/health_check_service_name_change
Apply health check service name changes to existing subchannels.
2019-08-29 07:14:40 -07:00
Juanli Shen d34f366337 Test message size of 100MB 2019-08-28 21:46:53 -07:00
Mark D. Roth 21c5424477 Add API for accessing per-call backend metric data in LB policies. 2019-08-28 12:48:06 -07:00
Juanli Shen a1ca6a099d Refactor response building in xds test 2019-08-28 12:44:31 -07:00
Mark D. Roth c8430023a5 Apply health check service name changes to existing subchannels. 2019-08-28 09:05:59 -07:00
Vijay Pai c22afac623
Merge pull request #16733 from vjpai/generic_lifetime
Confirm that generic API method name is not needed after call creation
2019-08-27 14:40:52 -07:00
Yash Tibrewal 2ba3ad5d2a
Merge pull request #20057 from yashykt/interceptionexample1
Improve comment
2019-08-23 15:58:36 -07:00
Yash Tibrewal 088b67deba Improve comment 2019-08-23 15:06:39 -07:00
Prashant Jaikumar 20e2964ada cfstream_test: workaround Apple CFStream bug 2019-08-21 22:03:48 -07:00
Juanli Shen 1abba74225 Fix unused result error 2019-08-19 14:40:27 -07:00
Juanli Shen d698b7e125
Merge pull request #19946 from AspirinSJL/xds_resolver
Add xds resolver
2019-08-19 09:35:17 -07:00
Juanli Shen a802b14be6 Add xds resolver 2019-08-16 15:09:32 -07:00
Qiancheng Zhao 1391c93a95 atomic client idle filter 2019-08-16 14:15:21 -07:00
Juanli Shen c1713800e0 Handle EDS response update in locality map 2019-08-16 09:06:06 -07:00
Prashant Jaikumar 141c2d24d1 Add support for running C++ tests on iOS 2019-08-14 20:44:22 -07:00
Juanli Shen 58aca9a2be
Merge pull request #19858 from AspirinSJL/locality_map_test
Add tests for xds locality map
2019-08-13 13:13:55 -07:00
Juanli Shen 6a16ddfa2d
Merge pull request #19922 from AspirinSJL/rm_notify_done
Remove unnecessary notification
2019-08-13 12:17:45 -07:00
rmstar 42b05bf190
Merge pull request #19838 from rmstar/time_change_flakes
Fixed time_change_test flakes
2019-08-13 11:02:18 -07:00
Juanli Shen 3c28c5f068 Remove unnecessary notification 2019-08-12 23:11:32 -07:00
Juanli Shen 8d101f1071 Wait longer before sending the drop update 2019-08-12 12:43:18 -07:00
Juanli Shen 1c9fb855d7 Add locality map tests 2019-08-11 19:12:47 -07:00
Juanli Shen 1291ece848 Add drop in xds policy 2019-08-09 23:26:45 -07:00
Juanli Shen 45dd8be442 Use LRS in xds policy 2019-08-09 12:08:32 -07:00
Juanli Shen 79f191114e Use EDS in xds LB policy 2019-08-07 22:43:45 -07:00
Prashant Jaikumar e2ebdc794d Fixed time_change_test flakes 2019-08-02 15:06:13 -07:00
Yash Tibrewal e6756a58ed
Merge pull request #19316 from yashykt/delegating_channel
Add Delegating Channel
2019-08-02 12:08:10 -07:00
Yash Tibrewal 3653439ba6 Merge master and move to experimental 2019-08-01 16:15:31 -07:00
Hope Casey-Allen bd8a04a6e9 Add human-readable names for channelz sockets and listen sockets 2019-07-30 15:53:46 -07:00
Qiancheng Zhao 29480c4f6b add client idle filter 2019-07-24 10:04:41 -07:00
Moiz Haidry da85cec0f2 Add condition to avoid duplicate shutdown 2019-07-19 14:19:23 -07:00
Moiz Haidry f4b1182a10 Addressed review comments 2019-07-19 13:48:35 -07:00
Moiz Haidry 7e2c5845e1 Merge branch 'master' of https://github.com/grpc/grpc into fix_mutex 2019-07-19 12:29:31 -07:00
Moiz Haidry 6d984166bd Porting Aaron Jacob's unit test that detecting the race 2019-07-19 11:45:33 -07:00
Karthik Ravi Shankar 553eff9cb0 Fix a test failure due to unused variable and formatting 2019-07-18 14:03:19 -07:00
Karthik Ravi Shankar 7461407ad0 Merge branch 'master' into callback-offload-only-not-bg-poller 2019-07-18 14:00:02 -07:00
Qiancheng Zhao 444806583d lazy resolving lb policy creation 2019-07-10 15:26:53 -07:00
Qiancheng Zhao 6de222a6ad refactor response generator in client_lb_end2end_test 2019-07-08 15:37:21 -07:00
rmstar ce282e7d7e
Merge pull request #19395 from rmstar/c++_on_ios
Fix C++ tests to run on iOS
2019-06-28 11:03:22 -07:00
Karthik Ravi Shankar 2602bdd3e4 Address review comments 2019-06-26 11:37:54 -07:00
Karthik Ravi Shankar 514413de70 Clang formatting errors 2019-06-25 20:14:15 -07:00
Karthik Ravi Shankar c041acb7a7 Fix the unit tests to exercise nesting correctly. 2019-06-25 20:09:06 -07:00
Karthik Ravi Shankar 44160d2b65 Add unit test to check the re-entrancy of callbacks 2019-06-25 15:43:06 -07:00
Prashant Jaikumar 43628b286f Update googletest version to v1.8.1
Bazel builds of test/cpp/end2end:end2end_test were failing on Mac OS with v1.8.0 due to missing gtest symbols. The issue is not seen in v1.8.1. A WORKSPACE file was added to gtest repo in 1.8.1, so gtest.BUILD can be removed.
2019-06-20 18:17:13 -07:00
Prashant Jaikumar fbfb93c88f Fix C++ tests to run on iOS
- Define grpc_iomgr_run_in_background in iomgr_posix_cfstream.cc
- Use *_IF_SUPPORTED() for death tests
- Move global test init, teardown to SetUpTestCase, TearDownTestCase as GTMGoogleTestRun doesn't run main()
2019-06-20 18:16:20 -07:00
Yash Tibrewal 219c3b38aa Clang-tidy 2019-06-13 16:55:37 -07:00
Yash Tibrewal 90f1c32b85 Sanity checks and return value 2019-06-13 12:29:48 -07:00
Yash Tibrewal 94e7edad99 Add Delegating Channel 2019-06-11 15:07:12 -07:00
Mark D. Roth c46eb428cb
Merge pull request #19066 from markdroth/lb_policy_channelz_api_cleanup
Remove channelz from LB policy API.
2019-06-07 08:39:39 -07:00
Mark D. Roth cfb31818ef Remove channelz from LB policy API. 2019-06-07 07:09:39 -07:00
rmstar 7d99c560ec
Merge pull request #19138 from rmstar/cfstreamtestlog
cfstream_test: print HTTP2 stream id of completed RPCs
2019-06-06 13:52:49 -07:00
rmstar fdbc1b0c86
Merge pull request #19226 from rmstar/cfstream_test_flake
Fix cfstream_test flake
2019-06-06 10:25:31 -07:00
Yang Gao d371dae02a
Merge pull request #19216 from yang-g/acceptor
Add listner fd as part of the external connection parameters
2019-06-04 12:13:58 -07:00
Prashant Jaikumar 58771fa12a Fix cfstream_test flake
Ask server to skip cancel check in network flap test.
2019-06-03 22:08:42 -07:00
Esun Kim bac7da1dae
Merge pull request #19136 from veblush/global-config-best
Applied the best practice using global configuration
2019-06-03 15:29:06 -07:00
yang-g 91eb1141a9 Ask server to skip cancel check 2019-06-03 13:16:48 -07:00
yang-g 6ced31ee89 resolve review comments 2019-06-03 13:10:12 -07:00
yang-g c156653997 Add listner fd as part of the external connection parameters 2019-06-03 10:38:37 -07:00
Esun Kim 434b3b62e5 Applied the best practice using global configuration 2019-05-31 14:46:58 -07:00
Yang Gao 07c9f7a36b
Merge pull request #19139 from yang-g/plugin_creds
Avoid accessing freed auth_metadata_context in C++ plugin.
2019-05-31 14:35:52 -07:00
Yash Tibrewal 32a37e235a
Merge pull request #19142 from yashykt/interceptionfix
Fix a bug where POST_RECV_MESSAGE was not being triggered
2019-05-30 16:27:32 -07:00
Yash Tibrewal cf05591971 Add comment about LoggingInterceptor 2019-05-30 14:50:28 -07:00
Karthik Ravi Shankar 196b0aa3a3
Revert "Revert "Start supporting a callback-based RPC under lock"" 2019-05-29 13:15:47 -07:00
Karthik Ravi Shankar b790c24e5c
Revert "Start supporting a callback-based RPC under lock" 2019-05-29 11:20:36 -07:00
yang-g 9d3288e408 Fix test bugs 2019-05-29 09:34:19 -07:00
yang-g 47dbf1dd26 Second approach 2019-05-28 23:47:29 -07:00
Yash Tibrewal 66c7560fc4 Fix server interceptors end2end test 2019-05-28 11:25:56 -07:00
Yash Tibrewal 6a2da31a36 Remove unused variable 2019-05-24 17:22:42 -07:00
Yash Tibrewal e260de873c Merge branch 'master' into interceptionfix 2019-05-24 17:03:11 -07:00
Yash Tibrewal c58b4a3964 Clang format 2019-05-24 17:00:54 -07:00
Yash Tibrewal 67bdbbdf6f Fix a bug where POST_RECV_MESSAGE is not being triggered 2019-05-24 16:58:56 -07:00
Yash Tibrewal 4746a8734d Merge branch 'master' into validatesvccfg 2019-05-24 15:27:16 -07:00
Prashant Jaikumar b1147052d3 cfstream_test: print HTTP2 stream id of completed RPCs
Log stream id of completed RPCs. This helps in debugging test failures.
2019-05-24 15:18:53 -07:00
yang-g 384f15ab6e Delay calling plugin_creds callback 2019-05-24 14:46:12 -07:00
Yash Tibrewal 886dc10daa Move validate_service_config to a new file 2019-05-24 14:29:16 -07:00
Karthik Ravi Shankar 072fdf54ed
Merge pull request #18813 from karthikravis/callback-rpc-lock
Start supporting a callback-based RPC under lock
2019-05-23 21:51:31 -07:00
Prashant Jaikumar 1ac1ab7396 Flaky network test enhancements and cleanups
- Parameterized flaky_network_test to run with different packet sizes and
credentials.
- Cleanup debugger_macros

Parametrize flaky_network_test to run with different packet sizes and
credentials.
2019-05-23 11:45:54 -07:00
Karthik Ravi Shankar 3f05ac9584 Merge branch 'master' into callback-rpc-lock 2019-05-22 17:39:08 -07:00
Juanli Shen a30c1d0971
Merge pull request #19018 from AspirinSJL/fix_fallback
xds enter fallback mode as long as no child policy is ready
2019-05-21 14:09:08 -07:00
Esun Kim 90fbdc92f5 Roll-forward "Config migration"
This reverts commit 236ae12bb1.
2019-05-20 15:47:24 -07:00
Yash Tibrewal f63dde8e8e Make validation function a global function 2019-05-20 11:45:07 -07:00
Mark D. Roth 531c0bd230
Merge pull request #19077 from markdroth/test_health_check_service_fix
Fix bug in test health check service implementation.
2019-05-20 09:39:44 -07:00
Yang Gao c4cb6e1787
Merge pull request #19016 from yang-g/message_allocator
Update the message allocator API
2019-05-20 08:49:14 -07:00
Mark D. Roth 440e9b79bf Fix bug in test health check service implementation. 2019-05-20 07:50:03 -07:00
Juanli Shen 98461b0fa8 xds enter fallback mode as long as no child policy is ready 2019-05-18 19:50:31 -07:00
yang-g 6215ccb587 resolve comments 2019-05-17 16:22:43 -07:00
Karthik Ravi Shankar fe85756a8a Fix end2end tests 2019-05-17 10:15:41 -07:00
Karthik Ravi Shankar 90fee3e586 Merge branch 'master' into callback-rpc-lock 2019-05-17 09:27:16 -07:00
Vijay Pai 41191323ec Make sure event_engine is alive before checking for MAYBE_SKIP_TEST 2019-05-16 13:45:02 -07:00
yang-g 7c5bfbbb32 Resolve comments 2019-05-16 09:19:44 -07:00
yang-g 51210ba922 Update the message allocator API 2019-05-16 09:19:44 -07:00
yang-g c639da7a1d Merge branch 'master' of https://github.com/grpc/grpc into port_sharing 2019-05-16 09:07:55 -07:00
yang-g ec6e7fd941 Rename enum 2019-05-16 09:07:34 -07:00
Alexander Polcyn 236ae12bb1 Revert "Config migration"
This reverts commit 87905ae5ea.
2019-05-14 14:36:33 -07:00
Karthik Ravi Shankar e3028a2836 Merge branch 'master' into callback-rpc-lock 2019-05-14 12:05:38 -07:00
Yash Tibrewal 4e711fab64 Add method to validate and set service config json 2019-05-13 14:53:36 -07:00
yang-g de57783beb Merge with head and resolve conflict 2019-05-13 08:56:02 -07:00
Yash Tibrewal 1ff5791e47 Add tests for setting a channel to lame on an invalid default service config 2019-05-10 14:33:22 -07:00
Mark D. Roth a4d4bb82c9 Revamp subchannel connectivity state monitoring APIs. 2019-05-10 07:57:11 -07:00
Yash Tibrewal aa89a97531
Merge pull request #18946 from yashykt/svccfgerrortransient
Service Config Changes to set channel in transient failure on invalid service config
2019-05-10 06:14:44 -07:00
Esun Kim 87905ae5ea Config migration 2019-05-09 12:29:38 -07:00
Yash Tibrewal 98d8f85d4e Reviewer comments 2019-05-09 10:58:00 -07:00
Yash Tibrewal 1984b34797 Try getting around clang tidy issue 2019-05-08 16:22:10 -07:00
Yash Tibrewal b53465c106 Add test for not special casing grpclb if loadbalancingconfig is used 2019-05-08 14:27:58 -07:00
Yash Tibrewal 6cba63eb47 reviewer comments and tests 2019-05-08 03:36:37 -07:00
yang-g 218e290074 Merge with head and resolve conflict 2019-05-07 22:46:45 -07:00
yang-g 898fc0da1e More fixes 2019-05-07 22:45:39 -07:00
Yash Tibrewal 8030e12624 Add more tests for service config state transitions 2019-05-07 03:57:56 -07:00
Yash Tibrewal aa0a26cdbc Do not save service config in DNS resolver 2019-05-07 00:03:43 -07:00
yang-g 152a7cc122 Resolve comments 2019-05-06 15:42:18 -07:00
Yash Tibrewal 71085f3e3b Changes 2019-05-02 18:21:52 -07:00
Yash Tibrewal db1ccad039 Service Config Changes to set channel in transient failure on invalid service config 2019-05-02 18:03:02 -07:00
Esun Kim ccf4734907
Merge pull request #18799 from veblush/config
New config system & migration sample
2019-05-01 09:01:35 -07:00
yang-g abd97b9170 Merge with head and resolve conflict 2019-04-30 23:01:01 -07:00
Esun Kim 1518ecbd76 Added new configuration system to core/grp.
More generic configuration system is introduced in order to i) unify the
way how modules access the configurations instead of using low-level
get/setenv functions and ii) enable the customization for where configuration
is stored. This could be extended to support flag, file, etc.

Default configuration system uses environment variables as before so
basically this is expected to work just as it did. This behavior can
change by redefining GPR_GLOBAL_CONFIG_DEFINE_*type* macros.

* Migrated configuration

GRPC_CLIENT_CHANNEL_BACKUP_POLL_INTERVAL_MS
GRPC_EXPERIMENTAL_DISABLE_FLOW_CONTROL
GRPC_ABORT_ON_LEAKS
GRPC_NOT_USE_SYSTEM_SSL_ROOTS
2019-04-30 15:49:24 -07:00
yang-g ac3a91edf8 Support accepting external connections. 2019-04-30 12:31:34 -07:00
Karthik Ravi Shankar 5a132b8245 Merge branch 'master' into grpc_namespace_credentials 2019-04-30 10:18:09 -07:00
Karthik Ravi Shankar bc09c70799
Merge pull request #18454 from grpc/grpc_namespace_channel_arguments
Bring ChannelArguments to grpc_impl from grpc
2019-04-30 10:16:45 -07:00
Vijay Pai 657ab449c6 Make single-argument constructor explicit 2019-04-26 13:16:54 -07:00
yang-g 37783d6329 Stop calling ParseCommandLineFlags directly, use wrapper call instead 2019-04-24 10:09:39 -07:00
Karthik Ravi Shankar 4d5a411557 Fix clang errors 2019-04-24 09:58:47 -07:00
Karthik Ravi Shankar a1493cfa62 Add missing files for build 2019-04-24 08:26:46 -07:00
Juanli Shen 51137e11ec
Merge pull request #18665 from AspirinSJL/xds_fallback_startup
Add fallback-at-startup into xds
2019-04-23 22:33:43 -07:00
rmstar 4bd5f0f63e
Merge pull request #18649 from rmstar/macppstress
Add C++ stress tests on mac
2019-04-23 22:13:31 -07:00
Karthik Ravi Shankar 38ffd8ca84 Merge branch 'master' into grpc_namespace_credentials 2019-04-23 18:22:09 -07:00
Juanli Shen 438cb44378 Add fallback-at-startup into xds 2019-04-23 17:06:23 -07:00
Yang Gao 5170c613cc
Merge pull request #18784 from yang-g/message_allocator
Message allocator support for callback unary
2019-04-23 15:49:49 -07:00
Prashant Jaikumar d20d46e976 Add C++ stress tests on mac 2019-04-23 14:07:50 -07:00
Karthik Ravi Shankar 60bdeef9f4 Move Channel also to impl for now 2019-04-23 14:03:06 -07:00
Karthik Ravi Shankar 603d014f0e Changes to fold credentials into grpc_impl from grpc 2019-04-23 13:54:26 -07:00
Karthik Ravi Shankar 858b5cca20 Fix clang_format_code.sh issues and move the internal calls to new name 2019-04-23 11:45:11 -07:00
Karthik Ravi Shankar 17ca558e13 Merge branch 'master' into grpc_namespace_channel_arguments 2019-04-23 11:38:13 -07:00
yang-g 41824319fa Resolve review comments 2019-04-23 08:54:36 -07:00
Nicolas "Pixel" Noble b9a279c030 Resolving ambiguous call to CreateCustomChannel. 2019-04-22 23:53:53 +02:00
Vijay Pai 20c08dbc7a Add client-side unary reactor model 2019-04-19 16:10:08 -07:00
Karthik Ravi Shankar d243f3dbe3 Merge branch 'master' into callback-rpc-lock 2019-04-19 12:59:04 -07:00
Karthik Ravi Shankar 39816efa3b Test invoking a callback-based RPC under lock 2019-04-19 12:57:08 -07:00
Soheil Hassas Yeganeh 2b9448a71c Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
This reverts commit d09c9f8e20.
2019-04-17 14:35:29 -04:00
yang-g 6929cdd654 initial 2019-04-16 15:43:58 -07:00
Alexander Polcyn d09c9f8e20 Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
This reverts commit a26c09dd25.
2019-04-11 16:52:54 -07:00
Vijay Pai ea59977fbc
Merge pull request #18687 from vjpai/cancel_order
C++ Callback API: Make sure that OnCancel happens after OnStarted
2019-04-10 16:15:43 -07:00
Vijay Pai 41c6cba9f5 Make sure that OnCancel happens after OnStarted 2019-04-10 11:32:34 -07:00
Yash Tibrewal 8e195ddeb9 Merge branch 'master' into lamechannelinterception 2019-04-09 15:30:16 -07:00
Yash Tibrewal 74540483c6 Merge branch 'master' into svc_cfg1 2019-04-08 19:51:45 -07:00
Soheil Hassas Yeganeh a26c09dd25 Introduce C++ wrappers for gpr_mu and gpr_cv.
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.

Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.

Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
Yash Tibrewal 3dc6eae912 Merge branch 'master' into svc_cfg1 2019-04-05 13:45:03 -07:00
Yash Tibrewal 8eeb429db0 Missing argument 2019-04-05 13:44:41 -07:00
Yash Tibrewal 327350ab39 ServiceConfig::Create expects non-Null error and better errors 2019-04-05 12:16:37 -07:00
Juanli Shen 597714b6a7
Merge pull request #18516 from AspirinSJL/fix_xds_test
Fix count in xds/grpclb test
2019-04-05 12:16:11 -07:00
Juanli Shen c2fb0c8951
Merge pull request #18560 from AspirinSJL/fix_restart_test
Fix BackendsRestart test for xds
2019-04-05 10:02:44 -07:00
Juanli Shen 4ae20ad972 Fix count in xds/grpclb test 2019-04-04 16:24:37 -07:00
Prashant Jaikumar 80140f53fb Fix CFStreamTest.NetworkTransition.
It looks like CFStream doesn't detect stream errors when the server is listening on 127.0.0.2 and the interface is shutdown.
The test started failing after address was changed from 10.0.0.1 to 127.0.0.2 in #18381. This commit changes the server address back to 10.0.0.1.
2019-04-03 16:33:47 -07:00
Yash Tibrewal cb6a2968fe Make Interceptors work for lame channels 2019-04-03 11:55:04 -07:00
Mark D. Roth ee4e4bead3 pick_first: don't go into TRANSIENT_FAILURE upon empty update when in IDLE. 2019-04-01 14:55:29 -07:00
Mark D. Roth ce2af3b958 Remove noisy log message. 2019-03-29 15:02:57 -07:00
Bill Feng c1b03b68da Merge remote-tracking branch 'upstream/master' into feature/reinstate-rbe-windows 2019-03-28 16:45:41 -07:00
Juanli Shen 1979edd03c Fix BackendsRestart test 2019-03-28 14:36:58 -07:00
rmstar 2e2cecebbf
Merge pull request #18381 from rmstar/concurrentrequests
Fix bug in CFStream endpoint
2019-03-27 14:19:14 -07:00
Mark D. Roth 934e31d7d1
Merge pull request #18357 from markdroth/address_list_not_in_channel_args
Restructure how addresses and service config are passed from resolver to LB policy
2019-03-27 11:40:44 -07:00
Prashant Jaikumar 4e9e662729 Fixed bug in CFStream endpoint.
We were failing to return an error when the transport tried to write to an endpoint that was in an errored state.
2019-03-26 18:36:44 -07:00
Yang Gao 8bbfbec4e4
Merge pull request #18497 from yang-g/callback
Fully log test scenario
2019-03-26 12:24:41 -07:00
Mark D. Roth 206592ce9c Restructure how addresses and service config are passed from resolver to LB policy. 2019-03-26 11:57:21 -07:00
yang-g 621840900f Fully log test scenario 2019-03-25 14:24:11 -07:00
Bill Feng d93959853f Enabled Windows Bazel build for cpp tests 2019-03-21 18:00:48 -07:00
Vijay Pai 50576179f8
Merge pull request #17978 from yashykt/interceptorcleanup1
Global Interceptor Registration allowed only once
2019-03-20 19:13:55 -07:00
Hope Casey-Allen 6ecf74f641 Increase timeout for test 2019-03-19 16:32:41 -07:00
Vijay Pai 5dff0812bc
Merge pull request #18341 from vjpai/cancel_callback
Support callback on cancellation of server-side unary RPCs
2019-03-19 14:42:20 -07:00
Vijay Pai 7b3a120295 Address reviewer comments 2019-03-18 16:51:15 -07:00
Vijay Pai f12f862d28 Strengthen test 2019-03-18 15:52:58 -07:00
Vijay Pai 0cb0cdb7e3 Address reviewer comments on test 2019-03-18 15:46:27 -07:00
Vijay Pai 93f0a3f653 Address reviewer comments 2019-03-18 15:37:35 -07:00
Mark D. Roth 233d3e27ff grpclb fallback-at-startup improvements 2019-03-18 13:40:23 -07:00
Vijay Pai 04a6b8467c Support callback on cancellation of server-side unary RPCs 2019-03-18 12:00:57 -07:00
Mark D. Roth adc2163038 Go into fallback mode when losing contact with balancer and backends. 2019-03-18 09:08:38 -07:00
Vijay Pai 8c3d4a7dfd
Merge pull request #18072 from vjpai/client_streaming_hold
C++ callback API: Add support for client-side extra-reaction operations via Holds
2019-03-16 10:27:36 -07:00
Vijay Pai 48ce4ca939 Add support for extra-reaction operations via Holds 2019-03-15 16:17:01 -07:00
Mark D. Roth 55d8238b0e
Merge pull request #18340 from markdroth/grpclb_test_improvement
Clean up grpclb and xds end2end tests.
2019-03-15 15:23:44 -07:00
Mark D. Roth b0ad6ac3ae Clean up grpclb and xds end2end tests. 2019-03-15 13:54:28 -07:00
Jan Tattermusch cf6a311761
Revert "Windows builds for gRPC C++ tests" 2019-03-15 17:15:20 +01:00
Vijay Pai 85f8e0f4b0
Merge pull request #18289 from vjpai/unimplemented_rpc
C++ callback API: properly handle and test unimplemented RPC method
2019-03-13 12:47:36 -07:00
Mark D. Roth a89df2e275
Merge pull request #18222 from markdroth/pick_first_selected_fails_connectivity_state_fix
Fix state reported by pick_first when we receive a GOAWAY with a pending subchannel list.
2019-03-12 14:31:30 -07:00
Mark D. Roth c9421eeb85 Fix state reported by pick_first when we receive a GOAWAY with a pending subchannel list. 2019-03-12 13:15:45 -07:00
Karthik Ravi Shankar b3889585a1
Revert "Moving ::grpc::ResourceQuota to ::grpc_impl::ResouceQuota" 2019-03-12 12:25:38 -07:00
Karthik Ravi Shankar cc632f8121
Merge pull request #18220 from grpc/grpc_namespace
Moving ::grpc::ResourceQuota to ::grpc_impl::ResouceQuota
2019-03-12 11:20:27 -07:00
Bill Feng d61f690a33
Merge pull request #18285 from billfeng327/update-deps-version
Windows local Bazel build for gRPC C++ tests
2019-03-08 14:17:36 -08:00
Yash Tibrewal 4f8891c3e5 Merge branch 'master' into deletepollcv 2019-03-07 17:57:14 -08:00
Yash Tibrewal 6b45cea2f0 Remove from poll-cv comments too 2019-03-07 17:56:49 -08:00
billfeng327 4241edeaa4 renamed tag to no_windows in conformation with Bazel and TensorFlow 2019-03-07 14:52:49 -08:00
Mark D. Roth 827c77bd24 Use fallback before timeout if balancer channel reports TRANSIENT_FAILURE. 2019-03-07 07:57:29 -08:00
Vijay Pai 240bf86760 Add unimplemented RPC test 2019-03-06 23:01:05 -08:00
Vijay Pai 96f8b7a532
Merge pull request #18239 from vjpai/callback_async_generic_service
C++: Support callback-based generic service
2019-03-06 19:35:26 -08:00
billfeng327 928aedf5c8 Merge branch 'master' into update-deps-version 2019-03-06 15:48:29 -08:00
billfeng327 ab06853fc9 C++ Windows test builds 2019-03-06 15:47:49 -08:00
Mark D. Roth d85e6f4e94 Make grpclb work when selected via service config with no balancer addresses. 2019-03-06 11:16:56 -08:00
Karthik Ravi Shankar f7dd48b2b6 Moving ::grpc::ResourceQuota to ::grpc_impl::ResouceQuota
This change moves ResourceQuota class fron grpc namespace to grpc_impl
namespace.
2019-03-06 10:12:23 -08:00
Mark D. Roth 2bd7ad0112
Merge pull request #18263 from markdroth/grpclb_child_policy_configurable
Second attempt: Make grpclb child policy configurable
2019-03-06 07:34:17 -08:00
Juanli Shen cd15e147e3
Merge pull request #18021 from AspirinSJL/real_resolver
Use real resolver in xds lb channel
2019-03-05 16:18:32 -08:00
Mark D. Roth 6d75cfe426 Revert "Merge pull request #18254 from grpc/revert-18078-grpclb_child_policy_configurable"
This reverts commit 6dcf6d1645, reversing
changes made to a2f1e924de.
2019-03-05 14:18:01 -08:00
Juanli Shen e889fda482 Use real resolver in xds lb channel 2019-03-05 13:29:55 -08:00
Mark D. Roth 9febbf2d92
Revert "Make grpclb child policy configurable" 2019-03-05 11:32:00 -08:00
rmstar f585e37bea
Merge pull request #18243 from rmstar/reconnectbackoff
Try to fix FlakyNetworkTest.ServerRestartKeepaliveDisabled flake
2019-03-05 11:27:08 -08:00
Mark D. Roth 762676249e Make grpclb child policy configurable. 2019-03-05 06:32:03 -08:00
Mark D. Roth a04b0646de Don't use a separate call context for subchannel calls. 2019-03-04 14:38:02 -08:00
Vijay Pai 397bdd6b7b Fix a bug that was exposed but unrelated... 2019-03-04 13:55:12 -08:00
Prashant Jaikumar ede3e61acb Try to fix FlakyNetworkTest.ServerRestartKeepaliveDisabled flake
Set channel arg for max connect time.
2019-03-04 13:25:33 -08:00
Vijay Pai 05d8ddfc6e Support callback-based generic service 2019-03-04 13:13:12 -08:00
apolcyn 046e3e4ab5
Merge pull request #18201 from apolcyn/fix_thing
Build c-ares bazel lib with alwayslink=1
2019-02-28 10:58:25 -08:00
Alex Polcyn 9644e588f6 Build c-ares bazel lib with alwayslink=1 2019-02-27 23:06:11 -08:00
Yang Gao 40241c5236
Merge pull request #18157 from yang-g/rollbackrollback
Roll-forward PR17308
2019-02-27 17:04:19 -08:00
Prashant Jaikumar 7f37d1cb0e Fix test flakes in flaky_network_test
- Set channel arg for maximum time between reconnection attempts.
- Don't check status of RPCs that can fail due to network flakiness.
2019-02-27 00:44:52 -08:00
Vijay Pai 2a80f0edc7 Support use of ByteBuffer for request-side of code-gen unary 2019-02-25 16:28:59 -08:00
yang-g 5480dc5cd6 fix client_lb_e2e_test 2019-02-25 10:28:06 -08:00
Vijay Pai c924e0b63e
Merge pull request #18136 from vjpai/callback_test_interceptor
Increase test scenarios for client-side of callback API plus fix exposed bugs
2019-02-25 09:25:59 -08:00
Vijay Pai 8feb16171a Add an expectation and fix a ServerContext bug 2019-02-25 00:48:11 -08:00
Vijay Pai 5f8fe7d5cc Test for simultaneous Read and WritesDone 2019-02-25 00:21:42 -08:00
Vijay Pai ac5f5c4fe2 Add ClientCancelsRequestStream test 2019-02-25 00:03:18 -08:00
Vijay Pai 05b98a4896 Also add streaming tests that cancel from client 2019-02-23 10:33:39 -08:00
Mark D. Roth 428fa7602c Transition into state CONNECTING when we start name resolution. 2019-02-22 10:31:16 -08:00
Vijay Pai 7eb08ad72e Add interceptors, secure credentials, and cancellation to client callback test 2019-02-22 01:33:05 -08:00
Prashant Jaikumar 98e0ff582a Fix C++ bulid on Mac OS 2019-02-20 22:06:51 -08:00
rmstar 22109adedd
Merge pull request #18082 from rmstar/cfstreamtestv2
Re-add cfstream_test
2019-02-20 15:38:51 -08:00
Prashant Jaikumar b31f402b46 Add flaky_network_test after fixing internal build failures.
Re-add flaky_network_test along with a couple of new testcases.
2019-02-19 16:54:47 -08:00
Prashant Jaikumar 6177befe94 Re-add cfstream_test
2nd attempt at adding cfstream_test after fixing internal build failures caused by first attempt.
2019-02-15 15:05:38 -08:00
hcaseyal cecea9c592
Revert "Added test for RPCs over a flaky network" 2019-02-15 13:36:02 -08:00
Vijay Pai 03de98d5ef
Revert "Add test for network transitions when CFStream is enabled" 2019-02-14 15:35:44 -08:00
Yash Tibrewal 73353ad281 Merge branch 'master' into interceptorcleanup1 2019-02-13 12:47:47 -08:00
Yash Tibrewal 50497c2317 Reviewer comments 2019-02-13 12:46:07 -08:00
rmstar 17651ca3cc
Merge pull request #17903 from rmstar/flakynetworktest
Added test for RPCs over a flaky network
2019-02-13 11:19:39 -08:00
rmstar 52360b8fa7
Merge pull request #17872 from rmstar/cfstream_test
Add test for network transitions when CFStream is enabled
2019-02-13 10:49:35 -08:00
Vijay Pai 75bf7c7f48
Merge pull request #18000 from rmstar/timechangetestsan
Fix TSAN flake in time_change_test
2019-02-12 15:17:35 -08:00
Prashant Jaikumar 485bc78ba3 Added flaky_network_test 2019-02-12 12:04:45 -08:00
Prashant Jaikumar 2f0f522423 Add end2end test for cfstream 2019-02-12 11:31:48 -08:00
Mark D. Roth 68a661dfb5
Merge pull request #17947 from markdroth/grpclb_service_config_fix
Don't pass service config from parent channel to grpclb balancer channel.
2019-02-12 07:46:50 -08:00
Vijay Pai a47c979ba0 Enable TCP callback tests if the event engine allows 2019-02-11 12:05:37 -08:00
Prashant Jaikumar 52695cae91 Fix TSAN flake in time_change_test 2019-02-10 23:59:47 -08:00
ncteisen d8947ae073 Fix internal build error 2019-02-08 17:17:00 -08:00
Yash Tibrewal cddb5519f2 Add a test only method to reset global interceptor 2019-02-08 15:57:29 -08:00
Mark D. Roth 0794507043 Don't pass service config from parent channel to grpclb balancer channel. 2019-02-08 13:07:27 -08:00
Yash Tibrewal c71b2f4fb7 Global Interceptor Registration allowed only once 2019-02-07 19:36:51 -08:00
Noah Eisen d97fd19eef
Merge pull request #17951 from ncteisen/empty-binary-metadata
Add Empty Binary Metadata Test
2019-02-06 15:19:00 -08:00
Jan Tattermusch f83fbe95b4
Merge pull request #17888 from xichengliudui/updatefiles
Fix various typos in .cc and .md files
2019-02-06 23:33:43 +01:00
ncteisen 3fe3be39fe Add empty binary metadata test 2019-02-06 11:04:54 -08:00