Commit Graph

78 Commits

Author SHA1 Message Date
Yijie Ma f99b8b5bc4
Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Cheng-Yu Chung 5498481265
Remove `include/grpcpp/impl/codegen/proto_utils.h` (#31532) 2022-11-29 21:33:55 +08:00
Esun Kim 250f9fc026
Revived google-readability-casting (#31607)
* Added google-readability-casting

* Fix

* Use brace init for constants

* more

* Fix

* Fix 2

* More fix

* Fixf
2022-11-11 16:44:37 -08:00
Esun Kim 660a6f281e
Added readability-redundant-string-init (#31609)
* Added readability-redundant-string-init

* Fix
2022-11-10 11:14:36 -08:00
Craig Tiller 9c98d67d7a
[c++14] absl::make_unique --> std::make_unique (#31159)
* [c++14] absl::make_unique --> std::make_unique

* fix

* fix
2022-09-29 06:45:17 -07:00
Esun Kim d43511f4af
Removed GRPC_ERROR_NONE (#31131) 2022-09-27 23:17:39 -07:00
Craig Tiller eb5ae61470
Reland (again) bytestream removal (#29987)
* Revert "Revert "Reland bytestream removal (#29911)" (#29964)"

This reverts commit e6c6840db3.

* initial fc fuzzer

* fixes

* add rq to fc fuzzer

* fleshing things out

* Automated change: Fix sanity tests

* cleanup

* send with payload

* ensure if no reader no flow control tokens are granted

* remove some public methods

* remove bogus benchmarks

* account for pending size

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests

* better logic

* Automated change: Fix sanity tests

* fix

* fixes

* fuzz pending size

* Automated change: Fix sanity tests

* fix

* Automated change: Fix sanity tests

* huh

* increase too short timeout

* review feedback

* review feedback

* fix u32 overflow

* fix

* robustness fixes for channelz_servicer_test

* fix

* Automated change: Fix sanity tests

* fix

* fix

* fix

* Automated change: Fix sanity tests

* dont send window updates if read closed

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-06-27 21:21:23 -07:00
Yash Tibrewal 78d6d71af3
Call: Send cancel op down the stack even when no ops are sent (#30004)
* Call: Send cancel op down the stack even when no ops are sent

* Add test
2022-06-14 13:10:41 -07:00
AJ Heller 18a8f6aad9
Refactor end2end tests to exercise each EventEngine (#29202)
* Refactor end2end tests to exercise each EventEngine

* fix incorrect bazel_only exclusions

* Automated change: Fix sanity tests

* microbenchmark fix

* sanitize, fix iOS flub

* Automated change: Fix sanity tests

* iOS fix

* reviewer feedback

* first pass at excluding EventEngine test expansion

Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.

* end2end fuzzers to be fuzzed differently via EventEngine.

* sanitize

* reviewer feedback

* remove misleading comment

* reviewer feedback: comments

* EE test_init needs to play with our build system

* fix golden file test runner

Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
Yash Tibrewal 674e938de5
More tests prep for graceful goaway (#29076)
* More tests prep for graceful goaway

* clang-tidy
2022-03-10 16:55:09 -08:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Vijay Pai 8aff94558c
De-experimentalize C++ callback API (#25728)
* De-experimentalize callback API

* Make FromServerContext based on ServerContextBase

* Fix lambda

* Fix headers

* De-experimentalize tests

* clang-format

* Fix consistency checks

* wip

* Fix const-ness of callback client read RPC requests

* Fix golden file

* Give full route_guide callback client example with Hold etc

* Complete example route-guide server

* De-experimentalize test services

* Omit unneeded using

* Remove some uses of non-experimental macro from test

* clang-format examples

* De-experimentalize async stub calls

* Remove experimental namespace use in qps, ubms

* De-experimentalize alarms, generic stubs, and context allocator

* De-experimentalize SetContextAllocator

* clang-format

* Fix conflicts

* Leave obsolete API in place until users can be migrated
2021-05-27 14:55:25 -07:00
mkruskal-google 2bf75aa68a
Add optional suffix to client-side stub objects (#25996)
* Adding suffix for stats handling to gRPC

* Fixing typo

* Fixing codegen, adding tests

* Fixing test failures

* Adding nullptr default in StubOptions

* Updating golden test file

* Replacing std::make_unique with absl::make_unique for pre-C++14 compatibility

* Fixing clang format  errors

* Reuse stub options for generic stubs

* Cleaning up compiler warnings in GenericStub
2021-04-26 17:19:43 -07:00
Yash Tibrewal f4e55b85bc Replace disrespectful term 2021-02-08 15:29:53 -08:00
Esun Kim 53ab235fb8 Fix google-explicit-constructor 2020-12-03 15:03:39 -08:00
Yash Tibrewal 02ca015b13 Experimental support and tests for CreateCustomInsecureChannelWithInterceptorsFromFd 2020-10-21 13:34:26 -07:00
Esun Kim 84df61b31a
Merge pull request #24453 from veblush/tidy-modernize-make-unique
[Clang-Tidy] Enable modernize-make-unique
2020-10-16 16:35:08 -07:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Esun Kim 6ae8463500 Fix by modernize-make-unique 2020-10-16 13:30:56 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Yash Tibrewal edbae5d8e6 Fix interceptor batch method FailHijackedRecvMessage for async APIs 2020-04-22 23:05:57 -07:00
Vijay Pai 176dfc2289 Remove unused parameter warning (15 of 20) 2019-10-17 08:51:50 -07:00
Yash Tibrewal 088b67deba Improve comment 2019-08-23 15:06:39 -07:00
Yash Tibrewal cf05591971 Add comment about LoggingInterceptor 2019-05-30 14:50:28 -07:00
Yash Tibrewal 6a2da31a36 Remove unused variable 2019-05-24 17:22:42 -07:00
Yash Tibrewal c58b4a3964 Clang format 2019-05-24 17:00:54 -07:00
Yash Tibrewal 67bdbbdf6f Fix a bug where POST_RECV_MESSAGE is not being triggered 2019-05-24 16:58:56 -07:00
Yash Tibrewal cb6a2968fe Make Interceptors work for lame channels 2019-04-03 11:55:04 -07:00
Yash Tibrewal 50497c2317 Reviewer comments 2019-02-13 12:46:07 -08:00
Yash Tibrewal cddb5519f2 Add a test only method to reset global interceptor 2019-02-08 15:57:29 -08:00
Yash Tibrewal c71b2f4fb7 Global Interceptor Registration allowed only once 2019-02-07 19:36:51 -08:00
Yash Tibrewal dd067fd390 Merge branch 'master' into nocopyinterception 2019-01-07 10:09:06 -08:00
Yash Tibrewal 059459a9ee Merge branch 'master' into failhijackedrecv 2019-01-04 17:28:25 -08:00
Yash Tibrewal 8ba5922e87 Merge branch 'master' into failhijackedsend 2019-01-04 15:29:00 -08:00
Yash Tibrewal 6fc7adf277 Merge branch 'master' into bidiinterceptiontest 2019-01-04 13:54:14 -08:00
Yash Tibrewal b05ca9697b Merge branch 'master' into failhijackedrecv 2019-01-04 11:30:03 -08:00
Yash Tibrewal a5ed3d245e Avoid unsigned signed comparison issues 2019-01-04 11:17:35 -08:00
Yash Tibrewal 4224384d39 Modifying semantics for GetSendMessage and GetSerializedSendMessage.
Also adding ModifySendMessage
2019-01-03 18:01:58 -08:00
Yash Tibrewal bac79bdabe Merge branch 'master' into failhijackedsend 2019-01-03 15:51:43 -08:00
Yash Tibrewal 50c60f03ba Rename GetSendMessage to GetSerializedSendMessage and GetOriginalSendMessage to GetSendMessage 2019-01-03 12:21:19 -08:00
Yash Tibrewal c6261f4b91 Rename new SendMessage types to SendMessagePtr 2019-01-02 14:46:52 -08:00
Yash Tibrewal 4aeba42528 Provide GetOriginalSendMessage for some APIs 2018-12-28 17:27:38 -08:00
Yash Tibrewal aecc5f7285 Add client interceptor test for bidi streaming hijacking interceptor 2018-12-28 16:03:20 -08:00
Yash Tibrewal 24e37e249a Merge branch 'master' into failhijackedrecv 2018-12-26 15:10:41 -08:00
Yash Tibrewal 5a6183f1bd Merge branch 'master' into failhijackedsend 2018-12-26 13:33:06 -08:00
Yash Tibrewal 3c3876a5da
Merge pull request #17544 from yashykt/factorydocs
Allow interceptor creators to return nullptr
2018-12-18 14:48:43 -08:00
Yash Tibrewal 31a775b425 Add missing argument 2018-12-18 12:52:14 -08:00
Yash Tibrewal a20263f64d Add tests using NullInterceptorFactory 2018-12-18 12:41:49 -08:00
Yash Tibrewal bb303513dc Merge master 2018-12-18 11:40:52 -08:00
Vijay Pai c52ae0d000 Give the interceptors header files in include/grpcpp/support 2018-12-17 15:17:01 -08:00