Commit Graph

92 Commits

Author SHA1 Message Date
Craig Tiller c32cbb57df
[memory_usage] Use a named target for the client (#33258)
Allows usage on machines that don't support ipv4.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
2023-05-26 10:28:18 -07:00
Craig Tiller a95e54d3d8
[memory-usage] remove testonly bit from memory_usage tests (#33231)
Allow usage in production tasks

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
2023-05-24 14:49:23 -07:00
Craig Tiller 4303a67e8b
[memory-usage] Propagate experiments through memory-usage test to client/server (#33206)
Will be used to evaluate experiment effects on memory usage once they're
toggled on.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
2023-05-22 11:46:00 -07:00
Yash Tibrewal aa11978541
Fix include guards for src/ and test/ directories (#32167)
* Fix include guards for src/ and test/ directories

* Sanity

* Update new files
2023-01-20 16:27:27 -08:00
Yijie Ma f99b8b5bc4
Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Cheng-Yu Chung b887534111
[cleanups] Remove `include/grpc/impl/codegen/propagation_bits.h` (#31870)
* Remove `include/grpc/impl/codegen/propagation_bits.h`

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests
2022-12-15 11:08:02 +08:00
Cheng-Yu Chung 77b3972f95
Clean up the TODO item in build target `grpc_base` part `channel_args` (#31642)
* Clean up the TODO item in build target `grpc_base` part `channel_args`

* Update

* Update

* Update

* Automated change: Fix sanity tests

* update

* Automated change: Fix sanity tests
2022-11-23 16:01:34 -05:00
Craig Tiller d410f1d0aa
[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch (#31554)
Add a check that SEND_STATUS_FROM_SERVER and RECV_MESSAGE are not in the same batch.

This is necessary pre-work for #31204 and implements part of grpc/proposal#336.

Also eliminates fling instead of updating it:

My expectation is nobody has looked at this corner in many years
It's not a benchmark we want: concentrating on a microbenchmark that doesn't include a binding layer caused us to favor designs that emphasized a lightweight core at the expense of a expensive bindings. We should consider the whole.

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-11-11 14:18:29 -08:00
Craig Tiller d9ac89a441
[gprpp] absl::Notification polyfill (#31008)
* [gprpp] absl::Notification polyfill

* grpc_core::

* Automated change: Fix sanity tests

* fix

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-16 09:06:03 -07:00
Esun Kim 888c64adf8
Fix the build script (#30985)
* Fix the build script

* Set -ex

* fix unsigned int comparisons and ignored return values

Co-authored-by: AJ Heller <hork@google.com>
2022-09-14 15:36:55 -07:00
Cheng-Yu Chung 779419505f
Replace `absl::exchange()` with `std::exchange()` (#30802)
* Replace `absl::exchange()` with `std::exchange()`

* Update `core_banned_functions.py`
2022-08-31 14:33:56 -04:00
Craig Tiller 622dd886e6
Update flaky tests list (#30771)
* Update flaky tests list

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-30 21:42:59 -07:00
Craig Tiller f573fd44f9
[test] Semi-automatic flaky test tracking (#30638)
* [test] Semi-automatic flaky test tracking

* fix

* Automated change: Fix sanity tests

* Update update_flakes.py

* fix formatting

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-19 16:22:31 -07:00
nancylucy01 cc96858f0b
Add channel memory benchmark into memory_diff.py (#30507)
* Added the channel benchmark to the python script

* removing warning

* Automated change: Fix sanity tests

* added label function for channel and skip for minstack channel

* Automated change: Fix sanity tests

Co-authored-by: nancylucy01 <nancylucy01@users.noreply.github.com>
2022-08-05 09:24:24 -07:00
nancylucy01 2284be0cdd
Create multiple channels in per channel memory benchmark (#30441)
* Added new files for channel client/server

* Committing to switch branch

* Rebasing branch

* Switching branch

* Server process getting called

* Still working

* RPC received success, with sleep

* gRPC Receive success, grpc timeout

* Earlier but Clang tidy

* Fix timeout issue, remove some logs

* Added signint handler, test passing but flaky

* added sleep to reduce flakiness, removed some dependencies, changed LOG to gpr_log

* Changed benchmark_name default back to call

* remove deleted files

* grpc shutdown timeout

* trying to add shutdown

* Some changes

* Removed shutdown

* Automated change: Fix sanity tests

* Changes for review comments

* Changed comments

* Changed benchmark driver defaults so that CI testing would happen for all benchmarks

* Get server memory using RPC

* Add PID method to get memory

* Added gpr_subprocess_get_process_id to windows

* Removed GetAfterSnapshot since theres a not RPC method to get memory

* Automated change: Fix sanity tests

* Changed benchmark driver defaults so that CI testing would happen for all benchmarks

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests

* Forgot semicolon

* Fix includes

* Automated change: Fix sanity tests

* Added GetMemUsage and changed Snapshot and callback server and client to call it

* Moved GetMemUsage from header file

* removed some unnecessary includes

* Automated change: Fix sanity tests

* Updating build file

* forgot a comma

* Added tags to BUILD for memstats

* Automated change: Fix sanity tests

* Switching branches

* Changed channel creation and GetBeforeSnapshot

* Switching branches

* Intermediate commit

* Revert merge commit

* Fixed merge issues

* Automated change: Fix sanity tests

* Changes to fix asan failures

* Automated change: Fix sanity tests

* Fix comment

Co-authored-by: nancylucy01 <nancylucy01@users.noreply.github.com>
2022-08-03 09:42:12 -07:00
nancylucy01 57e06148e5
Fix to #30390 Adding methods to get memory usage of server for the perchannel benchmark (#30435)
* Revert "Revert "Adding methods to get memory usage of server for the perchannel benchmark (#30390)" (#30433)"

This reverts commit 3fe438b55a.

* Made all variables used
2022-07-28 16:13:56 -07:00
Craig Tiller 3fe438b55a
Revert "Adding methods to get memory usage of server for the perchannel benchmark (#30390)" (#30433)
This reverts commit fcdea5afcd.
2022-07-28 13:26:34 -07:00
nancylucy01 fcdea5afcd
Adding methods to get memory usage of server for the perchannel benchmark (#30390)
* Added new files for channel client/server

* Committing to switch branch

* Rebasing branch

* Switching branch

* Server process getting called

* Still working

* RPC received success, with sleep

* gRPC Receive success, grpc timeout

* Earlier but Clang tidy

* Fix timeout issue, remove some logs

* Added signint handler, test passing but flaky

* added sleep to reduce flakiness, removed some dependencies, changed LOG to gpr_log

* Changed benchmark_name default back to call

* remove deleted files

* grpc shutdown timeout

* trying to add shutdown

* Some changes

* Removed shutdown

* Automated change: Fix sanity tests

* Changes for review comments

* Changed comments

* Changed benchmark driver defaults so that CI testing would happen for all benchmarks

* Get server memory using RPC

* Add PID method to get memory

* Added gpr_subprocess_get_process_id to windows

* Removed GetAfterSnapshot since theres a not RPC method to get memory

* Automated change: Fix sanity tests

* Changed benchmark driver defaults so that CI testing would happen for all benchmarks

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests

* Forgot semicolon

* Fix includes

* Automated change: Fix sanity tests

* Added GetMemUsage and changed Snapshot and callback server and client to call it

* Moved GetMemUsage from header file

* removed some unnecessary includes

* Automated change: Fix sanity tests

* Updating build file

* forgot a comma

* Added tags to BUILD for memstats

* Automated change: Fix sanity tests

Co-authored-by: nancylucy01 <nancylucy01@users.noreply.github.com>
2022-07-28 10:40:35 -07:00
Craig Tiller 9511ab003a
[iwyu] Add test/core/memory_usage (#30408)
* include-fix

* include-fix

* iwyu headers

* clang-fmt

* fix
2022-07-25 23:32:25 -07:00
Craig Tiller 05e6bf2e4a
[build] Add test/core/util, test/core/event_engine to auto build deps (#30364)
* [build] Add test/core/util, test/core/event_engine to auto build deps

* deal with suppressions

* fix suppressions

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fix

* progress

* Automated change: Fix sanity tests

* fix

* fix

* fix

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-25 21:59:25 -07:00
nancylucy01 3cd368b28d
Basic callback client and server for new perchannel benchmark (#30305)
* Added new files for channel client/server

* Committing to switch branch

* Rebasing branch

* Switching branch

* Server process getting called

* Still working

* RPC received success, with sleep

* gRPC Receive success, grpc timeout

* Earlier but Clang tidy

* Fix timeout issue, remove some logs

* Added signint handler, test passing but flaky

* added sleep to reduce flakiness, removed some dependencies, changed LOG to gpr_log

* Changed benchmark_name default back to call

* remove deleted files

* grpc shutdown timeout

* trying to add shutdown

* Some changes

* Removed shutdown

* Automated change: Fix sanity tests

* Changes for review comments

* Changed comments

* Changed benchmark driver defaults so that CI testing would happen for all benchmarks

* Automated change: Fix sanity tests

Co-authored-by: nancylucy01 <nancylucy01@users.noreply.github.com>
2022-07-25 10:04:29 -07:00
nancylucy01 24171b3b57
Changing memory benchmark driver's flags (#30276)
* Changed benchmark driver's flags and updated calling python script. Untested

* Changes made for debugging/testing

* Switching branch

* Removed debug statements and changed file permissions for memory_diff

* Minor changes for review

* Changed secure description

* Changed flag configuration for clarity

* Added dep to BUILD file

* Changed return value

* Edits for review, added comments

* Changed a print statement
2022-07-13 10:10:25 -07:00
AJ Heller 18a8f6aad9
Refactor end2end tests to exercise each EventEngine (#29202)
* Refactor end2end tests to exercise each EventEngine

* fix incorrect bazel_only exclusions

* Automated change: Fix sanity tests

* microbenchmark fix

* sanitize, fix iOS flub

* Automated change: Fix sanity tests

* iOS fix

* reviewer feedback

* first pass at excluding EventEngine test expansion

Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.

* end2end fuzzers to be fuzzed differently via EventEngine.

* sanitize

* reviewer feedback

* remove misleading comment

* reviewer feedback: comments

* EE test_init needs to play with our build system

* fix golden file test runner

Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
Craig Tiller bf72db4180
Collect memory measurements of the minimal stack (#29164)
* minstack measuring

* fix

* sort

* x

* x

* x

* x

* Automated change: Fix sanity tests

* review feedback

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-25 10:09:46 -07:00
Craig Tiller 7c74d58cbe
Disable memory_usage test on cmake builds (#28948) 2022-02-23 17:21:55 +01:00
Craig Tiller ff87ca02b2
Revive test/core/memory_usage (#28931)
* Revert "Deprecate gpr_get/set_allocation_functions"

This reverts commit 81df105ac8.

* memory stats

* Hack up to get per-call numbers

* expunge memory counters

* buildgen

* Automated change: Fix sanity tests

* sanity

* fix

* Automated change: Fix sanity tests

* simplify

* better

* Automated change: Fix sanity tests

* Disable windows memory_usage

* disable mac

* disable mac

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-02-22 15:39:40 -08:00
Esun Kim 81df105ac8 Deprecate gpr_get/set_allocation_functions 2019-11-04 19:47:33 -08:00
Vijay Pai 8ff71276f5 Remove unused parameter warning (11 of 20) 2019-10-17 08:51:29 -07:00
tanjunchen 64cdea5a07 fix some spelling mistakes in document 2019-10-04 09:07:35 +08:00
Jan Tattermusch 0f50bf0150 temporarily disable memory usage test on windows 2019-09-30 13:28:00 +02:00
Jan Tattermusch 6ebc1c616f set uses_polling=False for some bazel tests 2019-09-24 09:50:00 +02:00
Soheil Hassas Yeganeh dbf88dd66f Revert "Revert "Introduce string_view and use it for gpr_split_host_port.""
This reverts commit 80c177d4c4.
2019-06-27 20:56:15 -04:00
Soheil Hassas Yeganeh 80c177d4c4
Revert "Introduce string_view and use it for gpr_split_host_port." 2019-06-26 16:22:13 -04:00
Soheil Hassas Yeganeh ef0f9bf7ec Introduce string_view and use it for gpr_split_host_port. 2019-06-20 23:19:34 -04:00
yang-g 456f748b2f Revert "Merge pull request #18146 from grpc/revert-17308-shutdown"
This reverts commit 9079e98dfc, reversing
changes made to 76a38bfcc2.
2019-02-25 10:11:06 -08:00
Yang Gao 4bc2ca4de6
Revert "Move grpc_shutdown internals to a detached thread" 2019-02-22 16:34:24 -08:00
yang-g 545c555d31 Rename new public API 2019-02-14 14:22:40 -08:00
yang-g df9bd2f506 Merge remote-tracking branch 'upstream/master' into shutdown 2019-01-14 13:19:01 -08:00
ncteisen 3af464f29c return targets to library 2019-01-03 08:19:51 -08:00
ncteisen 69e99a8275 Add clang fallthrough annotation 2019-01-02 14:24:30 -08:00
Prashant Jaikumar 08dc0ade67 Fix bazel build for fling, memory_usage test 2018-12-21 15:49:15 -08:00
yang-g 49beab68be Bug fix 2018-12-21 14:03:18 -08:00
yang-g 67742ef63f Fix BUILD files. Manually edit bzl files 2018-12-06 14:37:52 -08:00
yang-g 0e11f2ebd0 convert more tests 2018-11-30 09:11:04 -08:00
Hope Casey-Allen 1547f604e0 Remove unused fuzzer 2018-10-31 08:45:28 -07:00
Hope Casey-Allen 1b27657044 Use grpc_cc_library and remove copt 2018-10-31 08:43:28 -07:00
Hope Casey-Allen c01f4a1d22 Fix internal BUILD error 2018-10-30 20:57:08 -07:00
Hope Casey-Allen 025bda7c33 Remove unused BUILD dependencies 2018-10-30 14:13:36 -07:00
Hope Casey-Allen fabff52be5 Move fallthrough comment so it is recognized internally 2018-10-30 12:17:56 -07:00
hcaseyal 30903abea2
Rename memory_profile_test to match .cc 2018-10-29 16:11:48 -07:00