0642bc213d
Revert "[iwyu] grpc++ ( #29610 )" ( #29720 )
...
This reverts commit c8159eabdf
2022-05-18 09:58:08 -07:00
c8159eabdf
[iwyu] grpc++ ( #29610 )
...
* [iwyu] grpc++
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* [iwyu] Better script
* eliminate race
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-18 07:16:53 -07:00
eded3b6bc3
client channel: record call completion even if recv_trailing_metadata was not started ( #29198 )
...
* client channel: record call completion even if recv_trailing_metadata was not started
* add test
* add test for opencensus filter
* remove unnecessary code
2022-03-24 14:22:16 -07:00
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
2022-02-17 17:56:19 -08:00
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
74a2cb6e2b
Revert "Revert "Reland slice changes ( #28601 )" ( #28615 )" ( #28624 )
...
* Revert "Revert "Reland slice changes (#28601 )" (#28615 )"
This reverts commit 939bbfc336
2022-01-20 12:47:33 -08:00
939bbfc336
Revert "Reland slice changes ( #28601 )" ( #28615 )
...
This reverts commit b33e0d40af
2022-01-19 09:40:19 -08:00
b33e0d40af
Reland slice changes ( #28601 )
...
* Revert "Revert "Eliminate slice interning (#28363 )" (#28598 )"
This reverts commit 03bf699600
2022-01-18 09:29:49 -08:00
03bf699600
Revert "Eliminate slice interning ( #28363 )" ( #28598 )
...
This reverts commit 6703186b7a
2022-01-18 15:44:18 +01:00
6703186b7a
Eliminate slice interning ( #28363 )
...
Eliminate slice interning, and structures in slices to support it.
Reduces grpc_slice_refcount from 40 bytes (+ a required 8 bytes elsewhere) to 16 bytes.
Removes a pointer dereference for every slice ref/unref.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-17 20:25:45 -08:00
4b881c5947
Remove grpc_mdelem ( #28267 )
...
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2022-01-07 09:42:27 -08:00
0deb64d1f6
Move content-type, colon prefixed metadata to new system ( #28204 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* initial refactoring
* optimize status encoding
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-12-13 12:11:45 -08:00
220cf641fa
Reland slice metadata conversion ( #28210 )
...
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-11-29 13:38:40 -08:00
7717587063
Revert "Move a bunch of slice typed metadata to new system ( #28107 )" ( #28208 )
...
This reverts commit 4d432aefc1
2021-11-24 15:41:36 -08:00
4d432aefc1
Move a bunch of slice typed metadata to new system ( #28107 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-24 11:42:37 -08:00
296f596a96
OpenCensus: Move metadata storage to arena ( #27948 )
2021-11-05 13:13:10 -07:00
36b0e06e20
OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch ( #27523 )
...
* OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch
* Reviewer comments
2021-10-02 13:36:10 -07:00
06ef5893f8
Metadata: replace usage of grpc_metadata_batch_remove with Remove method ( #27420 )
2021-09-21 14:45:49 -07:00
9872da79a1
Eliminate grpc_metadata_batch_{init,destroy,move} ( #27349 )
...
* Eliminate grpc_metadata_batch_{init,destroy,move}
* fixes
* fixes
* fixes
* fixes
* portability fixes
* fixes
* fix
* fix
* fix
* be explicit about being explicit
2021-09-20 17:25:26 -07:00
fd233193ec
Encapsulate metadata aggregates ( #27262 )
...
* Encapsulate metadata aggregates
* Automated change: Fix sanity tests
* add const
* Automated change: Fix sanity tests
* add a comment about an awful api
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-14 09:45:38 -07:00
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
2021-09-02 11:42:33 -07:00
9e4c657fa3
C++ opencensus filter: Fix point of creating context for overall call ( #27221 )
2021-09-01 18:37:53 -07:00
1b3e1541fa
Open census call attempt span name and attribute changes ( #26889 )
...
* C++ OpenCensus filter: Add attributes to per-attempt span
* Reviewer comments
* Reviewer comment
* Remove extraneous assert
2021-08-05 16:38:53 -07:00
a3d264e8fd
Open census filter stats api ( #26739 )
...
* Use new stats API in open census filter
* Fix time and latency calculation
* Fix parent census context
* Add tests
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Fix error unref
* Add a context object for the overall call
* Remove TODO
* Reviewer comments
2021-08-02 14:00:15 -07:00
ae3e2c9214
Second attempt: use CallTracer API in client channel code ( #26790 )
...
* Revert "Revert "use CallTracer API in client channel code (#26714 )" (#26772 )"
This reverts commit 98f57af91ca9657b560da9657b5
2021-07-26 15:30:16 -07:00
98f57af91c
Revert "use CallTracer API in client channel code ( #26714 )" ( #26772 )
...
This reverts commit 011fdefe36
2021-07-26 06:49:28 -07:00
1265cfd29a
Add OpenCensus measures and views for retries ( #26751 )
...
* Add OpenCensus measures and views for retries
* Fix views
* Fix measures
2021-07-23 11:53:57 -07:00
011fdefe36
use CallTracer API in client channel code ( #26714 )
...
* Add internal API to help trace retries and collect metrics
* Add headers
* Reviewer comments
* Revert changes for grpc_metadata_batch
* Regenerate projects
* support call tracer in client channel code
* Reviewer comments
* Reviewer comments
* Reviewer comments
* reviewer comments
* add RecordOnDoneSendInitialMetadata() hook
* Fix sanity
* make on_call_destruction_complete always invoked via LoadBalancedCall
* fix handling of status, stats, latency, and peer name
* fix build & clang-format
Co-authored-by: Yash Tibrewal <yashkt@google.com>
2021-07-22 15:17:24 -07:00
dc250d1c68
Add internal API to help trace retries and collect metrics ( #26673 )
...
* Add internal API to help trace retries and collect metrics
* Add headers
* Reviewer comments
* Revert changes for grpc_metadata_batch
* Regenerate projects
* Reviewer comments
* Reviewer comments
* Reviewer comments
* reviewer comments
* Fix sanity
2021-07-20 07:05:59 -07:00
ca945a58e9
Introduced grpc_error_handle ( #25902 )
...
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
2021-04-22 12:00:28 -07:00
57859e3c9d
Remove duplicate code for grpc encoding, and extra class. ( #22334 )
...
* Remove duplicate code for grpc encoding, and extra class.
Originally from #18359 by @bogdandrutu.
* Autoformat.
2021-04-08 11:42:56 +02:00
0db0ab052d
Update by review
2021-01-20 10:44:14 -08:00
9bd7c4917a
Fix unused-parameter warning
2021-01-19 18:18:09 -08:00
ac080fd17a
Fix readability-inconsistent-declaration-parameter-name manually
2020-11-30 14:22:40 -08:00
75e3e660fd
Fix google-readability-todo
2020-11-25 10:09:42 -08:00
aae4f4cf18
Fix by misc-unused-using-decls
2020-10-19 18:12:11 -07:00
6ae8463500
Fix by modernize-make-unique
2020-10-16 13:30:56 -07:00
c08f33c437
Fix clang-tidy errors
2020-10-15 16:07:25 -07:00
9dc71643fa
Return blank span if no call is active.
...
Otherwise unit tests of gRPC servers that call GetSpanFromServerContext
segfault.
2020-07-23 11:46:37 +02:00
f9fac8a6b7
Move ProtoServerReflectionPlugin from grpc_impl to grpc namespace
...
Reverts: https://github.com/grpc/grpc/pull/18600
2020-07-13 14:57:01 -07:00
8d0e703393
Merge pull request #22813 from mehrdada/fix-static-initialization-crap
...
Fix channelz plugin initializer
2020-07-06 11:19:05 -07:00
165ee5007a
Replaced grpc::string with std::string
2020-06-29 17:56:36 -07:00
7fa6826134
Merge branch 'master' into opencensus
2020-06-10 17:47:16 -07:00
e55267a6fd
Resolve conflicts
2020-06-10 17:41:45 -07:00
89763a96fd
Move OpenCensus back to ::grpc from ::grpc_impl
...
Revert - Revert "Revert "Fold opencensus into grpc_impl namespace"" #18396
2020-06-10 17:36:58 -07:00
99367a7f98
Fix plugin initializers
...
Previous code not threadsafe nor idiomatic
2020-04-28 20:16:39 -07:00
4c75b5c06b
Revert "Revert "Revert "Fold opencensus into grpc_impl namespace"""
...
This reverts commit f66b654795
2020-03-05 18:22:03 -08:00
2e958cf01b
(Census client filter: use current span and tags. original_author=g-easy)
2019-12-04 09:47:18 -08:00
08ba7246c0
Remove GRPC_CLOSURE_RUN and replace with grpc_core::Closure::Run
2019-11-01 16:21:16 -07:00
fe30ef5489
clang-format
2019-10-17 09:03:48 -07:00
5a88028c89
Remove unused parameter warning (1 of 20)
2019-10-17 08:50:38 -07:00
3a28314343
Merge branch 'master' into use_cpp11_for
2019-09-05 09:03:58 +08:00
6bca0f04a3
Use opencensus::tags::TagKey.
...
opencensus::stats::TagKey is deprecated.
2019-08-16 19:14:09 +10:00
6cf05561ce
Added overloads for metadata add/remove operations when static index is known.
...
In several cases, we wish to add or remove metadata when we already know what
kind of metadata it is (e.g. we know we're dealing with the path, or the
authority, or the user agent, etc.).
In these cases, we do not need to re-compute the metadata batch callout index
since we know it a-priori. This saves us some branches and ALU ops spent
pointlessly re-computing these indices in several hot-path filters.
We do need the original methods where we do compute the indices in cases where
we're operating over a collection of metadata, but this is relatively uncommon.
2019-08-14 10:51:59 -07:00
557446a11e
Added specializations for grpc_mdelem_create.
...
In several cases, we create grpc mdelem structures using known-static
metadata inputs. Furthermore, in several cases we create a slice on
the heap (e.g. grpc_slice_from_copied_buffer) where we know we are
transferring refcount ownership. In several cases, then, we can:
1) Avoid unnecessary ref/unref operations that are no-ops (for static
slices) or superfluous (if we're transferring ownership).
2) Avoid unnecessarily comprehensive calls to grpc_slice_eq (since
they'd only be called with static or interned slice arguments,
which by construction would have equal refcounts if they were
in fact equal.
3) Avoid unnecessary checks to see if a slice is interned (when we
know that they are).
To avoid polluting the internal API, we introduce the notion of
strongly-typed grpc_slice objects. We draw a distinction between
Internal (interned and static-storage) slices and Extern (inline and
non-statically allocated). We introduce overloads to
grpc_mdelem_create() and grpc_mdelem_from_slices() for the fastpath
cases identified above based on these slice types.
From the programmer's point of view, though, nothing changes - they
need only use grpc_mdelem_create() and grpc_mdelem_from_slices() as
before, and the appropriate fastpath will be picked based on type
inference. If no special knowledge exists for the slice type (i.e. we
pass in generic grpc_slice objects), the slowpath method will still
always return correct behaviour.
This is good for:
- Roughly 1-3% reduction in CPU time for several unary/streaming
ping pong fullstack microbenchmarks.
- Reduction of about 15-20% in CPU time for some hpack parser
microbenchmarks.
- 10-12% reduction of CPU time for metadata microbenchmarks involving
interned slice comparisons.
2019-07-30 17:07:44 -07:00
226e63dd0c
Move server context implementation to grpc_impl namespace and typedef the ref to it
2019-06-05 10:41:30 -07:00
8e092b45fa
Move ProtoServerReflectionPlugin from grpc to grpc_impl namespace
2019-04-01 13:32:40 -07:00
4260fe1147
More fixes
2019-03-21 17:51:28 -07:00
f66b654795
Revert "Revert "Fold opencensus into grpc_impl namespace""
2019-03-15 11:30:23 -07:00
2bf934f97d
Revert "Fold opencensus into grpc_impl namespace"
2019-03-15 10:20:06 -07:00
5e5e337b03
fix from clang format code
...
Add fixes from clang_format_code.sh.
2019-03-06 10:21:37 -08:00
b606cad6cc
Fold opencensus into grpc_impl namespace
...
Moving opencensus into grpc_impl namespace..
2019-03-04 15:47:37 -08:00
06c8294fb5
Merge branch 'master' into use_cpp11_for
2019-02-13 16:36:43 +08:00
8279777167
Destruct CensusContext to avoid leaking memory.
...
Otherwise, the placement-new leaks context -> span_ -> impl_ which is
a std::shared_ptr.
2018-12-19 12:37:39 +11:00
d8d9d78e5e
fix conflict
2018-10-22 23:38:54 +08:00
f551f475f0
GenerateServerContext: Don't use a parent context if it's invalid.
2018-10-08 20:43:06 +11:00
99e09fe821
Fix compilation error due to missing absl qualification.
2018-08-25 09:50:58 -07:00
ccc6ee3db0
Merge pull request #15984 from g-easy/hdrs
...
Move GetSpanFromServerContext() to public header.
2018-08-20 17:03:03 -07:00
381bcab8bd
Move a file from src/cpp to src/core since core depends on it
2018-08-16 15:44:19 -07:00
b840d5e45c
Revert "Add more filter priority levels"
2018-08-16 08:58:26 -07:00
d6ef707422
Add more filter priority levels
2018-08-01 11:22:32 -07:00
1b6e8514a9
Move GetSpanFromServerContext() to public header.
2018-07-11 14:55:46 +10:00
c0d251a10e
Fixing trailing metadata ops.
2018-06-19 16:21:26 -07:00
cb2767143c
update
2018-05-24 22:39:23 -07:00
60086793e0
update
2018-05-22 16:03:16 -07:00
fb38c259c5
fix conflict
2018-05-16 23:47:02 +08:00
41e4cedb70
Adding opencensus grpc plugin.
...
Rebasing to merge commits.
2018-05-10 11:41:15 -07:00
0e00c43082
Move headers from grpc++ to grpcpp
2018-02-15 14:49:34 -08:00
baa14a975e
Update clang-format to 5.0
2017-11-03 09:09:36 -07:00
7763f11c98
use range for loop
2017-06-21 10:22:26 +08:00
7897ae9308
auto-fix most of licenses
2017-06-08 11:22:41 +02:00
c0b2acb1a0
Use C++11 final and override
2016-11-01 16:31:56 -07:00
324cc66128
Fix missing dependencies
2016-10-17 11:27:35 -07:00
169c985f67
Remove generated pb files
2016-10-14 15:58:09 -07:00
146a3773da
PHP Proto3: upgrade protobuf to v3.1.0 and regenerate reflection.proto
2016-09-29 17:26:50 -07:00
ef394a954a
Fix typo
2016-09-23 14:04:33 -07:00
27e96f9beb
Add comments about how to re-generate reflection proto files
2016-09-22 20:56:46 -07:00
7f074e0e20
Merge branch 'v1.0.x' into manual-upmerge
2016-08-11 21:00:08 +02:00
3df9bdf880
Update generated files with new protobuf version
...
Also make the script fetch protoc from the usual place.
2016-08-03 10:48:23 -07:00
12c3811167
Use compiling instead of making
2016-07-20 17:54:37 -07:00
6b88b22d9e
Add comments for GRPC_NO_GENERATED_CODE
2016-07-19 19:12:46 -07:00
1318479011
Separate generated file and protobuf dependency
2016-07-18 13:07:42 -07:00
6b668cc93f
Remove range-based for, comparisons to nullptr
2016-06-16 07:49:36 +00:00
4e1a883a5f
Digraph
2016-06-16 07:32:42 +00:00
7ae31a8898
Add more comments, fix format issues
2016-06-06 14:35:51 -07:00
0601df3a04
Move reflection src/hdr to src/cpp/ext include/grpc++/ext
2016-06-06 13:08:06 -07:00
Craig Tiller