Commit Graph

2089 Commits

Author SHA1 Message Date
Mehrdad Afshari 327b3fb6f8 Eliminate raising-bad-type suppression 2018-04-19 10:39:38 -07:00
Mehrdad Afshari ce8e2fcd16 Eliminate unreachable suppression 2018-04-19 10:39:38 -07:00
Mehrdad Afshari 35c7e8c833 Eliminate bad-continuation suppression 2018-04-19 10:39:37 -07:00
Mehrdad Afshari 8e9baf35bd Bump protobuf runtime dependency versions 2018-04-19 02:07:59 -04:00
kpayson64 7a20c962df Break out qps services into seperate protos 2018-04-18 22:13:09 -07:00
Nathaniel Manista 4d647cf9c1 Fix a use of nonexistent .received_cancelled
.received_cancelled was changed to .cancelled() in
81edf5ff9af2d90813773acb9c2793e1a4cd1057; this change should have been
a part of that change.
2018-04-17 18:58:11 +00:00
Mark D. Roth a63aa993e0 Merge remote-tracking branch 'upstream/master' into c++_subchannel_list 2018-04-10 14:02:26 -07:00
Mehrdad Afshari 90cfc8ed57 Regenerate projects 2018-04-04 14:04:11 -07:00
Nicolas "Pixel" Noble 7d6d2e8bce Removing setsockopt completely actually. 2018-04-04 01:42:00 +02:00
Nicolas "Pixel" Noble 5426183de0 Taking care of gevent. 2018-04-04 00:56:07 +02:00
Mark D. Roth eef0cf6416 Merge remote-tracking branch 'upstream/master' into c++_subchannel_list 2018-04-03 14:55:42 -07:00
kpayson64 51d710273f Fix gevent test flakes 2018-04-02 11:10:31 -07:00
Mark D. Roth 7c1b5db3bb Convert subchannel_list code to C++. 2018-03-30 13:28:56 -07:00
David G. Quintas 07e75a02a0
Merge pull request #14615 from dgquintas/authority_header
Secure channels: use the right authority
2018-03-28 15:44:52 -07:00
kpayson64 c39496540c
Merge pull request #14561 from kpayson64/gevent_2
Initial Gevent Compatibility
2018-03-28 10:04:12 -07:00
kpayson64 1bfff8eec0 Initial gevent support
Because some cpp code ends up leaking into cython, we change
the cython generator to generate cpp code.
2018-03-27 19:44:43 -07:00
kpayson64 0bb2fe946e Explicitly stop servers in unit tests.
Relying on garbage collection to stop servers breaks with gevent.
2018-03-27 19:44:43 -07:00
David Garcia Quintas 158375a440 Merge branch 'master' of github.com:grpc/grpc into authority_header 2018-03-27 14:46:18 -07:00
David Garcia Quintas 49f625f232 more comments 2018-03-27 11:23:49 -07:00
David Garcia Quintas e44efe099d rest of pr comments 2018-03-26 16:23:07 -07:00
apolcyn bd6bdf9327
Merge pull request #13290 from apolcyn/cares_address_sorting_master_c
Add address sorting submodule for use in c-ares wrapper
2018-03-26 14:34:57 -07:00
David Garcia Quintas 811169d62f Merge branch 'master' of github.com:grpc/grpc into authority_header 2018-03-23 22:39:35 -07:00
David Garcia Quintas fa460dcf1d Factor out grpc_add_default_authority_if_not_present 2018-03-23 14:51:41 -07:00
Feng Li 7b2f5775d8 Release the GIL when calling grpc_call_start_batch. 2018-03-23 09:23:51 -07:00
David Garcia Quintas 8824a137b8 Merge branch 'master' of github.com:grpc/grpc into authority_header 2018-03-21 18:27:23 -07:00
Noah Eisen e21c7bfd80
Merge pull request #14765 from grpc/revert-14687-early-ok
Revert "Verify early OK behavior"
2018-03-21 17:39:29 -07:00
David Garcia Quintas 0abc077d45 Merge branch 'master' of github.com:grpc/grpc into authority_header 2018-03-21 17:10:15 -07:00
Noah Eisen dc93b71e53
Merge pull request #14751 from ncteisen/channel-tracing
[Fix Forward]: Channel Tracing Implementation; Part 1
2018-03-21 16:49:12 -07:00
David Garcia Quintas a10634cadc Merge branch 'master' of github.com:grpc/grpc into authority_header 2018-03-21 16:35:36 -07:00
Alexander Polcyn 690dde672a Add address sorting submodule for use in c-ares wrapper 2018-03-20 23:51:19 -07:00
Noah Eisen d2bc0c2609
Revert "Verify early OK behavior" 2018-03-20 15:59:47 -07:00
Ruslan Nigmatullin 99d0cee31b regenerate projects 2018-03-20 09:18:29 -07:00
Ruslan Nigmatullin 7ae3733cab [grpc] Add SSL session client cache support 2018-03-20 09:17:28 -07:00
ncteisen 3b42f83068 Revert "Revert "Channel Tracing Implementation; Part 1""
This reverts commit f2bea3725f.
2018-03-19 13:22:35 -07:00
Noah Eisen f2bea3725f
Revert "Channel Tracing Implementation; Part 1" 2018-03-19 12:05:18 -07:00
ncteisen b93a006d64 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-03-15 13:46:28 -10:00
David Garcia Quintas 961353ab6d moved filter to ext 2018-03-15 16:11:05 -07:00
kpayson64 2401c93e07
Merge pull request #14657 from ghostwriternr/reflection-readme
Create README for gRPC Python reflection package
2018-03-15 11:06:29 -07:00
Nathaniel Manista 62170372a7 Remove _face_interface_test
The Beta API has an execution date and RPC Framework is but a distant
memory.

This test is flaky with Python 3.5 on Windows! Some mysteries will just
have to remain unsolved...
2018-03-13 23:50:25 +00:00
Nathaniel Manista f7a8f8ba7c
Merge pull request #14687 from nathanielmanistaatgoogle/early-ok
Verify early OK behavior.
2018-03-13 16:44:11 -07:00
Nathaniel Manista 7726c303a6 Verify early OK behavior
Looks like early OK support was implemented in
https://github.com/grpc/grpc/pull/14080 but
https://github.com/grpc/grpc/issues/7032 was not marked fixed at the
time.

Good thing it was just an idea on our Google Summer of Code ideas
page...
2018-03-13 21:59:54 +00:00
Naresh c6e4372f8a Create README for gRPC Python reflection package
Currently, `warning: sdist: standard file not found` warning is always
printed when creating source distribution for gRPC python reflection
package. This should stop that.
2018-03-13 19:43:43 +00:00
David Garcia Quintas aa843f2bfc Testing making the authority filter a plugin, for cronet 2018-03-13 12:37:11 -07:00
kpayson64 539f5068bd Abstract libuv implementation
Structures the libuv implementation to allow for a plugable
BSD style socket implementation to allow for other IO Managers
2018-03-13 01:21:42 -07:00
David Garcia Quintas c7c0d69d8b Secure channels: use the right authority 2018-03-10 21:32:57 -08:00
Yihua Zhang 04fb58efbd Add ALTS code to grpc/core 2018-03-08 06:49:24 -08:00
Jan Tattermusch a5935917c5
Merge pull request #14629 from jtattermusch/bump_boringssl
Update third_party/boringssl to the latest chromium-stable
2018-03-08 10:44:02 +01:00
Sree Kuchibhotla ae277dd000
Revert "Add ALTS C stack to gRPC core" 2018-03-07 14:35:36 -08:00
kpayson64 b243732f3f
Merge pull request #14448 from kpayson64/remove_poller
Remove Python background poller thread
2018-03-07 14:06:20 -08:00
Jan Tattermusch d606e36061 regenerate projects 2018-03-07 21:21:38 +01:00
ncteisen 0c6024b94d Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-03-07 10:17:15 -08:00
Yihua Zhang eaf6486677 Add ALTS code to grpc/core 2018-03-06 21:40:45 -08:00
ncteisen e9587db853 Move status util 2018-03-06 08:16:04 -08:00
ncteisen 1cc064dbfc Reviewer feedback, s/object_registry/channel_trace_registry 2018-03-06 08:01:17 -08:00
ncteisen 31c05ba668 reviewer feedback, rename 2018-03-06 07:09:37 -08:00
ncteisen 94dad67f43 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-03-02 22:09:52 -08:00
ncteisen 75cf85c9ce Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-03-01 19:57:24 -08:00
Vijay Pai b357f2f548 Merge branch 'master' into 2phase_thd 2018-03-01 11:48:29 -08:00
Mark D. Roth 718c8341ca Retry support. 2018-02-28 13:00:04 -08:00
Mark D. Roth 3e7f2df047 Convert slice hash table and service config code to C++. 2018-02-26 14:39:26 -08:00
Vijay Pai 8b05d0284f Merge branch 'master' into 2phase_thd 2018-02-24 10:37:13 -06:00
Mehrdad Afshari 9073ea03ef Regenerate projects 2018-02-22 22:21:33 -08:00
Vijay Pai a8453a20d8 Merge branch 'master' into 2phase_thd 2018-02-21 10:24:15 -08:00
Ken Payson a75712a71f Remove Python background poller thread 2018-02-20 18:11:46 -08:00
Yihua Zhang 75f0a9fbd2 place security_connector in its own subdirectory 2018-02-20 10:09:47 -08:00
Vijay Pai da69355f30 C++ize gpr_thread as grpc_core::Thread, make it 2-phase init (construct/Start) 2018-02-19 22:39:58 -08:00
Vijay Pai 58a62755fc Remove support for detached threads. All threads must be joined. 2018-02-15 21:30:13 -08:00
Mehrdad Afshari db04c18289 Clarify add_done_callback works on both success and failure 2018-02-13 11:25:28 -08:00
ncteisen ac86f04373 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-02-13 09:27:35 -08:00
Vijay Pai 0693b72b7f Merge branch 'master' into gpr_review 2018-02-08 15:18:13 -08:00
Mark D. Roth 2a073981f3
Merge pull request #13684 from markdroth/c++_resolver
C++ Resolver API
2018-02-08 12:18:55 -08:00
Vijay Pai 18b9133f31 Merge branch 'master' into gpr_review 2018-02-08 12:18:09 -08:00
Vijay Pai 239b7d4b0b Merge branch 'master' into gpr_review 2018-02-08 11:08:41 -08:00
Mark D. Roth 209f644f04 Convert resolver API to C++. 2018-02-08 10:26:46 -08:00
Vijay Pai 32748c1b2a Merge branch 'master' into gpr_review3 2018-02-08 10:06:23 -08:00
Vijay Pai 8f4fbb1c55 Move avl to its own directory and rename it to grpc_avl 2018-02-08 10:04:08 -08:00
Muxi Yan cda058de8e build projects 2018-02-06 18:17:42 -08:00
Muxi Yan 6f0b195d20 Replace GRPC_COMPRESS_MESSAGE_* with GRPC_COMPRESS_* 2018-02-06 18:17:42 -08:00
Mehrdad Afshari b66e6fe761 Sleep a second to deflake ReconnectTest
The thread that watches connectivity on the channel might not
pick up that the server has gone away before the request is
dispatched, and return UNAVAILABLE instead of reconnecting
prior to sending the request.  The fundamental solution would
basically be enabling retries in C-core.  For now, we opt to
sleep a second to deflake this particular test case.
2018-02-06 16:07:32 -08:00
Vijay Pai 4c0640ebd6
Merge branch 'master' into gpr_review3 2018-02-02 09:12:11 -08:00
Vijay Pai e5b0a50416
Merge pull request #14015 from vjpai/alarm
Remove alarm from core, implement in C++ layer only
2018-02-02 08:44:20 -08:00
ncteisen bdb746ec00 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-01-29 10:58:59 -08:00
Matt Kwong a110c74c58 Update BoringSSL to latest chromium-stable ref 2018-01-26 18:21:25 -08:00
Nathaniel Manista 16316a9fec
Merge pull request #14107 from nathanielmanistaatgoogle/12531
Elide cygrpc.ChannelArg and cygrpc.ChannelArgs.
2018-01-26 12:59:34 -08:00
Mark D. Roth 77474d46ad
Merge pull request #13820 from yihuazhang/rename-gts
Rename GTS to ALTS for TSI plugin
2018-01-26 08:30:44 -08:00
Nathaniel Manista c73758acb0 Elide cygrpc.ChannelArg and cygrpc.ChannelArgs 2018-01-26 07:09:28 +00:00
Vijay Pai 8a99fdb57e Move cmdline and subprocess from public gpr to test/core/util 2018-01-25 20:11:38 -08:00
ncteisen 99bc5c624d Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-01-24 16:20:29 -08:00
Muxi Yan fd900e09fb Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2018-01-24 16:16:23 -08:00
Yihua Zhang d36fe0708b rename gts to alts 2018-01-23 10:40:45 -08:00
ncteisen 34ebf5dd9e Move object registry out of gpr 2018-01-23 09:10:14 -08:00
ncteisen bd0c019c39 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-01-23 08:58:11 -08:00
Vijay Pai 2b226adf60 Remove alarm from core, implement in C++ layer only 2018-01-21 21:03:56 -08:00
Mehrdad Afshari 6615ef5eef Relax call details interface from interceptor
A gRPC Python client interceptor is passed an instance of a class
that implements the ClientCallDetails interface.  The interceptor
can choose to create its own object that implements the interface,
and pass it back to the continuation invoked by the interceptor.

To make it easy to add additional attributes to call details,
without breaking user code that hardcode the attributes required
by the interface, instead of interospecting the object passed
to the interceptor at runtime, and to ease authorship of
interceptors that want to keep some attributes intact and not
care about them, we relax the requirements on the object that
is expected to get passed by the interceptor and let the user
omit some attributes.  Omitted attributes will be replaced
by the original value of the attribute given to the interceptor.
2018-01-21 16:20:47 -08:00
Mehrdad Afshari 43884047c9 Regenerate projects 2018-01-19 14:25:15 -08:00
Muxi Yan 19b4feaee7 Update surface API in cython pxi 2018-01-19 12:22:24 -08:00
Muxi Yan fb061c329a Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2018-01-19 12:20:15 -08:00
Mark D. Roth dbdf495f61 Split lib/support into lib/gpr and lib/gpr++. 2018-01-18 11:21:12 -08:00
Mehrdad Afshari f2a33b0e39 Reformat Python docstrings 2018-01-17 18:13:26 -08:00
kpayson64 e1e562eb17
Merge pull request #13965 from evanj/python-abort-fix
python: Context.abort should fail RPC even for StatusCode.OK
2018-01-12 17:09:43 -08:00
Evan Jones 145b199c4d python: Context.abort should fail RPC even for StatusCode.OK
grpc.ServicerContext.abort is documented to always raise an exception
to terminate the RPC. The code argument "must not be StatusCode.OK."
However, if you do pass StatusCode.OK, the RPC terminates successfully
on the client side, but returns None.

_server.py: If the user accidentally passes StatusCode.OK, treat it as
    StatusCode.UNKNOWN. This is what happens if the user accidentally
    passes something that is not a StatusCode instance. Additionally
    set details to ''.

_metadata_code_details_test.py: update test to verify the behavior of
    abort with invalid codes.
2018-01-12 18:20:55 -05:00
Nathaniel Manista 31ddbff8cf Elide cygrpc.Timespec 2018-01-10 22:58:00 +00:00
ncteisen b04efac6a5 Merge branch 'master' of https://github.com/grpc/grpc into channel-tracing 2018-01-09 13:49:37 -08:00
Mehrdad Afshari 87cd994b04 Upgrade yapf to 0.20.0
Upgrade yapf version to 0.20.0 and reformat Python files.
2018-01-02 14:40:00 -08:00
Nathaniel Manista e1d592a999
Merge pull request #13891 from nathanielmanistaatgoogle/12531
Reform cygrpc.OperationTag and cygrpc.Event.
2017-12-31 17:11:26 -08:00
Mehrdad Afshari c71c6a7f3d Merge branch v1.8.x into master
Upmerge v1.8.3 into master
2017-12-31 14:10:01 -08:00
Nathaniel Manista 7b9c023391 Reform cygrpc.OperationTag and cygrpc.Event
Rather than single classes they are now broken up into class families
with each class containing only those fields and methods that are
needed in the context in which the class is used.
2017-12-31 20:43:58 +00:00
Mehrdad Afshari 6c9a0a1a96 Bump version to 1.8.3 2017-12-30 18:28:13 -08:00
ncteisen 7d9b6358b5 Initial commit
Picks up work from https://github.com/grpc/grpc/pull/10259.
A merge was impossible due to the many sweeping changed that
have occured since I last touched that PR (c++-ization, exec_ctx,
reorganitation of filters, etc).
2017-12-28 15:09:17 -08:00
Nathaniel Manista 81edf5ff9a Reform cygrpc.Operation
It is now a family of classes conforming to an interface rather than a
single class no single instance of which makes use of all behavior
scoped to the class.

It also now only uses gRPC Core memory for the time of a single batch
rather than for the entire lifetime of the instance.
2017-12-21 19:31:15 +00:00
Mehrdad Afshari 271b042c4d Fix port picking logic in Python tests 2017-12-20 22:51:02 -08:00
kpayson64 247a05e4b3
Merge pull request #13843 from kpayson64/fix_python_tests
Disable so_reuseport for Python tests
2017-12-20 14:21:04 -08:00
Ken Payson 3bc8e422dc Disable so_reuseport for Python tests 2017-12-20 13:02:00 -08:00
Ken Payson 16e4bc010a Bump to 1.8.2 2017-12-19 17:29:04 -08:00
Mehrdad Afshari 0981f9fab1 Bump version to 1.8.1 2017-12-14 15:14:23 -08:00
Mehrdad Afshari 5b6b591343
Merge pull request #13789 from grpc/v1.8.x
Upmerge changes from v1.8.x to master
2017-12-14 13:56:36 -08:00
kpayson64 f5649c7e96
Merge pull request #13786 from kpayson64/fix_python_server_race
Fixes race condition in Python server shutdown
2017-12-14 13:11:35 -08:00
Ken Payson 8179b9523a Fixes race condition in Python server shutdown
When we set the call state to "CANCELLED" after
grpc_cancel_all_calls, we would block other start batch
operations from happening. The rpc_state for the cancelled
call would still be in the server's rpc_states set, but it
would never get removed because there were no active batches
for the call, and the only place we remove from rpc_states is
when a batch completes.

It is better to rely on c-core's cancellation. Once a call
is cancelled, all subsequent ops on that call will return
immediately with a cancellation error.

The RLock() change is due to the possibility that
_on_call_completed
gets invoked immediately when the call has already completed when the
rpc_future callback is created.
2017-12-14 12:07:07 -08:00
Nathaniel Manista e1c4021726 Reallow out-of-spec metadata
This restore unsupported, de facto behavior that was dropped in
80516e884a but that it turns out a lot of folks
have been using.
2017-12-14 18:52:37 +00:00
Muxi Yan 032e9b32dc Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2017-12-13 14:04:45 -08:00
Mehrdad Afshari 0ba96edc41 v1.8.0-pre2 is now v1.8.0 2017-12-12 14:01:25 -08:00
Mehrdad Afshari fdfaf1b12e Add tests for gRPC Python interceptor machinery 2017-12-12 12:01:07 -08:00
Mehrdad Afshari 108500f194 Add gRPC Python client-side interceptor machinery 2017-12-12 12:01:07 -08:00
Mehrdad Afshari 68e1978e9e Add gRPC Python service-side interceptor machinery 2017-12-12 12:01:02 -08:00
Muxi Yan c870ce5476 More message compression level clean-up 2017-12-11 15:53:22 -08:00
Mehrdad Afshari c5ba665b22 Merge remote-tracking branch 'origin/v1.8.x' 2017-12-11 11:32:11 -08:00
ncteisen 138ee78529 yapf grpcio_tests 2017-12-11 16:32:31 -08:00
ncteisen e2097f0cc9 yapf-ize grpc_testing 2017-12-11 16:27:29 -08:00
ncteisen 0f6c518e3c yapf-ize grpcio_reflection 2017-12-11 16:22:30 -08:00
ncteisen d258430bc3 yapf-ize grpcio_health_checking 2017-12-11 16:16:20 -08:00
ncteisen 128366374f Yapf-ize grpcio/grpc_.py 2017-12-11 16:14:24 -08:00
Mehrdad Afshari b0afa016cb Refactor: Rename call to response_iterator_call
Rename call to response_iterator_call file-wide for response-streaming tests.
2017-12-10 06:32:13 -08:00
Mehrdad Afshari 90ab995cb0 Tests for ServicerContext.abort 2017-12-10 20:45:18 -08:00
Mehrdad Afshari 9bc44e3829 Introduce ServicerContext.abort to abort an RPC
gRPC Python required RPCs terminating with non-OK status code to still
return a valid response value after calling set_code, even though the
response value was not supposed to be communicated to the client, and
returning None is considered a programming error.

This commit introduces an alternative mechanism to terminate RPCs by
calling the `abort` method on `ServicerContext` passed to the handler,
which raises an exception and signals to the gRPC runtime to abort the
RPC with the specified status code and details.
2017-12-10 20:45:13 -08:00
Nathaniel Manista d14035c55a
Merge pull request #13688 from nathanielmanistaatgoogle/12531
Elide cygrpc.Operations.
2017-12-08 14:40:37 -08:00
Muxi Yan 99024d6436 Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2017-12-08 14:02:18 -08:00
Nathaniel Manista c5c1216a65 Elide cygrpc.Operations 2017-12-08 20:55:15 +00:00
Nathaniel Manista 5cff6d3c2d
Merge pull request #13672 from nathanielmanistaatgoogle/12531
Streamline metadata in gRPC Python.
2017-12-08 10:50:22 -08:00
Nathaniel Manista 80516e884a Streamline metadata in gRPC Python 2017-12-08 11:07:35 +00:00
Yash Tibrewal caaf416eba virtual destructor in exec_ctx, remove unneeded flush in grpc_shutdown and remove grpc_exec_ctx from .pxi files in python 2017-12-07 21:09:11 -08:00
Nathaniel Manista ae74a320dc Fix Beta API metadata looseness 2017-12-08 03:02:32 +00:00
Muxi Yan 6043006af1 Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2017-12-06 22:29:12 -08:00
Muxi Yan fc38142db6 Merge commit 'b0bad8f^' into fix-stream-compression-config-interface 2017-12-06 22:02:08 -08:00
Muxi Yan 4a117f0be7 Merge e759d2a^ 2017-12-06 18:47:16 -08:00
Mehrdad Afshari aaf63d9277 Upmerge changes from v1.8.x to master 2017-12-05 10:01:41 -08:00
Mehrdad Afshari bfdaefef43 Refactor: rename 'e' to 'exception' 2017-12-04 21:49:45 -08:00
Mehrdad Afshari b030ccae05 Return UNKNOWN on GenericRpcHandler failure
A GenericRpcHandler registered on a gRPC Server is not supposed to raise
an exception and if it does so it is considered a programming defect.
However, gRPC is supposed to respond to the client with an UNKNOWN
status code.  Previously, this situation was left unhandled and the
client ended up receiving a response with CANCELLED status code.

This commit fixes the issue https://github.com/grpc/grpc/issues/13629.
2017-12-04 15:21:49 -08:00
Nathaniel Manista 562544151d
Merge pull request #13603 from nathanielmanistaatgoogle/credentials
Change client-side credentials' use of gRPC Core.
2017-12-04 08:39:08 -08:00
Nathaniel Manista 0c1f59e6d5
Merge pull request #13593 from nathanielmanistaatgoogle/12531
Refactor _plugin_wrapping.
2017-12-04 07:52:27 -08:00
Nathaniel Manista dfe8403280 Change client-side credentials' use of gRPC Core
Rather than allocating gRPC Core memory when instantiated and
retaining it until deleted, gRPC Python's credentials objects now
offer methods to create gRPC Core structures on demand.
2017-12-03 22:33:19 +00:00