Vijay Pai
91bb4e178c
Check for nullptr (deser failure) before destructing included request
2021-01-13 01:33:13 -08:00
Adam Cozzette
63ee5b62c2
Updated parse_json.cc to rely on config_protobuf.h for protobuf types
...
Google's internal version of the gRPC codebase uses a version of
protobuf with a different namespace and include paths. This commit makes
parse_json.cc rely on config_protobuf.h for protobuf types so that it
will work properly in that environment. I also replaced a call to
Status::error_code() with a call to Status::code() instead. This way the
code will work with absl::Status, which has a somewhat different API
compared to google::protobuf::util::Status.
2020-12-23 15:55:17 -08:00
Esun Kim
20509e823d
Fix google-explicit-constructor
2020-12-03 19:22:22 -08:00
Esun Kim
decc199ca8
Fix by clang-tidy
2020-12-03 16:24:19 -08:00
Vijay Pai
afe4d1d086
Reduce templating for async client unary call codegen
2020-10-30 14:26:47 -07:00
Vijay Pai
3ecb008aa0
Merge pull request #24494 from vjpai/server_code_size
...
Reduce template use in sync server unary calls
2020-10-29 22:56:51 -07:00
Esun Kim
9936d7785c
Merge pull request #24198 from chrisse74/protoUtilsStaticCast
...
proto_utils.h: suppress conversion warning
2020-10-25 09:26:05 -07:00
Esun Kim
43333b4232
Merge pull request #24535 from veblush/clean-up-WriteOptions
...
Clean up WriteOptions cctor
2020-10-23 10:52:58 -07:00
Vijay Pai
96503e3c72
Reduce code paths
2020-10-22 22:29:22 -07:00
Esun Kim
119228e7bb
Clean up WriteOptions cctor
2020-10-22 11:11:09 -07:00
Esun Kim
d812b0cf38
Fix errors in doxygen param descriptions
2020-10-22 10:42:59 -07:00
Vijay Pai
6f7a98916b
Reduce template use in server
2020-10-21 13:33:16 -07:00
Vijay Pai
476743786b
Also reduce templating for ClientUnaryReactor
2020-10-20 04:12:40 -07:00
Vijay Pai
97924fcfb2
Merge pull request #24420 from vjpai/sync_client_code_size_v2
...
Reduce sync client templating for protobuf without protobuf dependence
2020-10-20 00:08:17 -07:00
Vijay Pai
8f9233ca30
Merge pull request #24423 from vjpai/callback_client_code_size_v2
...
Reduce templating for unary callback client RPC without protobuf dependence
2020-10-20 00:07:51 -07:00
Esun Kim
34789b2d83
Fix by clang-format-8.
2020-10-16 11:37:18 -07:00
Vijay Pai
ef212a908e
Reduce sync client templating for protobuf
2020-10-15 04:48:20 -07:00
Vijay Pai
7e72bba162
Reduce templating for unary callback client RPC
2020-10-15 04:47:39 -07:00
Karthik Ravi Shankar
e549843885
Move remaining classes to grpc from grpc_impl
2020-10-06 13:15:51 -07:00
Vijay Pai
0809fd8b17
Merge pull request #24177 from vjpai/server_call_startup
...
Fix server backlog processing to not set stream until backlog cleared
2020-09-23 09:34:29 -07:00
Vijay Pai
f8b046e819
Eliminate ServerContextBase::Clear/Setup and fix unref process for core call
2020-09-22 00:37:25 -07:00
Christian Maurer
d48e350d58
Remove conversion warning by static casting
2020-09-21 16:34:05 +02:00
Vijay Pai
346a00eb31
Cleanup generic server contexts
2020-09-19 12:29:32 -07:00
Vijay Pai
b427807f3b
Fix server backlog processing to not set stream until backlog cleared
2020-09-17 15:38:06 -07:00
Karthik Ravi Shankar
30ed2f513f
Merge pull request #24082 from karthikravis/sync-stream
...
Move async, callback and sync implementation from grpc_impl to grpc namespace
2020-09-17 10:47:59 -07:00
Vijay Pai
6bbe905e27
Remove invalid forward declaration
2020-09-10 16:56:41 -07:00
Karthik Ravi Shankar
375d92be8d
Merge branch 'master' into sync-stream
2020-09-08 15:14:48 -07:00
Karthik Ravi Shankar
67667eb7b6
Revert ...
2020-09-03 08:16:10 -07:00
Karthik Ravi Shankar
b657c8d79c
Revert "Revert "Move ServerContext from ::grpc_impl to ::grpc""
2020-09-02 10:17:00 -07:00
Karthik Ravi Shankar
f1abdd1725
Revert "Move ServerContext from ::grpc_impl to ::grpc"
2020-09-01 22:54:54 -07:00
Karthik Ravi Shankar
9afbf02198
Merge branch 'master' into server-context
2020-08-31 17:37:37 -07:00
Karthik Ravi Shankar
967c0a2a32
Move Server from ::grpc_impl to ::grpc
...
Reverts: https://github.com/grpc/grpc/pull/18458
2020-08-20 14:53:17 -07:00
Karthik Ravi Shankar
a23578444c
Fix and format build after rebase
2020-08-20 14:17:49 -07:00
Karthik Ravi Shankar
dc3e1097e9
Merge branch 'master' into server-context
2020-08-19 14:18:27 -07:00
Vijay Pai
d4766cef2d
Merge pull request #23859 from grpc/vjpai-patch-1
...
Document purpose of `grpc/impl/codegen`
2020-08-17 13:44:36 -07:00
Karthik Ravi Shankar
d6ad6d16d2
Merge pull request #23795 from karthikravis/client-context
...
Move ClientContext from ::grpc_impl to ::grpc
2020-08-17 12:17:48 -07:00
Vijay Pai
8a3c0a8c95
Justify existence of this directory
2020-08-17 11:42:36 -07:00
Vijay Pai
355c7b26d4
Update README.md
2020-08-14 11:34:48 -07:00
Vijay Pai
7dd4e786cd
Justify this directory's existence
2020-08-14 11:28:03 -07:00
Karthik Ravi Shankar
56d7d9e804
Move ServerContext from ::grpc_impl to ::grpc
2020-08-13 14:24:29 -07:00
Karthik Ravi Shankar
751b9c105f
Move ClientContext from ::grpc_impl to ::grpc
...
Reverts: https://github.com/grpc/grpc/pull/19261
2020-08-11 16:28:50 -07:00
Karthik Ravi Shankar
15cce00f52
Revert "Revert "Fold Channel and CompletionQueue from grpc_impl to grpc""
2020-08-06 20:42:54 -07:00
Karthik Ravi Shankar
f3f9e8941a
Revert "Fold Channel and CompletionQueue from grpc_impl to grpc"
2020-08-06 15:56:09 -07:00
Karthik Ravi Shankar
ab775de1a2
Build and formatting fixes
2020-08-04 13:31:42 -07:00
Karthik Ravi Shankar
390132c87f
Merge branch 'master' into channel
2020-08-04 11:48:10 -07:00
Karthik Ravi Shankar
3c2f4b40e3
Fold Channel and CompletionQueue from grpc_impl to grpc
...
Reverts: https://github.com/grpc/grpc/pull/19067
2020-07-30 16:45:28 -07:00
Karthik Ravi Shankar
be7bab5cb8
Merge branch 'master' into server-credentials
2020-07-28 16:30:07 -07:00
Karthik Ravi Shankar
1de0bfd9e2
Revert "Revert "Move create_channel and credentials from ::grpc_impl to ::grpc""
2020-07-24 12:47:33 -07:00
Karthik Ravi Shankar
f1bc43edf6
Revert "Move create_channel and credentials from ::grpc_impl to ::grpc"
2020-07-24 11:08:54 -07:00
Karthik Ravi Shankar
2fc4cfadcf
Move ServerCredentials from ::grpc_impl to ::grpc
...
Reverts: https://github.com/grpc/grpc/pull/18452
2020-07-23 16:18:23 -07:00
Karthik Ravi Shankar
1999b20c7d
Merge branch 'master' into create-channel
2020-07-13 10:58:31 -07:00
Yash Tibrewal
e2bd6d9f29
Merge pull request #23415 from yashykt/genericfailsend
...
Fix FailHijackedRecvMessage for generic async APIs
2020-07-08 19:11:05 -07:00
Vijay Pai
7842ef6035
Merge pull request #23258 from tweej/I_is_reserved
...
I is a reserved identifier
2020-07-08 13:50:51 -07:00
Yash Tibrewal
a80bb13fd0
Fix FailHijackedRecvMessage for generic async APIs
2020-07-07 12:32:52 -07:00
Vijay Pai
2b0f14d54d
Don't drop message on WriteAndFinish with non-ok status
2020-07-07 01:38:44 -07:00
Karthik Ravi Shankar
44f721eeb0
Merge branch 'master' into create-channel
2020-06-30 15:52:24 -07:00
Esun Kim
165ee5007a
Replaced grpc::string with std::string
2020-06-29 17:56:36 -07:00
Karthik Ravi Shankar
7aadac509c
Merge branch 'master' into revert-23294-revert-23182-server-builder
2020-06-29 11:07:17 -07:00
Karthik Ravi Shankar
18cc2f6f34
Formatting fixes
2020-06-24 21:25:33 -07:00
Karthik Ravi Shankar
7f2eaaabac
Move create_channel and credentials from ::grpc_impl to ::grpc
...
Reverts: https://github.com/grpc/grpc/pull/18374 and
https://github.com/grpc/grpc/pull/18444
Credentials and create_channel are very closely intertwined, so it is
easier to migrate them together.
2020-06-24 17:34:06 -07:00
Karthik Ravi Shankar
9db914a0cc
Revert "Revert "Move ServerBuilder back to ::grpc from ::grpc_impl""
2020-06-24 12:28:27 -07:00
Karthik Ravi Shankar
0f64d1f96b
Revert "Move ServerBuilder back to ::grpc from ::grpc_impl"
2020-06-23 18:42:35 -07:00
Karthik Ravi Shankar
133f38a885
Make changes for ResourceQuota and friend namespaces.
2020-06-23 12:24:14 -07:00
Karthik Ravi Shankar
31e6b69c8e
Merge branch 'master' into server-builder
2020-06-22 13:59:33 -07:00
Patrice Chalin
5be0b22dc0
Update links to grpc.io guides in header files
2020-06-22 11:32:59 -04:00
T.J. Mercier
d8c9ab1645
I is a reserved identifier
2020-06-19 20:54:26 -07:00
Vijay Pai
5ef722a2c9
Privatize MaybeFinish
2020-06-17 12:06:55 -07:00
Vijay Pai
7eebba3781
Fixes needed to make roll-forward of StartCall and corking work
2020-06-16 13:06:16 -07:00
Vijay Pai
278671072f
Revert "Revert "Fix StartCall: make corking work and allow concurrent Start*""
2020-06-16 12:20:19 -07:00
Vijay Pai
b269fdbf8b
Don't mark server RPC canceled if finished with non-OK status
2020-06-11 10:15:05 -07:00
Karthik Ravi Shankar
934cf3e3df
Move ServerBuilder back to ::grpc from ::grpc_impl
...
Revert #18510
2020-06-10 22:47:29 -07:00
Karthik Ravi Shankar
11c54ada0d
Revert "Fix StartCall: make corking work and allow concurrent Start*"
2020-06-02 11:11:06 -07:00
Jacob Dlougach
35ab5bc616
Include <memory> for std::unique_ptr
...
Currently `#include <grpcpp/support/interceptor.h>` in some compilers (gcc 8, for example) will fail due to missing `<memory>` include. This PR fixes this issue.
2020-05-21 14:17:45 +01:00
Vijay Pai
899cbcab96
Fix StartCall: make corking work and allow concurrent Start*
2020-05-20 10:02:22 -07:00
Yash Tibrewal
8051d956af
Merge pull request #22429 from pavelsimo/patch-1
...
Fix typo in CallOpSet comments
2020-05-08 06:35:33 -07:00
Yash Tibrewal
6a6481cb83
Reviewer comments
2020-04-30 15:44:48 -07:00
Yash Tibrewal
e714d0fcb8
Reviewer comments
2020-04-28 13:24:23 -07:00
Yash Tibrewal
edbae5d8e6
Fix interceptor batch method FailHijackedRecvMessage for async APIs
2020-04-22 23:05:57 -07:00
Vijay Pai
397b3ee72e
Do a debug-check of API use
2020-03-31 16:03:44 -07:00
Vijay Pai
03fffe0fcb
Document that AddMultipleHolds argument must be positive
2020-03-31 13:42:32 -07:00
Vijay Pai
ee3952f72b
Merge pull request #22483 from vjpai/lambdify
...
Remove all std::mem_fn and std::bind from service definitions and setup
2020-03-26 23:52:06 -07:00
Kislay Kishore
bf3954c8cc
Fix typo
...
clinet -> client
2020-03-26 09:45:11 +05:30
Vijay Pai
c86cfc305c
Remove all std::mem_fn and std::bind from service definitions and setup
2020-03-25 16:48:36 -07:00
Pavel Simó
b91d433ba4
Fix typo
2020-03-20 14:13:51 +01:00
Vijay Pai
33f4b8336e
Add useful comments
2020-03-17 14:29:34 -07:00
Esun Kim
415d41f9e8
Rerun clang-formatter-7
2020-03-03 10:46:55 -08:00
Vijay Pai
e859aa8169
Update server_callback_impl.h
2020-02-27 14:16:25 -08:00
Vijay Pai
3620abf059
Properly follow precise conditions for callback inlining
2020-02-20 01:34:30 +00:00
Yash Tibrewal
820ee53030
Merge pull request #22000 from yashykt/unusedparams
...
Remove some unused parameter warnings
2020-02-13 16:23:19 -08:00
Esun Kim
fd72a70e7d
Update by review
2020-02-13 09:11:51 -08:00
Yash Tibrewal
4a02ff7747
Remove some unused parameter warnings
2020-02-12 17:56:34 -08:00
Esun Kim
89908faede
Delete default TimePoint constructor to detect error at compile time
2020-02-12 12:20:36 -08:00
Vijay Pai
06ca713df0
Instantiate tracking members regardless of NDEBUG
2020-02-11 13:54:25 -08:00
Vijay Pai
6b2aeec9f3
Revert "Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)""""
2020-02-11 13:50:53 -08:00
Nicolas Noble
de76cf8522
Stop using ByteSize as it's deprecated.
...
Fixes #21603
2020-01-29 10:46:19 -08:00
Lidi Zheng
312b31c264
Merge pull request #21806 from grpc/revert-21767-revert-21725-revert-21680-cq_ordering
...
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""
2020-01-27 16:34:45 -08:00
Lidi Zheng
cd086cb3e4
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""
2020-01-27 14:10:44 -08:00
Vijay Pai
a801ccbdc8
Reinterpret_cast after in-place new...
2020-01-24 12:25:51 -08:00
Vijay Pai
1f0cdd5aad
Construct DefaultReactor lazily since not always needed
2020-01-23 08:52:21 -08:00
Vijay Pai
16f2250585
Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)""
2020-01-22 21:58:35 -08:00