14c914dee0
xDS: refactor code for handling xDS extensions and add tests ( #31295 )
...
* general-purpose utility for validation xDS extensions
* plumb XdsExtension into HTTP filters and ClusterSpecifiers
* clang-format
* fix tests
* iwyu
* fix build with old compilers
2022-10-13 05:16:34 -07:00
d699b574a8
Remove `include/grpcpp/impl/codegen/server_callback.h` ( #31279 )
2022-10-12 15:37:14 -04:00
3475489bf3
xDS: NACK EDS resources with duplicate addresses ( #31321 )
...
* xDS: NACK EDS resources with duplicate addresses
* iwyu
* update e2e tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-10-12 11:45:11 -07:00
a1cb2f3d6f
Remove `include/grpcpp/impl/codegen/server_callback.h` ( #31280 )
2022-10-12 14:34:18 -04:00
b6bdde391a
client_lb_e2e_test: add another error case to the regex ( #31318 )
2022-10-11 16:13:32 -07:00
d1c04427f3
Remove `include/grpcpp/impl/codegen/rpc_method.h` ( #31269 )
2022-10-11 10:57:44 -04:00
ede4e42c7d
weighted_target LB: use uint64_t for aggregate weights to avoid overflow ( #31244 )
...
* weighted_target LB: use uint64_t for aggregate weights to avoid overflow
* iwyu
* fix undefined behavior
* iwyu
* iwyu again
* fix test weights to sum to uint32 max
2022-10-10 10:29:01 -07:00
cc58369279
Remove `include/grpcpp/impl/codegen/completion_queue.h` ( #31059 )
...
* Remove `include/grpcpp/impl/codegen/completion_queue.h`
* Update
* Update
* Fix build error
* Update
2022-10-10 11:35:09 -04:00
20d1efc38a
[stats] Move core stats to C++ ( #30936 )
...
* begin c++
* Automated change: Fix sanity tests
* progress
* progress
* missing-files
* Automated change: Fix sanity tests
* moved-from-stats
* remove old benchmark cruft, get tests compiling
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* add needed constructor
* Automated change: Fix sanity tests
* iwyu
* fix
* fix?
* fix
* fix
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* add visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: AJ Heller <hork@google.com>
2022-10-09 21:22:08 -07:00
afa3a6c890
[event_engine] Fix for the EE/iomgr shutdown ordering problem ( #31265 )
...
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* init/shutdown in event engine for now
* fix
* fix
* fix windows deadlock
* Automated change: Fix sanity tests
* fix
* better windows fix
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-10-07 21:35:49 -07:00
8f1004f435
Increase timeout in xds_cluster_end2end_test ( #31260 )
...
* Add testonly attribute to mock_event_engine
* Increase rpc timeout in xds_cluster_end2end_test.cc
2022-10-06 13:25:26 -07:00
d76c6f61f0
Remove `include/grpcpp/impl/codegen/method_handler.h` ( #31249 )
2022-10-06 15:50:54 -04:00
11fbb63279
outlier detection: remove env var protection ( #31251 )
...
* outlier detection: remove env var protection
* fix sanity
2022-10-06 11:26:29 -07:00
488f17eb46
Remove `include/grpcpp/impl/codegen/message_allocator.h` ( #31246 )
2022-10-06 13:18:24 -04:00
a192f155b9
Remove `include/grpcpp/impl/codegen/config.h` ( #31061 )
...
* Remove `include/grpcpp/impl/codegen/config.h`
* Update
2022-10-06 13:14:16 -04:00
8cffd1044e
OpenCensus: Ability to globally disable stats and tracing ( #31252 )
...
* OpenCensus: Ability to globally disable stats and tracing
* Fix docs
2022-10-05 14:38:15 -07:00
f2a377d35e
xDS cluster resource type: use ValidationErrors and add unit test ( #31025 )
...
* XdsBootstrap: move two more methods out of the interface
* Automated change: Fix sanity tests
* XdsClient: add unit test
* Automated change: Fix sanity tests
* fix memory leaks
* add helper method
* add unsubscription
* add test for multiple subscriptions
* clang-format
* fix build
* fix flakiness
* add checking for other node fields
* add v2 test
* add response builder
* add test for update from server
* add test for update containing only changed resources
* clang-format
* fix build
* add test for resource not existing upon subscription
* add test for stream closed by server
* add test for multiple watchers for the same resource
* add test for connection failure
* clang-format
* add test for resources wrapped in Resource wrapper message
* add test for resource validation failure
* add test for multiple invalid resources, and fix a case in XdsClient
* add test for validation failure for already-cached resource
* add test for server not resending resources after stream disconnect
* clang-format
* fix XdsClient to report channel errors to newly started watchers
* fix XdsClient to send cached errors/does-not-exists to newly started watchers
* fix watcher to ensure events arrive in the expected order
* fix tests
* clang-format
* add test for multiple resource types
* fix xds_cluster_e2e_test
* Automated change: Fix sanity tests
* cleanup
* add federation tests
* clang-format
* remove now-unnecessary XdsCertificateProviderPluginMapInterface
* code review comments
* simplify XdsResourceType::Decode() API
* XdsClient: add unit tests for XdsClusterResourceType
* add XdsClient with gRPC bootstrap config
* add LB policy tests
* started adding CertificateProvider tests
* update for recent API changes
* fix merge bugs
* xDS resource validation: identify extensions by type_url instead of name
* fix build
* migrate to ValidationErrors
* add xds_common_types_test
* finish TLS tests and add LRS tests
* move ScopedExperimentalEnvVar to its own library and remove redundant e2e tests
* add circuit breaking and outlier detection tests
* add validation to outlier detection LB policy parsing
* clang-format
* Automated change: Fix sanity tests
* fix signedness
* fix sanity
* fix sanity
* iwyu
* update code for XdsResourceTypeImpl changes
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-10-05 11:27:30 -07:00
126393c9c1
client_lb_end2end_test: update failure regex to include "Socket closed" ( #31242 )
2022-10-05 10:09:17 -07:00
2d00d50c59
[event_engine] Improve scaling in threadpool ( #31234 )
...
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fixes
* fixes
* fix
* fix-win
* fix iwyu
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-10-05 00:17:23 -07:00
3c96517fc0
Simplified GRPC_ERROR_CREATE macros ( #31222 )
...
* Simplified GRPC_ERROR_CREATE macros
* Code migration
2022-10-04 15:55:47 -07:00
4ba0f9afb5
Revert "Revert "Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )" ( #31079 )" ( #31087 )
...
This reverts commit da08fe1d6f
2022-10-04 13:59:32 -04:00
0e8a6515df
Remove `include/grpcpp/impl/codegen/client_context.h` ( #31006 )
...
* Remove `include/grpcpp/impl/codegen/client_context.h`
* Update
* Update
2022-10-03 18:01:22 -04:00
347bf1a1f4
Removed GRPC_ERROR_[INT|STR] macros ( #31195 )
...
* Clean-up which
* Reformat
2022-10-03 11:33:56 -07:00
4bd27c524a
More changes ( #31194 )
2022-09-30 17:10:01 -07:00
a23eae84c9
Revert "[flakes] Update flakiness ( #31121 )" ( #31173 )
...
This reverts commit bdc799af73
2022-09-29 14:06:44 -07:00
bdc799af73
[flakes] Update flakiness ( #31121 )
...
* update
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-29 11:04:22 -07:00
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2022-09-29 06:45:17 -07:00
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2022-09-28 08:39:56 -07:00
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2022-09-27 23:17:39 -07:00
a874b8f6ca
EventEngine::Run microbenchmarks ( #30769 )
...
* [WIP] EventEngine::Run microbenchmarks
* Add fanout impl and fix tracking of time spent doing work in threads
* tune down benchmarks; fix fanout counting logic.
* tune down closure fanout tests
* format
* odr
* reviewer feedback
* unify some fanout logic; add a large-AnyInvocable test
lambdas that take an allocation are about 10x slower
* reviewer feedback
* fix invalid vector access
* rm DNS
* format
* copy params for each lambda callback
This fixes segfaults when we cannot ensure all callbacks are complete
before exiting the test.
* s/promise/Notification/g bm_exec_ctx
* ODR and leak
* fix division by zero
* fix
2022-09-27 14:57:36 -07:00
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2022-09-27 14:34:07 -07:00
ba8af0157b
Removing GRPC_ERROR_[REF|UNREF|IS_NONE] ( #31089 )
...
* Removing GRPC_ERROR_[REF|UNREF|IS_NONE]
* Clean up unnecessary error
* Fix
* Fix2
* Remove unnecessary else
2022-09-26 15:41:12 -07:00
cdb7d2c93c
XdsEndpointResourceType: use ValidationErrors and add unit tests ( #31076 )
...
* simplify XdsResourceType::Decode() API
* fix xds_client_test
* xDS endpoint: use ValidationErrors to improve error messages
* fix sanity
* add xDS endpoint resource type test
* clang-format
* remove a couple of now-unnecessary end2end tests
* generate_projects
* fix xds_csds_e2e_test
* iwyu
* attempt to avoid ubsan failure
2022-09-26 11:45:56 -07:00
ebc4f236b6
[slice] Remove _internal variants of APIs ( #30953 )
...
* [slice] Remove _internal variants of APIs
* Automated change: Fix sanity tests
* fix
* reduce bloat
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-24 13:34:00 -07:00
32b43f0168
[channel_args] Make channel_stack_init take new type ( #30841 )
...
* [channel_args] Make channel_stack_init take new type
* fix
* fix
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-23 11:31:03 -07:00
747d016397
Support --max_recv_msg_size in grpc cli ( #31106 )
...
* Support --max_recv_msg_size in grpc cli
* Comment typos fixed in tests.
2022-09-23 11:13:29 -07:00
fb14fdf0e0
Performant thread-safe Work Queue ( #30821 )
...
* WorkQueue
* weaken the large obj stress test for Windows; documentation
* update comment
* Add WorkQueue microbenchmark. Results below ...
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_WorkQueueIntptrPopFront/1 297 ns 297 ns 2343500 items_per_second=3.3679M/s
BM_WorkQueueIntptrPopFront/8 7022 ns 7020 ns 99356 items_per_second=1.13956M/s
BM_WorkQueueIntptrPopFront/64 59606 ns 59590 ns 11770 items_per_second=1074k/s
BM_WorkQueueIntptrPopFront/512 477867 ns 477748 ns 1469 items_per_second=1071.7k/s
BM_WorkQueueIntptrPopFront/4096 3815786 ns 3814925 ns 184 items_per_second=1073.68k/s
I0902 19:05:22.138022069 12 test_config.cc:194] TestEnvironment ends
================================================================================
* use int64_t for times. 0 performance change
------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
------------------------------------------------------------------------------------------
BM_WorkQueueIntptrPopFront/1 277 ns 277 ns 2450292 items_per_second=3.60967M/s
BM_WorkQueueIntptrPopFront/8 6718 ns 6716 ns 105497 items_per_second=1.19126M/s
BM_WorkQueueIntptrPopFront/64 56428 ns 56401 ns 12268 items_per_second=1.13474M/s
BM_WorkQueueIntptrPopFront/512 458953 ns 458817 ns 1550 items_per_second=1.11591M/s
BM_WorkQueueIntptrPopFront/4096 3686357 ns 3685120 ns 191 items_per_second=1.1115M/s
I0902 19:25:31.549382949 12 test_config.cc:194] TestEnvironment ends
================================================================================
* add PopBack tests: same performance profile exactly
* use Mutex instead of Spinlock
It's safer, and so far equally performant in benchmarks of opt builds
* add deque test for comparison. It is faster on all tests.
* Add sparsely-populated multi-threaded benchmarks.
* fix
* fix
* refactor to help thread safety analysis
* Specialize WorkQueue for Closure*s and AnyInvocables
* remove unused callback storage
* add single-threaded benchmark for closure vs invocable
* sanitize
* missing include
* move bm_work_queue to microbenchmarks so it isn't exported
* s/workqueue/work_queue/g
* use nullptr instead of optionals for popped closures
* reviewer test suggestion
* private things are private
* add a work_queue fuzzer
Ran for 10 minutes @ 42 jobs @ 42 workers. Zero failures.
Checked in a selection of 100 good seeds after merging the thousands of
results.
* fix
* fix header guards
* nuke the corpora
* feedback
* sanitize
* Timestamp::Now
* fix
* fuzzers do not work on windows
* windows does not like multithreaded benchmark tests
2022-09-23 09:10:42 -07:00
f15ba1ffc7
[tls] Remove support for pthread tls ( #31040 )
...
* [tls] Remove support for pthread tls
* fix
* fix
* fix
* lalala
* fix
* fix
* Clean up deployment target changes
* additional clean up of deployment target
* regen podspec for updated file list
* remove destination change
* deployment target override for ios cpp test
* fix?
* fix run test script & update test destination
* [tls] Remove support for pthread tls
* fix
* fix
* fix
* lalala
* fix
* fix
* Clean up deployment target changes
* additional clean up of deployment target
* regen podspec for updated file list
* remove destination change
* deployment target override for ios cpp test
* fix?
* fix run test script & update test destination
* merge
* fix
* final script fix for proper destination & target
* more deployment target fix
* objc ios test script fix
Co-authored-by: Denny C. Dai <dennycd@me.com>
Co-authored-by: dennycd <dennycd@google.com>
2022-09-22 22:39:35 -07:00
1ad4bbe78e
Revert "fix ( #31018 )" ( #31021 )
...
This reverts commit 2e6f268dfc
2022-09-21 09:28:28 -07:00
da08fe1d6f
Revert "Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )" ( #31079 )
...
This reverts commit 17f515744f
2022-09-20 18:58:54 -07:00
9cff4d2d28
OpenCensus Plugin: Add missing measure and views for started RPCs ( #31034 )
2022-09-20 17:26:16 -07:00
07df5ff9c7
json_object_loader: refactor ErrorList into its own library ( #31049 )
...
* json_object_loader: refactor ErrorList into its own library
* fix observability_config_test
* generate_projects
* iwyu
2022-09-20 11:58:27 -07:00
0cb5faf8e4
Remove `include/grpcpp/impl/codegen/client_interceptor.h` ( #31054 )
...
* Remove `include/grpcpp/impl/codegen/client_interceptor.h`
* Update comment
2022-09-20 14:03:46 -04:00
17f515744f
Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )
2022-09-20 13:51:55 -04:00
e475e165a7
LB policies: convert to new JSON API ( #30468 )
...
* Declarative JSON parser
* Automated change: Fix sanity tests
* fix
* shrinking stuff a little
* static vtables
* separate fns
* simpler?
* make maps work
* windows fixes
* Automated change: Fix sanity tests
* simplify code
* Automated change: Fix sanity tests
* vtable-test
* dont always create vec/map impls for every type
* comments
* make error consistent
* move method private
* progress
* durations!
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* post-load
* Automated change: Fix sanity tests
* document JsonPostLoad() and add static_assert
* don't copy field names, to avoid length limitations
* use absl::Status
* accept either string or number for numeric values
* add test for direct data member of another struct type
* remove unused method
* add support for retaining part of the JSON wirthout processing
* update test for changes in Json::Parse() API
* add absl::optional support
* Automated change: Fix sanity tests
* fix tests, improve error messages, and add overload to parse to existing object
* remove overload of LoadFromJson()
* change special case for Json to instead use Json::Object
* fix build
* improve error structure, add missing types, and improve tests
* clang-format
* Automated change: Fix sanity tests
* update grpclb parsing
* fix build
* convert outlier_detection LB config
* convert priority LB policy
* convert ring_hash LB config
* add LoadJsonObjectField(), add LoadFromJson() overload that takes an ErrorList parameter, and add tests for parsing bare top-level types
* fix msan
* Automated change: Fix sanity tests
* WIP on RLS parsing conversion
* fix error message
* Automated change: Fix sanity tests
* fixed RLS parser tests
* fix error prefix in OD, priority, and ring_hash policies
* convert weighted_target policy
* convert xds_cluster_manager
* convert cds policy
* convert xds_cluster_resolver
* convert xds_cluster_impl
* Automated change: Fix sanity tests
* fix test
* fix xds_cluster_impl drop config parsing
* Automated change: Fix sanity tests
* attempt to fix mac build
* work around gcc6 problem
* Automated change: Fix sanity tests
* fix build
* add mechanism to conditionally disable individual fields
* fix build
* Automated change: Fix sanity tests
* fix move assignment operator
* fix build
* Automated change: Fix sanity tests
* fix build and simplify RLS duplicate key check
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix build
* iwyu
* fix build
* fix sanity
* add LoadRefCountedFromJson() and use it to eliminate some moves
* fix build
* Automated change: Fix sanity tests
Co-authored-by: Craig Tiller <craig.tiller@gmail.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Craig Tiller <ctiller@google.com>
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-09-20 09:14:14 -07:00
6d792b6bce
xDS resource validation: identify extensions by type_url instead of name ( #31024 )
...
* xDS resource validation: identify extensions by type_url instead of name
* fix build
2022-09-20 09:06:01 -07:00
5cd8ee25f8
GcpObservabilityConfig: New changes ( #31038 )
...
* GcpObservabilityConfig: New changes
* Fix IWYU
2022-09-19 15:29:46 -07:00
27e5b4e187
GcpObservabilityConfig: Fall-back to GCP environment variables ( #31022 )
2022-09-19 11:48:35 -07:00
6098202c09
GcpObservabilityTest: Cleanup ( #31023 )
2022-09-19 11:47:53 -07:00
2e6f268dfc
fix ( #31018 )
2022-09-16 12:41:08 -07:00
d9ac89a441
[gprpp] absl::Notification polyfill ( #31008 )
...
* [gprpp] absl::Notification polyfill
* grpc_core::
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-16 09:06:03 -07:00
96f5cddb5f
[time] Introduce time sources ( #30815 )
...
* [time] Introduce time sources
* make import trivial
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* review feedback
* fix
* Automated change: Fix sanity tests
* ios fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-15 21:41:04 -07:00
c2ab8c99bb
Revert "Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )" ( #30988 )
...
This reverts commit 96264e07b8
2022-09-14 14:19:36 -07:00
96264e07b8
Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )
...
This reverts commit 74c0d6fe3f
2022-09-14 11:53:55 -07:00
e5aadf985e
Revert "Revert "client_channel: allow LB policy to communicate update errors to resolver ( #30809 )" ( #30970 )" ( #30981 )
...
This reverts commit 1648bc08e0
2022-09-14 11:46:42 -07:00
b765b06155
Remove `include/grpcpp/impl/codegen/async_stream.h` ( #30941 )
...
* Remove `include/grpcpp/impl/codegen/async_stream.h`
* Fix
* Fix
* Update
2022-09-14 13:40:35 -04:00
74c0d6fe3f
[c++] Move environment functions to C++ ( #30937 )
...
* [gprpp] Move env to C++
* move headers/impl
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Update http_proxy.cc
* fix
* fix
* rename
* fix merge
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-14 10:17:15 -07:00
1648bc08e0
Revert "client_channel: allow LB policy to communicate update errors to resolver ( #30809 )" ( #30970 )
...
This reverts commit 9ff943b81e
2022-09-13 15:07:50 -07:00
92f58c18a8
Revert "Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )" ( #30962 )
...
This reverts commit bfea47093f
2022-09-13 13:16:55 -07:00
cb3d7a9e9e
Revert "Revert "Remove `include/grpcpp/impl/codegen/async_unary_call.h`"" ( #30955 )
...
* Revert "Revert "Remove `include/grpcpp/impl/codegen/async_unary_call.h` (#30945 )" (#30950 )"
This reverts commit 0c454fa875
2022-09-13 15:57:15 -04:00
63df245532
If `-infile` is not readable, bail out and show an error! ( #30760 )
...
Without this, `grpc_cli` will connect, send the metadata and then completely stall until it is killed leading to believe it is the server that is stalled instead of `grpc_cli` that won't send the message.
2022-09-13 12:55:42 -07:00
bfea47093f
Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )
...
This reverts commit 6c7f921f5f
2022-09-13 12:25:00 -07:00
b3ad894e05
GcpObservability: Use the observability config ( #30932 )
...
* GcpObservability: Use the observability config
* iwyu
* Fix build
2022-09-13 11:47:19 -07:00
6e57952589
Revert "Revert "Remove `include/grpcpp/impl/codegen/async_generic_service.h` ( #30450 )" ( #30951 )" ( #30956 )
...
This reverts commit a81b61113c
2022-09-13 14:45:38 -04:00
6c7f921f5f
[chttp2] Improve huffman decode efficiency ( #30479 )
...
* first pass
* refinement #1
* fix
* opt
* 8
* 5
* 12
* 10
* 7
* 15
* 8n
* 15n
* 8a
* 16a
* 15a
* 5a
* 10a
* 7a
* 9a
* 12a
* 11a
* 11b
* 11b
* 7b
* 15b
* 14b
* 15i
* 12i
* 9i
* 10i
* finalizing
* fix
* tweak
* 10f
* 10r
* 7r
* 8r
* 9r
* more
* rething
* 8s
* 9s
* 12s
* 7s
* 10s
* 15snr
* 12snr
* 14snr
* 13snr
* 11snr
* 20snr
* 15snr
* 18snr
* 7snr
* 7snr
* 12-2stp
* 13-2stp
* 14-2stp
* 11-2stp
* 10-2stp
* 9-3stp
* 8-3stp
* 7-3stp
* 8-2stp
* auto-tune1
* max-depth-2
* max-depth-3
* max-depth-2
* abbreviate
* working version
* add benchmark
* fix
* fix
* fix
* ditch define
* better code layout
* static fns
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix build
* cleanup and comment
* fmt
* fix
* test
* tag
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* progress
* progress
* progress
* fixes
* cleanup
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fmt
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* add encode/decode fuzzer
* Automated change: Fix sanity tests
* fix
* fix
* fix
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-13 11:24:35 -07:00
9ff943b81e
client_channel: allow LB policy to communicate update errors to resolver ( #30809 )
...
* client_channel: allow LB policy to communicate update errors to resolver
* fix tests
* Automated change: Fix sanity tests
* fix build
* fix another "ignoring return value" warning
* fix use-after-move
* fix channel to invoke resolver callback when service config fails on initial resolution
* remove outdated TODO
* improve comments
* fix PollingResolver to defer re-resolution requests while waiting for result-health callback
* Automated change: Fix sanity tests
* absl::exchange -> std::exchange
* fix dns_resolver_cooldown_test
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-09-12 17:17:03 -07:00
aaec373a10
Second attempt: XdsClient: add unit test and fix watcher notification bugs ( #30943 )
...
* Revert "Revert "XdsClient: add unit test and fix watcher notification bugs (#30823 )" (#30942 )"
This reverts commit 6d2c4a8314
2022-09-12 16:58:31 -07:00
0c454fa875
Revert "Remove `include/grpcpp/impl/codegen/async_unary_call.h` ( #30945 )" ( #30950 )
...
This reverts commit 7dbc73d4f3
2022-09-12 16:44:07 -07:00
a81b61113c
Revert "Remove `include/grpcpp/impl/codegen/async_generic_service.h` ( #30450 )" ( #30951 )
...
This reverts commit c6326bbc75
2022-09-12 16:43:55 -07:00
c6326bbc75
Remove `include/grpcpp/impl/codegen/async_generic_service.h` ( #30450 )
...
* Remove `include/grpcpp/impl/codegen/async_generic_service.h`
* Fix test
* Reserve compatibility
2022-09-12 18:19:59 -04:00
7dbc73d4f3
Remove `include/grpcpp/impl/codegen/async_unary_call.h` ( #30945 )
2022-09-12 18:05:10 -04:00
6d2c4a8314
Revert "XdsClient: add unit test and fix watcher notification bugs ( #30823 )" ( #30942 )
...
This reverts commit bcd8c991e6
2022-09-12 12:01:42 -07:00
bcd8c991e6
XdsClient: add unit test and fix watcher notification bugs ( #30823 )
...
This adds a unit test for XdsClient and fixes several watcher-notification bugs found in the process. Specifically:
- When an ADS stream fails or an xDS channel reports a connectivity failure, report an error only to the watchers for resources being subscribed to on that particular channel, not to watchers on other channels.
- Cache the error status for the channel, so that if a new watcher is started after the channel reports the error, we can immediately report that error to the new watcher.
- If a resource is NACKed and has not been previously cached, or does not exist, report that fact to any new watcher that may be started later.
- If a resource in an ADS response is unparseable but is wrapped in a `Resource` wrapper, we do know its name, so record the validation failure in the cache and report it to the watchers.
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-09-12 09:44:35 -07:00
ebcda5f0c1
GcpObservabilityConfig: s/disabled/enabled ( #30905 )
2022-09-09 15:58:38 -07:00
f7f4c9b584
GcpObservability: Code for reading config from env var ( #30889 )
...
* GcpObservability: Code for reading config from env var
* Comments
* Fix deps
* clang-tidy
2022-09-09 15:14:15 -07:00
2b46cb40d3
[config] Move certificate provider registry into core config ( #30890 )
...
* [config] Move certificate provider registry into core config
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-09 11:29:05 -07:00
a644d8c9b4
GcpObservabilityConfig: cloud_trace.sampling_rate ( #30904 )
2022-09-08 21:43:47 -07:00
260a02d1ad
Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure"" ( #30894 )
...
* Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure (#30866 )" (#30892 )"
This reverts commit 37b631d1fd
2022-09-08 13:43:37 -07:00
37b631d1fd
Revert "GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )" ( #30892 )
...
This reverts commit 31c68b5f10
2022-09-07 20:20:44 -07:00
7ba58bb925
[build] Move certificate provider registry into its own build target ( #30836 )
...
* [build] Move cert registry into its own build target
* Automated change: Fix sanity tests
* fix
* forgot to save file
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-07 17:23:03 -07:00
31c68b5f10
GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )
...
* GcpObservabilityConfig: Add some basic field parsing structure
* IWYU
* clang format
2022-09-07 15:27:23 -07:00
b463cabeec
Update flaky tests ( #30873 )
...
* Update flaky tests list
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-07 10:16:34 -07:00
fed6c180e9
[census] Add time scaling to test ( #30851 )
2022-09-06 08:40:39 -07:00
70dd34b438
Revert "Revert "Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args"" ( #30509 )
...
* Revert "Revert "Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args (#30028 )" (#30495 )"
This reverts commit 0b1a8c984b
2022-09-01 16:51:17 -07:00
bf9304ef17
client_channel, client_auth: rewrite disallowed status codes from the control plane ( #30789 )
...
* client_channel: rewrite illegal status codes from control plane
* rewrite illegal status codes for call creds
* move fail_lb policy out of retry_lb_fail test so it can be reused
* test resolver and LB policy status rewrites
* add test for ConfigSelector status rewriting
* attempt to add client_auth filter unit test
* fix client_auth_filter test
* cleanup test
* fix build
* fix some memory leaks
* Automated change: Fix sanity tests
* Update client_auth_filter_test.cc
* fix build
* code review comments
* clang-tidy
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
Co-authored-by: Craig Tiller <ctiller@google.com>
2022-09-01 15:15:14 -07:00
2142183ef4
XdsClient: don't ignore resources after an invalid Resource wrapper ( #30819 )
2022-09-01 14:02:00 -07:00
622dd886e6
Update flaky tests list ( #30771 )
...
* Update flaky tests list
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-30 21:42:59 -07:00
6746f670c1
[cleanup] Remove low level counters ( #30611 )
...
* [cleanup] Remove low level counters
* clean up code
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-30 21:13:15 -07:00
2c28b44852
subchannel: include IP address in status messages ( #30784 )
...
* subchannel: include IP address in status messages
* Automated change: Fix sanity tests
* add comment about lock annotations
* clang-format
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-08-30 17:01:59 -07:00
004788af3d
[cleanup] Remove profiling timers ( #30779 )
...
* [cleanup] Remove profiling timers
- nobody has used this system in years
- if we needed it, we'd probably rewrite it at this point to be something more modern
- let's remove it until that need arises
* fix
* fixes
2022-08-30 13:40:08 -07:00
60a1b4ad6f
Revert "Revert "GCP Observability: Add plugin registry API"" ( #30766 )
...
* Revert "Revert "GCP Observability: Add plugin registry API (#30571 )" (#30765 )"
This reverts commit b8fde2ab47
2022-08-29 17:22:03 -07:00
602c5e8e97
Add a provision to allow specification of separate set of channel args for the channel to grpclb server ( #30755 )
...
* Add a provision to allow specification of separate set of channel args for the grpclb channel
* fix asan issue
* review comments
* review comments
* add missing file
* remove unused hdr
* fix sanity
* fix comments
* remove unused hdr
2022-08-29 17:21:46 -07:00
535168431a
[lb_policy] Move to core configuration system ( #30483 )
...
* [load_balancing] Move interfaces to src/core/lib/load_balancing
* Automated change: Fix sanity tests
* progress
* progress
* fix
* missed file
* Automated change: Fix sanity tests
* update tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fixes
* fix
* fix
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-27 08:35:40 -07:00
b94fb2b894
Fix PickFirstTest.PendingUpdateAndSelectedSubchannelFails flake in client_lb_end2end_test ( #30741 )
...
* ConnectionAttemptInjector: fix tsan failures
* Add hold to test
* Add hold to test
* Address comments
* Address comments
* Address comments
* Fix typo
Co-authored-by: Mark D. Roth <roth@google.com>
2022-08-26 14:26:54 -07:00
5b6dac02ac
[stats] Cleanup & re-enable stats system ( #30610 )
...
* [stats] Cleanup stats system
* clear out optionality
* fix
* might as well...
* Automated change: Fix sanity tests
* clean out more unused stuff
* clean out more unused stuff
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-26 10:18:06 -07:00
b8fde2ab47
Revert "GCP Observability: Add plugin registry API ( #30571 )" ( #30765 )
...
This reverts commit 486710317f
2022-08-26 09:42:19 -07:00
486710317f
GCP Observability: Add plugin registry API ( #30571 )
...
* GCP Observability: Add plugin registry API
* Restrict visibility for now
* Move GcpObservability to its own thing
* Reviewer comments
2022-08-26 09:22:48 -07:00
5f7096614a
xds_e2e_test_lib: increase default timeouts in test framework ( #30756 )
...
* e2e tests: add test scaling factor to durations in channel args
* apply test scaling factor when encoding durations in xDS protos
* apply scaling factor in fixed timeout in WaitForNack()
* fix overflow
* clang-format
* adjust timeouts in fault injection tests
* add missing slowdown factor
* clang-format
* xds_e2e_test_lib: increase default timeouts in test framework
2022-08-26 09:22:35 -07:00
121a08f6a9
end2end tests: apply test slowdown factor in various places where it was missed ( #30749 )
...
* e2e tests: add test scaling factor to durations in channel args
* apply test scaling factor when encoding durations in xDS protos
* apply scaling factor in fixed timeout in WaitForNack()
* fix overflow
* clang-format
* adjust timeouts in fault injection tests
* add missing slowdown factor
* clang-format
* add tests for duration multiplication
2022-08-26 07:35:28 -07:00
143c852d2f
end2end tests: fix test service impl to apply test slowdown factor ( #30750 )
...
* end2end tests: fix test service impl to apply test slowdown factor
* fix build
2022-08-25 14:49:42 -07:00
807e93f250
[fixit] Deflake xds_outlier_detection_end2end_test ( #30690 )
...
* timing deflake
* Removed empty lines, unused setter.
* Shorten sleep time, removed 3 sleeps.
* hardcode sleep times everywhere
* add back test factor
* sanity check fix
2022-08-25 12:14:34 -07:00
2805b523d9
XdsRingHash: Tune timeouts ( #30742 )
...
* XdsRingHash: Tune timeouts
* Add WaitForBackendOptions timeout
* More tuning
* Fix
2022-08-24 18:01:58 -07:00
09558e9052
Adjust rpc timeouts in xds tests to reduce Deadline exceeded errors in msan ( #30732 )
2022-08-24 16:50:45 -07:00
03b6b01043
ConnectionAttemptInjector: fix tsan failures ( #30730 )
2022-08-24 12:47:17 -07:00
4a27b432b6
xds_cluster_e2e_test: change tests to provide better failure messages ( #30727 )
2022-08-24 10:17:01 -07:00
dc1cb1fb59
grpclb_e2e_test: increase timeout in InitiallyEmptyServerlist test ( #30726 )
2022-08-24 10:15:22 -07:00
93fb6add2a
[fixit] Reduce the size of this benchmark under expensive sanitizers ( #30715 )
2022-08-23 13:48:05 -07:00
f7d8ee068a
[fixit] Extend timeout for SameBackendListedMultipleTimes/V3 test ( #30716 )
...
Previously this failed 1/1000 times with a 1s timeout, giving a
`Deadline Exceeded` error. I was able to reproduce the failure in
22/1000 times with a 500ms timeout. Changing it to a 2s timeout in this
PR, the failure did not reproduce in 5000 runs.
2022-08-23 13:43:39 -07:00
a6d67ab6db
[fixit] Disable ub/msan on all qps, tsan on some qps tests ( #30713 )
2022-08-23 09:34:50 -07:00
7c86c34e63
[fixit] Solve the flakiness for test case `End2endTest.ClientCancelsBidi` ( #30664 )
...
* First try to solve the flakiness of End2endTest.ClientCancelsBidi
* Update using `absl::Notification`
* Update
2022-08-22 18:59:14 -07:00
f133d81714
[fixit] Scale down large tests ( #30676 )
...
We have many tests that create 100 threads or more, and mounting evidence that
this is harmful to our CI environment.
When the original code for many of these tests was written we ran our tests
under run_tests, which had explicit handling for tracking the number of threads
each test needed and making sure that we weren't over subscribing the test
runner. Bazel has no such facility (and the facility in run_tests has since
been removed) and so we need to adjust.
This PR adjusts down a single test and is part of a series so that we can
review and roll back easily if required.
2022-08-22 16:34:33 -07:00
72e76f6a86
client_lb_e2e_test: fix flake in PickFirstTest.CheckStateBeforeStartWatch ( #30698 )
2022-08-22 14:42:10 -07:00
c03b2f6b38
[fixit] Scale down large tests ( #30677 )
...
We have many tests that create 100 threads or more, and mounting evidence that
this is harmful to our CI environment.
When the original code for many of these tests was written we ran our tests
under run_tests, which had explicit handling for tracking the number of threads
each test needed and making sure that we weren't over subscribing the test
runner. Bazel has no such facility (and the facility in run_tests has since
been removed) and so we need to adjust.
This PR adjusts down a single test and is part of a series so that we can
review and roll back easily if required.
2022-08-22 07:41:56 -07:00
eed4766424
rls_e2e_test: check authority on server side instead of using death test ( #30652 )
2022-08-19 17:19:46 -07:00
9f9d87cfa6
Fix CBF on mac by switching to grpc_core::Mutex and grpc_core::CondVar ( #30666 )
2022-08-19 16:59:18 -07:00
f573fd44f9
[test] Semi-automatic flaky test tracking ( #30638 )
...
* [test] Semi-automatic flaky test tracking
* fix
* Automated change: Fix sanity tests
* Update update_flakes.py
* fix formatting
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-19 16:22:31 -07:00
fedba4654d
xds_routing_e2e_test: fix XdsRetryPolicyMaxBackOff flake ( #30649 )
2022-08-19 15:41:25 -07:00
221a969e04
client_lb_end2end_test: fix flake caused by not doing graceful server shutdown ( #30647 )
2022-08-19 13:56:42 -07:00
96af4084c9
Fix StatusCancelledWithoutStartingRecvTrailingMetadata flake in client_lb_end2end_test ( #30629 )
...
* Fix metadata flake in client_lb_end2end_test
* Address review comments
* Return bool
* Address review comment
2022-08-19 12:37:51 -07:00
dca225be95
[fixit] Increase sleep time for test `ProxyEnd2endTest.RpcDeadlineExpires` to reduce flakiness ( #30631 )
...
* Increase sleep time for test `ProxyEnd2endTest.RpcDeadlineExpires`
* Update
2022-08-18 18:46:23 -04:00
02df22f52f
FaultInjection: Fix random number generation ( #30623 )
...
* FaultInjection: Fix random number generation
* Put random generation under a mutex
* Fix IWYU
* Regenerate projects
* Modify timeouts
* Dbg build knobs
* Remove unnecessary slowdown factor
* Tune error tolerance and add note on broken computation of ComputeIdealNumRpcs
2022-08-18 15:34:55 -07:00
aba48793f8
XdsSecurityTest: Use a timeout of 5000ms for RPCs ( #30621 )
...
* XdsSecurityTest: Use a timeout of 5000ms for RPCs
* Reviewer comments
* Remove old comment
2022-08-17 17:30:48 -07:00
feeb54ec33
[fixit] Fix flakiness for test case ChannelzSamplerTest.SimpleTest by reducing the chance of port conflict ( #30620 )
...
* Fix flakiness for test case ChannelzSamplerTest.SimpleTest by reducing the chance of port conflict
* Update
2022-08-17 19:32:29 -04:00
f0a2b3d660
Fix flakiness in //test/cpp/common:timer_test ( #30606 )
2022-08-16 18:08:55 -07:00
b9f6b2663c
XdsEnd2EndTest: Increase default RPC timeout ( #30609 )
2022-08-16 17:34:08 -07:00
faa0679c57
Fix flake in client_lb_end2end_test ( #30601 )
...
* Fix ubsan failure
* Fix build failures with istio test
* Fix other status code
* Fix flake in client_lb_end2end_test
2022-08-16 14:17:46 -07:00
103f4c2f1e
[fixit] Increase timeout value for XDS Core End2End Test ( #30593 )
2022-08-16 15:44:48 -04:00
3c9cbb2d4d
OpenCensus: fixes broken traces exporting caused by a missing EndSpan ( #29745 )
...
* OpenCensus: fixes broken traces exporting caused by a missing EndSpan
* Fix variable name
* Fixes test.
* Adds timeout to span test
2022-08-10 17:18:21 -07:00
dc4414aa0c
XdsClient: access certificate provider data via dependency injection ( #30506 )
...
* don't pass context through AdsResponseParser::ParseResource()
* don't pass certificate provider info through XdsApi
* use dependency injection for cert provider map
* move XdsEncodingContext into XdsResourceType
* remove unnecessary field
* clang-format
* Automated change: Fix sanity tests
* fix xds_bootstrap_test
* fix build
* Automated change: Fix sanity tests
* fix test and clang-format
* remove unnecessary field
* fix test
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-08-05 11:27:59 -07:00
ae70e65e13
[build] Shard tests a little more ( #30489 )
...
* [build] Shard tests a little more
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-04 11:44:46 -07:00
0b1a8c984b
Revert "Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args ( #30028 )" ( #30495 )
...
This reverts commit 2c977a4d98
2022-08-04 11:35:27 -07:00
2c977a4d98
Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args ( #30028 )
...
* convert tcp code to use EndpointConfig and successfully compile
* regenerate projects
* copying config options used in tcp code to create map backed endpoint configs
* fix minor build issues
* fix includes in tests
* fix some build and test issues
* modifying endpoint config definition from an abstract interface into a concrete implementation
* minor fix
* add unreachable code check
* fix some windows build issues
* fix more build issues
* adding a grpc_tcp_generic_options struct to hold data extracted from EndpointConfig
* code formatting
* simplify
* fix sanity checks
* fix windows issues
* some posix fixes
* disabling copy constructor and copy assignment operator for endpoint config
* fix sanity checks
* fix syntax error
* fix weird formatting
* fix build issue
* fix review comments
* reverting un-necessary change
* remove channel args completely from windows impl since it is unused
* remove unused headers and fix usage in endpoint_pair_windows.cc
* cleanup
* cleanup
* fix some initialization issues
* re-generate projects
* removing some files
* fix ifdef for windows
* fixing windows build issue due to improper header file include
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* review comments
* add comment
* review comments
* rename GetPointer to GetVoidPointer
* cleanup
* Automated change: Fix sanity tests
* removing EndpointConfig::Get method
* Automated change: Fix sanity tests
* minor fix
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
2022-08-03 13:41:48 -07:00
f78581a18f
Istio Echo: Add version string ( #30477 )
2022-08-03 10:35:31 -07:00
7fcb2e1229
outlier_detection LB: reset state when OD is disabled ( #30418 )
...
* outlier_detection LB: reset state when OD is disabled
* leave interval unset when no OD config is present
* Automated change: Fix sanity tests
* fix clang-tidy
* don't check for interval of infinite duration
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-08-02 08:02:36 -07:00
536b9351ec
JSON: use absl::Status instead of grpc_error ( #30397 )
...
* JSON: use absl::Status instead of grpc_error
* Automated change: Fix sanity tests
* fix credentials_test
* fix tests
* add missing build dep
* fix build
* fix test
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-27 09:52:21 -07:00
f4edc883ab
service config API: use absl::Status instead of grpc_error ( #30321 )
...
* service config API: use absl::Status instead of grpc_error
* Automated change: Fix sanity tests
* add missing build deps
* attempt to work around build breakage on older compilers
* trying the work-around in more spots
* more work-arounds
* more workarounds
* Automated change: Fix sanity tests
* work around another compiler problem
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-26 09:29:07 -07:00
05e6bf2e4a
[build] Add test/core/util, test/core/event_engine to auto build deps ( #30364 )
...
* [build] Add test/core/util, test/core/event_engine to auto build deps
* deal with suppressions
* fix suppressions
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* progress
* Automated change: Fix sanity tests
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-25 21:59:25 -07:00
856abd9446
[iwyu] Add test/core/util ( #30289 )
...
* [iwyu] Add test/core/util
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-20 16:18:19 -07:00
f5bb60d8e8
[channel_args] Improve comparison performance ( #30322 )
...
* [channel_args] Improve comparison performance
* fix
* Automated change: Fix sanity tests
* faster still
* fix
* fix
* some no cost boosts if they get hit
* fix
* final tweak for pointers
* check
* fix
* Automated change: Fix sanity tests
* fix
* ugh
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-19 15:40:09 -07:00
785d6b656a
Add logging for invalid client PayloadConfig in QPS test ( #30261 )
...
* Add invalid PayloadConfig logging to QPS test
* flip conditions
2022-07-19 12:18:02 -07:00
a1d42f84ef
xds_cluster_resolver: pass useful resolution_note to children ( #30283 )
...
* xds_cluster_resolver: pass useful resolution_note to children
* clang-format
2022-07-18 16:54:16 -07:00
201213c681
client channel: add tests for authority override precedence ( #30172 )
...
* client channel: add tests for authority override precedence
* add unit test
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-18 16:02:59 -07:00
3ec0e29bcf
[test] Convert cq verifier to C++ ( #30256 )
...
* [test] Convert cq verifier to C++
* Automated change: Fix sanity tests
* fix
* dead code
* strength reduction
* dead code
* fix
* when search/replace goes wrong
* review feedback
* review feedback
* cleanup
* fixes
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-14 04:41:30 -07:00
4491ed26aa
BUILD: move work_serializer to its own build target ( #30255 )
...
* BUILD: move work_serializer to its own build target
* add autodeps tag
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-13 13:21:07 -07:00
98b1a7710e
Changed num_threads based on slowness factor for xSAN ( #30240 )
...
* Changed num_threads
* Update by review
* Update by review
2022-07-11 14:47:55 -07:00
d7e6878ec4
[chttp2] use new channel args type ( #30252 )
...
* x
* x
* Automated change: Fix sanity tests
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-10 22:43:44 -07:00
1b5295a4a2
[iomgr] Remove executor/...
...
I've tried this before in #27445 and we found some internal usage of this code. Today I can find no such usage, so let's try again.
2022-07-08 12:07:36 -07:00
d304712f64
[channel_args] Spread grpc_core::ChannelArgs through client channel code ( #30008 )
...
* [channel_args] Spread grpc_core::ChannelArgs through client channel code
* progress
* progress
* grpc compiles
* uniqueptr+compiles
* fix
* fix
* fix
* fix
* fix
* fix
* fixes
* fix
* fix
* fixes
* fix-lb
* fix
* fix up arg construction
* fix
* fix
* fix
* fix
* move to const& to save bytes
* fix
* fix
* progress
* review feedback
* fix
* fix
* fixes
* fixes
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* debug-helper
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-07 19:19:11 -07:00
694e634a79
client_lb_end2end_test: fix flake in RoundRobin.SingleReconnect test ( #30229 )
...
* client_lb_end2end_test: fix flake in RoundRobin.SingleReconnect test
* fix condition used to determine when client has seen backend 0 down
* remove duplicate counter reset
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-07 14:59:13 -07:00
a3afb81274
Second attempt: XdsClient: refactor transport code to make it injectable ( #30225 )
...
* Revert "Revert "XdsClient: refactor transport code to make it injectable (#30183 )" (#30223 )"
This reverts commit fa57b9d0bc
2022-07-07 10:03:23 -07:00
fa57b9d0bc
Revert "XdsClient: refactor transport code to make it injectable ( #30183 )" ( #30223 )
...
This reverts commit bd9bc5fd3e
2022-07-06 12:29:57 -07:00
bd9bc5fd3e
XdsClient: refactor transport code to make it injectable ( #30183 )
...
* XdsClient: refactor transport code to make it injectable
* clang-format
* Automated change: Fix sanity tests
* remove unnecessary dtor
* fix build
* re-add missing drain of WorkSerializer queue after receiving a message
* remove unused code
* fix memory leak
* Automated change: Fix sanity tests
* fix another memory leak
* fix unused parameter
* fix tsan failure
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-06 09:26:34 -07:00
74e1023f0a
priority LB: fix dumb reversed-conditional bug ( #30149 )
...
* C++ end2end tests: refactor ConnectionAttemptInjector code
* priority LB: fix dumb reversed-conditional bug
* clang-format
* add test
2022-07-01 09:13:56 -07:00
5e19c780c3
XdsSecurityTest: Rework infrastructure ( #30138 )
...
* XdsSecurityTest: Rework infrastructure
* Reviewer comments
* Comment
* Add TODO
2022-06-30 16:25:28 -07:00
d379e811be
C++ end2end tests: refactor ConnectionAttemptInjector code ( #30148 )
...
* C++ end2end tests: refactor ConnectionAttemptInjector code
* clang-format
2022-06-30 14:32:27 -07:00
9bc16ede7c
Update authz tests to use callback ( #30058 )
...
* Update authz core tests to use callback
2022-06-30 12:16:22 -07:00
eb5ae61470
Reland (again) bytestream removal ( #29987 )
...
* Revert "Revert "Reland bytestream removal (#29911 )" (#29964 )"
This reverts commit e6c6840db3
2022-06-27 21:21:23 -07:00
3aad52e4d3
XdsSecurityTest flakiness: Add broken pipe to expected error messages ( #30091 )
2022-06-27 13:19:00 -07:00
03dcd61068
[iomgr] Second take for iomgr shutdown ( #30101 )
...
* better api for ee up/down
* fixes
* mac fix
* review feedback
* nuke bm_cq_multiple_threads
* Revert "nuke bm_cq_multiple_threads"
This reverts commit dcda194a42
2022-06-24 13:36:59 -07:00
c66c362191
Reland "Enable GRPC_ERROR_IS_ABSEIL_STATUS" ( #30047 )
...
* Revert "Revert "Enable GRPC_ERROR_IS_ABSEIL_STATUS (#29869 )" (#30031 )"
This reverts commit 2d0d1775a9
2022-06-23 12:38:19 -07:00
870fe8624f
security handshaker: include security connector type in error message ( #30046 )
...
* weighted_target and RLS: delegate to child picker on error
* security handshaker: include security connector type in error message
* update test
* fix sanity
* fix crash
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-06-23 02:05:56 -07:00
3a8e54b005
round_robin: update status upon each new connection failure ( #30001 )
...
* refactor connection injectors in client_lb_end2end_test and add test for sticky TF
* round_robin: update status upon each new connection failure
* fix ring_hash too
* clang-format
2022-06-22 15:40:29 -07:00
86e282ba97
weighted_target and RLS: delegate to child picker on error ( #29870 )
...
* weighted_target and RLS: delegate to child picker on error
* fix RLS bug that caused us to always use the last target in the list
* add comment
2022-06-22 15:21:18 -07:00
7976501534
client_lb_end2end_test: refactor connection injectors and add test for sticky TF ( #29993 )
...
* refactor connection injectors in client_lb_end2end_test and add test for sticky TF
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-06-22 12:22:00 -07:00
d0c8b29ef7
xDS: fix endpoint weight defaults ( #30079 )
...
* xDS: fix endpoint weight defaults
* add test
* NACK endpoint weight of 0
* iwyu
* clang-tidy
* fix test
2022-06-22 11:54:38 -07:00
e085568c88
Fix build failures with istio test ( #30074 )
...
* Fix ubsan failure
* Fix build failures with istio test
* Fix other status code
2022-06-21 12:14:28 -07:00
c6145a93bf
xds Istio Interop: Handle failures properly ( #30036 )
...
* xds Istio Interop: Handle failures properly
* Unused parameters
* Remove unnecessary sleep
2022-06-17 11:27:15 -07:00
f17110adef
xDS Istio Interop: Forward ForwardEcho requests for unhandled protocols ( #30005 )
...
* xDS Istio Interop: Forward ForwardEcho requests for unhandled protocols
* Add deadline
* clang-tidy
* Reviewer commentsg
2022-06-16 17:23:32 -07:00
2d0d1775a9
Revert "Enable GRPC_ERROR_IS_ABSEIL_STATUS ( #29869 )" ( #30031 )
...
This reverts commit c6058b5e6b
2022-06-15 21:41:55 -07:00
c6058b5e6b
Enable GRPC_ERROR_IS_ABSEIL_STATUS ( #29869 )
...
* Enable GRPC_ERROR_IS_ABSEIL_STATUS
* Sanitize
* Fix ServerRequestCallTest
2022-06-15 15:06:15 -07:00
78d6d71af3
Call: Send cancel op down the stack even when no ops are sent ( #30004 )
...
* Call: Send cancel op down the stack even when no ops are sent
* Add test
2022-06-14 13:10:41 -07:00
a1e1d34f36
Log peer address in interop soak client ( #30006 )
2022-06-14 10:55:55 -07:00
f12972506e
xDS: improve status messages from xDS resolver failures ( #29975 )
2022-06-14 10:25:30 -07:00
a78df68e96
xds: add "ignore_resource_deletion" server feature ( #29633 )
...
* xds: add "ignore_resource_deletion" server feature
* add logging
* clang-format
* fix build
* fix build
* add test for LDS resource deletion on gRPC server
* clang-format
2022-06-13 14:01:13 -07:00
6532084a06
[iwyu] rest of the owl: src/core/lib - excluding iomgr, gpr ( #29735 )
...
* [iwyu] rest of the owl: src/core/lib - excluding iomgr, gpr
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* x
* fix?
* fix
* windows fix
* fix
* fix
* fix
* fix
* fix
* debug
* fix
* fix
* Revert "debug"
This reverts commit c99b8d12dd
2022-06-10 13:04:47 -07:00
f8eedac1fc
Changing grpc_tcp_client_vtable to include TCP cancel connect method ( #29968 )
...
* Changing grpc_tcp_client_vtable to include TCP cancel connect method
* fix unused parameter error
* update
* fix sanity checks
2022-06-10 10:56:34 -07:00
8459824e5c
xds end2end tests: change tests to check all RPC failure statuses ( #29974 )
...
* WIP
* fix from merge
* fix ring_hash tests
* ring hash: fix picker propagation bug in xds_cluster_manager policy
* fix build
* clang-format (ish)
* fix build
* more conversion
* remove old CheckRpcSendFailure
* fix SendRpcsAndCountFailuresWithMessage
* fix WaitForBackend
* clang-format
* revert xds resolver change, that will be done in a separate PR
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-06-09 18:00:38 -07:00
691199ab80
xDS Istop Interop: Add differentiation on the protocol being used ( #29965 )
...
* xDS Istop Interop: Add differentiation on the protocol being used
* Fixes
* clang-tidy
2022-06-09 13:51:39 -07:00
470a3066c7
ring hash: fix picker propagation bug in xds_cluster_manager policy ( #29959 )
...
* ring hash: fix picker propagation bug in xds_cluster_manager policy
* fix build
* fix build
2022-06-09 10:08:47 -07:00
e6c6840db3
Revert "Reland bytestream removal ( #29911 )" ( #29964 )
...
* Revert "Reland bytestream removal (#29911 )"
This reverts commit 98dcba2807
2022-06-09 08:51:06 -07:00
c6ebbb5482
Added GRPC_ERROR_IS_NONE ( #29937 )
...
* Added GRPC_ERROR_IS_NONE
* Convert
* Fix
2022-06-08 11:24:20 -07:00
1e9fe0b8b3
Istio Echo Server Implementation ( #29940 )
...
* Istio Echo Server Implementation
* New line fix
* Fix race
2022-06-07 19:13:01 -07:00
27e6a094e1
client_lb_end2end_test: fix broken tests ( #29938 )
...
* client_lb_end2end_test: fix broken tests
* poll polling engine gives slightly different error messages
2022-06-07 15:32:47 -07:00
35b7d88654
client_lb_end2end_test: explicitly check failed RPC statuses ( #29906 )
...
* client_lb_end2end_test: explicitly check failed RPC statuses
* appease clang-tidy
* fix memory leak
2022-06-07 11:59:08 -07:00
17bec49af7
rls: use UNAVAILABLE instead of status from RLS RPC, and test failure statuses ( #29893 )
...
* rls: use UNAVAILABLE instead of status from RLS RPC, and test failure statuses
* simplify
2022-06-07 10:11:20 -07:00
98dcba2807
Reland bytestream removal ( #29911 )
...
* Revert "Revert "Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )" (#29894 )" (#29910 )"
This reverts commit 713a1581d5
2022-06-05 18:42:28 -07:00
713a1581d5
Revert "Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )" ( #29910 )
...
This reverts commit 93cdc8b77e
2022-06-05 11:01:48 -07:00
93cdc8b77e
Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )
...
* Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )"
This reverts commit d53986657f
2022-06-04 15:51:16 -07:00
e49c61cd2f
client_channel: remove synchronous subchannel connectivity state API ( #28339 )
...
* ring_hash: don't recreate ring when individual subchannel states change
* client_channel: remove synchronous subchannel connectivity state API
* change subchannel list to automatically start watching all subchannels
* use a separate loop to start watches, so list size is logged correctly
* fix RR to re-resolve on IDLE again
* fix ring_hash to delay promoting new subchannel list
* fix pick_first to wait for all subchannels to report state
* clean up SubchannelList API
* fix unused argument error
* fix another unused argument error
* clang-format
* fix RR to not re-resolve on initial IDLE state
* also don't re-resolve in initial TF state; same for ring_hash
* clang-format
* change RR and PF to initially report CONNECTING, and add second loop to priority policy
* simplify priority logic a bit
* fix grpclb to drop ref to stats object even if the subchannel call is never started
* fix memory leak in ring_hash
* fix tsan failure in grpclb code
* iwyu
* add missing BUILD deps
* update outlier_detection policy
* fix test
* fix pick_first to not report TF prematurely due to subchannel sharing
* fix test to not depend on timing
2022-06-03 06:44:26 -07:00
d53986657f
Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )
...
This reverts commit aacf0e252b
2022-06-02 19:34:49 -07:00
aacf0e252b
[transport] Remove ByteStream ( #29637 )
...
* A starter SliceBuffer implementation
* Add comments and fix sanity checks
* Minor fixes
* more minor fixes
* Addressing review comments and adding a slice_buffer_test
* fix sanity checks
* regenerate projects
* fixing undefined function error
* reverting changes from memory_allocator.cc and adding them to src/core/lib/slice/slice_buffer.cc to allow memory allocator lib to build correctly
* fix sanity checks
* adding an open source slice definition
* regnerate projects
* fix asan error
* Automated change: Fix sanity tests
* addressing review comments
* fix sanity checks
* regenerate projects
* update
* fix sanity checks
* Converting slice buffer to retarin ownership of the underlying ctype
* [slice_buffer] Introduce grpc_core::SliceBuffer
* add test
* Automated change: Fix sanity tests
* [byte-stream] Delete ByteStream
* progress
* progress
* missing files
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* sanity
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* iwyu
* fix
* progress
* fix
* fix
* progress
* code compiles
* fix?
* bogus assert
* Automated change: Fix sanity tests
* fix
* fix
* fix?
* fix
* fix
* better expression of function
* fix?
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add fullstack test without retry filter
* debug
* missing files
* gc
* fix h2_full_no_retry
* remove headers
* fixes
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* progress
* x
* tear apart flow control
* continue itnegration
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* cleanup
* Automated change: Fix sanity tests
* fix
* x
* x
* Revert "debug"
This reverts commit 0120a944925fe05120776df476b22f
2022-06-02 16:04:32 -07:00
e89883cc87
Revert "Revert "Fix grpc_sockaddr_to_uri to return URI encoded string. Also see #29323 which has a similar fix for unix abstract addresses."" ( #29798 )
...
Reverts #29639
2022-06-02 13:51:04 -07:00
5d9cdc8e67
xds: Add XdsLbRegistry ( #29756 )
...
* xds: Add XdsLbRegistry
* Formatting
* Fix upb output
* Allow alternative type url for Custom LBs
* Cleanup
* Reviewer comments
* Add some comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Fix tests
* Fix tests
* Fix tests
* Fix tests
* Fix tests
* Unused parameters
* Change to make TextFormat usage work internally
* Fix namespace qualification error
2022-06-01 14:08:26 -07:00
bbf56baa88
client_lb_end2end_test: fix flake in RoundRobinTest.UpdateInError ( #29847 )
2022-06-01 07:47:19 -07:00
8cdf8beafd
xDS: Workaround to get gRPC clients working with istio ( #29841 )
...
* xDS: Workaround to get gRPC clients working with istio
* Formatting
* Comment test too
* Disable instead of commenting
2022-05-31 17:39:46 -07:00
b8e3e59b15
testing: fix address sorting test on macos by removing a fragile assumption ( #29820 )
...
* Fix address sorting test: remove a fragile assumption
2022-05-31 16:24:40 -07:00
65a7ce3f04
Revert "Revert "server: add method to expose authority seen by server ( #29768 )" ( #29806 )" ( #29807 )
...
This reverts commit e39e943529
2022-05-31 14:15:45 -07:00
64b422091e
xds_core_end2end_test: increase timeouts to fix flakiness ( #29803 )
...
* xds_core_end2end_test: increase timeouts to fix flakiness
* clang-format
2022-05-27 14:34:53 -07:00
a4cbeee699
xds_core_end2end_test: increase RPC timeout on BootstrapSource test ( #29802 )
2022-05-27 14:32:53 -07:00
98c40ce772
client_lb_end2end_test: increase timeouts in RoundRobinTest.UpdateInError ( #29805 )
2022-05-27 08:11:23 -07:00
Mark D. Roth