Commit Graph

479 Commits

Author SHA1 Message Date
Craig Tiller fe913387da
Remove idempotent/cacheable requests (#28922)
* Remove idempotent/cacheable requests

* more cleanup

* bump core version

* fix

* fix

* fix

* review feedback

* fixes

* fix

* remove more

* objc

* fix

* fix

* fix

* scrub

* Modify XdsRbacTests

Co-authored-by: Yash Tibrewal <yashkt@google.com>
2022-03-04 14:42:59 -08:00
AJ Heller 85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) (#28917)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
AJ Heller e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller fc7314c701
Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Mohan Li 155aa95f82
Fix memory stomp error in the fallback test client (#28380)
* Fix memory stomp error in the fallback test client

* Fix memory stomp error in the fallback test client
2021-12-20 11:09:50 -08:00
Jan Tattermusch ce74e092e6
add --log_metadata_and_status feature to interop_client (#28021) 2021-11-23 15:32:13 -08:00
Richard Belleville 468768865b
Make Buildifier Sanity Test Strict (#27807)
* Fix all lint errors in repo.

* Use strict buildifier by default

* Whoops. That file does not exist

* Attempt fix to buildifier invocation

* Add missing copyright
2021-11-03 14:57:04 -07:00
Craig Tiller d1e01ac139
Add a test for a (now-illegal) build file construct (#27602)
* Add a test for a (now-illegal) build file construct

* add to test suite!

* fix

* fix

* fix syntax
2021-10-06 07:43:59 -07:00
Yash Tibrewal 72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API (#26544)
* De-experimentalize XdsCredentials and XdsServerCredentials API

* Use GRPC_DEPRECATED
2021-09-09 16:22:25 -07:00
Yash Tibrewal 7fd731f704
De-experimentalize XdsServerBuilder (#27296) 2021-09-09 14:14:11 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
AJ Heller 4ba3fa52b9
Clean up some instances of -Wunreachable-code-aggressive (#27054)
See https://github.com/grpc/grpc/pull/26951 for why this is not enforced
at the moment.
2021-08-18 11:43:46 -07:00
apolcyn d742153b32
Include the peer address in interop soak test high-latency error messages (#26932) 2021-08-10 09:47:16 -07:00
Yash Tibrewal 29d220a0ef
Re-experimentalize XdsServerBuilder (#26892)
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
2021-08-06 10:29:28 -07:00
ZHANG Dapeng ca482bdbc7
Enable xds retry test for cpp (#26828)
* enable retry

* enable cpp

* fix cpp format

* fix indent
2021-07-29 15:39:35 -07:00
Yash Tibrewal 4daedf0233
De-experimentalize XdsServerBuilder (#26543) 2021-07-02 19:33:15 -07:00
Craig Tiller 03bdfa4a74
Make socket mutators work for server connections (#26328)
* Make socket mutators work for server connections

* compile fix

* compile fix

* compile fix

* compile fix

* cleanup

* Revert "cleanup"

This reverts commit 480fcc600a.

* Revert "Revert "cleanup""

This reverts commit 29fbc349d2.
2021-06-23 14:40:35 -07:00
AJ Heller 5cda00427d
Remove use of C++20 initializers (#26028)
Since this codebase only supports C++11 at this point, doing a build
with strict warnings will fail using C++20 initializers.

```
$ bazel build --define=use_strict_warning=true :all //src/core/... //src/compiler/... //test/...

test/cpp/interop/grpclb_fallback_test.cc:154:9: error: designated
initializers are a C++20 extension [-Werror,-Wc++20-designator]
        .mutate_fd = TcpUserTimeoutMutateFd,
```

See
https://source.cloud.google.com/results/invocations/f9710ed0-994f-488f-adb8-a7e987f1620d/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_bazel_build/log
2021-04-20 14:37:00 -07:00
Lidi Zheng 735c7047aa
[C++] Add admin and reflection to xds interop binaries (#25964)
* Add admin and reflection to xds interop binaries

* Prepare for https://github.com/grpc/grpc/pull/25978

* Remove _xds rules
2021-04-19 11:04:42 -07:00
Yash Tibrewal 23152e74ce
Enable channelz for xds_interop_client and xds_interop_server (#25939)
* Enable channelz for xds_interop_client and xds_interop_server

* Regenerate projects
2021-04-13 15:05:07 -07:00
Esun Kim a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr (#25628) 2021-03-09 21:30:35 -08:00
Yash Tibrewal 8eb2e13a6e
C++ xDS interop test server changes (#25633)
* C++ xDS interop test server changes
2021-03-05 16:25:50 -08:00
Esun Kim 377fe6095a
Upgrade clang-tidy and clang-format to 11 (#25590)
* Upgrade clang-tidy and clang-format to 11
* Reformat code
* Fix abseil-string-find-str-contains
* Fix modernize-make-unique
2021-03-04 11:54:30 -08:00
Yash Tibrewal 4b9ec936e8
xDS Interop Client changes for PSM security tests (#25613) 2021-03-04 10:09:25 -08:00
apolcyn 35569cd544
Make --server_port optional in C++ interop client (#25550)
* make --server_port optional in C++ interop client
2021-02-26 11:38:11 -08:00
Donna Dionne b2443df1e1 xds_interop_client.cc modification: new stats and new timeout_sec config 2021-01-21 15:23:02 -08:00
Esun Kim 9bd7c4917a Fix unused-parameter warning 2021-01-19 18:18:09 -08:00
Donna Dionne 88876b194c Fixing interop client to send all RPC types for each duration_per_query. 2020-12-22 10:15:48 -08:00
Donna Dionne 9b1172697e Adding a expect_status flag in xds interop client to get ready for
timeout tests.
2020-12-21 09:51:26 -08:00
Esun Kim 53ab235fb8 Fix google-explicit-constructor 2020-12-03 15:03:39 -08:00
Esun Kim 7d7c3cc711 Update by review 2020-12-02 13:42:53 -08:00
Esun Kim 2ff84ed8c2 C++ cast for void* 2020-11-30 17:29:15 -08:00
Esun Kim ec0b88a5d7 Fix google-readability-casting 2020-11-30 17:27:51 -08:00
Esun Kim 75e3e660fd Fix google-readability-todo 2020-11-25 10:09:42 -08:00
Donna Dionne e4a060fb1e Adding client changes needed for circuit breaking tests
- reworking interop client to accpet ClientConfig RPC
- adding new stats RPC
2020-11-20 16:23:49 -08:00
Donna Dionne c85ce105ee Fixing a bug in cpp xds interop client after the use of absl::GetFlag
Code used absl::string_view to point into FLAG_xxx, when we changed
to uses absl::GetFlag, absl::string_view is pointing into temp variables
which results in undefined behaviour for the flags.
2020-11-15 15:30:43 -08:00
Mark D. Roth 27e1c1c56d clang-tidy: enable google-readability-braces-around-statements 2020-11-06 13:41:44 -08:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim aae4f4cf18 Fix by misc-unused-using-decls 2020-10-19 18:12:11 -07:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Esun Kim ece76ee1e8 Fix code by readability-container-size-empty 2020-10-16 09:48:20 -07:00
Esun Kim 6d6648c7e1 Fix clang-tidy errors 2020-10-13 09:51:31 -07:00
Vijay Pai f8b046e819 Eliminate ServerContextBase::Clear/Setup and fix unref process for core call 2020-09-22 00:37:25 -07:00
Yash Tibrewal d10e06b60a Add interop test for special_status_message 2020-09-17 14:00:47 -07:00
Eric Gribkoff 7df3017c8a Update semantics of --fail_on_failed_rpc 2020-07-27 10:11:19 -07:00
Mark D. Roth e681f37054 Remove env var protection of new xds routing code. 2020-07-20 07:59:07 -07:00
Donna Dionne ea459f72f5 Fixing unsafe std::move. 2020-07-16 16:05:31 -07:00
Donna Dionne 1f30faad13 Fixing call to absl::StrSplit to deal with empty string case. 2020-07-15 17:31:10 -07:00