Commit Graph

3440 Commits

Author SHA1 Message Date
Yash Tibrewal af2b170d8a Comment out names of unused arguments 2019-04-23 12:14:52 -07:00
Karthik Ravi Shankar 858b5cca20 Fix clang_format_code.sh issues and move the internal calls to new name 2019-04-23 11:45:11 -07:00
Karthik Ravi Shankar 17ca558e13 Merge branch 'master' into grpc_namespace_channel_arguments 2019-04-23 11:38:13 -07:00
yang-g 41824319fa Resolve review comments 2019-04-23 08:54:36 -07:00
Vijay Pai 1a4f5e8ade
Fix typo in comment
It's a ServerWriteReactor
2019-04-22 11:29:16 -07:00
Vijay Pai 20c08dbc7a Add client-side unary reactor model 2019-04-19 16:10:08 -07:00
Arjun Roy 7d946633ea grpc_slice_refcount devirtualization 2019-04-19 12:20:26 -07:00
SataQiu c4a2069d9c fix spelling errors of include/* 2019-04-19 12:20:26 -07:00
Soheil Hassas Yeganeh 1c186784cd Make sure grpc::internal::Mutex has enough space for gpr_mu, std::mutex, and pthread_mutex_t. 2019-04-17 14:35:34 -04:00
Soheil Hassas Yeganeh 2b9448a71c Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
This reverts commit d09c9f8e20.
2019-04-17 14:35:29 -04:00
yang-g 051d421579 Resolve sanity 2019-04-17 08:57:48 -07:00
yang-g 6929cdd654 initial 2019-04-16 15:43:58 -07:00
Jean de Klerk a19d8dcfb5 docs: add note about retrying UNAVAILABLE
release note: no
2019-04-15 12:45:27 -06:00
Jan Tattermusch 1d9e442b4d
Merge pull request #18707 from SataQiu/fix-repeated-words
Clean up repeated words
2019-04-15 13:37:09 +02:00
Alexander Polcyn a31e86b780 Revert remaining conversions 2019-04-11 17:54:33 -07:00
Alexander Polcyn d09c9f8e20 Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
This reverts commit a26c09dd25.
2019-04-11 16:52:54 -07:00
Karthik Ravi Shankar 00f736adda Remove unecessary file 2019-04-11 15:46:08 -07:00
Karthik Ravi Shankar 62fb156122 Fold CompletionQueue and ServerCompletionQueue into grpc_impl 2019-04-11 13:16:32 -07:00
Karthik Ravi Shankar c93a3aaed3 Remove more files 2019-04-11 12:07:52 -07:00
Karthik Ravi Shankar 2554f122c1 Remove unecessary files 2019-04-11 12:06:41 -07:00
Karthik Ravi Shankar 973fa6950e Fold Channel into grpc_impl from grpc namespace 2019-04-11 12:04:23 -07:00
Vijay Pai ea59977fbc
Merge pull request #18687 from vjpai/cancel_order
C++ Callback API: Make sure that OnCancel happens after OnStarted
2019-04-10 16:15:43 -07:00
Karthik Ravi Shankar 2e88231fc0
Revert "Revert "Merge pull request #18458 from grpc/grpc_namespace_server"" 2019-04-10 15:04:05 -07:00
Soheil Hassas Yeganeh e85dd2e644 Fix build errors 2019-04-10 14:15:28 -07:00
Karthik Ravi Shankar f03b309787 Revert "Merge pull request #18458 from grpc/grpc_namespace_server"
This reverts commit dc1089a6d1, reversing
changes made to 31843787cc.

This change also includes - Revert "Merge pull request #17932 from soheilhy/gprpp-mutex"

This reverts commit df4b6a763d, reversing
changes made to dc1089a6d1.
2019-04-10 13:54:05 -07:00
Karthik Ravi Shankar dad3f34207
Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace.""" 2019-04-10 12:14:04 -07:00
Vijay Pai 41c6cba9f5 Make sure that OnCancel happens after OnStarted 2019-04-10 11:32:34 -07:00
Karthik Ravi Shankar 891b6cf7ae
Revert "Folding CompletionQueue and ServerCompletionQueue." 2019-04-10 10:22:59 -07:00
SataQiu 44f92cdd17 clean up repeated words 2019-04-10 16:25:25 +08:00
Karthik Ravi Shankar d2b2f7f5a3 Merge branch 'master' into completion-queue-fold 2019-04-09 13:44:33 -07:00
Karthik Ravi Shankar 918cb46011
Merge pull request #18198 from grpc/revert-18076-revert-17797-channel
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
2019-04-09 13:34:02 -07:00
hcaseyal ca11dfb349
Merge pull request #18686 from hcaseyal/callback_doc
Update callback API documentation
2019-04-09 12:45:06 -07:00
Karthik Ravi Shankar 506ca7fc36 Fix clang script errors 2019-04-09 11:51:39 -07:00
Karthik Ravi Shankar b84d3db762 Fix build after merge from master 2019-04-09 11:11:09 -07:00
Karthik Ravi Shankar afd602ccba Merge branch 'master' into completion-queue-fold 2019-04-09 10:46:03 -07:00
Karthik Ravi Shankar 5a08d2aae7 Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-09 08:22:37 -07:00
Karthik Ravi Shankar 53c5bf5ced Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-08 16:04:24 -07:00
Soheil Hassas Yeganeh a26c09dd25 Introduce C++ wrappers for gpr_mu and gpr_cv.
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.

Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.

Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
Karthik Ravi Shankar 4cb0d0d6b1 Fix errors from clang scripts 2019-04-08 13:41:19 -07:00
Karthik Ravi Shankar 991409798c Fix clang script errors 2019-04-08 13:09:41 -07:00
Karthik Ravi Shankar 9875fabdd4 Merge branch 'master' into revert-18076-revert-17797-channel 2019-04-08 12:55:07 -07:00
Karthik Ravi Shankar 958f373d32 Merge branch 'master' into grpc_namespace_server 2019-04-08 12:42:37 -07:00
Karthik Ravi Shankar 0141f9a55b Merge branch 'master' into grpc_namespace_channel_arguments 2019-04-08 11:59:28 -07:00
Karthik Ravi Shankar 68905e559e
Merge pull request #18510 from grpc/revert-18502-revert-18242-grpc_namespace_serverbuilder
Revert "Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder""
2019-04-08 11:09:42 -07:00
Hope Casey-Allen b86e70592e Format 2019-04-08 10:13:17 -07:00
Hope Casey-Allen cee3292cdf Update callback API documentation 2019-04-08 09:11:04 -07:00
Moiz Haidry ca209ae00e Fix typo in server credentials impl header file 2019-04-05 09:33:40 -07:00
Karthik Ravi Shankar 9b42ab79e0 Make build fixes for bazel build :all 2019-04-04 16:40:16 -07:00
Karthik Ravi Shankar f01997b377 Merge branch 'master' into grpc_namespace_channel_arguments 2019-04-04 16:31:42 -07:00
Karthik Ravi Shankar c50dd23ea7 Merge branch 'master' into grpc_namespace_server 2019-04-04 15:56:09 -07:00
Karthik Ravi Shankar dd39f78e3f Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-04-04 15:45:42 -07:00
Karthik Ravi Shankar af283b3183
Merge pull request #18452 from grpc/grpc_namespace_server_credentials
Fold server credentials from grpc to grpc_impl namespace
2019-04-04 13:47:26 -07:00
Karthik Ravi Shankar 5b1bf21090
Merge pull request #18434 from grpc/grpc_namespace_generic_stub
Fold GenericStub from grpc_impl to grpc
2019-04-04 13:46:44 -07:00
Karthik Ravi Shankar a93ff7d617 Fix script errors 2019-04-04 10:14:26 -07:00
Karthik Ravi Shankar 79a0be902e Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-04-04 10:13:18 -07:00
Karthik Ravi Shankar 0cedc27cb6 Merge branch 'master' into grpc_namespace_server_credentials 2019-04-04 10:04:30 -07:00
Karthik Ravi Shankar 9222d4f3c2 Fix clang issues 2019-04-04 10:03:26 -07:00
Karthik Ravi Shankar 23a77f7c0e Merge branch 'master' into grpc_namespace_server 2019-04-04 09:56:51 -07:00
Karthik Ravi Shankar 9b312aa25b
Merge pull request #18600 from karthikravis/grpc_namespace_proto_server
Move ProtoServerReflectionPlugin from grpc to grpc_impl namespace
2019-04-03 15:33:04 -07:00
Karthik Ravi Shankar 12c20bc67c
Merge pull request #18436 from grpc/grpc_namespace_auth_metadata_processor
Fold AuthMetadataProcessor into grpc_impl from grpc
2019-04-03 14:49:09 -07:00
Karthik Ravi Shankar a70b7d8d83
Merge pull request #18455 from grpc/grpc_namespace_error_details
Fold ErrorDetails into grpc_impl from grpc
2019-04-03 14:24:13 -07:00
Karthik Ravi Shankar e642e175e7
Merge pull request #18374 from grpc/grpc_namespace_channel_create
Moving create_channel from grpc to grpc_impl
2019-04-03 13:56:19 -07:00
Karthik Ravi Shankar 99b3016336
Merge pull request #18419 from grpc/grpc_namespace_server_load_reporting
Move LoadReportingServiceServerBuilderOption from grpc to grpc_impl
2019-04-03 13:48:37 -07:00
Karthik Ravi Shankar 87d2d68c4f Merge branch 'master' into grpc_namespace_server_credentials 2019-04-03 12:53:09 -07:00
Karthik Ravi Shankar 8a2807c2a6 Merge branch 'master' into grpc_namespace_server 2019-04-03 12:46:41 -07:00
Karthik Ravi Shankar e5ea95db88 Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-04-03 12:25:09 -07:00
Karthik Ravi Shankar 43b33ee371 Fix errors from clang scripts 2019-04-01 18:59:01 -07:00
Karthik Ravi Shankar c4b7423ad0 Fix errors due to rebase 2019-04-01 18:40:40 -07:00
Muxi Yan 71727d1efb Merge remote-tracking branch 'upstream/master' into default-cfstream-2 2019-04-01 15:34:07 -07:00
Karthik Ravi Shankar f0d82d57e2 Merge branch 'master' into grpc_namespace_server_credentials 2019-04-01 13:59:12 -07:00
Karthik Ravi Shankar 8c2be21971 Merge branch 'master' into grpc_namespace_auth_metadata_processor 2019-04-01 13:53:16 -07:00
Karthik Ravi Shankar 3d6f118a5f Merge branch 'master' into grpc_namespace_generic_stub 2019-04-01 13:52:27 -07:00
Karthik Ravi Shankar 150935aeef Merge branch 'master' into grpc_namespace_server_load_reporting 2019-04-01 13:50:30 -07:00
Karthik Ravi Shankar ccf8c8c16c
Merge branch 'master' into grpc_namespace_proto_server 2019-04-01 13:47:31 -07:00
Karthik Ravi Shankar 8e092b45fa Move ProtoServerReflectionPlugin from grpc to grpc_impl namespace 2019-04-01 13:32:40 -07:00
Karthik Ravi Shankar 87c98ad3fb
Merge pull request #18379 from grpc/grpc_namespace_server_initializer
Move ServerInitializer to grpc_impl namespace from grpc
2019-04-01 12:48:28 -07:00
Karthik Ravi Shankar a9a0739dc8
Merge pull request #18371 from grpc/grpc_namespace_healthserviceinterface
Move ::grpc::HealthCheckServiceInterface to ::grpc_impl namespace
2019-04-01 12:28:13 -07:00
Karthik Ravi Shankar 3d5a9758fa
Merge pull request #18345 from grpc/revert-18343-revert-18220-grpc_namespace
Revert "Revert "Moving ::grpc::ResourceQuota to ::grpc_impl::ResouceQuota""
2019-04-01 12:27:51 -07:00
Karthik Ravi Shankar a10d4825c1
Merge pull request #18372 from grpc/grpc_namespace_server_posix
Move server_posix from grpc to grpc_impl namespace
2019-03-29 10:18:56 -07:00
Karthik Ravi Shankar 3354f2c5a7
Merge pull request #18373 from grpc/grpc_namespace_channel_create_posix
Move create_channel_posix from grpc to grpc_impl namespace
2019-03-29 10:17:59 -07:00
Karthik Ravi Shankar dcc199048f
Merge pull request #18396 from grpc/revert-18392-revert-18223-grpc_namespace_opencensus
Revert "Revert "Fold opencensus into grpc_impl namespace""
2019-03-29 10:09:01 -07:00
Karthik Ravi Shankar c85a03e308
Merge pull request #18377 from grpc/grpc_namespace_server_builder_option
Move ServerBuilderOption from grpc to grpc_impl namespace
2019-03-29 10:08:17 -07:00
Karthik Ravi Shankar 4fe664e065
Merge pull request #18375 from grpc/grpc_namespace_channelz_service_plugin
Move channelz_service_plugin from grpc to grpc_impl namespace
2019-03-29 10:07:53 -07:00
Karthik Ravi Shankar b2d9d7c8be Merge branch 'master' into grpc_namespace_channel_create 2019-03-29 08:46:27 -07:00
Karthik Ravi Shankar 29c0aacfc0 Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-03-29 08:24:54 -07:00
Karthik Ravi Shankar 53cf5ddb6b Fix include guard 2019-03-29 08:23:00 -07:00
Muxi Yan d771bcab2c Merge remote-tracking branch 'upstream/master' into default-cfstream-2 2019-03-28 14:49:15 -07:00
Vijay Pai 847b0155d9 Promise to call OnStarted and forbid Start* until after OnStarted 2019-03-27 16:30:07 -07:00
Karthik Ravi Shankar fc50caf725 Fix clang format issues 2019-03-27 15:03:20 -07:00
Karthik Ravi Shankar b8713cf08e Merge branch 'master' into grpc_namespace_server_load_reporting 2019-03-27 15:01:47 -07:00
Karthik Ravi Shankar f463ae2b05 Merge branch 'master' into grpc_namespace_auth_metadata_processor 2019-03-27 14:46:13 -07:00
Karthik Ravi Shankar 40440b9f9c Merge branch 'master' into grpc_namespace_generic_stub 2019-03-27 14:42:02 -07:00
Karthik Ravi Shankar dc3a715be4 Fix clang format code errors. 2019-03-27 14:33:58 -07:00
Karthik Ravi Shankar c399349dad Merge branch 'master' into grpc_namespace_server 2019-03-27 14:32:10 -07:00
Karthik Ravi Shankar 858e0dffe9 Merge branch 'master' into grpc_namespace_error_details 2019-03-27 14:26:16 -07:00
Karthik Ravi Shankar 8499415edd Merge branch 'master' into grpc_namespace_channel_arguments 2019-03-27 14:21:55 -07:00
Karthik Ravi Shankar 2f2ed7228b Fix clang_format_code.sh errors 2019-03-27 14:20:14 -07:00
Karthik Ravi Shankar 7068560b2b Merge branch 'master' into grpc_namespace_server_credentials 2019-03-27 14:18:42 -07:00
Karthik Ravi Shankar 0f078898d5 Merge branch 'master' into revert-18502-revert-18242-grpc_namespace_serverbuilder 2019-03-27 12:50:49 -07:00
Karthik Ravi Shankar e4945761f3 Merge branch 'master' into grpc_namespace_healthserviceinterface 2019-03-27 12:38:25 -07:00
Karthik Ravi Shankar 1bb2db83d8 Merge branch 'master' into grpc_namespace_channel_create_posix 2019-03-27 12:35:05 -07:00
Karthik Ravi Shankar 20f3e29d41 Merge branch 'master' into grpc_namespace_channel_create 2019-03-27 12:33:02 -07:00
Karthik Ravi Shankar 2ed030b3e8 Merge branch 'master' into grpc_namespace_channelz_service_plugin 2019-03-27 12:30:47 -07:00
Karthik Ravi Shankar 577ddfb1a1 Move ServerInitializer to grpc_impl namespace from grpc 2019-03-27 12:28:35 -07:00
Karthik Ravi Shankar a88e3f4c2e Move ServerBuilderOption from grpc to grpc_impl namespace 2019-03-27 12:20:43 -07:00
Vijay Pai abb991be25 Further clarify some APIs by removing their comments from internal:: 2019-03-27 09:46:08 -07:00
Vijay Pai 9169159f30 Comments for all callback API methods 2019-03-26 23:33:23 -07:00
Karthik Ravi Shankar 996da58667
Revert "Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder"" 2019-03-26 08:04:32 -07:00
Karthik Ravi Shankar e4bb7cb8bb
Revert "Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder" 2019-03-25 19:57:17 -07:00
Vijay Pai f4fdd829d7
Merge pull request #17892 from RohanTalip/HandlerParameter-doc
Renamed the param in the documentation for HandleParameter to match the actual parameter.
2019-03-25 16:46:17 -07:00
Karthik Ravi Shankar 88fc2a6a52
Merge pull request #18242 from grpc/grpc_namespace_serverbuilder
Moving ::grpc::ServerBuilder to ::grpc_impl::ServerBuilder
2019-03-25 15:59:01 -07:00
Karthik Ravi Shankar b2b1e57337 Fix errors from test scripts. 2019-03-25 15:55:06 -07:00
Karthik Ravi Shankar 850d02d67d Move channelz_service_plugin from grpc to grpc_impl namespace 2019-03-25 15:55:06 -07:00
Karthik Ravi Shankar 4b0175f2c8 Fix errors from clang_format_code.sh 2019-03-25 15:53:22 -07:00
Karthik Ravi Shankar 130962490b Make changes to fix test failures 2019-03-25 15:52:42 -07:00
Karthik Ravi Shankar 392554e341 Fixing clang_tidy_format.sh issues. 2019-03-25 15:52:42 -07:00
Karthik Ravi Shankar 49773cbe9a Fix namespace to grpc 2019-03-25 15:52:42 -07:00
Karthik Ravi Shankar d23753ca46 Move create_channel_posix from grpc to grpc_impl namespace 2019-03-25 15:52:42 -07:00
Karthik Ravi Shankar d204654836 Fix errors from clang_format_code.sh 2019-03-25 15:51:28 -07:00
Karthik Ravi Shankar 6e5587b165 Fix build issues. 2019-03-25 15:50:35 -07:00
Karthik Ravi Shankar 35e793d23a Fix more more tests. 2019-03-25 15:50:35 -07:00
Karthik Ravi Shankar 8dbaa13f52 Fix more grpc namespace issues 2019-03-25 15:50:35 -07:00
Karthik Ravi Shankar 92bde3922f Fix tests to use grpc namespace. 2019-03-25 15:50:35 -07:00
Karthik Ravi Shankar b25f6da3f0 Make changes to fix test failures 2019-03-25 15:50:35 -07:00
Karthik Ravi Shankar e27ddbc87e Move ::grpc::HealthCheckServiceInterface to ::grpc_impl namespace 2019-03-25 15:50:35 -07:00
Soheil Hassas Yeganeh a3366c1b7f
Merge pull request #18464 from soheilhy/slice-buffer
Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
2019-03-23 22:42:23 -04:00
Karthik Ravi Shankar ecfc107f32 Make more changes to remove grpc qualifier from tests 2019-03-21 18:40:00 -07:00
Nicolas Noble 0045a22101
Merge pull request #18443 from guzt/fuchsia_gn
Add Fuchsia support.
2019-03-21 13:00:27 -07:00
Soheil Hassas Yeganeh ad1b3e5094 Introduce grpc_byte_buffer_reader_peek and use it for Protobuf parsing.
grpc_byte_buffer_reader_next() copies and references the slice. This
is not always necessary since the caller will not use the slice
after destroying the byte buffer.

A prominent example is the protobuf parser, which
calls grpc_byte_buffer_reader_next() and immediately unrefs the slice
after the call. This ref() and unref() calls can be very expensive
in the hot path.

This commit introduces grpc_byte_buffer_reader_peek() which
essentialy return a pointer to the slice in the buffer, i.e.,
no copies, and no refs.

QPS of 1MiB 1 Channel callback benchmark increases by 5%.
More importantly insructions per cycle is increased by 10%.

Also add tests and benchmarks for byte_buffer_reader_peek()

This commit reaplies 509e77a5a3
2019-03-21 06:03:45 -04:00
Vijay Pai 50576179f8
Merge pull request #17978 from yashykt/interceptorcleanup1
Global Interceptor Registration allowed only once
2019-03-20 19:13:55 -07:00
Karthik Ravi Shankar 04af168cf8 Move Server into grpc_impl from grpc 2019-03-20 13:05:36 -07:00
Karthik Ravi Shankar 338b4cb5c9 Fold ErrorDetails into grpc_impl from grpc 2019-03-20 11:17:46 -07:00
Karthik Ravi Shankar 6da0ca4421 Bring ChannelArguments to grpc_impl from grpc 2019-03-20 10:38:03 -07:00
Arjun ca69f911a7 Add initial Fuchsia support.
1. Add a BUILD.gn file
2. Support fuchsia as a platform

This is heavily based on the changes in https://fuchsia.googlesource.com/third_party/grpc/
2019-03-20 10:26:49 -07:00
Karthik Ravi Shankar 54171e276f Fold server credentials from grpc to grpc_impl namespace 2019-03-20 10:00:34 -07:00
Karthik Ravi Shankar d684ddc7e3 Fold AuthMetadataProcessor into grpc_impl from grpc 2019-03-19 12:49:42 -07:00
Karthik Ravi Shankar 526bf39f89 Fold GenericStub from grpc_impl to grpc 2019-03-19 12:34:30 -07:00
Karthik Ravi Shankar f58aed2d06 Make changes to server_posix to expose method outside 2019-03-19 10:50:53 -07:00
Karthik Ravi Shankar 1d357572cf Revert "Moving ::grpc::ResourceQuota to ::grpc_impl::ResouceQuota"
This reverts commit d8d8bec7c8.
2019-03-19 10:43:02 -07:00
Karthik Ravi Shankar 8dcd98ef8c Fix server unit test errors. 2019-03-19 10:19:39 -07:00
Vijay Pai 7b3a120295 Address reviewer comments 2019-03-18 16:51:15 -07:00
Vijay Pai 93f0a3f653 Address reviewer comments 2019-03-18 15:37:35 -07:00
Karthik Ravi Shankar e9593285a8 Move LoadReportingServiceServerBuilderOption from grpc to grpc_impl 2019-03-18 13:20:42 -07:00
Vijay Pai 04a6b8467c Support callback on cancellation of server-side unary RPCs 2019-03-18 12:00:57 -07:00
Karthik Ravi Shankar 6c9951680e Fix clang_format_code.sh errors. 2019-03-18 10:40:27 -07:00
Karthik Ravi Shankar 322e720fe6 Merge branch 'master' into grpc_namespace_serverbuilder 2019-03-18 10:39:38 -07:00
Karthik Ravi Shankar 1061604a01 Fix clang_format_code.sh errors 2019-03-18 10:06:10 -07:00
Karthik Ravi Shankar c08e5bee40 Fix make errors 2019-03-17 22:15:21 -07:00
Vijay Pai 8c3d4a7dfd
Merge pull request #18072 from vjpai/client_streaming_hold
C++ callback API: Add support for client-side extra-reaction operations via Holds
2019-03-16 10:27:36 -07:00
Vijay Pai 797b01a85e
Merge pull request #17760 from Norman0406/fix-interceptor_memory_leak
Fixing memory leak in interceptor by removing unsued send_status_
2019-03-16 10:14:19 -07:00