Commit Graph

11 Commits

Author SHA1 Message Date
Mark D. Roth 2b03154cf4 Update naming doc. 2019-03-14 12:28:29 -07:00
Vu Cong Tuan 69fab8eacb Fix many typos in doc
Signed-off-by: Vu Cong Tuan <tuanvc@vn.fujitsu.com>
2019-02-14 11:14:16 +07:00
Alex Lo f932b8e2d0
ipv6 addresses must be bracketed if using a port
The host/port splitting code will not pull out a port if there are >=2 colons[1].
Unit test code demos this [2].  Note other documentation gets this right[3].  Example IP came from this issue[4] and the unit tests[2].
See also: relevant RFCs [5] [6]

[1]618a3f561d/src/core/lib/gpr/host_port.cc (L81)
[2]618a3f561d/test/core/client_channel/resolvers/sockaddr_resolver_test.cc (L107)
[3]https://chromium.googlesource.com/external/github.com/grpc/grpc/+/chromium-deps/2016-07-19/src/core/ext/client_config/README.md
[4]https://github.com/grpc/grpc/issues/6623
[5]http://www.iana.org/go/rfc5952#section-6
[6]http://www.iana.org/go/rfc3986#section-3.2.3
2018-11-12 16:16:40 -05:00
Mark D. Roth 69b416a08c Update naming documentation. 2018-08-28 08:53:31 -07:00
Mark D. Roth b4227370fc Code review changes and other improvements. 2017-01-18 09:21:20 -08:00
Mark D. Roth 892e917a09 Fix link. 2016-12-14 08:12:39 -08:00
Mark D. Roth 3cadfb152f Started updating docs. 2016-12-14 07:52:47 -08:00
Craig Tiller eda85c6765 Expunge all references to zookeeper 2016-07-01 12:45:19 -07:00
Abhishek Kumar c7e13188fa Update naming.md
Fixed code formatting issues.
2015-07-21 14:26:17 -07:00
Abhishek Kumar 2d8eeb416b Formatting fixes
Added some formatting fixes .
2015-07-21 10:00:36 -07:00
Abhishek Kumar 8c8ecd8da1 Initial draft of a naming proposal.
First draft for public review and comments.

Some code formatting is still broken.
2015-07-20 16:37:50 -07:00