7b79173991
Logging: Fill status code, status message and status details ( #32464 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2023-02-23 17:03:58 -08:00
184d4826d4
Gcp Observability: Fix resource labels for stats and tracing ( #32460 )
...
For stats, the StackDriver/OpenCensus API allows setting the
MonitoredResource directly, so use that.
For tracing, there is no explicit MonitoredResource to use, so just
insert it into the attributes for a span.
2023-02-22 23:35:20 -08:00
d93d0022cd
GCP Observability: Fix constant labels support for stats when tracing is disabled ( #32451 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2023-02-22 14:49:55 -08:00
4b05dc88b7
GCP Observability: Plumb environment autodetection for OpenCensus stats and tracing ( #32431 )
2023-02-19 22:25:23 -08:00
04e3a8e73d
GCP Observability : Framework for detecting the environment ( #32294 )
...
This code is not plumbed through yet, but it provides the core
infrastructure needed to detect the proper GCP environment resources
needed to set up the labels/attributes/resources for stats, tracing and
logging.
Details on how the various environment resources are setup has been
derived by looking at java's cloud logging library and OpenTelemetry's
future plans. (Could be better explained in an offline review since some
links are internal).
Requesting @veblush for a full review and @markdroth for a structural
review.
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2023-02-16 16:20:20 -08:00
0893fca089
[promises] Roll forward server promise calls with fixes ( #32261 )
...
* stuff
* spam-cleanup
* Revert "Revert "[promises] Server call (#31448 )" (#32260 )"
This reverts commit dbfb888e1f
2023-02-01 16:07:46 -08:00
dbfb888e1f
Revert "[promises] Server call ( #31448 )" ( #32260 )
...
* Revert "[promises] Server call (#31448 )"
This reverts commit bbeb15006a
2023-02-01 09:18:04 -08:00
bbeb15006a
[promises] Server call ( #31448 )
...
* add experiment
* allow instantiation
* scratchings
* scratchings
* sniffly
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* progress
* change pipe labels to enable server code to be written
* better api
* Automated change: Fix sanity tests
* progress
* [promises] Implementation of deadline for server-based-calls
* compression filter compiles again
* Automated change: Fix sanity tests
* fix
* server tracing fixes
* get client initial metadata
* progress
* progress
* server call surface progress
* Automated change: Fix sanity tests
* move payload
* server-progress
* recv-message-server-connchan
* logging
* fix context-gate
* recv fix@top
* Automated change: Fix sanity tests
* recv close on server
* top termination start
* [promises] Move Empty to be first class
* fixes
* fix
* flow control fix
* got to orphan!
* orphan
* call orphan
* spam cleanup
* fix
* new cancelation semantics
* progress
* large metadata fixes
* fix
* fix
* log
* better logs
* fix-chanz
* logging, necessaryness
* fix typo
* fixes
* fix
* fix
* fix-pipe
* cleanup logging
* fix
* build-fix
* fix
* Automated change: Fix sanity tests
* logging
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* better primitive
* Revert "better primitive"
This reverts commit 119b5ee244#32049 )"
This reverts commit 5fc92eaeaefa33301dcd
2023-01-30 21:39:11 -08:00
7b02b7c253
[stats] Add experiment to use transport reported request latency whenever available ( #32168 )
...
* [stats] Add experiment to use transport reported request latency whenever available
* redux: add a new metric
* review-feedback
* Automated change: Fix sanity tests
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-24 08:09:59 -08:00
beffe313e5
GCP Observability Logging: Base64 Encode metadata, message and status-details ( #32184 )
...
* GCP Observability Logging: Base64 Encode metadata, message and status-details
* Use padding for message and status-details
2023-01-23 18:57:09 -08:00
7f7a352ccc
Fix flakiness in test/cpp/ext/filters/census/... ( #32174 )
2023-01-23 12:13:45 -08:00
aa11978541
Fix include guards for src/ and test/ directories ( #32167 )
...
* Fix include guards for src/ and test/ directories
* Sanity
* Update new files
2023-01-20 16:27:27 -08:00
21618f3aef
GCP Observability: Add labels support for logging ( #32130 )
...
* GCP Observability: Add labels support for logging
* clang format
* Reviewer comments
2023-01-18 16:08:30 -08:00
05491fb2f6
Gcp Observabiliy : Add constant labels support for stats and tracing ( #32128 )
...
* Gcp Observabiliy : Add constant labels support for stats and tracing
* Register GCP Observability labels
* sanity
* Fix build for CI
* TEST_TAG_KEY fix
* Remove duplicitous constant label setting
2023-01-18 14:32:36 -08:00
25465100fd
LoggingTest: s/GUARDED_BY/ABSL_GUARDED_BY ( #32144 )
2023-01-18 14:24:11 -08:00
33be15bdb6
Gcp Observability: Lazily initialize channels post-init ( #32091 )
...
* Gcp Observability: Lazily initialize channels post-init
* IWYU and fix build deps
* Run RegistryPostInit for client census filters too
* Remove unused function
2023-01-13 11:13:20 -08:00
d5c1dc1667
GCP Observability: Fix env var names ( #32066 )
2023-01-10 14:02:07 -08:00
5fc92eaeae
Disable logging test ( #32049 )
2023-01-10 10:50:56 -08:00
ad6f6c49e0
Logging filter ( #31755 )
...
* initial
* Intermediate
* Another try
* Try multiple necesary pulls
* Filter works other than client half close
* Fixes
* Add a cancelled RPC test
* Handle trailer only responses
* Tests for disabled logging and truncated payloads
* Fix authority and peer
* Add TODOs and asserts for half-close
* Fix tests for half-close and cancel
* 2d748fcb1cf45cac62729b8346ad15e6abc79e97
* Fix sanity checks
* Strict bazel build
* Fix package
* IWYU
* Fix cmake
* Explicit cast to string
* Size casts
* Fix Arena leak and disable macos build for now
* Reviewer comments
2023-01-06 13:52:15 -08:00
d3d4dd7325
StatsPluginEnd2EndTest: Add QueueOnceLoadBalancingPolicy to remove flakiness from test ( #32019 )
...
* StatsPluginEnd2EndTest: Add QueueOnceLoadBalancingPolicy to remove flakiness from test
* Unused arg
* Remove unnecessary DelegatingPicker
* Reviewer comments
* explicit constructor
* Remove unnecessary dependency
* Reviewer comments
* Sanity
* clang tidy
2023-01-05 12:45:52 -08:00
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2022-12-22 23:01:53 -08:00
9e7c8bff55
Tracing: Add annotations for when call is removed from resolver result queue and lb pick queue ( #31913 )
...
* Tracing: Add annotations for when call is removed from resolver result queue and lb pick queue
* Add test for pending resolver result queue as well
* Update annotation messages
2022-12-16 10:31:48 -08:00
15c4a98bc7
Gcp Observability Logging: Add handling for adding entry as a json payload ( #31723 )
2022-11-21 14:32:04 -08:00
0389940093
GcpObservability: Add config support for constant labels ( #31710 )
2022-11-18 17:26:20 -08:00
0ba0c4bf74
Added googletest clang-tidy checks ( #31610 )
...
* Added google-googletest
* Autofix
* Fix test names
* Fix
2022-11-18 13:02:20 -08:00
7372e55ba9
Revert "Revert "Observability Logging: Interfaces and structure"" ( #31681 )
...
* Revert "Revert "Observability Logging: Interfaces and structure (#31651 )" (#31669 )"
This reverts commit 3be177223e
2022-11-17 11:12:36 -08:00
3be177223e
Revert "Observability Logging: Interfaces and structure ( #31651 )" ( #31669 )
...
This reverts commit 2146107e25
2022-11-15 18:24:00 -08:00
2146107e25
Observability Logging: Interfaces and structure ( #31651 )
...
* Observability Logging: Interfaces and structure
* Revert unrelated changes
* Fix test build
* Add dependency on Google Apis Logging V2 service and add a dummy logging call
* Add authority
2022-11-15 18:02:22 -08:00
829f41b733
ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability ( #31571 )
...
* ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability
* Trailing new lines
* Fix naked include
* clang-tidy
* Reviewer comments
* Reviewer comments
2022-11-09 14:13:20 -08:00
5dfd384655
ObservabilityConfig: Add missing test ( #31572 )
2022-11-09 12:30:09 -08:00
a99a65b6e2
GcpObservability: Add parsing for logging config ( #31502 )
...
* GcpObservability: Add parsing for logging config
* Unused parameters
* Reviewer comments
2022-10-31 17:02:20 -07:00
3b6675c2de
OpenCensus: Move measures, views and CensusContext to include file ( #31341 )
...
* OpenCensus: Move measure and view declarations to include file
* Move CensusContext class too
* Fix IWYU
* Guard with experimental
* Formatting
* clang tidy fixes
* cleanup
* Reviewer comments
2022-10-20 17:42:08 -07:00
727ae8c885
GcpObservability: Add experimental public target ( #31339 )
...
* GcpObservability: Add experimental public target
* Yapf and IWYU
2022-10-17 12:43:45 -07:00
2ffff621a4
OpenCensusTest: Fix flakiness ( #31349 )
2022-10-13 16:06:51 -07:00
8cffd1044e
OpenCensus: Ability to globally disable stats and tracing ( #31252 )
...
* OpenCensus: Ability to globally disable stats and tracing
* Fix docs
2022-10-05 14:38:15 -07:00
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2022-09-27 14:34:07 -07:00
9cff4d2d28
OpenCensus Plugin: Add missing measure and views for started RPCs ( #31034 )
2022-09-20 17:26:16 -07:00
07df5ff9c7
json_object_loader: refactor ErrorList into its own library ( #31049 )
...
* json_object_loader: refactor ErrorList into its own library
* fix observability_config_test
* generate_projects
* iwyu
2022-09-20 11:58:27 -07:00
5cd8ee25f8
GcpObservabilityConfig: New changes ( #31038 )
...
* GcpObservabilityConfig: New changes
* Fix IWYU
2022-09-19 15:29:46 -07:00
27e5b4e187
GcpObservabilityConfig: Fall-back to GCP environment variables ( #31022 )
2022-09-19 11:48:35 -07:00
6098202c09
GcpObservabilityTest: Cleanup ( #31023 )
2022-09-19 11:47:53 -07:00
c2ab8c99bb
Revert "Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )" ( #30988 )
...
This reverts commit 96264e07b8
2022-09-14 14:19:36 -07:00
96264e07b8
Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )
...
This reverts commit 74c0d6fe3f
2022-09-14 11:53:55 -07:00
74c0d6fe3f
[c++] Move environment functions to C++ ( #30937 )
...
* [gprpp] Move env to C++
* move headers/impl
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Update http_proxy.cc
* fix
* fix
* rename
* fix merge
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-14 10:17:15 -07:00
b3ad894e05
GcpObservability: Use the observability config ( #30932 )
...
* GcpObservability: Use the observability config
* iwyu
* Fix build
2022-09-13 11:47:19 -07:00
ebcda5f0c1
GcpObservabilityConfig: s/disabled/enabled ( #30905 )
2022-09-09 15:58:38 -07:00
f7f4c9b584
GcpObservability: Code for reading config from env var ( #30889 )
...
* GcpObservability: Code for reading config from env var
* Comments
* Fix deps
* clang-tidy
2022-09-09 15:14:15 -07:00
a644d8c9b4
GcpObservabilityConfig: cloud_trace.sampling_rate ( #30904 )
2022-09-08 21:43:47 -07:00
260a02d1ad
Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure"" ( #30894 )
...
* Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure (#30866 )" (#30892 )"
This reverts commit 37b631d1fd
2022-09-08 13:43:37 -07:00
37b631d1fd
Revert "GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )" ( #30892 )
...
This reverts commit 31c68b5f10
2022-09-07 20:20:44 -07:00
31c68b5f10
GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )
...
* GcpObservabilityConfig: Add some basic field parsing structure
* IWYU
* clang format
2022-09-07 15:27:23 -07:00
fed6c180e9
[census] Add time scaling to test ( #30851 )
2022-09-06 08:40:39 -07:00
60a1b4ad6f
Revert "Revert "GCP Observability: Add plugin registry API"" ( #30766 )
...
* Revert "Revert "GCP Observability: Add plugin registry API (#30571 )" (#30765 )"
This reverts commit b8fde2ab47
2022-08-29 17:22:03 -07:00
b8fde2ab47
Revert "GCP Observability: Add plugin registry API ( #30571 )" ( #30765 )
...
This reverts commit 486710317f
2022-08-26 09:42:19 -07:00
486710317f
GCP Observability: Add plugin registry API ( #30571 )
...
* GCP Observability: Add plugin registry API
* Restrict visibility for now
* Move GcpObservability to its own thing
* Reviewer comments
2022-08-26 09:22:48 -07:00
f573fd44f9
[test] Semi-automatic flaky test tracking ( #30638 )
...
* [test] Semi-automatic flaky test tracking
* fix
* Automated change: Fix sanity tests
* Update update_flakes.py
* fix formatting
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-19 16:22:31 -07:00
3c9cbb2d4d
OpenCensus: fixes broken traces exporting caused by a missing EndSpan ( #29745 )
...
* OpenCensus: fixes broken traces exporting caused by a missing EndSpan
* Fix variable name
* Fixes test.
* Adds timeout to span test
2022-08-10 17:18:21 -07:00
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
eded3b6bc3
client channel: record call completion even if recv_trailing_metadata was not started ( #29198 )
...
* client channel: record call completion even if recv_trailing_metadata was not started
* add test
* add test for opencensus filter
* remove unnecessary code
2022-03-24 14:22:16 -07:00
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
2022-02-17 17:56:19 -08:00
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
6bf8e22484
Add http cancel api ( #28354 )
...
Add an API to cancel HTTP1 requests
2022-01-25 10:37:05 -08:00
1050eedb87
enable clang-tidy readability-static-definition-in-anonymous-namespace check ( #28033 )
2021-11-17 07:48:43 -08:00
468768865b
Make Buildifier Sanity Test Strict ( #27807 )
...
* Fix all lint errors in repo.
* Use strict buildifier by default
* Whoops. That file does not exist
* Attempt fix to buildifier invocation
* Add missing copyright
2021-11-03 14:57:04 -07:00
d1e01ac139
Add a test for a (now-illegal) build file construct ( #27602 )
...
* Add a test for a (now-illegal) build file construct
* add to test suite!
* fix
* fix
* fix syntax
2021-10-06 07:43:59 -07:00
969f3d55ef
Check that grpc_package statements have the right name ( #27608 )
...
* named-right
* Update check_package_name.py
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-10-05 23:01:11 -07:00
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
2021-09-02 11:42:33 -07:00
9e4c657fa3
C++ opencensus filter: Fix point of creating context for overall call ( #27221 )
2021-09-01 18:37:53 -07:00
a3d264e8fd
Open census filter stats api ( #26739 )
...
* Use new stats API in open census filter
* Fix time and latency calculation
* Fix parent census context
* Add tests
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Fix error unref
* Add a context object for the overall call
* Remove TODO
* Reviewer comments
2021-08-02 14:00:15 -07:00
9bd7c4917a
Fix unused-parameter warning
2021-01-19 18:18:09 -08:00
75e3e660fd
Fix google-readability-todo
2020-11-25 10:09:42 -08:00
8456e2138a
Check localhost is resolved to ipv4 or ipv6 and update test accordingly.
2020-10-23 14:38:36 -07:00
aae4f4cf18
Fix by misc-unused-using-decls
2020-10-19 18:12:11 -07:00
e7434d385e
Fix by tidy-modernize-use-override
2020-10-16 14:01:06 -07:00
2e958cf01b
(Census client filter: use current span and tags. original_author=g-easy)
2019-12-04 09:47:18 -08:00
c34bef4ca4
Format all Bazel files with buildifier
2019-11-05 14:03:52 -08:00
5cc45de443
disable some broken test on windows RBE
2019-09-30 13:28:02 +02:00
43628b286f
Update googletest version to v1.8.1
...
Bazel builds of test/cpp/end2end:end2end_test were failing on Mac OS with v1.8.0 due to missing gtest symbols. The issue is not seen in v1.8.1. A WORKSPACE file was added to gtest repo in 1.8.1, so gtest.BUILD can be removed.
2019-06-20 18:17:13 -07:00
9a41671cb1
Remove grpc:: from API to ensure general availability
2019-03-21 14:22:06 -07:00
f570c5ce7e
Make changes for making opencensus API visible from gRPC namespace
2019-03-15 11:43:28 -07:00
f66b654795
Revert "Revert "Fold opencensus into grpc_impl namespace""
2019-03-15 11:30:23 -07:00
2bf934f97d
Revert "Fold opencensus into grpc_impl namespace"
2019-03-15 10:20:06 -07:00
b606cad6cc
Fold opencensus into grpc_impl namespace
...
Moving opencensus into grpc_impl namespace..
2019-03-04 15:47:37 -08:00
67742ef63f
Fix BUILD files. Manually edit bzl files
2018-12-06 14:37:52 -08:00
e75fc243da
change tests to use the new class instead of grpc_test_init
2018-11-30 08:57:38 -08:00
95393cf530
Fixed opencensus benchmark to be compliant with grpc benchmarks.
2018-05-10 13:26:23 -07:00
41e4cedb70
Adding opencensus grpc plugin.
...
Rebasing to merge commits.
2018-05-10 11:41:15 -07:00
Yash Tibrewal