Commit Graph

5450 Commits

Author SHA1 Message Date
Mark D. Roth 34b00a243c
Merge pull request #19028 from markdroth/service_config_cleanup
Clean up some names in the service config code.
2019-05-15 14:31:39 -07:00
Mark D. Roth 356e7c2107 Clean up some names in the service config code. 2019-05-15 07:57:03 -07:00
Alexander Polcyn 236ae12bb1 Revert "Config migration"
This reverts commit 87905ae5ea.
2019-05-14 14:36:33 -07:00
Soheil Hassas Yeganeh 801eed8387
Merge pull request #18926 from soheilhy/slicebuffer-first
Introduce slice_buffer helper methods to avoid copies.
2019-05-14 13:39:17 -04:00
Yash Tibrewal aa89a97531
Merge pull request #18946 from yashykt/svccfgerrortransient
Service Config Changes to set channel in transient failure on invalid service config
2019-05-10 06:14:44 -07:00
Esun Kim 87905ae5ea Config migration 2019-05-09 12:29:38 -07:00
Yash Tibrewal dfa45cb7ac Merge branch 'master' into svccfgerrortransient 2019-05-08 16:44:33 -07:00
apolcyn 9278411207
Merge pull request #17688 from apolcyn/ares_timeouts
Add a backup poller to c-ares resolver to take better advantage of c-ares query timeout/retry logic
2019-05-08 16:16:12 -07:00
Alexander Polcyn 2a4d62819b Revise c-ares timeouts to use c-ares's internal timeout/retry logic 2019-05-08 09:57:39 -07:00
Yash Tibrewal 02bd17ff15 cleanup 2019-05-08 03:46:48 -07:00
Yash Tibrewal 6cba63eb47 reviewer comments and tests 2019-05-08 03:36:37 -07:00
Alexander Polcyn d5fb6da369 Revert "Use aligned_alloc directly for grpc_core::Arena"
This reverts commit 333ba8feae.
2019-05-06 15:24:21 -07:00
Alexander Polcyn cb966a4e5e Revert "Renamed macros for memory alignment"
This reverts commit a3fe7c0c90.
2019-05-06 15:24:09 -07:00
Yash Tibrewal 587ae4a2d9 Fix existing tests 2019-05-03 15:40:39 -07:00
Soheil Hassas Yeganeh 1f0476267b Add a better comment and rename consume_first to remove_first. 2019-05-02 14:07:06 -04:00
Esun Kim ccf4734907
Merge pull request #18799 from veblush/config
New config system & migration sample
2019-05-01 09:01:35 -07:00
Soheil Hassas Yeganeh 4c0c2965fe Use peek_first instead of mutable_first.
Use DEBUG_ASSERT instead of ASSERT.
2019-04-30 22:20:06 -04:00
Esun Kim 1518ecbd76 Added new configuration system to core/grp.
More generic configuration system is introduced in order to i) unify the
way how modules access the configurations instead of using low-level
get/setenv functions and ii) enable the customization for where configuration
is stored. This could be extended to support flag, file, etc.

Default configuration system uses environment variables as before so
basically this is expected to work just as it did. This behavior can
change by redefining GPR_GLOBAL_CONFIG_DEFINE_*type* macros.

* Migrated configuration

GRPC_CLIENT_CHANNEL_BACKUP_POLL_INTERVAL_MS
GRPC_EXPERIMENTAL_DISABLE_FLOW_CONTROL
GRPC_ABORT_ON_LEAKS
GRPC_NOT_USE_SYSTEM_SSL_ROOTS
2019-04-30 15:49:24 -07:00
Soheil Hassas Yeganeh fd5f787080 Introduce slice_buffer helper methods to avoid copies.
take_first(), grpc_undo_first(), ... are very clostly
methods that unnecessarily copy grpc_slice with extra
ref counting requirements.

Introduce alternatives to avoid copies and refs wherever
possible.

This results in 1% improvements in the benchmarks.
2019-04-30 18:38:29 -04:00
Arjun Roy a3fe7c0c90 Renamed macros for memory alignment 2019-04-29 15:38:41 -07:00
Arjun Roy 333ba8feae Use aligned_alloc directly for grpc_core::Arena 2019-04-29 15:37:17 -07:00
yang-g 5e7e494638 Use milliseconds for test_server timeout 2019-04-29 12:26:50 -07:00
Yash Tibrewal b476a30e69 Merge branch 'master' into svc_cfg2 2019-04-26 11:43:12 -07:00
Yash Tibrewal a2cea50402
Merge pull request #18874 from yashykt/atleast
s/atleast/at\ least
2019-04-26 10:46:51 -07:00
Arjun Roy 887ef819a7
Merge pull request #18857 from arjunroy/memset_remove
Removed some unnecessary memset operations in core.
2019-04-25 17:34:00 -07:00
Yash Tibrewal 9345b7e276 s/atleast/at\ least 2019-04-25 17:15:30 -07:00
Yash Tibrewal 156d743c37 Reviewer comments 2019-04-25 16:38:10 -07:00
Arjun Roy cf9301f964 Removed some unnecessary memset operations in core. 2019-04-25 13:59:10 -07:00
Yang Gao ad4f805692
Merge pull request #18853 from yang-g/init_test
Stop calling ParseCommandLineFlags directly, use wrapper call instead
2019-04-24 23:33:41 -07:00
Yash Tibrewal f7c8e8be62 clang tidy 2019-04-24 16:51:59 -07:00
Arjun Roy 8ce42f67b2 Shrink arena size by 40 bytes and add additional
alignment options (for cache-alignment).

We shrink by:
1) Removing an unnecessary zone pointer.
2) Replacing gpr_mu (40 bytes when using pthread_mutex_t) with
std::atomic_flag.

We also header-inline the fastpath alloc (ie. when not doing a zone
alloc) and move the malloc() for a zone alloc outside of the mutex
critical zone, which allows us to replace the mutex with a spinlock.

We also cache-align created arenas.
2019-04-24 16:39:03 -07:00
Yash Tibrewal a045170818 Merge branch 'master' into svc_cfg2 2019-04-24 15:45:16 -07:00
Yash Tibrewal a2316142b2 Reviewer comments 2019-04-24 15:29:46 -07:00
yang-g 37783d6329 Stop calling ParseCommandLineFlags directly, use wrapper call instead 2019-04-24 10:09:39 -07:00
Yash Tibrewal 4309a98b66 Health checking service name to be passed as a channel arg for now 2019-04-22 21:18:47 -07:00
Yash Tibrewal 70839d966f Reviewer comments 2019-04-22 19:12:11 -07:00
Yash Tibrewal a4036b2d8c Add tests for health check parsing too 2019-04-19 14:34:37 -07:00
Arjun Roy 7d946633ea grpc_slice_refcount devirtualization 2019-04-19 12:20:26 -07:00
Yash Tibrewal c3ae72c089 Merge branch 'master' into svc_cfg2 2019-04-19 00:43:32 -07:00
Yash Tibrewal 576828696a Add parsing tests 2019-04-18 23:57:10 -07:00
Yash Tibrewal 116ce0fb24 Use health check parser 2019-04-18 23:57:10 -07:00
Yash Tibrewal 813865acaf Adding service config parser 2019-04-18 23:56:40 -07:00
Yihua Zhang ef4508ca0d fix memory leaks in ssl credential reload. 2019-04-16 11:09:30 -07:00
Mark D. Roth 62d9be1533
Merge pull request #18631 from markdroth/pare_down_channel_args_api
Move functions for individual args out of channel_args.{h,cc}.
2019-04-16 07:11:33 -07:00
Mark D. Roth 63777c714f
Merge pull request #18628 from markdroth/remove_error_from_connectivity_state_tracker
Remove error from connectivity state tracking.
2019-04-15 14:05:25 -07:00
Mark D. Roth 432c97e1ba Remove error from connectivity state tracking. 2019-04-15 13:14:19 -07:00
Vijay Pai ec06d677e2
Merge pull request #16681 from arrowd/master
Fix various tests on FreeBSD.
2019-04-10 14:16:36 -07:00
Yash Tibrewal aa908cdd8d
Merge pull request #18556 from yashykt/unixpath
Explicitly call getsockname after accept for unix sockets to get the sun_path
2019-04-09 15:04:52 -07:00
Yash Tibrewal 3d0788a242
Merge pull request #18586 from yashykt/svc_cfg1
Global Registry for Service Config Parsers
2019-04-09 14:54:59 -07:00
Yash Tibrewal ab29cdd28e Add test 2019-04-09 12:50:39 -07:00