Commit Graph

459 Commits

Author SHA1 Message Date
Karthik Ravi Shankar 11c54ada0d
Revert "Fix StartCall: make corking work and allow concurrent Start*" 2020-06-02 11:11:06 -07:00
Jacob Dlougach 35ab5bc616
Include <memory> for std::unique_ptr
Currently `#include <grpcpp/support/interceptor.h>` in some compilers (gcc 8, for example) will fail due to missing `<memory>` include. This PR fixes this issue.
2020-05-21 14:17:45 +01:00
Vijay Pai 899cbcab96 Fix StartCall: make corking work and allow concurrent Start* 2020-05-20 10:02:22 -07:00
Yash Tibrewal 8051d956af
Merge pull request #22429 from pavelsimo/patch-1
Fix typo in CallOpSet comments
2020-05-08 06:35:33 -07:00
Yash Tibrewal 6a6481cb83 Reviewer comments 2020-04-30 15:44:48 -07:00
Yash Tibrewal e714d0fcb8 Reviewer comments 2020-04-28 13:24:23 -07:00
Yash Tibrewal edbae5d8e6 Fix interceptor batch method FailHijackedRecvMessage for async APIs 2020-04-22 23:05:57 -07:00
Vijay Pai 397b3ee72e
Do a debug-check of API use 2020-03-31 16:03:44 -07:00
Vijay Pai 03fffe0fcb
Document that AddMultipleHolds argument must be positive 2020-03-31 13:42:32 -07:00
Vijay Pai ee3952f72b
Merge pull request #22483 from vjpai/lambdify
Remove all std::mem_fn and std::bind from service definitions and setup
2020-03-26 23:52:06 -07:00
Kislay Kishore bf3954c8cc
Fix typo
clinet -> client
2020-03-26 09:45:11 +05:30
Vijay Pai c86cfc305c Remove all std::mem_fn and std::bind from service definitions and setup 2020-03-25 16:48:36 -07:00
Pavel Simó b91d433ba4
Fix typo 2020-03-20 14:13:51 +01:00
Vijay Pai 33f4b8336e Add useful comments 2020-03-17 14:29:34 -07:00
Esun Kim 415d41f9e8 Rerun clang-formatter-7 2020-03-03 10:46:55 -08:00
Vijay Pai e859aa8169
Update server_callback_impl.h 2020-02-27 14:16:25 -08:00
Vijay Pai 3620abf059 Properly follow precise conditions for callback inlining 2020-02-20 01:34:30 +00:00
Yash Tibrewal 820ee53030
Merge pull request #22000 from yashykt/unusedparams
Remove some unused parameter warnings
2020-02-13 16:23:19 -08:00
Esun Kim aa666f4b76
Merge pull request #21996 from veblush/deadline-catch
Delete default TimePoint constructor to detect error at compile time
2020-02-13 12:34:15 -08:00
Esun Kim cf618b1b8c Removed unused sync_[no]_cxx11 files 2020-02-13 09:26:51 -08:00
Esun Kim fd72a70e7d Update by review 2020-02-13 09:11:51 -08:00
Yash Tibrewal 4a02ff7747 Remove some unused parameter warnings 2020-02-12 17:56:34 -08:00
Esun Kim 89908faede Delete default TimePoint constructor to detect error at compile time 2020-02-12 12:20:36 -08:00
Vijay Pai 06ca713df0 Instantiate tracking members regardless of NDEBUG 2020-02-11 13:54:25 -08:00
Vijay Pai 6b2aeec9f3 Revert "Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""" 2020-02-11 13:50:53 -08:00
Nicolas Noble de76cf8522
Stop using ByteSize as it's deprecated.
Fixes #21603
2020-01-29 10:46:19 -08:00
Lidi Zheng 312b31c264
Merge pull request #21806 from grpc/revert-21767-revert-21725-revert-21680-cq_ordering
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""
2020-01-27 16:34:45 -08:00
Lidi Zheng cd086cb3e4
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)""" 2020-01-27 14:10:44 -08:00
Vijay Pai a801ccbdc8 Reinterpret_cast after in-place new... 2020-01-24 12:25:51 -08:00
Vijay Pai 1f0cdd5aad Construct DefaultReactor lazily since not always needed 2020-01-23 08:52:21 -08:00
Vijay Pai 16f2250585 Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"" 2020-01-22 21:58:35 -08:00
Vijay Pai 64281e8c79 Clarify ownership in comments 2020-01-21 10:45:04 -08:00
Jan Tattermusch e7d5ca0b46
Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)" 2020-01-20 14:42:29 +01:00
Vijay Pai 6466c7f166 Log an error (in dbg mode) if CQ is Shutdown before its Server(s) 2020-01-16 11:51:44 -08:00
Vijay Pai 2f0362ee3a
Remove unused (and defective) constructor 2020-01-05 16:27:30 -08:00
Vijay Pai 4062025312 Check for negative on NextMessageSize 2019-12-18 22:20:31 -08:00
Vijay Pai c758bf9571 clang-fmt 2019-12-16 13:43:55 -08:00
Vijay Pai bffc5701e6 Fix cancellation 2019-12-16 13:39:21 -08:00
Vijay Pai 377a32c0ce
Merge pull request #21443 from vjpai/fix_bug_21210
Move operations out of lock in Bind functions
2019-12-11 21:48:36 -08:00
Vijay Pai 19404f516c
Merge pull request #21405 from vjpai/deexperimentalize_codegen
De-experimentalize generated callback code
2019-12-11 18:50:13 -08:00
Vijay Pai d82b3124fe Move operations out of lock in Bind functions 2019-12-11 16:34:46 -08:00
Vijay Pai 8d9d8326f5 De-experimentalize generated code 2019-12-11 16:21:23 -08:00
Esun Kim 169e775958
Revert "Generic API: assert when sending uninitialized byte buffer" 2019-12-11 12:58:34 -08:00
Hope Casey-Allen 89e5c2f45a Add assert for API misuse 2019-12-06 14:45:00 -08:00
Vijay Pai 62e01dd922 Add non-experimental:: versions under ifdef 2019-12-04 06:27:41 -08:00
Vijay Pai 1c5aa3c0ad Remove namespace experimental here also 2019-12-03 21:37:55 -08:00
Vijay Pai eac7b5ee49 port_platform should be included since that's where NONEXPERIMENTAL is specified 2019-12-03 20:20:39 -08:00
Vijay Pai 2c87eaabd4 De-experimentalize generic features of callback API under an ifdef 2019-12-03 12:24:13 -08:00
Vijay Pai 94a8c5888a Remove namespace experimental from namespace grpc_impl 2019-12-02 15:36:05 -08:00
Yash Tibrewal b4d6916552
Merge pull request #20567 from yashykt/docupdate
Stronger guarantee on failure of read/write operations
2019-11-25 11:59:10 -08:00