Commit Graph

34 Commits

Author SHA1 Message Date
Craig Tiller c0473cc823 Merge github.com:grpc/grpc into compress 2016-02-11 08:51:16 -08:00
David Garcia Quintas 26a9848416 Removed outdated mention of AsynchronousService 2016-02-11 00:45:00 -08:00
David Garcia Quintas ab5da5ef7a Added missing codegen includes 2016-02-09 20:31:37 -08:00
Vijay Pai 30bf3ea4b9 clang-format 2016-02-08 13:21:07 -08:00
Vijay Pai c593ca0171 reset the shared_ptr 2016-02-08 11:38:42 -08:00
Vijay Pai bedf57fe8c Ref the collection only when it will be used (and later finalized) 2016-02-05 16:45:54 -08:00
Vijay Pai 2b5638668e Drop the ref 2016-02-05 15:11:36 -08:00
Vijay Pai 5506bea349 Undo much of the previous commits so that only CallOpSet groups
with a Sneaky member are in a collection.
2016-02-05 14:23:24 -08:00
Vijay Pai 7e3f9b0178 Forgot to include these edits in the last commit 2016-02-05 13:43:17 -08:00
Vijay Pai 38004a8e39 Wrap groups of related CallOpSet's into a ref-counted structure
whenever appropriate so as to avoid any unintentional free-before-use
problems.

Potential performance issue: this triggers an additional allocation
for each Async call initiation, along with the cost of ref-counting
shared_ptr . But this is worth it for the additional safety provided
here without any change to the exposed C++ API.
2016-02-05 13:40:22 -08:00
Craig Tiller 97cb41cfaf Merge github.com:grpc/grpc into compress 2016-02-05 10:44:56 -08:00
Craig Tiller a44cbfc11c Fix race condition in transport API
Specifically:

Receiving trailing and initial metadata had to be published in
lock-step.
=> If we wanted trailing metadata, we might not get initial metadata processed
   until messages arrived.
=> Compression code had no idea what codec to use.

To fix it, publish initial metadata as soon as it's ready (this is a
transport API change).

Requires changes to grpc_call to ensure ordering in processing initial
metadata and messages (one may be delayed).

Exposed at least some bugs in C++ where we never read initial metadata.

I expect at least one more similar bug.
2016-02-03 16:02:49 -08:00
Sree Kuchibhotla 3075c81028 Update comment on TryCancel() API 2016-01-29 18:25:22 -08:00
Sree Kuchibhotla f25c6ba229 Comments and format 2016-01-28 18:04:03 -08:00
Sree Kuchibhotla 7fa9d6f4c8 TryCancel() on ServerContext() 2016-01-28 17:32:48 -08:00
David Garcia Quintas 6523391782 sanity fixes 2016-01-27 20:07:36 -08:00
David Garcia Quintas b4e51b52bd Merge branch 'master' of github.com:grpc/grpc into sync-async-plus-interfaces 2016-01-27 19:57:58 -08:00
David Garcia Quintas 5a9462339d copyrights 2016-01-27 19:22:14 -08:00
David Garcia Quintas 6bd7b97dc6 DONE!!1one 2016-01-27 19:21:12 -08:00
David Garcia Quintas e1300deb87 After GrpcLibrary refactoring. Compiles and passes. WIP still 2016-01-27 18:41:26 -08:00
David Garcia Quintas 6a48405ed0 pre sync_stream.cc creation. Does not compile 2016-01-25 19:12:37 -08:00
David Garcia Quintas b523c732d1 async_stream.h done. Compiles 2016-01-25 18:22:28 -08:00
David Garcia Quintas 3452ae27c1 copyrights 2016-01-25 17:34:49 -08:00
David Garcia Quintas 2425bbbc55 Further work. Compiles. WIP 2016-01-25 17:32:48 -08:00
David Garcia Quintas ddcb53a9de made codegen targets in build.yaml 2016-01-21 17:48:34 -08:00
David Garcia Quintas 1d9b8079cb clang-format 2016-01-21 10:08:22 -08:00
David Garcia Quintas a43aadd7e1 fixed copyrights 2016-01-21 10:01:28 -08:00
David Garcia Quintas 08a0a3306e Made "codedgen" directories closed over #includes 2016-01-21 01:04:36 -08:00
David Garcia Quintas f3ddb7c55a clang-format 2016-01-20 16:02:22 -08:00
David Garcia Quintas 6190854157 updated copyrights 2016-01-20 11:21:27 -08:00
David Garcia Quintas a701ed7759 Merge branch 'proto_interfaces' into yang-g-sync_async_mix 2016-01-19 18:44:47 -08:00
David Garcia Quintas 1f4e72c19c override -> GRPC_OVERRIDE 2016-01-19 14:45:32 -08:00
David Garcia Quintas 44f3249018 Introduced ServerInterface 2016-01-15 16:49:16 -08:00
David Garcia Quintas e50c6c2f5e WIP. Added ChannelInterface 2016-01-13 16:02:00 -08:00