Commit Graph

56 Commits

Author SHA1 Message Date
Tanvi Jagtap 986428d252 [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36636)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping

1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :

1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

Closes #36636

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36636 from tanvi-jagtap:regex_test_cpp f2cac9c5a4
PiperOrigin-RevId: 634954173
2024-05-17 20:10:09 -07:00
Mark D. Roth 0944410d6c [reorg] move test/core/util -> test/core/test_util (#36446)
Closes #36446

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test 5dcc85e006
PiperOrigin-RevId: 629229220
2024-04-29 17:06:40 -07:00
Tanvi Jagtap de9bdf7f8e [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36269)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK

Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only a few - which fit into single - line regex will be changed. This would be small in number just to reduce the load later.

Replacing CHECK with CHECK_EQ , CHECK_NE etc could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36269

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36269 from tanvi-jagtap:tjagtap_gpr_assert_qps 26dcf74e27
PiperOrigin-RevId: 623504407
2024-04-10 08:41:23 -07:00
Craig Tiller 67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); (#31757)
* crash function

* progress

* fix

* fix

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fixes

* Automated change: Fix sanity tests

* fix

* Automated change: Fix sanity tests

* fix

* fix

* use cpp attr

* Automated change: Fix sanity tests

* fix

* fix

* fix

* fix

* fix

* fix

* add exclusion

* fix

* typo

* fix

* fmt

* Update tcp_socket_utils.cc

* Automated change: Fix sanity tests

* fix

* revert php changes

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-11 08:50:32 -08:00
Yijie Ma f99b8b5bc4
Convert c-style comments to C++-style comments (#31923)
* baseline

* fix clang-tidy

* manually revert these files

* manually fixup at eof

* revert 2 more files

* change check_deprecated_grpc++.py

* change end2end_defs.include template

* fix check_include_guards.py

* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py

not yet ready to be submitted

* fix

yapf check_include_guards.py
remove a space...

* fix version.cc.template

* fix version_info.h.template
2022-12-22 23:01:53 -08:00
Esun Kim f3fedae7c8
Added readability-redundant-string-cstr (#31707)
* Added readability-redundant-string-cstr

* Auto fix

* No need to wrap std::string
2022-11-18 17:12:46 -08:00
AJ Heller 18a8f6aad9
Refactor end2end tests to exercise each EventEngine (#29202)
* Refactor end2end tests to exercise each EventEngine

* fix incorrect bazel_only exclusions

* Automated change: Fix sanity tests

* microbenchmark fix

* sanitize, fix iOS flub

* Automated change: Fix sanity tests

* iOS fix

* reviewer feedback

* first pass at excluding EventEngine test expansion

Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.

* end2end fuzzers to be fuzzed differently via EventEngine.

* sanitize

* reviewer feedback

* remove misleading comment

* reviewer feedback: comments

* EE test_init needs to play with our build system

* fix golden file test runner

Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-03-30 15:43:05 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim ece76ee1e8 Fix code by readability-container-size-empty 2020-10-16 09:48:20 -07:00
Esun Kim 3e7d5976b5 Add TestEnvironment to tests 2020-07-30 11:06:52 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
ncteisen d3631f9c79 fix clang tidy 2018-11-26 06:11:30 -05:00
Alexander Polcyn d9dbb76969 Allow specifying specific credential types to reach specific works in QPS benchmark driver 2018-11-21 10:13:10 -08:00
Hope Casey-Allen e360d82216 Clang tidy 2018-08-25 19:31:00 -07:00
Hope Casey-Allen 839a0520a2 Add an option to collect medians every epoch. Useful for gathering per second median latencies 2018-08-25 18:33:11 -07:00
Vijay Pai c90a85649b Change grpc++ references in names to grpcpp 2018-03-08 22:04:59 -08:00
Craig Tiller 4ac2b8e585 Enable clang-tidy as a sanity check, fix up all known failures 2017-11-10 14:14:17 -08:00
Vijay Pai 088112fea1 Create inproc version of QPS test and add a few simple tests of this to standard testing suite. 2017-10-19 14:29:13 -07:00
Guantao Liu ac9fdfbc40 Removed unnecessary default values and fixed sanity. 2017-07-14 17:33:19 -07:00
Guantao Liu abe3cf51f0 Add a new metric 'Queries/CPU-sec'.
Enable internal credential types.
2017-07-12 17:36:30 -07:00
ncteisen dc1b51e6b3 clang fmt 2017-06-19 09:00:25 -07:00
ncteisen 24e820762a Add json out flag to qps driver 2017-06-19 07:36:51 -07:00
Jan Tattermusch 7897ae9308 auto-fix most of licenses 2017-06-08 11:22:41 +02:00
Yuxuan Li 999ac157e6 initial implementation. 2017-05-03 21:36:36 -07:00
Nicolas "Pixel" Noble 6f7dcd0ade Clang-format. 2017-03-27 18:51:55 +02:00
Nicolas "Pixel" Noble b02dd01584 Fixing qps & benchmark. 2017-03-24 21:56:51 +01:00
yang-g 90f43d4fa4 add missing header 2017-03-14 10:58:44 -07:00
apolcyn 44e907af0e Merge pull request #9322 from apolcyn/deprecate_benchmark_core_lists
Don't configure core lists in in benchmark driver
2017-01-17 17:30:41 -08:00
Alexander Polcyn 62a7ca8c95 re-run clang-format.sh 2017-01-12 11:32:15 -08:00
Alexander Polcyn a6e796f58f ignore core counts and core lists in qps json driver 2017-01-11 13:49:43 -08:00
Yuxuan Li ac87a46225 enable uploading server cpu usage data from performance tests to big query 2017-01-11 10:01:16 +00:00
Alexander Polcyn 4873d30ea2 allow disable core_list setting and override qps server in benchmarks 2016-12-20 19:24:43 -08:00
Yuxuan Li c9ca0a9e70 clang-format for recently changed files. merged upstream master 2016-10-28 14:08:36 -07:00
Yuxuan Li 60d55f80c4 Change flag precision to flag stride, better description.
Add flag error_tolerence to define the search stopping criteria.
Move the equal condition in the binary search to smaller than condition.
Wrap get_cpu_usage(), so on non-linux platform, the compiler won't
complain and will get cpu usage to be 0.
2016-10-21 18:18:29 -07:00
Yuxuan Li c6c6cc269e change default values flags 2016-10-06 18:28:05 -07:00
Yuxuan Li 69c61319df change flags type, name according to the comments.
change binary search stride from 1 to FLAGS_precision
2016-10-06 17:00:48 -07:00
Yuxuan Li 77c18981c2 change binary search log info from GPR_INFO to GPR_DEBUG 2016-10-06 15:06:29 -07:00
Yuxuan Li c265a0ab02 clean up unnecessary new lines and logging. 2016-10-06 15:06:22 -07:00
Yuxuan Li 49aeb59389 clang-formated and latency_vs_load.cc is deleted as its functionality
has been merged into qps_json_driver.
2016-10-06 15:06:01 -07:00
Yuxuan Li d31c78c6f0 updated protobuf, merged latency_vs_load.cc(not deleted yet) and qps_json_driver.cc 2016-10-06 15:05:55 -07:00
Yuxuan Li 58977f1466 initial merge of latency vs load to qps_json_driver.cc 2016-10-06 15:05:50 -07:00
Yuxuan Li fe21ec90f6 batched changes 2016-10-06 15:05:29 -07:00
Vijay Pai ceb1a7d79f Add more information so that we can have a meaningful exit code 2016-07-07 11:06:04 -07:00
yang-g 17487f9a22 Make grpc++ independent of protobuf 2016-06-03 15:21:15 -07:00
Nicolas Noble 241dea56c8 Merge pull request #6147 from ctiller/strong-includes
Rollup of changes from latest import
2016-04-21 18:59:06 -07:00
Craig Tiller 7beea147e5 Merge github.com:grpc/grpc into strong-includes 2016-04-21 17:07:36 -07:00
Vijay Pai dfdfe26958 Make sure that there is at least one scenario, otherwise indicates malformed
input
2016-04-21 11:38:31 -07:00