befeeba0f5
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log ( #36594 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)
Reviewers need to check :
1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.
Closes #36594
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36594 from tanvi-jagtap:regex_src_cpp d9c21d6456
2024-05-14 19:17:38 -07:00
b72d31845e
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT ( #36453 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK.
These changes have been made using string replacement and regex.
Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced.
Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36453
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36453 from tanvi-jagtap:tjagtap_ruby 5442361454
2024-05-02 23:36:24 -07:00
bae0c705aa
[Deps] Update to Clang-16 ( #34492 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2023-10-11 16:26:32 -07:00
905df9dee6
Update Abseil to 20230125 ( #32139 )
...
* Update abseil to 1.20230125.0
* Fix IWYU
2023-01-30 16:20:24 -08:00
aa11978541
Fix include guards for src/ and test/ directories ( #32167 )
...
* Fix include guards for src/ and test/ directories
* Sanity
* Update new files
2023-01-20 16:27:27 -08:00
67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); ( #31757 )
...
* crash function
* progress
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* fix
* use cpp attr
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* add exclusion
* fix
* typo
* fix
* fmt
* Update tcp_socket_utils.cc
* Automated change: Fix sanity tests
* fix
* revert php changes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2023-01-11 08:50:32 -08:00
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2022-12-22 23:01:53 -08:00
0f9d024fec
[iwyu] c++ ( #29721 )
...
* Revert "Revert "[iwyu] grpc++ (#29610 )" (#29720 )"
This reverts commit 0642bc213d
2022-05-19 07:34:48 -07:00
0642bc213d
Revert "[iwyu] grpc++ ( #29610 )" ( #29720 )
...
This reverts commit c8159eabdf
2022-05-18 09:58:08 -07:00
c8159eabdf
[iwyu] grpc++ ( #29610 )
...
* [iwyu] grpc++
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* [iwyu] Better script
* eliminate race
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-18 07:16:53 -07:00
672f31c6ac
Channel args preconditioning ( #28132 )
...
* Channel args preconditioning
* docs
* fixes
* Automated change: Fix sanity tests
* fix
* fix this again after merge error
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-22 15:24:39 -08:00
a629c9a03e
Reland resource quota work ( #28017 )
...
* Check if memory owner available prior to polling it
The transport may drop the memory owner during its destruction sequence
* tcp_fix
* Revert "Revert "New resource quota integration (#27643 )" (#28014 )"
This reverts commit 0ea2c37263
2021-11-15 08:23:51 -08:00
0ea2c37263
Revert "New resource quota integration ( #27643 )" ( #28014 )
...
This reverts commit 39f0877d25
2021-11-11 14:26:19 -08:00
39f0877d25
New resource quota integration ( #27643 )
...
* new resource quota integration
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fix
* fixes
* windows-fix
* fixes
* fixes
* fix
* fix-asan
* banned
* banned
* fixes
* clang-tidy-fix
* Automated change: Fix sanity tests
* fix-cronet
* review feedback
* review feedback
* Automated change: Fix sanity tests
* fixes
* bug fix
* fixes
* compile fix
* exclude megabyte size payloads from 1byte tests
* windows fix
* start moving ios
* keep moving windows
* Get windows compilation working.
* Automated change: Fix sanity tests
* better
* fixes
* remove slice buffer from memory_allocator.h
* Revert "remove slice buffer from memory_allocator.h"
This reverts commit 234a63b6e3
2021-11-10 22:53:04 -08:00
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
f84f3a7522
Fix potential nullptr names in resource_user/slice_allocator creation ( #27154 )
...
absl::string_view permits construction with nullptr, which yields UB.
This PR fixes all call sites that could have created these objects with
nullptr names.
2021-08-26 19:30:07 -07:00
1835f00ef1
Revert "Revert "Made grpc_core::Mutex compatible to absl::Mutex" ( #25537 )" ( #25549 )
...
This reverts commit 8e268dcec8
2021-02-24 16:49:34 -08:00
8e268dcec8
Revert "Made grpc_core::Mutex compatible to absl::Mutex" ( #25537 )
...
* Revert "Made grpc_core::Mutex compatible to absl::Mutex"
This reverts commit 0b53341328#25486 )"
This reverts commit 9d897cb1a56d8e7d3819
2021-02-24 10:32:49 -08:00
0b53341328
Made grpc_core::Mutex compatible to absl::Mutex
2021-02-10 09:56:55 -08:00
6dc1748f6c
Revert "Made grpc_core::Mutex compatible to absl::Mutex"
2021-02-10 07:53:02 -08:00
6a1518bd22
Made grpc_core::Mutex compatible to absl::Mutex
2021-02-08 16:15:53 -08:00
53ab235fb8
Fix google-explicit-constructor
2020-12-03 15:03:39 -08:00
da7f82fa9c
Properly synchronize thread creation failure case
2020-09-23 10:12:16 -07:00
f40a702441
Clean up headers
2019-11-15 09:38:31 -08:00
a3689a8b6c
Properly handle race at thread creation
2019-10-25 12:35:20 -07:00
19a57f0f96
Revert "c++ check if workerthread could be spawned"
2019-10-25 11:18:03 -07:00
6e4d2e86dc
Merge pull request #20376 from chrisse74/master
...
c++ check if workerthread could be spawned
2019-10-16 23:38:38 -07:00
02c3bd6c2c
One more formatting change
2019-10-16 01:27:21 -07:00
f586be8532
Fix formatting
2019-10-16 01:14:05 -07:00
827fd04402
moved created() into header file
2019-10-16 08:30:37 +02:00
bbb66caa64
rename isCreated, make it inline const
2019-10-16 08:01:53 +02:00
64cdea5a07
fix some spelling mistakes in document
2019-10-04 09:07:35 +08:00
ed9ec64cea
Check if workerthread could be spawned
2019-09-26 09:21:56 +02:00
57cc401597
typo fix
2019-05-25 11:20:08 +08:00
2b9448a71c
Revert "Revert "Introduce C++ wrappers for gpr_mu and gpr_cv.""
...
This reverts commit d09c9f8e20
2019-04-17 14:35:29 -04:00
d09c9f8e20
Revert "Introduce C++ wrappers for gpr_mu and gpr_cv."
...
This reverts commit a26c09dd25
2019-04-11 16:52:54 -07:00
a26c09dd25
Introduce C++ wrappers for gpr_mu and gpr_cv.
...
Introduce RAII wrappers in the grpc::internal and grpc_core
namespaces, and use them in place of std::mutex and
std::condition_variable.
Note that, since std::mutex is also used by the public
C++ headers we cannot introduce these wrappers in grpc_core.
Also, note that in grpcpp we cannot use gRPC core and vice versa.
So we had to duplicate the code, once using core_codegen_interface
and once using direct calls.
2019-04-08 18:27:07 -04:00
9c32dab63d
Expand comment based on reviewer feedback
2018-08-15 14:46:51 -07:00
d9781df474
Address reviewer comments
2018-08-15 10:13:22 -07:00
14ad82a76d
Create a new method handler for resource exhaustion and tie into thread mgr
2018-08-14 16:23:21 -07:00
bdd13cb0ae
Revert "Revert "Restrict the number of threads in C++ sync server""
2018-08-01 11:22:40 -07:00
bea98c3c1b
Revert "Restrict the number of threads in C++ sync server"
2018-07-31 21:12:45 -07:00
6eac5e41b1
std::max is not available on some windows platforms
2018-07-27 17:23:02 -07:00
c2a22a1ab8
Address core review comments
2018-07-27 16:19:03 -07:00
b95772eeb9
Add Tests in Core and C++ and fix a few related bugs in thread_manager.cc
2018-07-24 16:35:25 -07:00
ec1c112cc1
Each ThreadManager is a resource user
2018-07-20 15:10:16 -07:00
809cf96c56
Name needs to only be alphanumeric+underscore+dash
2018-03-05 23:04:57 -08:00
7fed69b7ad
Use static_cast rather than reinterpret_cast whenever possible
2018-03-05 16:35:10 -08:00
162ae4f50c
Remove std::thread, keep everything else unchanged ( #13 )
2018-03-02 16:16:04 -08:00
0e00c43082
Move headers from grpc++ to grpcpp
2018-02-15 14:49:34 -08:00
Tanvi Jagtap