Commit Graph

577 Commits

Author SHA1 Message Date
AJ Heller e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) (#28901)" (#28916)
This reverts commit fc7314c701.
2022-02-17 17:56:19 -08:00
AJ Heller fc7314c701
Avoid fully qualifying namespaces (and add check) (#28901)
Based on a handful of https://abseil.io/tips, it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.

This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
Mohan Li 155aa95f82
Fix memory stomp error in the fallback test client (#28380)
* Fix memory stomp error in the fallback test client

* Fix memory stomp error in the fallback test client
2021-12-20 11:09:50 -08:00
Jan Tattermusch ce74e092e6
add --log_metadata_and_status feature to interop_client (#28021) 2021-11-23 15:32:13 -08:00
Richard Belleville 468768865b
Make Buildifier Sanity Test Strict (#27807)
* Fix all lint errors in repo.

* Use strict buildifier by default

* Whoops. That file does not exist

* Attempt fix to buildifier invocation

* Add missing copyright
2021-11-03 14:57:04 -07:00
Craig Tiller d1e01ac139
Add a test for a (now-illegal) build file construct (#27602)
* Add a test for a (now-illegal) build file construct

* add to test suite!

* fix

* fix

* fix syntax
2021-10-06 07:43:59 -07:00
Yash Tibrewal 72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API (#26544)
* De-experimentalize XdsCredentials and XdsServerCredentials API

* Use GRPC_DEPRECATED
2021-09-09 16:22:25 -07:00
Yash Tibrewal 7fd731f704
De-experimentalize XdsServerBuilder (#27296) 2021-09-09 14:14:11 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
AJ Heller 4ba3fa52b9
Clean up some instances of -Wunreachable-code-aggressive (#27054)
See https://github.com/grpc/grpc/pull/26951 for why this is not enforced
at the moment.
2021-08-18 11:43:46 -07:00
apolcyn d742153b32
Include the peer address in interop soak test high-latency error messages (#26932) 2021-08-10 09:47:16 -07:00
Yash Tibrewal 29d220a0ef
Re-experimentalize XdsServerBuilder (#26892)
* Re-experimentalize XdsServerBuilder

* Fix compiler issue
2021-08-06 10:29:28 -07:00
ZHANG Dapeng ca482bdbc7
Enable xds retry test for cpp (#26828)
* enable retry

* enable cpp

* fix cpp format

* fix indent
2021-07-29 15:39:35 -07:00
Yash Tibrewal 4daedf0233
De-experimentalize XdsServerBuilder (#26543) 2021-07-02 19:33:15 -07:00
Craig Tiller 03bdfa4a74
Make socket mutators work for server connections (#26328)
* Make socket mutators work for server connections

* compile fix

* compile fix

* compile fix

* compile fix

* cleanup

* Revert "cleanup"

This reverts commit 480fcc600a.

* Revert "Revert "cleanup""

This reverts commit 29fbc349d2.
2021-06-23 14:40:35 -07:00
AJ Heller 5cda00427d
Remove use of C++20 initializers (#26028)
Since this codebase only supports C++11 at this point, doing a build
with strict warnings will fail using C++20 initializers.

```
$ bazel build --define=use_strict_warning=true :all //src/core/... //src/compiler/... //test/...

test/cpp/interop/grpclb_fallback_test.cc:154:9: error: designated
initializers are a C++20 extension [-Werror,-Wc++20-designator]
        .mutate_fd = TcpUserTimeoutMutateFd,
```

See
https://source.cloud.google.com/results/invocations/f9710ed0-994f-488f-adb8-a7e987f1620d/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_bazel_build/log
2021-04-20 14:37:00 -07:00
Lidi Zheng 735c7047aa
[C++] Add admin and reflection to xds interop binaries (#25964)
* Add admin and reflection to xds interop binaries

* Prepare for https://github.com/grpc/grpc/pull/25978

* Remove _xds rules
2021-04-19 11:04:42 -07:00
Yash Tibrewal 23152e74ce
Enable channelz for xds_interop_client and xds_interop_server (#25939)
* Enable channelz for xds_interop_client and xds_interop_server

* Regenerate projects
2021-04-13 15:05:07 -07:00
Esun Kim a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr (#25628) 2021-03-09 21:30:35 -08:00
Yash Tibrewal 8eb2e13a6e
C++ xDS interop test server changes (#25633)
* C++ xDS interop test server changes
2021-03-05 16:25:50 -08:00
Esun Kim 377fe6095a
Upgrade clang-tidy and clang-format to 11 (#25590)
* Upgrade clang-tidy and clang-format to 11
* Reformat code
* Fix abseil-string-find-str-contains
* Fix modernize-make-unique
2021-03-04 11:54:30 -08:00
Yash Tibrewal 4b9ec936e8
xDS Interop Client changes for PSM security tests (#25613) 2021-03-04 10:09:25 -08:00
apolcyn 35569cd544
Make --server_port optional in C++ interop client (#25550)
* make --server_port optional in C++ interop client
2021-02-26 11:38:11 -08:00
Donna Dionne b2443df1e1 xds_interop_client.cc modification: new stats and new timeout_sec config 2021-01-21 15:23:02 -08:00
Esun Kim 9bd7c4917a Fix unused-parameter warning 2021-01-19 18:18:09 -08:00
Donna Dionne 88876b194c Fixing interop client to send all RPC types for each duration_per_query. 2020-12-22 10:15:48 -08:00
Donna Dionne 9b1172697e Adding a expect_status flag in xds interop client to get ready for
timeout tests.
2020-12-21 09:51:26 -08:00
Esun Kim 53ab235fb8 Fix google-explicit-constructor 2020-12-03 15:03:39 -08:00
Esun Kim 7d7c3cc711 Update by review 2020-12-02 13:42:53 -08:00
Esun Kim 2ff84ed8c2 C++ cast for void* 2020-11-30 17:29:15 -08:00
Esun Kim ec0b88a5d7 Fix google-readability-casting 2020-11-30 17:27:51 -08:00
Esun Kim 75e3e660fd Fix google-readability-todo 2020-11-25 10:09:42 -08:00
Donna Dionne e4a060fb1e Adding client changes needed for circuit breaking tests
- reworking interop client to accpet ClientConfig RPC
- adding new stats RPC
2020-11-20 16:23:49 -08:00
Donna Dionne c85ce105ee Fixing a bug in cpp xds interop client after the use of absl::GetFlag
Code used absl::string_view to point into FLAG_xxx, when we changed
to uses absl::GetFlag, absl::string_view is pointing into temp variables
which results in undefined behaviour for the flags.
2020-11-15 15:30:43 -08:00
Mark D. Roth 27e1c1c56d clang-tidy: enable google-readability-braces-around-statements 2020-11-06 13:41:44 -08:00
capstan 131579d52d Roll forward of commit 7883b51: Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.

This reverts commit da66b7d14e.

NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
2020-11-06 16:07:19 +01:00
Nathan Herring da66b7d14e
Revert "Abseil Flags" 2020-10-24 15:19:55 -07:00
capstan 7883b5133d Use abseil's flags in tests.
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493.
2020-10-23 19:36:33 +02:00
Esun Kim aae4f4cf18 Fix by misc-unused-using-decls 2020-10-19 18:12:11 -07:00
Esun Kim e7434d385e Fix by tidy-modernize-use-override 2020-10-16 14:01:06 -07:00
Esun Kim ece76ee1e8 Fix code by readability-container-size-empty 2020-10-16 09:48:20 -07:00
Esun Kim 6d6648c7e1 Fix clang-tidy errors 2020-10-13 09:51:31 -07:00
Vijay Pai f8b046e819 Eliminate ServerContextBase::Clear/Setup and fix unref process for core call 2020-09-22 00:37:25 -07:00
Yash Tibrewal d10e06b60a Add interop test for special_status_message 2020-09-17 14:00:47 -07:00
Eric Gribkoff 7df3017c8a Update semantics of --fail_on_failed_rpc 2020-07-27 10:11:19 -07:00
Mark D. Roth e681f37054 Remove env var protection of new xds routing code. 2020-07-20 07:59:07 -07:00
Donna Dionne ea459f72f5 Fixing unsafe std::move. 2020-07-16 16:05:31 -07:00
Donna Dionne 1f30faad13 Fixing call to absl::StrSplit to deal with empty string case. 2020-07-15 17:31:10 -07:00
Donna Dionne fc8923c0a3 Updating C++ interop client and server to do path matching and header
matching tests.
2020-07-14 18:23:18 -07:00
Mark D. Roth 9404f66f70 Replace most uses of gpr_asprintf() with absl calls. 2020-07-07 12:01:02 -07:00
Esun Kim 073c499e18 Added TCP_USER_TIMEOUT auto-detection 2020-07-06 20:27:58 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Alexander Polcyn 5727ccc28f Rename deadline/timeout 2020-06-10 23:25:29 -07:00
Alexander Polcyn 46c13cd870 Add a flag to interop soak tests to exit early and fail if X seconds have passed and we're not done yet. 2020-06-08 18:40:11 -07:00
Alexander Polcyn 1dad16c0d9 Use C-core's histogram, drop use of exec_ctx header 2020-05-08 15:54:38 -07:00
Alexander Polcyn b872ffe2f2 Make channel soak interop test more debuggable, add max_failures and
max_acceptable_latency_ms options
2020-05-07 11:41:16 -07:00
Eric Gribkoff 5330ead3ab Add --fail_on_failed_rpc flag to xds tests 2020-04-24 08:57:43 -07:00
Yash Tibrewal 331b332392 Try fixing interop tests 2020-04-10 16:43:30 -07:00
Eric Gribkoff db2edf9737 Properly set context on async call 2020-03-05 00:36:03 -08:00
Eric Gribkoff 49ede8e078
Merge pull request #22226 from ericgribkoff/async_xds_interop-client
xds interop client: use async api and initialize an int
2020-03-04 10:32:36 -08:00
Eric Gribkoff 627f5d5f47 xds interop client: use async api and initialize an int
fixes two bugs with the client, with an uninitialized int and where the
"timer" used to approximate a QPS would block waiting for a synchronous
RPC to timeout, which dramatically limited the QPS.
2020-03-03 17:19:20 -08:00
Esun Kim 415d41f9e8 Rerun clang-formatter-7 2020-03-03 10:46:55 -08:00
Yash Tibrewal a77d7c0f5a
Merge pull request #21999 from yashykt/xdsinteropclangtidy
Clang tidy xds interop client
2020-02-13 12:33:56 -08:00
Jan Tattermusch 33e9718584 buildifier format 2020-02-13 12:46:22 +01:00
Jan Tattermusch 9cd65c71b2 add missing //test/cpp/interop:http2_client target 2020-02-13 12:46:22 +01:00
Yash Tibrewal 0a863f2243 Clang tidy xds interop client 2020-02-12 17:34:42 -08:00
Eric Gribkoff 2574d98967 buildifier 2020-02-09 19:03:59 -08:00
Eric Gribkoff 39eb1d31b8 clang tidy 2020-02-09 01:07:14 -08:00
Eric Gribkoff 7401256927 check arg early, correct var name 2020-02-06 18:20:50 -08:00
Eric Gribkoff 2509e0c97e clang tidy 2020-02-04 01:28:31 -08:00
Eric Gribkoff 1d59b25dea Add xDS test client and server 2020-02-04 00:39:52 -08:00
Esun Kim f31ca23a6a Add TestEnvironment to more tests 2020-01-09 17:01:52 -08:00
Lidi Zheng c34bef4ca4 Format all Bazel files with buildifier 2019-11-05 14:03:52 -08:00
Vijay Pai e35c869aaf Remove unused-parameter warnings, round 2 (19 of 19) 2019-10-21 09:16:35 -07:00
Vijay Pai 406b70629a Remove unused parameter warning (17 of 20) 2019-10-17 08:52:00 -07:00
Qixuan Li 6a89c0e57e Add more logging to channel_soak interop test to indicate the boundary of an iteration 2019-10-15 21:46:45 +00:00
Jan Tattermusch d970489db2 use no_windows for some C++ tests 2019-09-30 13:27:57 +02:00
Alexander Polcyn 3afb0b2635 Fix fallback test breaking on mac bazel 2019-07-15 18:43:01 -07:00
Alexander Polcyn 3958a53bf7 Address review comments; fix sanity 2019-07-11 19:08:27 -07:00
Alexander Polcyn 4999420c7d Add a test client for certain grpclb fallback scenarios 2019-07-11 18:31:21 -07:00
Soheil Hassas Yeganeh dbf88dd66f Revert "Revert "Introduce string_view and use it for gpr_split_host_port.""
This reverts commit 80c177d4c4.
2019-06-27 20:56:15 -04:00
Qixuan Li 913acf456b fix minor nits 2019-06-26 22:32:33 +00:00
Qixuan Li 0e85762b67 add pick_first_unary 2019-06-26 13:49:36 -07:00
Muxi Yan f5551f1138
Revert " Added some Objective C tests and minor bug fixes." 2019-06-12 13:49:17 -07:00
Prashant Jaikumar 2b6e7c4423 Added some Objective C tests and minor bug fixes.
Objective-C tests: metadata, compression, keepalives, channel args.
Stress tests: network flap while streaming call in progress.

Bug fixes:
Stream gzip handling in interop server.
Keep alive, backoff time truncation bug in Obj-C layer.
2019-06-07 10:26:55 -07:00
Wayne Zhang edc506849f Expose interop test for others 2019-05-22 15:24:33 -07:00
Vijay Pai ec06d677e2
Merge pull request #16681 from arrowd/master
Fix various tests on FreeBSD.
2019-04-10 14:16:36 -07:00
Bill Feng d93959853f Enabled Windows Bazel build for cpp tests 2019-03-21 18:00:48 -07:00
Yang Gao 2ee9795183
Merge pull request #18156 from mkbehr/interop-client-additional-metadata
Let the c++ interop_client send additional metadata, controlled by a flag.
2019-03-18 11:31:20 -07:00
Jan Tattermusch cf6a311761
Revert "Windows builds for gRPC C++ tests" 2019-03-15 17:15:20 +01:00
Michael Behr f2ba191dcc Merge remote-tracking branch 'upstream/master' into interop-client-additional-metadata 2019-03-14 15:30:29 -04:00
Michael Behr 7f6ed9267f Convert metadata flag keys to lowercase. 2019-03-14 15:27:15 -04:00
billfeng327 4241edeaa4 renamed tag to no_windows in conformation with Bazel and TensorFlow 2019-03-07 14:52:49 -08:00
billfeng327 928aedf5c8 Merge branch 'master' into update-deps-version 2019-03-06 15:48:29 -08:00
billfeng327 ab06853fc9 C++ Windows test builds 2019-03-06 15:47:49 -08:00
Michael Behr 1603242add Parse additional metadata flag manually instead of by regex 2019-03-06 12:39:22 -05:00
Michael Behr ddf7666fdf Merge remote-tracking branch 'upstream/master' into interop-client-additional-metadata 2019-02-27 12:07:54 -05:00
Michael Behr 0a53c2ed2e Move new functions out of client_helper.cc 2019-02-27 12:04:32 -05:00
Vu Cong Tuan 9c4de5a0ff Fix typos in test code
Signed-off-by: Vu Cong Tuan <tuanvc@vn.fujitsu.com>
2019-02-27 09:11:01 +07:00
Michael Behr 60f060e078 Let interop_client send additional metadata, controlled by a flag. 2019-02-25 11:26:22 -05:00
Vijay Pai 80a0488d33
Make declaration match definition 2019-01-29 10:29:14 -08:00
apolcyn ec10359c7b
Merge pull request #17213 from apolcyn/add_cloud_to_prod_gcd_tests
Add an interop test specific to GoogleDefaultCreds
2019-01-27 23:47:59 -08:00
Jan Tattermusch 2b028c8cec do not use default server override for C++ interop client 2018-12-20 14:49:54 +01:00
Alexander Polcyn a4e9f33b85 Add interop cloud to prod test for GoogleDefaultCredentials 2018-12-07 17:19:17 -08:00
yang-g 67742ef63f Fix BUILD files. Manually edit bzl files 2018-12-06 14:37:52 -08:00
Vijay Pai a192fc6880 Fix clang-tidy issues 2018-11-11 14:32:55 -08:00
Yash Tibrewal a55d60056b Fix build 2018-10-26 17:16:17 -07:00
Juanli Shen e401a0898c
Merge pull request #16873 from AspirinSJL/add_interop
Add interop test into bazel build
2018-10-23 10:50:54 -07:00
Juanli Shen 800a09b24e Add interop test into bazel build 2018-10-22 16:50:07 -07:00
Jan Tattermusch 9de25dc1e6
Revert "Add c++ google default creds to cloud to prod auth scenarios" 2018-10-15 12:19:50 +02:00
Alexander Polcyn aea5f109a6 Add c++ google default creds to cloud to prod auth scenarios 2018-10-11 13:53:54 -07:00
Gleb Popov 39eb19ed35 Fix various tests on FreeBSD. 2018-09-22 22:41:39 +03:00
Adele Zhou 165417e4fa Change the test name to long_lived_channel 2018-09-12 14:30:02 -07:00
Adele Zhou 094dc6822c Added long_connection test. 2018-09-12 11:37:50 -07:00
Yihua Zhang f621eee4cf run cloud-to-prod interop tests with google default credentials 2018-08-10 11:31:15 -07:00
ncteisen 12f1cc059b Reviewer feedback 2018-07-18 07:33:08 -07:00
ncteisen b6597b4fbd Add two new soak interop tests 2018-07-17 17:12:26 -07:00
Noah Eisen 373fc6dc40 Manual fixes to enable performance- clang tidy checks 2018-06-14 14:58:09 -04:00
Noah Eisen 58e0cbf9fb Enable the performance-* clang-tidy checks 2018-06-14 14:58:09 -04:00
Juanli Shen 70eeade08e Fix bug in RunServer() 2018-05-08 10:22:50 -07:00
Alexander Polcyn 11c1739a10 Provide a way to run C++ interop server with custom ServerBuilderOptions 2018-05-03 23:01:43 -07:00
Yihua Zhang 0dcbb83420 add alts to interop tests 2018-04-20 08:50:45 -07:00
Vijay Pai c90a85649b Change grpc++ references in names to grpcpp 2018-03-08 22:04:59 -08:00
Noah Eisen 4d20a66685 Run clang fmt 2018-02-09 09:34:04 -08:00
Noah Eisen be82e64b3d Autofix c casts to c++ casts 2018-02-09 09:16:55 -08:00
Vijay Pai 239b7d4b0b Merge branch 'master' into gpr_review 2018-02-08 11:08:41 -08:00
Vijay Pai b1ef84a7fd Merge branch 'master' into gpr_review_host_port 2018-02-07 11:12:35 -08:00
Muxi Yan 6f0b195d20 Replace GRPC_COMPRESS_MESSAGE_* with GRPC_COMPRESS_* 2018-02-06 18:17:42 -08:00
Vijay Pai d4d0a30c6f Privatize useful.h and avl.h 2018-02-02 09:16:44 -08:00
Vijay Pai ae376bf9d9 Privatize host_port.h; was not used in any wrapped language implementation 2018-01-25 23:06:24 -08:00
Muxi Yan fb061c329a Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2018-01-19 12:20:15 -08:00
Mark D. Roth dbdf495f61 Split lib/support into lib/gpr and lib/gpr++. 2018-01-18 11:21:12 -08:00
yang-g 19d1eb2228 When seeing an error in interop test, also log the debug error string. 2017-12-19 16:41:51 -08:00
Muxi Yan c870ce5476 More message compression level clean-up 2017-12-11 15:53:22 -08:00
Muxi Yan 6043006af1 Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2017-12-06 22:29:12 -08:00
Muxi Yan 67454d71e8 Merge commit 'b0bad8f' into fix-stream-compression-config-interface 2017-12-06 22:09:36 -08:00
Muxi Yan fc38142db6 Merge commit 'b0bad8f^' into fix-stream-compression-config-interface 2017-12-06 22:02:08 -08:00
Muxi Yan 38fcd0c6c3 clang-format 2017-12-06 18:55:05 -08:00
Yang Gao 6a019e732a
Merge pull request #13329 from dwittmer/dwittmer_runserver
Add support to RunServer for notifying clients via condition variable that the interop server has started.
2017-12-04 09:51:23 -08:00
Dan Wittmer 472d7c9232 Fix formatting - missed moving ‘*’ next to type. 2017-11-17 15:49:11 -08:00
Dan Wittmer b88ab92af2 Fix formatting of RunServer params. 2017-11-17 15:23:32 -08:00
ncteisen adbfbd5977 Remove all extern C 2017-11-17 14:08:57 -08:00
Dan Wittmer 6d18fcd3ab Add ServerStartedCondition to hold the mutex, condition variable and condition. Changes allow callers to correctly handle spurious wakeups. 2017-11-16 16:45:23 -08:00
Dan Wittmer 728f1d2c44 s//used 2017-11-16 14:37:49 -08:00
Craig Tiller 4ac2b8e585 Enable clang-tidy as a sanity check, fix up all known failures 2017-11-10 14:14:17 -08:00
Dan Wittmer 572dd8e897 Change adds a version of grpc::testing::interop::RunServer that allows clients to pass in optional condition_variable which will be notified when the server has started and port to use, avoiding the need for callers to work with command line options.
Above is used to support clients running the server in a separate thread in the same process as the tests are run to support local only tests.

Existing grpc::testing::interop::RunServer calls into new version passing in FLAGS_port and null condition variable.
2017-11-09 12:01:31 -08:00
Yash Tibrewal 40422d5fa6 Merge master 2017-11-06 14:43:31 -08:00
Craig Tiller baa14a975e Update clang-format to 5.0 2017-11-03 09:09:36 -07:00
Yash Tibrewal 39aed1ae8b Remove unnecessary extern Cs 2017-10-25 17:04:35 -07:00
Muxi Yan 03fc857a6f Merge remote-tracking branch 'upstream/master' into fix-stream-compression-config-interface 2017-10-06 18:47:09 -07:00