Commit Graph

674 Commits

Author SHA1 Message Date
Nikolai Semenov 7b8fb43b33
WriteOptions::clear_write_through method (#26774)
* Add WriteOptions::clear_write_through method

* Rearrange WriteOptions methods in a logical manner
2022-01-31 18:36:46 -08:00
AJ Heller 5dfeec7a7e
Update docs for ServerAsyncResponseWriter::Finish object lifetimes (#28290)
Fixes #28239
2022-01-26 20:43:44 -08:00
Yash Tibrewal 50a207ee9c
Promote ClientContext::set_wait_foor_ready to be non-experimental (#28247) 2021-12-01 18:57:41 -08:00
Esun Kim f4c18944e2
Early exit BackUp() on count == 0 (#27946) 2021-11-05 10:18:49 -07:00
Alisha Nanda 0a502d8f2e
Fix race between Read and ServerContext::IsCancelled in Sync API (#27056)
* Fix OOM issues in qps tests

* Add more verbose logging.

* Fix clang error

* Fix race between IsCancelled and Read

* Fix build errors from using bool in C code
2021-09-15 12:29:02 -07:00
Craig Tiller ea389c00c2
Adjust include order per style guide (#27175)
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
Craig Tiller 28316341bf
Annotate impl/codegen with IWYU pragmas (#27252)
* Add a tool to annotate impl/codegen with IWYU pragmas

* xx

* oops

* fmt

* x

* fix wrong direction bug

* use defaultdict

* better annotations

* better annotations

* Automated change: Fix sanity tests

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-08 09:13:03 -07:00
AJ Heller 0407f4be49
Fix free-after-use bug in server callback handler (#27187)
Successful asan run https://source.cloud.google.com/results/invocations/33bc587c-a440-45bd-9886-a23789645a7d/targets

Successful TGP available upon request.
2021-08-31 11:01:57 -07:00
Craig Tiller 4dff0ee48a
Fix bug in CQNext (#27022)
Internal bug b/170934515

In some cases, calling CQ::Next will return true without passing up a
new tag value, which is very much illegal. My expectation is that this
is due to messing up between SHUTDOWN and TIMEOUT in lower layer code
that doesn't particularly matter much to most callers, but was being
erroneously checked here.
2021-08-17 10:50:10 -07:00
Tamir Duberstein 013e67a029
Deprecate grpc{_core,::internal}::WaitUntil (#26866)
It is not possible for such a function to be implemented in a way that
is understood by annotalysis. Mark it deprecated and replace instances
of its use with direct mutex/condvar usage.

Add a bunch of missing thread safety annotations while I'm here.
2021-08-04 17:03:25 -07:00
Esun Kim 931f91b745
Changed GRPCPP_ABSEIL_SYNC to GPR_ABSEIL_SYNC (#25681) 2021-08-02 12:18:21 -07:00
Rainer Schoenberger ede7923116
Fix ABNF grammar formatting in doxygen documentation (#26467) 2021-07-07 17:50:44 -07:00
Vijay Pai ae0516fece
Remove some EXPERIMENTAL comments (#26618)
* Remove some EXPERIMENTAL comments

* Update server_interface.h
2021-07-07 14:25:42 -07:00
Vijay Pai 3e19babc1e
Remove all possible traces of grpc::experimental for callback API (#26584) 2021-06-30 19:55:08 -07:00
Vijay Pai 0b65c34ae5
De-experimentalize default_reactor_test_peer.h and last uses of CallbackServerContext (plus namespace cleanup) (#26569)
* De-experimentalize default_reactor_test_peer.h (plus namespace cleanup)

* Remove experimental refs to callback API in server_context.h
2021-06-29 12:24:09 -07:00
Vijay Pai ea4b68e7a1
Drop experimental tags from core callback API (#26535) 2021-06-24 17:20:43 -07:00
Vijay Pai cf1ebf7387
Remove experimental tag from uses of the C++ callback API (#26495) 2021-06-20 00:47:07 -07:00
Esun Kim eec81014d8
Revert "async_unary_call: add a Destroy method, called by std::default_delete. (#26389)" (#26449)
This reverts commit b3b036ca17.
2021-06-08 10:29:44 -07:00
Aaron Jacobs b3b036ca17
async_unary_call: add a Destroy method, called by std::default_delete. (#26389)
This implements gRFC L80:

    https://github.com/grpc/proposal/blob/a3a0e23b/L80-cpp-async-response-reader-destruction.md
2021-06-07 09:02:08 +02:00
Vijay Pai 8aff94558c
De-experimentalize C++ callback API (#25728)
* De-experimentalize callback API

* Make FromServerContext based on ServerContextBase

* Fix lambda

* Fix headers

* De-experimentalize tests

* clang-format

* Fix consistency checks

* wip

* Fix const-ness of callback client read RPC requests

* Fix golden file

* Give full route_guide callback client example with Hold etc

* Complete example route-guide server

* De-experimentalize test services

* Omit unneeded using

* Remove some uses of non-experimental macro from test

* clang-format examples

* De-experimentalize async stub calls

* Remove experimental namespace use in qps, ubms

* De-experimentalize alarms, generic stubs, and context allocator

* De-experimentalize SetContextAllocator

* clang-format

* Fix conflicts

* Leave obsolete API in place until users can be migrated
2021-05-27 14:55:25 -07:00
Esun Kim a99ead4bf4
Added new method to ByteBuffer & Slice (#26014) 2021-05-27 11:18:18 -07:00
Hung Dang e6782daf95
Fix an unused parameter warning in grpcpp/impl/codegen/service_type.h (#26346)
* Initial commit

* Address @veblush comment.
2021-05-27 11:08:30 -07:00
Vijay Pai 153bc67f45
Revert "Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)" (#26379)
This reverts commit 259a74c0e6.
2021-05-27 09:16:05 -07:00
Yash Tibrewal 259a74c0e6
Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)" (#26375)
This reverts commit 66253c521a.
2021-05-26 22:20:23 -07:00
shangwu-google 8b3f4fca25
Client context test peer (#25610)
* Create client_context_test_peer.h

mock-up class for ClientContext

* Add ClientContextTestPeer as a friend for test

* Update client_context_test_peer.h

* Update client_context_test_peer.h

* unit test for client_context_test_peer.h

* unit test for client_context_test_peer.h

* fix for tools/buildgen/generate_projects.sh

* Revert "fix for tools/buildgen/generate_projects.sh"

This reverts commit b007aa8c2b.

* re-fix for tools/buildgen/generate_projects.sh

* Remove an empty line

Co-authored-by: Vijay Pai <vpai@google.com>
2021-05-25 18:51:34 -07:00
Vijay Pai 66253c521a
Revert "Revert "Expose trailers-only response status through C++ callback API"" (#26365)
* Revert "Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)"

This reverts commit 05c3b30ea0.

* Move the trailers_only check from ClientContext to ClientReactor

* Remove unneeded change in client_context.cc
2021-05-25 17:43:21 -07:00
Yash Tibrewal 05c3b30ea0
Revert "Expose trailers-only response status through C++ callback API (#26249)" (#26363)
This reverts commit 393bae7e88.
2021-05-25 13:44:10 -07:00
Vijay Pai 393bae7e88
Expose trailers-only response status through C++ callback API (#26249)
* Expose trailers-only response status through callback API

* Fix change-detector test

* Address reviewer comment about trailers_only headers

* Add TODO requested by markdroth

* Move variable in struct to improve space efficiency

* Don't instantiate ExecCtx in channel_args destructor unless needed
2021-05-21 14:42:41 -07:00
Vijay Pai 0f80378a21
Resolve race between OnReadDone(ok=false) and IsCancelled (#26245)
* Resolve and test race between OnReadDone(ok=false) and IsCancelled

* Fix retry case

* Fix health check case

* Address reviewer comments.

* ADD TODO requested by markdroth
2021-05-19 14:05:46 -07:00
Vijay Pai edf500fb82
Add useful status error message when server threadpool is exhausted (#26146) 2021-05-03 12:16:12 -07:00
mkruskal-google 2bf75aa68a
Add optional suffix to client-side stub objects (#25996)
* Adding suffix for stats handling to gRPC

* Fixing typo

* Fixing codegen, adding tests

* Fixing test failures

* Adding nullptr default in StubOptions

* Updating golden test file

* Replacing std::make_unique with absl::make_unique for pre-C++14 compatibility

* Fixing clang format  errors

* Reuse stub options for generic stubs

* Cleaning up compiler warnings in GenericStub
2021-04-26 17:19:43 -07:00
Esun Kim 2dc8df9ef6
Fix bugprone unhandled self assignment (#25667)
* Add bugprone-unhandled-self-assignment

* Fix bugprone-unhandled-self-assignment
2021-03-10 13:38:23 -08:00
Esun Kim a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr (#25628) 2021-03-09 21:30:35 -08:00
Vijay Pai dae5624e47
Thread annotations for C++ callback API headers (#25571)
* Annotate headers

* clang-format
2021-03-04 10:15:21 -08:00
Esun Kim f862a2259f
Add abseil thread annotations to grpcpp/sync (#25560)
* Add abseil annotation to grpcpp/sync
* Bump alpine linux to 3.11 from 3.9
2021-03-03 08:39:20 -08:00
Vijay Pai 26e4c14b1e
Add virtual destructor to ClientReactor base class (#25599)
* Add virtual destructor

* Remove subclass empty destructors
2021-03-02 21:08:07 -08:00
WANG Lei f99a08fe46
Remove unused parameter from UnaryDeserializeHelper (#25332)
* fix -Wunused-parameter warning

* clang-fmt

* clang-format

Co-authored-by: Vijay Pai <vpai@google.com>
2021-03-02 17:51:36 -08:00
Vijay Pai 909cac3866
Document reaction concurrency and reactor lifetime (#25481) 2021-02-24 09:18:15 -08:00
Vijay Pai dba8bb59a0 Implement callback CQ at C++ layer using shared thread pool if non-background iomgr 2021-02-16 16:02:23 -08:00
Esun Kim 6468d8a69d Make grpcpp/mutex compatible absl/mutex 2021-02-11 15:02:42 -08:00
mkruskal-google 0416696848
Update auth_context.h 2021-01-28 16:27:48 -05:00
ZhouyihaiDing a584bc4f02 Support ServerContext for callback API 2021-01-19 22:00:10 -08:00
AJ Heller ec9451e856 Fix typo in documentation 2021-01-13 11:23:50 -08:00
Vijay Pai 91bb4e178c Check for nullptr (deser failure) before destructing included request 2021-01-13 01:33:13 -08:00
Adam Cozzette 63ee5b62c2 Updated parse_json.cc to rely on config_protobuf.h for protobuf types
Google's internal version of the gRPC codebase uses a version of
protobuf with a different namespace and include paths. This commit makes
parse_json.cc rely on config_protobuf.h for protobuf types so that it
will work properly in that environment. I also replaced a call to
Status::error_code() with a call to Status::code() instead. This way the
code will work with absl::Status, which has a somewhat different API
compared to google::protobuf::util::Status.
2020-12-23 15:55:17 -08:00
Esun Kim 20509e823d Fix google-explicit-constructor 2020-12-03 19:22:22 -08:00
Esun Kim decc199ca8 Fix by clang-tidy 2020-12-03 16:24:19 -08:00
Vijay Pai afe4d1d086 Reduce templating for async client unary call codegen 2020-10-30 14:26:47 -07:00
Vijay Pai 3ecb008aa0
Merge pull request #24494 from vjpai/server_code_size
Reduce template use in sync server unary calls
2020-10-29 22:56:51 -07:00
Esun Kim 9936d7785c
Merge pull request #24198 from chrisse74/protoUtilsStaticCast
proto_utils.h: suppress conversion warning
2020-10-25 09:26:05 -07:00
Esun Kim 43333b4232
Merge pull request #24535 from veblush/clean-up-WriteOptions
Clean up WriteOptions cctor
2020-10-23 10:52:58 -07:00
Vijay Pai 96503e3c72 Reduce code paths 2020-10-22 22:29:22 -07:00
Esun Kim 119228e7bb Clean up WriteOptions cctor 2020-10-22 11:11:09 -07:00
Esun Kim d812b0cf38 Fix errors in doxygen param descriptions 2020-10-22 10:42:59 -07:00
Vijay Pai 6f7a98916b Reduce template use in server 2020-10-21 13:33:16 -07:00
Vijay Pai 476743786b Also reduce templating for ClientUnaryReactor 2020-10-20 04:12:40 -07:00
Vijay Pai 97924fcfb2
Merge pull request #24420 from vjpai/sync_client_code_size_v2
Reduce sync client templating for protobuf without protobuf dependence
2020-10-20 00:08:17 -07:00
Vijay Pai 8f9233ca30
Merge pull request #24423 from vjpai/callback_client_code_size_v2
Reduce templating for unary callback client RPC without protobuf dependence
2020-10-20 00:07:51 -07:00
Esun Kim 34789b2d83 Fix by clang-format-8. 2020-10-16 11:37:18 -07:00
Vijay Pai ef212a908e Reduce sync client templating for protobuf 2020-10-15 04:48:20 -07:00
Vijay Pai 7e72bba162 Reduce templating for unary callback client RPC 2020-10-15 04:47:39 -07:00
Karthik Ravi Shankar e549843885 Move remaining classes to grpc from grpc_impl 2020-10-06 13:15:51 -07:00
Vijay Pai 0809fd8b17
Merge pull request #24177 from vjpai/server_call_startup
Fix server backlog processing to not set stream until backlog cleared
2020-09-23 09:34:29 -07:00
Vijay Pai f8b046e819 Eliminate ServerContextBase::Clear/Setup and fix unref process for core call 2020-09-22 00:37:25 -07:00
Christian Maurer d48e350d58 Remove conversion warning by static casting 2020-09-21 16:34:05 +02:00
Vijay Pai 346a00eb31 Cleanup generic server contexts 2020-09-19 12:29:32 -07:00
Karthik Ravi Shankar 0839200623 Fix the method_handler_impl public header
This header is pointing to a deleted file. This commit points it to the
file containing the public class.
2020-09-18 11:45:38 -07:00
Vijay Pai b427807f3b Fix server backlog processing to not set stream until backlog cleared 2020-09-17 15:38:06 -07:00
Karthik Ravi Shankar 30ed2f513f
Merge pull request #24082 from karthikravis/sync-stream
Move async, callback and sync implementation from grpc_impl to grpc namespace
2020-09-17 10:47:59 -07:00
Vijay Pai 6bbe905e27
Remove invalid forward declaration 2020-09-10 16:56:41 -07:00
Karthik Ravi Shankar 375d92be8d Merge branch 'master' into sync-stream 2020-09-08 15:14:48 -07:00
Karthik Ravi Shankar 67667eb7b6 Revert ... 2020-09-03 08:16:10 -07:00
Karthik Ravi Shankar b657c8d79c
Revert "Revert "Move ServerContext from ::grpc_impl to ::grpc"" 2020-09-02 10:17:00 -07:00
Karthik Ravi Shankar f1abdd1725
Revert "Move ServerContext from ::grpc_impl to ::grpc" 2020-09-01 22:54:54 -07:00
Karthik Ravi Shankar 9afbf02198 Merge branch 'master' into server-context 2020-08-31 17:37:37 -07:00
Karthik Ravi Shankar 967c0a2a32 Move Server from ::grpc_impl to ::grpc
Reverts: https://github.com/grpc/grpc/pull/18458
2020-08-20 14:53:17 -07:00
Karthik Ravi Shankar a23578444c Fix and format build after rebase 2020-08-20 14:17:49 -07:00
Karthik Ravi Shankar dc3e1097e9 Merge branch 'master' into server-context 2020-08-19 14:18:27 -07:00
Vijay Pai d4766cef2d
Merge pull request #23859 from grpc/vjpai-patch-1
Document purpose of `grpc/impl/codegen`
2020-08-17 13:44:36 -07:00
Karthik Ravi Shankar d6ad6d16d2
Merge pull request #23795 from karthikravis/client-context
Move ClientContext from ::grpc_impl to ::grpc
2020-08-17 12:17:48 -07:00
Vijay Pai 8a3c0a8c95 Justify existence of this directory 2020-08-17 11:42:36 -07:00
Vijay Pai 355c7b26d4
Update README.md 2020-08-14 11:34:48 -07:00
Vijay Pai 7dd4e786cd
Justify this directory's existence 2020-08-14 11:28:03 -07:00
Karthik Ravi Shankar 56d7d9e804 Move ServerContext from ::grpc_impl to ::grpc 2020-08-13 14:24:29 -07:00
Karthik Ravi Shankar 751b9c105f Move ClientContext from ::grpc_impl to ::grpc
Reverts: https://github.com/grpc/grpc/pull/19261
2020-08-11 16:28:50 -07:00
Karthik Ravi Shankar 15cce00f52
Revert "Revert "Fold Channel and CompletionQueue from grpc_impl to grpc"" 2020-08-06 20:42:54 -07:00
Karthik Ravi Shankar f3f9e8941a
Revert "Fold Channel and CompletionQueue from grpc_impl to grpc" 2020-08-06 15:56:09 -07:00
Karthik Ravi Shankar ab775de1a2 Build and formatting fixes 2020-08-04 13:31:42 -07:00
Karthik Ravi Shankar 390132c87f Merge branch 'master' into channel 2020-08-04 11:48:10 -07:00
Karthik Ravi Shankar 3c2f4b40e3 Fold Channel and CompletionQueue from grpc_impl to grpc
Reverts: https://github.com/grpc/grpc/pull/19067
2020-07-30 16:45:28 -07:00
Karthik Ravi Shankar be7bab5cb8 Merge branch 'master' into server-credentials 2020-07-28 16:30:07 -07:00
Karthik Ravi Shankar 1de0bfd9e2
Revert "Revert "Move create_channel and credentials from ::grpc_impl to ::grpc"" 2020-07-24 12:47:33 -07:00
Karthik Ravi Shankar f1bc43edf6
Revert "Move create_channel and credentials from ::grpc_impl to ::grpc" 2020-07-24 11:08:54 -07:00
Karthik Ravi Shankar 2fc4cfadcf Move ServerCredentials from ::grpc_impl to ::grpc
Reverts: https://github.com/grpc/grpc/pull/18452
2020-07-23 16:18:23 -07:00
Karthik Ravi Shankar 1999b20c7d Merge branch 'master' into create-channel 2020-07-13 10:58:31 -07:00
Yash Tibrewal e2bd6d9f29
Merge pull request #23415 from yashykt/genericfailsend
Fix FailHijackedRecvMessage for generic async APIs
2020-07-08 19:11:05 -07:00
Vijay Pai 7842ef6035
Merge pull request #23258 from tweej/I_is_reserved
I is a reserved identifier
2020-07-08 13:50:51 -07:00
Yash Tibrewal a80bb13fd0 Fix FailHijackedRecvMessage for generic async APIs 2020-07-07 12:32:52 -07:00
Vijay Pai 2b0f14d54d
Don't drop message on WriteAndFinish with non-ok status 2020-07-07 01:38:44 -07:00
Karthik Ravi Shankar 44f721eeb0 Merge branch 'master' into create-channel 2020-06-30 15:52:24 -07:00
Esun Kim 165ee5007a Replaced grpc::string with std::string 2020-06-29 17:56:36 -07:00
Karthik Ravi Shankar 7aadac509c Merge branch 'master' into revert-23294-revert-23182-server-builder 2020-06-29 11:07:17 -07:00
Karthik Ravi Shankar 18cc2f6f34 Formatting fixes 2020-06-24 21:25:33 -07:00
Karthik Ravi Shankar 7f2eaaabac Move create_channel and credentials from ::grpc_impl to ::grpc
Reverts: https://github.com/grpc/grpc/pull/18374 and
https://github.com/grpc/grpc/pull/18444

Credentials and create_channel are very closely intertwined, so it is
easier to migrate them together.
2020-06-24 17:34:06 -07:00
Karthik Ravi Shankar 9db914a0cc
Revert "Revert "Move ServerBuilder back to ::grpc from ::grpc_impl"" 2020-06-24 12:28:27 -07:00
Karthik Ravi Shankar 0f64d1f96b
Revert "Move ServerBuilder back to ::grpc from ::grpc_impl" 2020-06-23 18:42:35 -07:00
Karthik Ravi Shankar 133f38a885 Make changes for ResourceQuota and friend namespaces. 2020-06-23 12:24:14 -07:00
Karthik Ravi Shankar 31e6b69c8e Merge branch 'master' into server-builder 2020-06-22 13:59:33 -07:00
Patrice Chalin 5be0b22dc0 Update links to grpc.io guides in header files 2020-06-22 11:32:59 -04:00
T.J. Mercier d8c9ab1645 I is a reserved identifier 2020-06-19 20:54:26 -07:00
Vijay Pai 5ef722a2c9 Privatize MaybeFinish 2020-06-17 12:06:55 -07:00
Vijay Pai 7eebba3781 Fixes needed to make roll-forward of StartCall and corking work 2020-06-16 13:06:16 -07:00
Vijay Pai 278671072f
Revert "Revert "Fix StartCall: make corking work and allow concurrent Start*"" 2020-06-16 12:20:19 -07:00
Vijay Pai b269fdbf8b Don't mark server RPC canceled if finished with non-OK status 2020-06-11 10:15:05 -07:00
Karthik Ravi Shankar 934cf3e3df Move ServerBuilder back to ::grpc from ::grpc_impl
Revert #18510
2020-06-10 22:47:29 -07:00
Karthik Ravi Shankar 11c54ada0d
Revert "Fix StartCall: make corking work and allow concurrent Start*" 2020-06-02 11:11:06 -07:00
Jacob Dlougach 35ab5bc616
Include <memory> for std::unique_ptr
Currently `#include <grpcpp/support/interceptor.h>` in some compilers (gcc 8, for example) will fail due to missing `<memory>` include. This PR fixes this issue.
2020-05-21 14:17:45 +01:00
Vijay Pai 899cbcab96 Fix StartCall: make corking work and allow concurrent Start* 2020-05-20 10:02:22 -07:00
Yash Tibrewal 8051d956af
Merge pull request #22429 from pavelsimo/patch-1
Fix typo in CallOpSet comments
2020-05-08 06:35:33 -07:00
Yash Tibrewal 6a6481cb83 Reviewer comments 2020-04-30 15:44:48 -07:00
Yash Tibrewal e714d0fcb8 Reviewer comments 2020-04-28 13:24:23 -07:00
Yash Tibrewal edbae5d8e6 Fix interceptor batch method FailHijackedRecvMessage for async APIs 2020-04-22 23:05:57 -07:00
Vijay Pai 397b3ee72e
Do a debug-check of API use 2020-03-31 16:03:44 -07:00
Vijay Pai 03fffe0fcb
Document that AddMultipleHolds argument must be positive 2020-03-31 13:42:32 -07:00
Vijay Pai ee3952f72b
Merge pull request #22483 from vjpai/lambdify
Remove all std::mem_fn and std::bind from service definitions and setup
2020-03-26 23:52:06 -07:00
Kislay Kishore bf3954c8cc
Fix typo
clinet -> client
2020-03-26 09:45:11 +05:30
Vijay Pai c86cfc305c Remove all std::mem_fn and std::bind from service definitions and setup 2020-03-25 16:48:36 -07:00
Pavel Simó b91d433ba4
Fix typo 2020-03-20 14:13:51 +01:00
Vijay Pai 33f4b8336e Add useful comments 2020-03-17 14:29:34 -07:00
Esun Kim 415d41f9e8 Rerun clang-formatter-7 2020-03-03 10:46:55 -08:00
Vijay Pai e859aa8169
Update server_callback_impl.h 2020-02-27 14:16:25 -08:00
Vijay Pai 3620abf059 Properly follow precise conditions for callback inlining 2020-02-20 01:34:30 +00:00
Yash Tibrewal 820ee53030
Merge pull request #22000 from yashykt/unusedparams
Remove some unused parameter warnings
2020-02-13 16:23:19 -08:00
Esun Kim aa666f4b76
Merge pull request #21996 from veblush/deadline-catch
Delete default TimePoint constructor to detect error at compile time
2020-02-13 12:34:15 -08:00
Esun Kim cf618b1b8c Removed unused sync_[no]_cxx11 files 2020-02-13 09:26:51 -08:00
Esun Kim fd72a70e7d Update by review 2020-02-13 09:11:51 -08:00
Yash Tibrewal 4a02ff7747 Remove some unused parameter warnings 2020-02-12 17:56:34 -08:00
Esun Kim 89908faede Delete default TimePoint constructor to detect error at compile time 2020-02-12 12:20:36 -08:00
Vijay Pai 06ca713df0 Instantiate tracking members regardless of NDEBUG 2020-02-11 13:54:25 -08:00
Vijay Pai 6b2aeec9f3 Revert "Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""" 2020-02-11 13:50:53 -08:00
Nicolas Noble de76cf8522
Stop using ByteSize as it's deprecated.
Fixes #21603
2020-01-29 10:46:19 -08:00
Lidi Zheng 312b31c264
Merge pull request #21806 from grpc/revert-21767-revert-21725-revert-21680-cq_ordering
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"""
2020-01-27 16:34:45 -08:00
Lidi Zheng cd086cb3e4
Revert "Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)""" 2020-01-27 14:10:44 -08:00
Vijay Pai a801ccbdc8 Reinterpret_cast after in-place new... 2020-01-24 12:25:51 -08:00
Vijay Pai 1f0cdd5aad Construct DefaultReactor lazily since not always needed 2020-01-23 08:52:21 -08:00
Vijay Pai 16f2250585 Revert "Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)"" 2020-01-22 21:58:35 -08:00
Vijay Pai 64281e8c79 Clarify ownership in comments 2020-01-21 10:45:04 -08:00
Jan Tattermusch e7d5ca0b46
Revert "Log an error (in dbg mode) if CQ is Shutdown before its Server(s)" 2020-01-20 14:42:29 +01:00
Vijay Pai 6466c7f166 Log an error (in dbg mode) if CQ is Shutdown before its Server(s) 2020-01-16 11:51:44 -08:00
Vijay Pai 2f0362ee3a
Remove unused (and defective) constructor 2020-01-05 16:27:30 -08:00