Commit Graph

12 Commits

Author SHA1 Message Date
Akshay Shah bd335033e2 [docs] Clarify expected semantics of deflate compression (#36113)
I was surprised to see that the C++ core interprets "grpc-accept-encoding: deflate" like HTTP: it compresses messages using zlib with deflate compression, rather than using raw deflate. Matching HTTP semantics makes sense, of course, but this misnomer has historically confused HTTP implementations too.

This detail didn't seem important enough to warrant inclusion in the main protocol specification, so I've proposed an addition to `docs/compression.md` to document the expected behavior. I'm happy to move the addition around if you'd prefer it elsewhere.

Closes #36113

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36113 from akshayjshah:deflate 9177d39d63
PiperOrigin-RevId: 617635558
2024-03-20 15:06:44 -07:00
Eric Anderson 18dd95f735 doc/compression.md: Make it clear compression is per-RPC
"initial call" should not be understood as "initial call on the connection" but
"initial call of the RPC". All the data necessary for understanding client's
compression abilities is provide per-RPC, so no connection-level state should
be used. Using such state would break the use of proxies.
2020-05-06 11:23:23 -07:00
Wilson 4924a21434 Improve clarity of Compression Method Asymmetry Between Peers section 2018-03-09 23:12:15 -08:00
Shohei Kamimori 35367cc3ed fix typo 2018-02-05 18:46:41 +09:00
0oneo a01ce50d12 fix typo in compression.md
replace "`grpc-accept-encoding h`eader" with "`grpc-accept-encoding` header"
2017-08-30 13:46:15 +08:00
Alexander Polcyn d809a15ec4 cpp doc nits 2017-05-05 11:02:07 -07:00
David Garcia Quintas 75f6828636 Fixed typo 2016-06-23 10:16:16 -07:00
David Garcia Quintas cc00745e8c brought spec up to date 2016-06-23 00:18:15 -07:00
David Garcia Quintas b665dd2722 reworded some 2016-06-21 11:52:29 -07:00
David Garcia Quintas 9f26a149a5 fixed incomplete sentence 2016-06-21 10:15:01 -07:00
David Garcia Quintas 87e6770a18 pr comments 2016-06-16 22:04:08 -07:00
David Garcia Quintas 3165ff3d95 Added compression spec 2016-03-08 01:03:10 -08:00