Commit Graph

912 Commits

Author SHA1 Message Date
AJ Heller 1a8b22f2de [build] Restrict visibility for creating core credentials types. (#36216)
Closes #36216

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36216 from drfloob:conceal-core-cred-creation a44a299273
PiperOrigin-RevId: 625425746
2024-04-17 01:21:29 +00:00
Yash Tibrewal dbaeee2611 Revert "[experiments] Stabilize http2_stats_fix (#36351)" (#36362)
Missed a few steps before stabilizing this

Closes #36362

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36362 from yashykt:Revert36351 5110bc04ec
PiperOrigin-RevId: 625080972
2024-04-15 14:20:21 -07:00
Yash Tibrewal 84ee28e695 [experiments] Stabilize http2_stats_fix (#36351)
Closes #36351

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36351 from yashykt:RemoveHttp2StatsFix 768a7a4de4
PiperOrigin-RevId: 624332015
2024-04-12 17:05:39 -07:00
Esun Kim 3fe06af9a3 [Build] No bind for upb (#36349)
To simplify the build process, let's remove unnecessary Bazel bindings. These bindings were originally used to manage differences between OSS and our internal build environment. However, bindings are now deprecated and introduce unnecessary complexity. Removing them will make the build process more straightforward and easier to maintain.

Closes #36349

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36349 from veblush:upb-link 3eda0c6f92
PiperOrigin-RevId: 624284314
2024-04-12 14:03:46 -07:00
Mark D. Roth 696d644bcf [pick_first] avoid retaining unneeded memory after selecting subchannel (#34766)
The pick_first policy creates a list of subchannels for each resolver update and then iterates over the list, attempting to connect to each subchannel in turn, until one of them succeeds.  However, once a subchannel does succeed, the policy unrefs the other subchannels but still retains a bunch of now-unnecessary state in the subchannel list itself.  This wastes a bunch of memory, especially now that petiole policies are delegating to pick_first.  This PR contains a new pick_first implementation that stops retaining that state, which significantly reduces per-channel memory.

There is one behavior change here, which is that if we have a connected subchannel and we get a resolver update that no longer includes that address, we now go IDLE instead of proactively trying to connect to the new addresses.

Closes #34766

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/34766 from markdroth:pick_first_free_memory_after_connecting 7236b4321f
PiperOrigin-RevId: 623887639
2024-04-11 11:36:27 -07:00
Esun Kim 414ff20941 [Dep] Removing unnecessary upb targets (#36330)
Removing unnecessary upb targets except the following public targets
- `@com_google_protobuf//upb:base`
- `@com_google_protobuf//upb:mem`
- `@com_google_protobuf//upb:message`
- `@com_google_protobuf//upb:reflection`
- `@com_google_protobuf//upb/json`
- `@com_google_protobuf//upb/text`

Context: Internal b/332756248

Closes #36330

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36330 from veblush:upb-clean-up 70a9360489
PiperOrigin-RevId: 623632254
2024-04-10 16:05:01 -07:00
Esun Kim 34a7e76359 [Deps] Rollfoward Protobuf upgrade to v26.1 (#36323)
This reverts commit 78b9d84fd3.

Closes #36323

PiperOrigin-RevId: 623547891
2024-04-10 11:07:26 -07:00
Esun Kim 78b9d84fd3 [Dep] Rollback Protobuf upgrade to v25.1 (#36247)
This is for gRPC Python that has an issue with Protobuf Python v26

Closes #36247

PiperOrigin-RevId: 621629528
2024-04-03 13:56:36 -07:00
Craig Tiller aa3b659e48 [call-v3] Remove `v3_backend_metric_filter` experiment (#36227)
We're all rolled out.

Closes #36227

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36227 from ctiller:v3bmf 08392ddd36
PiperOrigin-RevId: 621263847
2024-04-02 12:43:02 -07:00
Craig Tiller adf6c7b644 [idle] Remove v3 channel idle filter experiment (#36213)
It looks like we're settling on moving this functionality into the channel itself - so removing the filter makes sense (especially since it had some significant bugs)

Closes #36213

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36213 from ctiller:x-ex 3040dcec95
PiperOrigin-RevId: 620996358
2024-04-01 17:15:27 -07:00
Craig Tiller f45b9a8f3d [build] Deduplicate compilation of core e2e tests (#36198)
Closes #36198

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36198 from ctiller:e2edup 38e1d82c1d
PiperOrigin-RevId: 620955836
2024-04-01 14:44:01 -07:00
Craig Tiller 26df942eb4 [build] Stop compiling every test.cc file for every config (#36197)
Instead, build a library and re-use that across compilations.

This still invokes a link step per target, and we'll want to deal with that at some point too, but at least this makes some progress to not being as wasteful with our compilation resources.

Additionally: remove bm_pollset -- it was having some problems compiling, and we really don't need it anymore.

Closes #36197

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36197 from ctiller:maintain-this-shite 9955026e23
PiperOrigin-RevId: 620946543
2024-04-01 14:04:25 -07:00
Esun Kim 03312884dc [Deps] Upgraded protobuf to v26.1 (#35796)
This is to upgrade Protobuf to v26.1 along with upb, and utf8_range.

Closes #35796

PiperOrigin-RevId: 620259696
2024-03-29 09:19:06 -07:00
apolcyn d1287ad07a [build] create xds_end2end_test_lib visibility tag (#36187)
As title

Closes #36187

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36187 from apolcyn:vis_tag 6ce3930e3f
PiperOrigin-RevId: 619955425
2024-03-28 17:36:49 +00:00
Yash Tibrewal 95c4f32b23 [RegisteredMethod] Remove experiment (#36181)
Closes #36181

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36181 from yashykt:RemoveRegisteredMethodLookupInTransport 3709bfa1cf
PiperOrigin-RevId: 619695276
2024-03-28 17:34:39 +00:00
AJ Heller 3d82c522fa [EventEngine] Refactor ServerCallbackCall to use EventEngine::Run (#36126)
This removes two Executor::Run dependencies, and requires that all ServerCallbackCall implementations implement the new `RunAsync` method. There's one other known other implementation of ServerCallbackCall that will need to be updated.

We could also support an "inefficient" path that uses the default engine (not implemented here), for all subclasses that do not want to update. As far as anyone is aware, the ServerCallbackCall class was never intended to be subclassed externally.

Closes #36126

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36126 from drfloob:server-callback-on-ee 6242a78a3f
PiperOrigin-RevId: 619621598
2024-03-28 17:34:00 +00:00
Mark D. Roth e715261ac6 [slice] remove absl_base64 experiment (#36178)
Closes #36178

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36178 from markdroth:b64_remove 0139e3bce8
PiperOrigin-RevId: 619288082
2024-03-26 13:16:27 -07:00
Craig Tiller ca478bd429 [experiments] Remove some, extend some (#36166)
Remove rolled out experiments v3_compression_filter, v3_server_auth_filter; Extend WIP v3_channel_idle_filter for a bit, and extend work_serializer_clears_time_cache until OSS issues with work_serializer_dispatch are resolved.

Closes #36166

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36166 from ctiller:updat3 2c7223f63b
PiperOrigin-RevId: 619057925
2024-03-25 21:35:03 -07:00
Esun Kim 1ce1159a75 [CI] Moved to Bazel 7 (#36105)
Let's use Bazel 7 by default.

Closes #36105

PiperOrigin-RevId: 617653203
2024-03-20 16:16:12 -07:00
Esun Kim 0703276770 [CI] Bazel upgrade (#36104)
Upgraded Bazel as follows;
- Bazel 6.4 to 6.5
- Bazel 7.0 to 7.1

Closes #36104

PiperOrigin-RevId: 616237591
2024-03-15 14:08:10 -07:00
Mark D. Roth 390fef0590 [RR and WRR] clean up dualstack experiments (#35135)
Closes #35135

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35135 from markdroth:dualstack_rr_wrr_cleanup 438b29df5c
PiperOrigin-RevId: 615208297
2024-03-12 16:26:41 -07:00
Mark D. Roth 6546fcd196 [pick first] remove happy eyeballs experiment (#36092)
Closes #36092

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36092 from markdroth:pf_happy_eyeballs_cleanup 24d49849bb
PiperOrigin-RevId: 615157870
2024-03-12 13:45:44 -07:00
Mark D. Roth ae131c991f [client idleness] remove experiment (#35229)
Closes #35229

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35229 from markdroth:client_idleness_experiment_cleanup 65c570d07a
PiperOrigin-RevId: 614882554
2024-03-11 20:02:13 -07:00
Xuan Wang 0f77a5ad9e [BoringSSL] Update third_party/boringssl-with-bazel (#36089)
Change was created by the release automation script. See go/grpc-release.

Additional Changes:
* Boring SSL started to [Require SSE2 when targetting 32-bit x86](56d3ad9d23), thus added `-msse2` to fix some build failures.

Closes #36089

PiperOrigin-RevId: 614822548
2024-03-11 15:58:36 -07:00
Yash Tibrewal 3032b5c48d [OTel C++] Add CMake build support (#36063)
Changes -
* Add CMake build support to `grpcpp_otel_plugin`. Currently, we are only supporting the `find_package CONFIG` method for depending on `opentelemetry-cpp`.
* Since, `grpcpp_otel_plugin` is an extension of gRPC, it will not be built by default. To enable building of this target, a new CMake option `gRPC_BUILD_GRPCPP_OTEL_PLUGIN` is being added.
* Also add `CMakeLists.txt` to the otel example.

The `otel_plugin_test` can also be built through cmake but, for the CI to work, there are some additional changes. Those will be made in an upcoming PR.

Closes #36063

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36063 from yashykt:OTelCMakeSupport 3bc783823b
PiperOrigin-RevId: 613734473
2024-03-07 16:12:10 -08:00
Yash Tibrewal 4ce4f4ea3a [OTel] Add OTel C++ as a submodule (#36032)
Closes #36032

PiperOrigin-RevId: 611657802
2024-02-29 18:06:02 -08:00
Yousuk Seung ed065878e0 [experiments] enable work_serializer_dispatch (posix) (#35992)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35992

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35992 from yousukseung:work-serializer-windows 7b21f46dde
PiperOrigin-RevId: 610042481
2024-02-24 13:22:54 -08:00
Yijie Ma 9db40fa845 [EventEngine] Enable the EventEngine DNS Resolver on Posix (#35573)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35573

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35573 from yijiem:enable-oss-ee-dns-posix-real 1df91d1d84
PiperOrigin-RevId: 609193851
2024-02-21 18:35:54 -08:00
Craig Tiller 7d023ade47 [experiments] Remove completed experiments (and extend rstpit) (#35949)
Closes #35949

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35949 from ctiller:juicy 7fb4afbd69
PiperOrigin-RevId: 609037044
2024-02-21 10:11:45 -08:00
AJ Heller 53fae27f88 [experiment] Disable promise_based_client_call test on Windows (#35952)
There is a continuous failure in the master/windows/bazel_rbe/grpc_bazel_rbe_opt tests. These generate a lot of noise at the moment, and may be hiding other issues, so they are being disabled in CI.

Closes #35952

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35952 from drfloob:ohnowindowspbcc 39ded8e8fa
PiperOrigin-RevId: 608688522
2024-02-20 12:02:25 -08:00
Esun Kim 6f406a7a68 Updated libprotobuf_mutator to the latest (#35833)
This is partially related to protobuf upgrade (https://github.com/grpc/grpc/pull/35796) but it's not strictly required. But it's still a good thing to get this up-to-dated.

Closes #35833

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35833 from veblush:libprotobuf_mutator_update 0fcc0c19dc
PiperOrigin-RevId: 607726401
2024-02-16 10:16:28 -08:00
Yousuk Seung ccc8017bf0 enable work_serializer_dispatch (#35891)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #35891

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35891 from yousukseung:work_serializer ca36cde216
PiperOrigin-RevId: 607380601
2024-02-15 10:36:32 -08:00
Mark D. Roth 17d9e20ff1 [slice] use absl base64 APIs instead of slice base64 APIs (#35851)
Closes #35851

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35851 from markdroth:base64 6caf83d3da
PiperOrigin-RevId: 606759013
2024-02-13 15:05:50 -08:00
Shane Loretz 385431ca4b [Python Bazel] Allow overwriting grpc_library in python_rules.bzl (#35629)
Continues #35412 addressing feedback in https://github.com/grpc/grpc/pull/35412#issuecomment-1875980755

I'm unable to test the workspace with the newly added py_test, so I'm hoping a CI run here will tell me if the test works.

```console
~/grpc/test/distrib/bazel/python$ bazel --nohome_rc --nosystem_rc test //...
Loading:
Loading:
Loading: 0 packages loaded
Analyzing: 37 targets (0 packages loaded, 0 targets configured)
ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:266:21: @com_google_protobuf//upb_generator:protoc-gen-upb_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule
ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:305:21: @com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule
ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:338:21: @com_google_protobuf//upb_generator:protoc-gen-upbdefs_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule
ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:305:21: Target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_stage1' contains an error and its package is in error and referenced by '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain'
ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_github_grpc_grpc/src/proto/grpc/gcp/BUILD:19:14: every rule of type proto_library implicitly depends upon the target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain', but this target could not be found because of: Target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain' contains an error and its package is in error
ERROR: Analysis failed
ERROR: Analysis of target '//namespaced/upper/example:no_import_no_strip_py_pb2_grpc' failed; build aborted:
INFO: Elapsed time: 0.171s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured)
ERROR: Couldn't start the build. Unable to run tests
```

Closes #35629

PiperOrigin-RevId: 606695865
2024-02-13 11:45:29 -08:00
AJ Heller 1a198795fa [experiment] Disable chaotic_good tests on Windows (#35897)
Experiment test failures are blocking fixes on Windows.

Closes #35897

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35897 from drfloob:no-chaotic-good-on-windows 5190d16e60
PiperOrigin-RevId: 606681739
2024-02-13 11:05:56 -08:00
Craig Tiller c75d5c9878 [chaotic-good] Credential implementation (#35884)
Closes #35884

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35884 from ctiller:noodling dbba5d5578
PiperOrigin-RevId: 606362603
2024-02-12 14:21:08 -08:00
Craig Tiller d1cb0c0874 [chaotic-good] Bring up core e2e tests (#35663)
Closes #35663

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35663 from ctiller:shush-e2e 0c1f82ed71
PiperOrigin-RevId: 605717663
2024-02-09 13:34:46 -08:00
Eugene Ostroukhov 239399212a [BoringSSL] "Revert Update third_party/boringssl-with-bazel (#35842)" (#35847)
This reverts commit c968d1a56a.

Closes #35847

PiperOrigin-RevId: 605117622
2024-02-07 15:34:34 -08:00
Eugene Ostroukhov c968d1a56a [BoringSSL] Update third_party/boringssl-with-bazel (#35842)
Closes #35842

PiperOrigin-RevId: 605091673
2024-02-07 14:05:13 -08:00
Eugene Ostroukhov 038215b504 [BoringSSL] Revert "Update third_party/boringssl-with-bazel (#35811)" (#35834)
This reverts commit c2a2e8c09d.

Closes #35834

PiperOrigin-RevId: 604800979
2024-02-06 16:34:14 -08:00
Eugene Ostroukhov c2a2e8c09d [BoringSSL] Update third_party/boringssl-with-bazel (#35811)
Change was created by the release automation script. See go/grpc-release.

Closes #35811

PiperOrigin-RevId: 604701943
2024-02-06 11:02:39 -08:00
AJ Heller 6cd53e1c80 [experiment] Disable Posix EventEngine Client experiment (#35819)
Disabling before the 1.62 branch cut.

There is a flake in one specific interop test: cloud_to_prod_auth:c++:*:oauth2_auth_token:tls, with * being default or gateway_v4. There is also an unresolved PHP crash on test shutdown, just debug builds on Mac (not Linux or Windows).

Closes #35819

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35819 from drfloob:disable-posix-ee-client c42e8b8c20
PiperOrigin-RevId: 604474559
2024-02-05 16:59:51 -08:00
Alisha Nanda 5091b39a28 Remove registered_methods_map experiment (#35673)
Closes #35673

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35673 from ananda1066:remove_exp 76257e08ed
PiperOrigin-RevId: 603734117
2024-02-02 11:07:43 -08:00
Mark D. Roth 354cdecc12 [call v3] add experiment (#35784)
Closes #35784

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35784 from markdroth:call_v3_experiment 2cabe8cca2
PiperOrigin-RevId: 603435692
2024-02-01 11:49:41 -08:00
Esun Kim 1f979d2a83 [BoringSSL] Update third_party/boringssl-with-bazel (#35768)
Change was created by the release automation script. See go/grpc-release.

On top of changes made by the script, `setup.py` had to be updated to have `/std:c11` option for MSVC to use c11 features for boringssl.

Closes #35768

PiperOrigin-RevId: 603403329
2024-02-01 10:06:33 -08:00
Craig Tiller 5b444972f3 [promises+event_engine] Re-enable promise_based_client_call testing (#35678)
The client promise code seems to cause a problem with iomgr pollset shutdown which is causing flakiness.

Right now I don't think it's likely that we'll get this code rolled out before the event engine client lands, so I'm making the experiment dependent on event engine polling.

Closes #35678

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35678 from ctiller:flake 4512fa81b0
PiperOrigin-RevId: 601926443
2024-01-26 19:25:15 -08:00
Craig Tiller 2bb10be729 [experiments] Allow experiments to opt-in to testing against all pollers (default to not) (#35683)
Closes #35683

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35683 from ctiller:minimize2 ac22512f99
PiperOrigin-RevId: 601886350
2024-01-26 15:47:13 -08:00
AJ Heller 8a3a46e295 [EventEngine] Enable the PosixEventEngine client experiment (#35669)
Closes #35669

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35669 from drfloob:posix-ee-client-flip 0d563ed3a1
PiperOrigin-RevId: 601857289
2024-01-26 13:55:28 -08:00
Esun Kim 714640d71f [Deps] Upgrade Abseil to 2024-01-16 (#35589)
Closes #35589

PiperOrigin-RevId: 601647295
2024-01-25 20:14:19 -08:00
AJ Heller 4f50d36f4b [experiment] Stop testing promise_based_client_call due to leak (#35671)
There's roughly a 25% flake of a leak, blocking PR submission due to ASAN failures. Example: https://source.cloud.google.com/results/invocations/5d9fc8b9-c64f-4aaa-bbe6-2fb5f8fd0b24/targets/%2F%2Ftest%2Fcore%2Fend2end:negative_deadline_test@poller%3Dpoll@experiment%3Dpromise_based_client_call/log

Reproducible via: `bazel test --config=asan --test_env=GRPC_VERBOSITY=debug --test_filter='**' --test_sharding_strategy=disabled --runs_per_test=100 -- //test/core/end2end:negative_deadline_test@poller=poll@experiment=promise_based_client_call`

Closes #35671

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35671 from drfloob:broken-promise-based-client-call fe73351671
PiperOrigin-RevId: 601602596
2024-01-25 16:37:06 -08:00