Commit Graph

17 Commits

Author SHA1 Message Date
AJ Heller 3d82c522fa [EventEngine] Refactor ServerCallbackCall to use EventEngine::Run (#36126)
This removes two Executor::Run dependencies, and requires that all ServerCallbackCall implementations implement the new `RunAsync` method. There's one other known other implementation of ServerCallbackCall that will need to be updated.

We could also support an "inefficient" path that uses the default engine (not implemented here), for all subclasses that do not want to update. As far as anyone is aware, the ServerCallbackCall class was never intended to be subclassed externally.

Closes #36126

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36126 from drfloob:server-callback-on-ee 6242a78a3f
PiperOrigin-RevId: 619621598
2024-03-28 17:34:00 +00:00
Mark D. Roth a2b473ec89
address_sorting BUILD: remove license comment breaking import (#31145) 2022-09-27 15:51:21 -07:00
Austin Schuh d30404868f
ARM and -Wextra fixups (#19141)
* Make generated code compile with -Wunused-parameters

-Wunused-parameters is turned on by -Werror -Wextra.  gRPC code
generation creates header files with unused parameters.  So let's modify
the generator to not generate code which will make -Wunused-parameters
unhappy.

* Fix unsigned vs signed comparisons and 32 bit string formats

Fix unsigned vs signed comparison warnings.

For 64 bit numbers printed in gRPC, the string formats assume that you
are running on a 64 bit machine.  Use inttypes.h to make it portable.
Also, use size_t format strings for the same reason.

* Fix unaligned memory access

cost_entry_ptr has no alignment guarentees that ubsan can find.  So it
fails the test with an alignment problem.  Use memcopy to read the data
from the pointer to fix this.

* Fix undefined behavior with memcpy and memcmp

Passing in a 0 length piece of data and a null pointer is undefined
behavior.  If the length is 0, don't pass it in.  This fixes ubsan
failures.

* Clang-format

* Automated change: Fix sanity tests
2021-09-27 04:54:05 -07:00
Alexander Polcyn 69a1115e44 Include stddef.h in address_sorting.h 2020-10-21 11:31:27 -07:00
Lidi Zheng c34bef4ca4 Format all Bazel files with buildifier 2019-11-05 14:03:52 -08:00
Alexander Polcyn 9896c64186 Revert "Merge pull request #16158 from apolcyn/revert_windows_breakage"
This reverts commit d9e8f86675, reversing
changes made to 04847aeb1e.
2018-07-27 01:38:26 -07:00
Alexander Polcyn f34c653936 Revert "Merge pull request #15797 from apolcyn/windows_compile_and_sort"
This reverts commit ae8d3efc3a, reversing
changes made to e41215e181.
2018-07-26 14:32:07 -07:00
Alex Polcyn 1b1d5e52e7 Get c-ares to compile and do address sorting on windows 2018-07-25 13:21:43 -07:00
apolcyn 4736804598
Merge pull request #15208 from apolcyn/fix_addr_sorting_compare_bug
Fix bug in an address sorting comparison
2018-04-30 17:55:12 -07:00
Alexander Polcyn 7e1687b3ef address comment 2018-04-27 18:52:39 -07:00
Alexander Polcyn 0d98c8d9f0 Fix a bug in an address sorting comparison 2018-04-26 20:51:56 -07:00
dmaclach 3fb36a1410
Update License
As far as I can tell, the license file here was completely wrong and was adding 300+ K of unnecessary bloat to every app that included grpc.
2018-04-23 15:14:21 -07:00
Alexander Polcyn 046ad6b13f Fix bug in addr sorting shutdonw 2018-04-19 10:20:20 -07:00
Alex Polcyn 77f64f76bd Put address_sorting's public header under its own directory. Also add
test_only to sort function used in test.
2018-03-20 23:51:23 -07:00
Alexander Polcyn 47a92893a3 Remove unnecessary header inclusion from address sorting's public header 2018-03-20 23:51:23 -07:00
Alexander Polcyn d21ee15076 Stop relying on certain ipv6 macros. Also bazel build updates.
Fix error just made in bazel/grpc_build_system.bzl

Fix merge conflict support/env -> gpr/env
2018-03-20 23:51:23 -07:00
Alexander Polcyn 690dde672a Add address sorting submodule for use in c-ares wrapper 2018-03-20 23:51:19 -07:00