829f41b733
ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability ( #31571 )
...
* ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability
* Trailing new lines
* Fix naked include
* clang-tidy
* Reviewer comments
* Reviewer comments
2022-11-09 14:13:20 -08:00
5b8f006ece
[build] Stop publishing iomgr/error.h from grpc_base ( #31521 )
...
* [build] Stop publishing iomgr/error.h from grpc_base
* fixes
* fix
2022-11-08 20:04:31 -08:00
90d8754b0e
Sanitizer auto fix ( #31582 )
2022-11-08 14:23:35 -05:00
8696d49e23
Added version macros ( #31033 )
2022-11-07 11:31:00 -08:00
50fbe51238
Fix IWYU with clang-15 ( #31556 )
...
* Fix iwyu
* iwyu fix
* more fixed
* Build fix
* more fix
* More fixes 3
2022-11-04 15:49:56 -07:00
530b702259
Update Clang 15 ( #31518 )
...
* clang-15
* iwyu
* run clang_format_code
* Clang-Tidy config
* Fix misc-unused-using-decls
* Fixed performance-inefficient-vector-operation
* Sanity
2022-11-04 09:08:03 -07:00
37c6662919
Remove `include/grpcpp/impl/codegen/callback_common.h` ( #31311 )
...
* Remove `include/grpcpp/impl/codegen/callback_common.h`
* Update
2022-11-01 18:34:20 -04:00
08ee2a3487
Remove `include/grpcpp/impl/codegen/call_op_set.h` ( #31310 )
2022-10-31 22:33:35 -04:00
a99a65b6e2
GcpObservability: Add parsing for logging config ( #31502 )
...
* GcpObservability: Add parsing for logging config
* Unused parameters
* Reviewer comments
2022-10-31 17:02:20 -07:00
5f6c357e74
Move some targets from //: to //src/core: ( #31402 )
...
* temp
* temp
* temp
* top BUILD builds
* everything builds
* buildify
* temp fix_build_deps change
* fix gpr_atm
* additional changes
* fix build files
* nofixdeps
* Generate projects
* json_args
* fix context
* Generate projects
* Sprinkle some avoid_dep tags
* Run fix_build_deps
* Remove additional avoid_dep
* Revert some targets
* grpc_mock_cel
2022-10-20 20:12:53 -07:00
3b6675c2de
OpenCensus: Move measures, views and CensusContext to include file ( #31341 )
...
* OpenCensus: Move measure and view declarations to include file
* Move CensusContext class too
* Fix IWYU
* Guard with experimental
* Formatting
* clang tidy fixes
* cleanup
* Reviewer comments
2022-10-20 17:42:08 -07:00
1a9ce63199
Revert "Remove `include/grpcpp/impl/codegen/status_code_enum.h` ( #31284 )" ( #31387 )
...
This reverts commit 3981105be6
2022-10-18 10:27:04 -07:00
3981105be6
Remove `include/grpcpp/impl/codegen/status_code_enum.h` ( #31284 )
2022-10-18 11:34:24 -04:00
727ae8c885
GcpObservability: Add experimental public target ( #31339 )
...
* GcpObservability: Add experimental public target
* Yapf and IWYU
2022-10-17 12:43:45 -07:00
20d1efc38a
[stats] Move core stats to C++ ( #30936 )
...
* begin c++
* Automated change: Fix sanity tests
* progress
* progress
* missing-files
* Automated change: Fix sanity tests
* moved-from-stats
* remove old benchmark cruft, get tests compiling
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* add needed constructor
* Automated change: Fix sanity tests
* iwyu
* fix
* fix?
* fix
* fix
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* add visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: AJ Heller <hork@google.com>
2022-10-09 21:22:08 -07:00
85794d4094
Deprecated grpc_error_std_string ( #31267 )
2022-10-07 10:16:18 -07:00
0469b1ea68
OpenCensus: Fix data race ( #31255 )
2022-10-06 09:17:04 -07:00
c802adfa8a
[event_engine] Move security executor usage to event engine ( #31231 )
...
* [event_engine] Move security executor usage to event engine
* build-fix
* fix-iwyu
2022-10-05 20:50:56 -07:00
a10a591612
GCP Observability: Disable OpenCensus Stats/Tracing if the config doesn't enable them ( #31253 )
2022-10-05 15:35:06 -07:00
8cffd1044e
OpenCensus: Ability to globally disable stats and tracing ( #31252 )
...
* OpenCensus: Ability to globally disable stats and tracing
* Fix docs
2022-10-05 14:38:15 -07:00
347bf1a1f4
Removed GRPC_ERROR_[INT|STR] macros ( #31195 )
...
* Clean-up which
* Reformat
2022-10-03 11:33:56 -07:00
4bd27c524a
More changes ( #31194 )
2022-09-30 17:10:01 -07:00
f11282df8d
Bump dev version v1.51-dev ( #31174 )
...
* bump version to 1.51.0-dev
* regenerate projects
2022-09-29 14:58:01 -07:00
c62013d699
[c++] Implement DynamicThreadPool in-terms-of event engine ( #30553 )
...
* Make GetDefaultEventEngine return a shared_ptr
This works around valgrind memory leaks by giving EventEngines a fixed
lifetime.
* dynamic pointer cast + documentation
* change the default engine's shared_ptr mechanics; add test
* Integrate new shared_ptr throughout
* promise fix
* forget previous default engines after setting a new EE factory
* Automated change: Fix sanity tests
* fix the autofixer's mistake
* add EventEngine to promise based filter context
* fix fuzer time control
* fix
* add PHP valgrind suppressions for NativeDNSResolver (does not destroy)
* manual iwyu/sanitize
* fix dependency
* fix
* add EE factory reset
* Automated change: Fix sanity tests
* fix
* manual sanitize
* bdp_estimator: replace mutex with atomic
* format
* comment out unused args
* remove stowaway
* unused param
* prelude
* use-ee
* simpler
* fix
* Automated change: Fix sanity tests
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-29 07:09:26 -07:00
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2022-09-29 06:45:17 -07:00
d7266f48f4
GcpObservability: Disable observability traces for CloudOps endpoints ( #31094 )
...
* GcpObservability: Disable observability traces for CloudOps endpoints
* Fix deps and IWYU
2022-09-28 16:09:13 -07:00
4ccb80252b
Revert "Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )" ( #31155 )
...
This reverts commit 6fbff9c6a9
2022-09-28 15:37:50 -07:00
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2022-09-28 08:39:56 -07:00
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2022-09-27 23:17:39 -07:00
6fbff9c6a9
Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )
...
This reverts commit dedcc7dbf6
2022-09-27 21:53:35 -07:00
dedcc7dbf6
GcpObservability: Change default views provided ( #31144 )
...
* GcpObservability: Change default views provided
* Fix IWYU
* Fix deps
2022-09-27 16:53:42 -07:00
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2022-09-27 14:34:07 -07:00
ba8af0157b
Removing GRPC_ERROR_[REF|UNREF|IS_NONE] ( #31089 )
...
* Removing GRPC_ERROR_[REF|UNREF|IS_NONE]
* Clean up unnecessary error
* Fix
* Fix2
* Remove unnecessary else
2022-09-26 15:41:12 -07:00
ebc4f236b6
[slice] Remove _internal variants of APIs ( #30953 )
...
* [slice] Remove _internal variants of APIs
* Automated change: Fix sanity tests
* fix
* reduce bloat
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-24 13:34:00 -07:00
9cff4d2d28
OpenCensus Plugin: Add missing measure and views for started RPCs ( #31034 )
2022-09-20 17:26:16 -07:00
5e0165bc02
EventEngine: fix callers of Run() and RunAfter() to create ExecCtx ( #31047 )
2022-09-20 09:07:15 -07:00
5cd8ee25f8
GcpObservabilityConfig: New changes ( #31038 )
...
* GcpObservabilityConfig: New changes
* Fix IWYU
2022-09-19 15:29:46 -07:00
27e5b4e187
GcpObservabilityConfig: Fall-back to GCP environment variables ( #31022 )
2022-09-19 11:48:35 -07:00
7cb9731e4e
Remove `include/grpcpp/impl/codegen/call_op_set_interface.h` ( #30990 )
2022-09-16 17:27:50 -04:00
c2ab8c99bb
Revert "Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )" ( #30988 )
...
This reverts commit 96264e07b8
2022-09-14 14:19:36 -07:00
96264e07b8
Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )
...
This reverts commit 74c0d6fe3f
2022-09-14 11:53:55 -07:00
74c0d6fe3f
[c++] Move environment functions to C++ ( #30937 )
...
* [gprpp] Move env to C++
* move headers/impl
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Update http_proxy.cc
* fix
* fix
* rename
* fix merge
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-14 10:17:15 -07:00
b3ad894e05
GcpObservability: Use the observability config ( #30932 )
...
* GcpObservability: Use the observability config
* iwyu
* Fix build
2022-09-13 11:47:19 -07:00
ebcda5f0c1
GcpObservabilityConfig: s/disabled/enabled ( #30905 )
2022-09-09 15:58:38 -07:00
f7f4c9b584
GcpObservability: Code for reading config from env var ( #30889 )
...
* GcpObservability: Code for reading config from env var
* Comments
* Fix deps
* clang-tidy
2022-09-09 15:14:15 -07:00
e90972bef6
Bump gcc 6 to 7 ( #30903 )
...
* Bump gcc 6 to 7
* Update
* Update 2
2022-09-09 09:23:11 -07:00
a644d8c9b4
GcpObservabilityConfig: cloud_trace.sampling_rate ( #30904 )
2022-09-08 21:43:47 -07:00
260a02d1ad
Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure"" ( #30894 )
...
* Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure (#30866 )" (#30892 )"
This reverts commit 37b631d1fd
2022-09-08 13:43:37 -07:00
610a248059
[stats] Optimize histogram system ( #30834 )
...
* recurse
* bsearch
* bounds
* optimize stats
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-09-08 13:30:28 -07:00
37b631d1fd
Revert "GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )" ( #30892 )
...
This reverts commit 31c68b5f10
2022-09-07 20:20:44 -07:00
31c68b5f10
GcpObservabilityConfig: Add some basic field parsing structure ( #30866 )
...
* GcpObservabilityConfig: Add some basic field parsing structure
* IWYU
* clang format
2022-09-07 15:27:23 -07:00
004788af3d
[cleanup] Remove profiling timers ( #30779 )
...
* [cleanup] Remove profiling timers
- nobody has used this system in years
- if we needed it, we'd probably rewrite it at this point to be something more modern
- let's remove it until that need arises
* fix
* fixes
2022-08-30 13:40:08 -07:00
0a7d131b9e
GcpObservability: Fix import ( #30793 )
2022-08-30 08:55:32 -07:00
60a1b4ad6f
Revert "Revert "GCP Observability: Add plugin registry API"" ( #30766 )
...
* Revert "Revert "GCP Observability: Add plugin registry API (#30571 )" (#30765 )"
This reverts commit b8fde2ab47
2022-08-29 17:22:03 -07:00
b8fde2ab47
Revert "GCP Observability: Add plugin registry API ( #30571 )" ( #30765 )
...
This reverts commit 486710317f
2022-08-26 09:42:19 -07:00
486710317f
GCP Observability: Add plugin registry API ( #30571 )
...
* GCP Observability: Add plugin registry API
* Restrict visibility for now
* Move GcpObservability to its own thing
* Reviewer comments
2022-08-26 09:22:48 -07:00
778f04dccf
Bump version on master branch to 1.50.0.dev ( #30614 )
...
* bump version to 1.50.0-dev
* regenerate projects
2022-08-17 18:20:27 -07:00
d025c1732f
Revert "Reland: Make GetDefaultEventEngine return a shared_ptr ( #30563 )" ( #30573 )
...
This reverts commit ee7c0a8e4c
2022-08-12 14:31:56 -07:00
0e38bb3b5c
Update OpenCensus to HEAD ( #30567 )
...
* Update OpenCensus to HEAD
* Fix build
* IWYU
* Fix IWYU
2022-08-12 10:12:13 -07:00
ee7c0a8e4c
Reland: Make GetDefaultEventEngine return a shared_ptr ( #30563 )
...
* Reland: "Make GetDefaultEventEngine return a shared_ptr (#30280 )"
This reverts commit 45959e7cc1
2022-08-12 08:09:31 -07:00
45959e7cc1
Revert "Make GetDefaultEventEngine return a shared_ptr ( #30280 )" ( #30558 )
...
This reverts commit 4df74f2b4c
2022-08-10 18:28:30 -07:00
3c9cbb2d4d
OpenCensus: fixes broken traces exporting caused by a missing EndSpan ( #29745 )
...
* OpenCensus: fixes broken traces exporting caused by a missing EndSpan
* Fix variable name
* Fixes test.
* Adds timeout to span test
2022-08-10 17:18:21 -07:00
4df74f2b4c
Make GetDefaultEventEngine return a shared_ptr ( #30280 )
...
This works around valgrind memory leaks by giving EventEngines a fixed
lifetime. We eventually want ref-counted EventEngines internally, so this is
a step in the right direction as well.
2022-08-10 11:32:09 -07:00
8f5300b95d
Rename the default EventEngine headers ( #30528 )
...
* Rename the default EventEngine headers
Small cleanup. This code hasn't been related to factories for a month or
two.
* ensure only one target contains default_event_engine.h
* src + hdr in same target
* include guards
2022-08-08 13:13:53 -07:00
f268659bf1
Revert "Revert "[filter-stack] Eliminate flags on initial metadata ( #30444 )" ( #30475 )" ( #30476 )
...
This reverts commit 4bc69cbe38
2022-08-03 12:03:07 -07:00
4bc69cbe38
Revert "[filter-stack] Eliminate flags on initial metadata ( #30444 )" ( #30475 )
...
This reverts commit cd30b2dda1
2022-08-02 22:07:54 -07:00
cd30b2dda1
[filter-stack] Eliminate flags on initial metadata ( #30444 )
...
* [filterstack] Eliminate flags on initial metadata
Instead prefer to pass this data in non-encoded metadata.
Needed to fix MetadataMap::Copy to copy non-encoded metadata (not doing so was unintended).
Removed the flags from call_details because there's not been a use for them there for a very long time.
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-08-02 20:22:35 -07:00
756498e157
Adding lock and reset call_ in ~ClientContext to avoid race condition ( #30270 )
...
* Adding lock and reset call_ in ~ClientContext to avoid race condition
* Remove lock in ~ClientContext
2022-08-02 12:22:36 -07:00
536b9351ec
JSON: use absl::Status instead of grpc_error ( #30397 )
...
* JSON: use absl::Status instead of grpc_error
* Automated change: Fix sanity tests
* fix credentials_test
* fix tests
* add missing build dep
* fix build
* fix test
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-27 09:52:21 -07:00
f4edc883ab
service config API: use absl::Status instead of grpc_error ( #30321 )
...
* service config API: use absl::Status instead of grpc_error
* Automated change: Fix sanity tests
* add missing build deps
* attempt to work around build breakage on older compilers
* trying the work-around in more spots
* more work-arounds
* more workarounds
* Automated change: Fix sanity tests
* work around another compiler problem
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-07-26 09:29:07 -07:00
0450157e06
[iwyu] Better handle <type_traits> ( #30349 )
...
* update mapping
* run tool
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-20 16:48:20 -07:00
d304712f64
[channel_args] Spread grpc_core::ChannelArgs through client channel code ( #30008 )
...
* [channel_args] Spread grpc_core::ChannelArgs through client channel code
* progress
* progress
* grpc compiles
* uniqueptr+compiles
* fix
* fix
* fix
* fix
* fix
* fix
* fixes
* fix
* fix
* fixes
* fix-lb
* fix
* fix up arg construction
* fix
* fix
* fix
* fix
* move to const& to save bytes
* fix
* fix
* progress
* review feedback
* fix
* fix
* fixes
* fixes
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* debug-helper
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-07-07 19:19:11 -07:00
89f7534e43
Bump dev version 202207012203 ( #30177 )
...
* bump version to 1.49.0-dev
* regenerate projects
2022-07-04 16:38:08 -07:00
80541dbc25
Revert "Revert "Second attempt: health check service: rewrite using callback … ( #29813 )" ( #30168 )
...
This reverts commit 897bc2c100
2022-07-01 11:43:14 -07:00
b1b59eb508
Add the link to Foundational C++ Support Policy ( #30157 )
2022-06-30 13:22:59 -07:00
0fc0384b5a
Revert "EventEngine::RunAt: C++ Alarm ( #30024 )" ( #30147 )
...
This reverts commit da0eb19b22
2022-06-29 15:35:31 -07:00
eb5ae61470
Reland (again) bytestream removal ( #29987 )
...
* Revert "Revert "Reland bytestream removal (#29911 )" (#29964 )"
This reverts commit e6c6840db3
2022-06-27 21:21:23 -07:00
ad936d3710
[bloat] Prefer std::vector to absl::InlinedVector ( #30086 )
...
* [bloat] Prefer std::vector to absl::InlinedVector
* fix
* fix
* fix
* fix
* fixes
* fix
* fixes
2022-06-24 04:04:12 -07:00
c66c362191
Reland "Enable GRPC_ERROR_IS_ABSEIL_STATUS" ( #30047 )
...
* Revert "Revert "Enable GRPC_ERROR_IS_ABSEIL_STATUS (#29869 )" (#30031 )"
This reverts commit 2d0d1775a9
2022-06-23 12:38:19 -07:00
da0eb19b22
EventEngine::RunAt: C++ Alarm ( #30024 )
...
* EventEngine::RunAt: C++ Alarm
* format
* mutex
* iwyu
* RunAfter EE API change
* Automated change: Fix sanity tests
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-06-16 20:19:00 -07:00
823682e4df
OrcaService: fix timer race on cancellation ( #30035 )
...
* temporary debug statement
* fix race; remove debug statements
* reviewer suggestion
2022-06-16 16:28:57 -07:00
d9f64437b0
[event_engine] Use durations for scheduling things ( #30023 )
...
* [event_engine] Use durations for scheduling things
* fix
* Automated change: Fix sanity tests
* run-after
* fix
* Automated change: Fix sanity tests
* rename
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-06-16 09:39:31 -07:00
2d0d1775a9
Revert "Enable GRPC_ERROR_IS_ABSEIL_STATUS ( #29869 )" ( #30031 )
...
This reverts commit c6058b5e6b
2022-06-15 21:41:55 -07:00
c6058b5e6b
Enable GRPC_ERROR_IS_ABSEIL_STATUS ( #29869 )
...
* Enable GRPC_ERROR_IS_ABSEIL_STATUS
* Sanitize
* Fix ServerRequestCallTest
2022-06-15 15:06:15 -07:00
6598793c9f
EventEngine::RunAt: Orca Service Timer ( #30011 )
...
* EventEngine::RunAt: Orca Service Timer
* optional changes to optionals
* Automated change: Fix sanity tests
* fix the build (the auto-fixer broke it)
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2022-06-14 17:10:47 -07:00
6532084a06
[iwyu] rest of the owl: src/core/lib - excluding iomgr, gpr ( #29735 )
...
* [iwyu] rest of the owl: src/core/lib - excluding iomgr, gpr
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* x
* fix?
* fix
* windows fix
* fix
* fix
* fix
* fix
* fix
* debug
* fix
* fix
* Revert "debug"
This reverts commit c99b8d12dd
2022-06-10 13:04:47 -07:00
e6c6840db3
Revert "Reland bytestream removal ( #29911 )" ( #29964 )
...
* Revert "Reland bytestream removal (#29911 )"
This reverts commit 98dcba2807
2022-06-09 08:51:06 -07:00
c6ebbb5482
Added GRPC_ERROR_IS_NONE ( #29937 )
...
* Added GRPC_ERROR_IS_NONE
* Convert
* Fix
2022-06-08 11:24:20 -07:00
a5b08d7a77
[iwyu] Improve iwyu for public headers ( #29834 )
...
* [iwyu] Improve iwyu for public headers
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-06-07 10:31:15 -07:00
98dcba2807
Reland bytestream removal ( #29911 )
...
* Revert "Revert "Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )" (#29894 )" (#29910 )"
This reverts commit 713a1581d5
2022-06-05 18:42:28 -07:00
713a1581d5
Revert "Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )" ( #29910 )
...
This reverts commit 93cdc8b77e
2022-06-05 11:01:48 -07:00
93cdc8b77e
Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )
...
* Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )"
This reverts commit d53986657f
2022-06-04 15:51:16 -07:00
d53986657f
Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )
...
This reverts commit aacf0e252b
2022-06-02 19:34:49 -07:00
aacf0e252b
[transport] Remove ByteStream ( #29637 )
...
* A starter SliceBuffer implementation
* Add comments and fix sanity checks
* Minor fixes
* more minor fixes
* Addressing review comments and adding a slice_buffer_test
* fix sanity checks
* regenerate projects
* fixing undefined function error
* reverting changes from memory_allocator.cc and adding them to src/core/lib/slice/slice_buffer.cc to allow memory allocator lib to build correctly
* fix sanity checks
* adding an open source slice definition
* regnerate projects
* fix asan error
* Automated change: Fix sanity tests
* addressing review comments
* fix sanity checks
* regenerate projects
* update
* fix sanity checks
* Converting slice buffer to retarin ownership of the underlying ctype
* [slice_buffer] Introduce grpc_core::SliceBuffer
* add test
* Automated change: Fix sanity tests
* [byte-stream] Delete ByteStream
* progress
* progress
* missing files
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* sanity
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* iwyu
* fix
* progress
* fix
* fix
* progress
* code compiles
* fix?
* bogus assert
* Automated change: Fix sanity tests
* fix
* fix
* fix?
* fix
* fix
* better expression of function
* fix?
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add fullstack test without retry filter
* debug
* missing files
* gc
* fix h2_full_no_retry
* remove headers
* fixes
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* progress
* x
* tear apart flow control
* continue itnegration
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* cleanup
* Automated change: Fix sanity tests
* fix
* x
* x
* Revert "debug"
This reverts commit 0120a944925fe05120776df476b22f
2022-06-02 16:04:32 -07:00
65a7ce3f04
Revert "Revert "server: add method to expose authority seen by server ( #29768 )" ( #29806 )" ( #29807 )
...
This reverts commit e39e943529
2022-05-31 14:15:45 -07:00
761bb3bfc3
Bump version to 1.48.0-dev (on master branch) ( #29829 )
...
* bump version to 1.48.0-dev
* regenerate projects
2022-05-27 15:16:27 -07:00
897bc2c100
Revert "Second attempt: health check service: rewrite using callback … ( #29813 )
...
* Revert "Second attempt: health check service: rewrite using callback API (#29562 )"
This reverts commit 90ee4e85f5
2022-05-27 11:26:26 -07:00
e39e943529
Revert "server: add method to expose authority seen by server ( #29768 )" ( #29806 )
...
This reverts commit 449adce98b
2022-05-26 16:15:14 -07:00
449adce98b
server: add method to expose authority seen by server ( #29768 )
...
* server: add method to expose authority seen by server
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2022-05-26 15:03:28 -07:00
da7069e33d
[iwyu] rest of the owl: src/core/ext ( #29642 )
...
* [iwyu] rest of owl: src/core/ext, excluding binder
* merge
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-24 12:50:30 -07:00
06377249e3
Add NetBSD support (Community-supported) ( #29542 )
...
* Add NetBSD support
* Add NetBSD to platforms list as 'Community Supported'
* Add contact email for issues with the NetBSD port.
2022-05-23 13:41:52 -07:00
2f6277c1fb
Version changes ( #29752 )
2022-05-20 16:21:24 -07:00
667691c499
server: per-rpc backend metric reporting ( #29621 )
...
Users can now report per-rpc metrics from servers to clients.
2022-05-20 15:54:30 -07:00
0f9d024fec
[iwyu] c++ ( #29721 )
...
* Revert "Revert "[iwyu] grpc++ (#29610 )" (#29720 )"
This reverts commit 0642bc213d
2022-05-19 07:34:48 -07:00
0642bc213d
Revert "[iwyu] grpc++ ( #29610 )" ( #29720 )
...
This reverts commit c8159eabdf
2022-05-18 09:58:08 -07:00
c8159eabdf
[iwyu] grpc++ ( #29610 )
...
* [iwyu] grpc++
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* [iwyu] Better script
* eliminate race
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-18 07:16:53 -07:00
93e6894485
Revert "Fix gRPC C++ init bug ( #29689 )" ( #29701 )
...
This reverts commit de613e3a9e
2022-05-16 10:48:50 -07:00
de613e3a9e
Fix gRPC C++ init bug ( #29689 )
2022-05-14 13:56:08 -07:00
5918f98ecb
[iwyu] Enable nosafe_headers ( #29591 )
...
* Add flag
* sweep1
* fixes
* speedup
* fixes
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-06 11:31:11 -07:00
90ee4e85f5
Second attempt: health check service: rewrite using callback API ( #29562 )
...
* Revert "Revert "health check service: rewrite using callback API (#29457 )" (#29559 )"
This reverts commit d4680eb8eb
2022-05-04 14:03:03 -07:00
18bec00b58
[channel-stack] Eliminate post-init in channel stack builder ( #29514 )
...
* Eliminate post-init in channel stack builder
We've had a post init function on channel stack builder for a very long
time, an it serves to run some code after initialization completes.
We need the functionality for a few things, but the function passed in
is intimately tied to the filter in use - we never vary it between
multiple functions for the same filter... which means it makes more
sense to locate this functionality as part of the filter interface.
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-05-03 13:06:51 -07:00
d4680eb8eb
Revert "health check service: rewrite using callback API ( #29457 )" ( #29559 )
...
This reverts commit 2b00c7d2ad
2022-05-02 20:59:44 -07:00
2b00c7d2ad
health check service: rewrite using callback API ( #29457 )
2022-05-02 10:37:31 -07:00
2badafbc4d
Expose NoOpCertificateVerifier to C++ ( #29322 )
...
* expose NoOpCertificateVerifier to C+
2022-04-27 13:46:01 -07:00
6f3d7ccdb1
Modifying slice buffer add to merge two contiguous slices sharing the same refcount object ( #29466 )
...
* Modifying slice buffer add to merge two contiguous slices sharing the same refcount object
* sanity checks
* updating test
* fixing grpc_slice_buffer_add API misuse in proto utils
* fix sanity checks
* minor fix
2022-04-22 11:54:41 -07:00
8bb45aa3a6
Convert grpc_channel to C++ ( #29266 )
...
* begin
* tests
* fix
* http
* Filter fuzzer
* progress
* basics
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
2022-04-20 20:55:15 -07:00
f12658cdcd
Remove unmatched grpc_init from *ChannelFromFd methods ( #29434 )
...
* Remove unmatched grpc_init from *ChannelFromFd methods
These unmatched grpc_init calls were preventing grpc_shutdown from
completing, which notably showed up in the only tests we have that
exercise these methods: `client_interceptors_end2end_tests.cc`.
These inits appear to be unnecessary, so I removed them. But if I've
missed some reason they're needed, an alternative is to find the right
place to add the corresponding `init_lib.shutdown();` call. I'm not sure
where that would be at this point.
See b/175634383
* Alternative: init & shutdown before calling any core library
2022-04-18 16:30:47 -07:00
98fc0260e3
Bump dev version to v1.47.0-dev ( #29414 )
...
* bump version to 1.47.0-dev
* regenerate projects
2022-04-15 13:25:15 -07:00
58de9394aa
fixing unused return value error ( #29358 )
2022-04-08 13:25:36 -07:00
60c56f7d01
Second attempt: implement ORCA RPC service for OOB backend metric reporting ( #29352 )
...
* Revert "Revert "ORCA: implement ORCA RPC service for OOB backend metric reporting (#29215 )" (#29351 )"
This reverts commit 71b355624f
2022-04-08 11:12:18 -07:00
71b355624f
Revert "ORCA: implement ORCA RPC service for OOB backend metric reporting ( #29215 )" ( #29351 )
...
This reverts commit 6d6380de58
2022-04-07 16:15:49 -07:00
6d6380de58
ORCA: implement ORCA RPC service for OOB backend metric reporting ( #29215 )
...
* ORCA: implement ORCA RPC service for OOB backend metric reporting
* fix unused parameter error
* gen_upb_api
* add missing build deps
* increase test timing fudge factor
* add missing copyright header
* buildifier
* don't register as a generic service
* report interval defaults to min interval
* don't regenerate the response proto unless something changed
* use INTERNAL for proto parsing failure
* use absl::Duration in public API
2022-04-07 07:58:58 -07:00
eded3b6bc3
client channel: record call completion even if recv_trailing_metadata was not started ( #29198 )
...
* client channel: record call completion even if recv_trailing_metadata was not started
* add test
* add test for opencensus filter
* remove unnecessary code
2022-03-24 14:22:16 -07:00
99a30de9e7
Bump version to 1.46.0-dev (on master branch) ( #29064 )
...
* bump version to 1.46.0-dev
* regenerate projects
2022-03-09 16:44:12 -08:00
fe913387da
Remove idempotent/cacheable requests ( #28922 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* Modify XdsRbacTests
Co-authored-by: Yash Tibrewal <yashkt@google.com>
2022-03-04 14:42:59 -08:00
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-03-01 11:34:05 -08:00
c08eb4fc41
Attempt to upgrade upb to the latest ( #28685 )
...
* Update upb to 85e5c76cb7098d3ae35e575d652a40568013a149
* Update grpc_deps.bzl
* Run gen_upb_api.sh
* Run run_sed.sh
* Update gen_build_yaml.py
* Regen projects
* Reformat
* Update third_party/upb to 950cdab42fe4c83f06a2be46eeb46a068e486eed
* Update third_party/upb to c9c31241bc39922b092a81d192badd50cccaaa81
* Update src/upb/gen_build_yaml.py
* Generated projects
* Update third_party/upb to a02d92e0257a35f11d4a58b6a932506cbdbb2f29
* Patching in https://github.com/protocolbuffers/upb/pull/524
* Sed script went too far.
Co-authored-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
2022-02-28 09:26:31 -08:00
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-02-23 20:50:03 -08:00
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-18 16:18:54 -08:00
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
2022-02-17 17:56:19 -08:00
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
2022-02-17 16:23:25 -08:00
6565584c7b
Bump the minimum gcc to 5 ( #28786 )
2022-02-11 10:31:25 -08:00
b458db9246
Eliminate gRPC insecure build ( #25586 )
...
* force submit
* fix test error
* remove is_client from local tsi and its callsites
* fix too_many_pings_test
* add missing dep
2022-02-10 11:17:18 -08:00
1cdcd88fb1
Add experimental API for CRL checking support to gRPC C++ TlsCredentials ( #28407 )
2022-01-26 20:23:48 -08:00
6bf8e22484
Add http cancel api ( #28354 )
...
Add an API to cancel HTTP1 requests
2022-01-25 10:37:05 -08:00
e4107caf26
c++-ize channel stack builder ( #28660 )
...
* c++-ize channel stack builder
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* comment
* move functions out of line
* Automated change: Fix sanity tests
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-24 15:28:08 -08:00
17c6a486cd
Expose promise-ness to filter proper ( #28658 )
...
* Expose promise-ness to filter proper
* Make transports able to export promises too
* Add make promise op to transport
2022-01-24 09:05:32 -08:00
74a2cb6e2b
Revert "Revert "Reland slice changes ( #28601 )" ( #28615 )" ( #28624 )
...
* Revert "Revert "Reland slice changes (#28601 )" (#28615 )"
This reverts commit 939bbfc336
2022-01-20 12:47:33 -08:00
402981be8e
Bump version to 1.45.0-dev ( #28553 )
...
* bump version to 1.45.0-dev
* regenerate projects
2022-01-20 09:23:06 +01:00
939bbfc336
Revert "Reland slice changes ( #28601 )" ( #28615 )
...
This reverts commit b33e0d40af
2022-01-19 09:40:19 -08:00
aeea02fab8
TLS Session Keys export for GRPC C++ ( #26812 )
...
* Adding TLS Key export logic to core and c++ wrappers
* Adding and end2end cpp tls key export test and updating broken test due to interface changes
* regenerate projects
* updating tls key export core logic with addition of APIs to grpc_security.h
* undoing changes to tls_security_connector_test
* regenerate projects
* changing the logging format enum name as per GRFC comments
* regenerate projects
* removing some commented code
* updating changes as per review comments
* adding GRPCAPI annotations to functions defined in grpc_security.h
* regenerate projects
* fixed some code styling issues
* removing grpc_security.h include from tls_credentials_options.h
* updating files as per review comments
* minor fixes
* moving some code around
* removing key log format from tls session key log config and converting it to a simple string
* regenerate projects
* fixing mistakes in recent merge with master
* regenerate projects
* regenerate projects
* fixing some distrib and snity errors
* fixing formatting errors
* fixing more sanity checks and raising supported openssl versions to 1.1.1
* updating min supported openssl version to 1.1.1
* updating min supported openssl version in tls_key_export_test
* updating test to fix incorrect vector initialization
* updating as per latest comments
* fixing sanity checks
* addressing review comments
* fixing sanity checks
* fixed c++ comment style
* Automated change: Fix sanity tests
* fixing review comments
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
2022-01-18 14:44:55 -08:00
b33e0d40af
Reland slice changes ( #28601 )
...
* Revert "Revert "Eliminate slice interning (#28363 )" (#28598 )"
This reverts commit 03bf699600
2022-01-18 09:29:49 -08:00
03bf699600
Revert "Eliminate slice interning ( #28363 )" ( #28598 )
...
This reverts commit 6703186b7a
2022-01-18 15:44:18 +01:00
6703186b7a
Eliminate slice interning ( #28363 )
...
Eliminate slice interning, and structures in slices to support it.
Reduces grpc_slice_refcount from 40 bytes (+ a required 8 bytes elsewhere) to 16 bytes.
Removes a pointer dereference for every slice ref/unref.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-17 20:25:45 -08:00
4b881c5947
Remove grpc_mdelem ( #28267 )
...
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2022-01-07 09:42:27 -08:00
55b365f287
Move resolver code around a little ( #27846 )
...
* move service config
* service config should not depend on grpc_base
* move resolver, deal with fallout
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* review feedback
* review feedback
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix vis
* fix
* fixes
* Automated change: Fix sanity tests
* visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2022-01-06 10:53:40 -08:00
0deb64d1f6
Move content-type, colon prefixed metadata to new system ( #28204 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* initial refactoring
* optimize status encoding
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-12-13 12:11:45 -08:00
ba06eeb07c
Bump to v1.44.0 dev ( #28248 )
...
* Bump version to v1.44.0-dev
* Regenerate projects
2021-12-06 09:50:51 -08:00
220cf641fa
Reland slice metadata conversion ( #28210 )
...
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
2021-11-29 13:38:40 -08:00
7717587063
Revert "Move a bunch of slice typed metadata to new system ( #28107 )" ( #28208 )
...
This reverts commit 4d432aefc1
2021-11-24 15:41:36 -08:00
4d432aefc1
Move a bunch of slice typed metadata to new system ( #28107 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-24 11:42:37 -08:00
672f31c6ac
Channel args preconditioning ( #28132 )
...
* Channel args preconditioning
* docs
* fixes
* Automated change: Fix sanity tests
* fix
* fix this again after merge error
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-11-22 15:24:39 -08:00
0bdb4d650b
Revert "Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )" ( #28144 )
...
This reverts commit eec0ca98c1
2021-11-19 09:15:04 -08:00
eec0ca98c1
Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )
...
This reverts commit 2ea8e50c3a
2021-11-18 14:50:39 -08:00
1050eedb87
enable clang-tidy readability-static-definition-in-anonymous-namespace check ( #28033 )
2021-11-17 07:48:43 -08:00
2ea8e50c3a
use CppImplOf for grpc_server ( #28112 )
...
* use CppImplOf for grpc_server
* fix build
* fix sanity
2021-11-17 07:46:53 -08:00
a629c9a03e
Reland resource quota work ( #28017 )
...
* Check if memory owner available prior to polling it
The transport may drop the memory owner during its destruction sequence
* tcp_fix
* Revert "Revert "New resource quota integration (#27643 )" (#28014 )"
This reverts commit 0ea2c37263
2021-11-15 08:23:51 -08:00
0ea2c37263
Revert "New resource quota integration ( #27643 )" ( #28014 )
...
This reverts commit 39f0877d25
2021-11-11 14:26:19 -08:00
39f0877d25
New resource quota integration ( #27643 )
...
* new resource quota integration
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* fixes
* fix
* fixes
* windows-fix
* fixes
* fixes
* fix
* fix-asan
* banned
* banned
* fixes
* clang-tidy-fix
* Automated change: Fix sanity tests
* fix-cronet
* review feedback
* review feedback
* Automated change: Fix sanity tests
* fixes
* bug fix
* fixes
* compile fix
* exclude megabyte size payloads from 1byte tests
* windows fix
* start moving ios
* keep moving windows
* Get windows compilation working.
* Automated change: Fix sanity tests
* better
* fixes
* remove slice buffer from memory_allocator.h
* Revert "remove slice buffer from memory_allocator.h"
This reverts commit 234a63b6e3
2021-11-10 22:53:04 -08:00
2e14f6fa70
Support Custom Post-handshake Verification in TlsCredentials ( #25631 )
...
* custom verification refactoring - post-handshake verification
2021-11-10 13:45:52 -08:00
296f596a96
OpenCensus: Move metadata storage to arena ( #27948 )
2021-11-05 13:13:10 -07:00
13d98176b5
bump version on master to 1.43-dev ( #27930 )
...
* bump version on master to 1.43-dev
* bump core version
* update g_stands_for.md
2021-11-04 16:19:56 -07:00
6f4f920398
switch to official protobuf podspec ( #27830 )
2021-10-29 15:58:34 -07:00
b85ca5d5ce
MetadataCredentialsPluginWrapper: Create thread pool only if needed ( #27791 )
...
Non-blocking metadata credentials plugins do not use a thread pool.
2021-10-21 17:03:03 -07:00
eceffa09cb
upgrade protobuf to 3.18.1 (automatically generated) ( #27722 )
...
* Update third_party/protobuf
* run tools/distrib/python/make_grpcio_tools.py
* regenerate protos for csharp, ruby, php
* update build_handwritten.yaml
* update Protobuf-C++.podspec
* regenerate projects
* [objc] Patch protobuf podspec for 3.18.1 update
- excluding reflection_tester with gtest dependency
Co-authored-by: dennycd <dennycd@google.com>
2021-10-21 14:52:28 -07:00
a61bb8ed5b
Move service config code out of client_client to its own target ( #27683 )
...
* Move service config code out of client_client to its own target
* Fix BUILD
* Fix test build
* Reviewer comments
* Reviewer comments
* Automated change: Fix sanity tests
* Reviewer comments
Co-authored-by: yashykt <yashykt@users.noreply.github.com>
2021-10-12 18:30:04 -07:00
a1db97be90
Revert "Revert "Revert "Revert "File watcher authorization policy provider implementation"" ( #27605 )" ( #27644 )" ( #27645 )
...
This reverts commit b8e01f73a0
2021-10-08 15:52:13 -07:00
b8e01f73a0
Revert "Revert "Revert "File watcher authorization policy provider implementation"" ( #27605 )" ( #27644 )
...
This reverts commit 5912aedb2b
2021-10-07 16:45:30 -07:00
ec4c61a3ae
Various fixes on absl::Status migration ( #27557 )
2021-10-07 14:49:59 -07:00
5912aedb2b
Revert "Revert "File watcher authorization policy provider implementation"" ( #27605 )
...
* Revert "Revert "File watcher authorization policy provider implementation (#26779 )" (#27591 )"
This reverts commit a1ad74f7af
2021-10-07 09:54:23 -07:00
a1ad74f7af
Revert "File watcher authorization policy provider implementation ( #26779 )" ( #27591 )
...
This reverts commit 310accd077
2021-10-05 09:12:08 -07:00
f5b3a49af6
Describe support-levels for undocumented supported platforms ( #27363 )
...
Quite a few platforms were missing from this list. No new support is
being added, this PR just documents the current state of affairs.
2021-10-04 19:05:52 -07:00
310accd077
File watcher authorization policy provider implementation ( #26779 )
...
* File watcher authorization policy provider implementation
2021-10-04 14:22:45 -07:00
36b0e06e20
OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch ( #27523 )
...
* OpenCensusCallTracer: Move context generation to StartTransportStreamOpBatch
* Reviewer comments
2021-10-02 13:36:10 -07:00
9b41852a5e
channel_init --> core configuration system ( #27347 )
...
* channel_init --> core configuration system
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* eliminate grpc_base_c
* fixes
* fix merge
* fix
* update visibility
* fixes
* feedback
* fix comment
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-27 15:51:39 -07:00
5690ea0106
Added gcc11 and clang12 tests ( #27190 )
2021-09-27 10:48:58 -07:00
d30404868f
ARM and -Wextra fixups ( #19141 )
...
* Make generated code compile with -Wunused-parameters
-Wunused-parameters is turned on by -Werror -Wextra. gRPC code
generation creates header files with unused parameters. So let's modify
the generator to not generate code which will make -Wunused-parameters
unhappy.
* Fix unsigned vs signed comparisons and 32 bit string formats
Fix unsigned vs signed comparison warnings.
For 64 bit numbers printed in gRPC, the string formats assume that you
are running on a 64 bit machine. Use inttypes.h to make it portable.
Also, use size_t format strings for the same reason.
* Fix unaligned memory access
cost_entry_ptr has no alignment guarentees that ubsan can find. So it
fails the test with an alignment problem. Use memcopy to read the data
from the pointer to fix this.
* Fix undefined behavior with memcpy and memcmp
Passing in a 0 length piece of data and a null pointer is undefined
behavior. If the length is 0, don't pass it in. This fixes ubsan
failures.
* Clang-format
* Automated change: Fix sanity tests
2021-09-27 04:54:05 -07:00
06ef5893f8
Metadata: replace usage of grpc_metadata_batch_remove with Remove method ( #27420 )
2021-09-21 14:45:49 -07:00
ffb2c5e599
Metadata: replace usage of grpc_metadata_batch_link_{head,tail} with Link{Head,Tail} method ( #27419 )
...
* Metadata: replace usage of grpc_metadata_batch_link_{head,tail} with Link{Head,Tail} method
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-21 14:44:59 -07:00
b669a3c521
Revert "Revert "a useful change ( #27381 )" ( #27411 )" ( #27412 )
...
This reverts commit 5db17f7350
2021-09-20 19:46:11 -07:00
9872da79a1
Eliminate grpc_metadata_batch_{init,destroy,move} ( #27349 )
...
* Eliminate grpc_metadata_batch_{init,destroy,move}
* fixes
* fixes
* fixes
* fixes
* portability fixes
* fixes
* fix
* fix
* fix
* be explicit about being explicit
2021-09-20 17:25:26 -07:00
5db17f7350
Revert "a useful change ( #27381 )" ( #27411 )
...
This reverts commit 11eb70bbed
2021-09-20 10:30:59 -07:00
11eb70bbed
a useful change ( #27381 )
...
* a useful change
* Automated change: Fix sanity tests
* fix
* fix
* QsortCompare it is!
* Automated change: Fix sanity tests
* add missing header
* clang-tidy fixes, tweak clamp to only use <
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-20 09:13:27 -07:00
b9a997be11
Bump version to v1.41.0 ( #27370 )
...
* Bump version to v1.41.x
* Regenerate projects
2021-09-16 16:32:34 -07:00
0a502d8f2e
Fix race between Read and ServerContext::IsCancelled in Sync API ( #27056 )
...
* Fix OOM issues in qps tests
* Add more verbose logging.
* Fix clang error
* Fix race between IsCancelled and Read
* Fix build errors from using bool in C code
2021-09-15 12:29:02 -07:00
fd233193ec
Encapsulate metadata aggregates ( #27262 )
...
* Encapsulate metadata aggregates
* Automated change: Fix sanity tests
* add const
* Automated change: Fix sanity tests
* add a comment about an awful api
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2021-09-14 09:45:38 -07:00
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
2021-09-09 16:22:25 -07:00
5765d320d2
Remove unused APIs ( #27270 )
2021-09-08 12:49:00 -07:00
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
2021-09-08 12:14:44 -07:00
f9a2a7401a
Upgrade third_party/protobuf to v3.17.3 ( #27227 )
...
* update protobuf dependency
* version changes and generated files
* updating upb to use the latest proto and regen files
2021-09-05 22:21:37 -07:00
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
2021-09-02 11:42:33 -07:00
9e4c657fa3
C++ opencensus filter: Fix point of creating context for overall call ( #27221 )
2021-09-01 18:37:53 -07:00
f84f3a7522
Fix potential nullptr names in resource_user/slice_allocator creation ( #27154 )
...
absl::string_view permits construction with nullptr, which yields UB.
This PR fixes all call sites that could have created these objects with
nullptr names.
2021-08-26 19:30:07 -07:00
69661fb82e
Regenerate projects
2021-08-21 02:04:00 -07:00
1040c1b90a
Add note on officially supported platforms ( #22344 )
...
* Add initial section on support
* Update src/cpp/README.md
Co-Authored-By: Nicolas Noble <nicolasnoble@users.noreply.github.com>
* Reviewer comments
* Reviewer comments
Co-authored-by: Nicolas Noble <nicolasnoble@users.noreply.github.com>
2021-08-17 13:58:35 -07:00
1b3e1541fa
Open census call attempt span name and attribute changes ( #26889 )
...
* C++ OpenCensus filter: Add attributes to per-attempt span
* Reviewer comments
* Reviewer comment
* Remove extraneous assert
2021-08-05 16:38:53 -07:00
013e67a029
Deprecate grpc{_core,::internal}::WaitUntil ( #26866 )
...
It is not possible for such a function to be implemented in a way that
is understood by annotalysis. Mark it deprecated and replace instances
of its use with direct mutex/condvar usage.
Add a bunch of missing thread safety annotations while I'm here.
2021-08-04 17:03:25 -07:00
a3d264e8fd
Open census filter stats api ( #26739 )
...
* Use new stats API in open census filter
* Fix time and latency calculation
* Fix parent census context
* Add tests
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Fix error unref
* Add a context object for the overall call
* Remove TODO
* Reviewer comments
2021-08-02 14:00:15 -07:00
a325d7f77a
Pointing the protobuf submodule to the new URL ( #26811 )
...
* Pointing the protobuf submodule to the new URL
* Also changing WORKSPACE dependencies
* More references to the old URL...
2021-07-29 10:19:16 -07:00
ae3e2c9214
Second attempt: use CallTracer API in client channel code ( #26790 )
...
* Revert "Revert "use CallTracer API in client channel code (#26714 )" (#26772 )"
This reverts commit 98f57af91ca9657b560da9657b5
2021-07-26 15:30:16 -07:00
98f57af91c
Revert "use CallTracer API in client channel code ( #26714 )" ( #26772 )
...
This reverts commit 011fdefe36
2021-07-26 06:49:28 -07:00
1265cfd29a
Add OpenCensus measures and views for retries ( #26751 )
...
* Add OpenCensus measures and views for retries
* Fix views
* Fix measures
2021-07-23 11:53:57 -07:00
011fdefe36
use CallTracer API in client channel code ( #26714 )
...
* Add internal API to help trace retries and collect metrics
* Add headers
* Reviewer comments
* Revert changes for grpc_metadata_batch
* Regenerate projects
* support call tracer in client channel code
* Reviewer comments
* Reviewer comments
* Reviewer comments
* reviewer comments
* add RecordOnDoneSendInitialMetadata() hook
* Fix sanity
* make on_call_destruction_complete always invoked via LoadBalancedCall
* fix handling of status, stats, latency, and peer name
* fix build & clang-format
Co-authored-by: Yash Tibrewal <yashkt@google.com>
2021-07-22 15:17:24 -07:00
dc250d1c68
Add internal API to help trace retries and collect metrics ( #26673 )
...
* Add internal API to help trace retries and collect metrics
* Add headers
* Reviewer comments
* Revert changes for grpc_metadata_batch
* Regenerate projects
* Reviewer comments
* Reviewer comments
* Reviewer comments
* reviewer comments
* Fix sanity
2021-07-20 07:05:59 -07:00
a4b43ccdf2
Added CentOS 7 note for pkg-config ( #26554 )
2021-07-15 09:45:01 -07:00
b9a69481c2
Revert "Support user provided "scope" in JWT and GDC ( #26577 )" ( #26645 )
...
This reverts commit 6df967966b
2021-07-09 15:05:34 -07:00
0e6c888574
Bump version to 1.40.0-dev ( #26600 )
...
* Bump version to 1.40.0
* Regenerate projects
* Tweak version.cc.template to satisfy formatter
* Regenerate projects
2021-07-02 14:33:34 -07:00
6df967966b
Support user provided "scope" in JWT and GDC ( #26577 )
...
* support scope overriding in jwt and gdc
* fix formatting
* fix bazel build issue
* fix clang tidy
2021-07-01 10:26:33 -07:00
471df71003
removing grpc_metadata::flags, improving GRPC_INITIAL_METADATA_* comments ( #26562 )
2021-06-30 12:03:29 -07:00
ea4b68e7a1
Drop experimental tags from core callback API ( #26535 )
2021-06-24 17:20:43 -07:00
932dbed49d
Revert "Allow to specify user provided audience in google default credentials and JWT credentials ( #26456 )" ( #26531 )
...
This reverts commit 5a91a513fd
2021-06-22 16:30:30 -07:00
cf1ebf7387
Remove experimental tag from uses of the C++ callback API ( #26495 )
2021-06-20 00:47:07 -07:00
5a91a513fd
Allow to specify user provided audience in google default credentials and JWT credentials ( #26456 )
...
* support user provided audience in gdc and jwt
2021-06-11 09:44:46 -07:00
39d007e83b
Updated instructions for vcpkg install on Windows ( #26373 )
...
* Updated instructions for vcpkg install on Windows
bootstrap-vcpkg.sh script doesn't work out of the box on Windows
Rest of the commands are OS-neutral
* Update README.md
2021-06-11 11:21:49 +02:00
a3ae8e00a2
Revert "Allow to specify user provided audience in google default credentials and JWT credentials ( #26392 )" ( #26440 )
...
This reverts commit 304262e135
2021-06-07 15:24:54 -07:00
b9a643a817
Static policy provider implementation. ( #26134 )
2021-06-03 23:18:08 -07:00
304262e135
Allow to specify user provided audience in google default credentials and JWT credentials ( #26392 )
...
* support user provided audience in gdc and jwt
* fix 1st round of comments
* fix ruby and php to use new GDC API
* fix python clang issue
* address 2nd round of comments
* fix string_view issue
* remove length param in string_view constructor
2021-06-03 16:02:19 -07:00
57c1c91525
Add missing header inclusions. ( #26424 )
2021-06-03 15:44:05 -07:00
8aff94558c
De-experimentalize C++ callback API ( #25728 )
...
* De-experimentalize callback API
* Make FromServerContext based on ServerContextBase
* Fix lambda
* Fix headers
* De-experimentalize tests
* clang-format
* Fix consistency checks
* wip
* Fix const-ness of callback client read RPC requests
* Fix golden file
* Give full route_guide callback client example with Hold etc
* Complete example route-guide server
* De-experimentalize test services
* Omit unneeded using
* Remove some uses of non-experimental macro from test
* clang-format examples
* De-experimentalize async stub calls
* Remove experimental namespace use in qps, ubms
* De-experimentalize alarms, generic stubs, and context allocator
* De-experimentalize SetContextAllocator
* clang-format
* Fix conflicts
* Leave obsolete API in place until users can be migrated
2021-05-27 14:55:25 -07:00
a99ead4bf4
Added new method to ByteBuffer & Slice ( #26014 )
2021-05-27 11:18:18 -07:00
153bc67f45
Revert "Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )" ( #26375 )" ( #26379 )
...
This reverts commit 259a74c0e6
2021-05-27 09:16:05 -07:00
259a74c0e6
Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )" ( #26375 )
...
This reverts commit 66253c521a
2021-05-26 22:20:23 -07:00
66253c521a
Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )
...
* Revert "Revert "Expose trailers-only response status through C++ callback API (#26249 )" (#26363 )"
This reverts commit 05c3b30ea0
2021-05-25 17:43:21 -07:00
05c3b30ea0
Revert "Expose trailers-only response status through C++ callback API ( #26249 )" ( #26363 )
...
This reverts commit 393bae7e88
2021-05-25 13:44:10 -07:00
393bae7e88
Expose trailers-only response status through C++ callback API ( #26249 )
...
* Expose trailers-only response status through callback API
* Fix change-detector test
* Address reviewer comment about trailers_only headers
* Add TODO requested by markdroth
* Move variable in struct to improve space efficiency
* Don't instantiate ExecCtx in channel_args destructor unless needed
2021-05-21 14:42:41 -07:00
3eb96489f4
Don't instantiate ExecCtx in channel_args destructor unless needed ( #26332 )
2021-05-21 11:14:44 -07:00
0f80378a21
Resolve race between OnReadDone(ok=false) and IsCancelled ( #26245 )
...
* Resolve and test race between OnReadDone(ok=false) and IsCancelled
* Fix retry case
* Fix health check case
* Address reviewer comments.
* ADD TODO requested by markdroth
2021-05-19 14:05:46 -07:00
cbcb0253a0
Additional logging for proto deserialization ( #26159 )
...
* Fix build failures in xds_end2end_test
* Change Status::OK to StatusCode::OK
* Added additional logging for proto deserialization failure
* Added additional logging for serialization failure
* Revert "Added additional logging for serialization failure"
This reverts commit 2dbbbed9d431f4e6e3c8
2021-05-11 15:36:39 -07:00
a989179ace
Bump master to v1.39.0 ( #26207 )
...
* Bump version to v1.39.0
* Regenerate projects
* Buildifier format
2021-05-11 06:49:10 -07:00
edf500fb82
Add useful status error message when server threadpool is exhausted ( #26146 )
2021-05-03 12:16:12 -07:00
81276fff2e
Update protobuf version to 3.15.8 ( #26105 )
...
* Update protobuf version to 3.15.8
* Run tools/distrib/python/make_grpcio_tools.py
2021-04-30 11:03:23 -07:00
dc6948cf35
Use atomics to remove locks in Channel/Server::CallbackCQ() ( #26091 )
2021-04-27 14:54:07 -07:00
2bf75aa68a
Add optional suffix to client-side stub objects ( #25996 )
...
* Adding suffix for stats handling to gRPC
* Fixing typo
* Fixing codegen, adding tests
* Fixing test failures
* Adding nullptr default in StubOptions
* Updating golden test file
* Replacing std::make_unique with absl::make_unique for pre-C++14 compatibility
* Fixing clang format errors
* Reuse stub options for generic stubs
* Cleaning up compiler warnings in GenericStub
2021-04-26 17:19:43 -07:00
460898f11c
Migrated from grpc_error_string to grpc_error_std_string ( #26068 )
...
* Added grpc_error_std_string
* Migrated to grpc_error_std_string
2021-04-23 16:31:54 -07:00
ca945a58e9
Introduced grpc_error_handle ( #25902 )
...
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
2021-04-22 12:00:28 -07:00
feff79abc7
add test-only channel arg to set per-channel xDS bootstrap config ( #25936 )
...
* pass XdsClient to LB policies via channel args
* add channel arg for overriding bootstrap config on a per-channel basis
* change tests to use new channel arg approach -- currently failing for server-side tests
* use the same channel args approach on the server side
* clang-format
* fix CircuitBreakingMultipleChannelsShareCallCounter test
* fix XdsEnabledServerTest test
* add TODO
* clang-format
* generate_projects
* fix clang-tidy
* fix build
* attempt to fix python
2021-04-21 10:16:33 -07:00
2210819f85
Remove _xds suffix Bazel rules completely ( #25980 )
...
* Reduce the usage of _xds Bazel rules
* Inject DISABLED_XDS_PROTO_IN_CC to admin_services_end2end_test
* Remove _xds suffix Bazel rules completely
* Remove the _xds rules from imports
* Simplify the ifndef usage in admin_services_end2end_test
2021-04-15 12:50:00 -07:00
57859e3c9d
Remove duplicate code for grpc encoding, and extra class. ( #22334 )
...
* Remove duplicate code for grpc encoding, and extra class.
Originally from #18359 by @bogdandrutu.
* Autoformat.
2021-04-08 11:42:56 +02:00
9964ae875b
Bump master version to 1.38 ( #25838 )
...
* Bump version to 1.38
* Regenerate projects
2021-03-30 13:57:13 -07:00
d3d15395e1
Mark that callback generic service is frequently-polled ( #25798 )
2021-03-24 09:31:01 -07:00
b457f43227
Implement C++ Admin Interface API ( #25753 )
...
* Implement C++ Admin Interface API
* Address reviewer's requests
* Remove static asserts for raw pointers
* Make sanity tests happy
* Windows: pacify conflict between ifndef and macros
* Disable admin services test on iOS
* Make iOS happy by:
* Letting grpcpp_admin conditionally depend on grpcpp_csds
* Fix an unexpected side-effect of dependency update
2021-03-23 09:53:12 -07:00
1040fbdb9f
Re-introduce "CSDS Implementation" ( #25762 )
...
* Revert "Revert "CSDS Implementation (#25038 )" (#25745 )"
This reverts commit 98fd4e1e36
2021-03-22 13:14:19 -07:00
fb5543c7c6
Add g_gli_initializer to server_context ( #25759 )
2021-03-18 16:06:49 -07:00
98fd4e1e36
Revert "CSDS Implementation ( #25038 )" ( #25745 )
...
This reverts commit 27de24a38e
2021-03-17 13:38:47 -07:00
27de24a38e
CSDS Implementation ( #25038 )
...
* Implement the xDS Config Dump as CSDS in Core
* Revemp the logic of caching and constructing the CSDS response
* Unref created error
* Fix the clang tidy complains
* Resolve comments about symbol preload and Json ctor
* Improve readability
* Merge with new ADS logic && support latest CSDS
* Refactor the version/client_status logic
* Add support for error_state
* Add support for does_not_exist
* Add node information
* Fix the ProtoBuf segfault
* More test cases
* Refactor to use bytes as cache instead of JSON
* Apply clang_tidy's suggestion
* Resolve reviewer's requests
* Tiny stylish fixes && make sanity test happy
* WIP: still working on the matchers
* Update a bunch of matchers
* Improve readability a bit
* Resolve reviewer's suggestions
* Resolve reviewer's comments
* Make Unpack fail fast
2021-03-16 18:17:37 -07:00
b36d3f7e33
Annotate C++ server ( #25605 )
...
* Make annotations real in server header
* More annotations
* clang-fmt
* Annotate shutdown state variables
* Fix annotation of CV predicate
* Fix param list
2021-03-10 10:52:26 -08:00
a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr ( #25628 )
2021-03-09 21:30:35 -08:00
377fe6095a
Upgrade clang-tidy and clang-format to 11 ( #25590 )
...
* Upgrade clang-tidy and clang-format to 11
* Reformat code
* Fix abseil-string-find-str-contains
* Fix modernize-make-unique
2021-03-04 11:54:30 -08:00
37bd0a0cbd
Fix race at server shutdown between actual shutdown and MatchOrQueue ( #25541 )
...
* Fix race at server shutdown between actual shutdown and MatchOrQueue
* Address reviewer comments
* Add thread safety annotations
* Address reviewer comments
2021-03-01 12:16:53 -08:00
2a656ce68b
Don't dynamically allocate default server context ( #25576 )
2021-02-26 14:21:35 -08:00
Yash Tibrewal