natas_hw
/
grpc
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

php: call credentials plugin_get_metadata metadata leak

This commit is contained in:
Zhouyihai Ding 2018-01-23 20:43:53 -08:00
parent c84c8d44c7
commit ec0669c8a2
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/php/ext/grpc/call.c
View File

@ -128,10 +128,12 @@ bool create_metadata_array(zval *array, grpc_metadata_array *metadata) {
HashTable *inner_array_hash;
zval *value;
zval *inner_array;
grpc_metadata_array_init(metadata);
metadata->count = 0;
metadata->metadata = NULL;
if (Z_TYPE_P(array) != IS_ARRAY) {
return false;
}
grpc_metadata_array_init(metadata);
array_hash = Z_ARRVAL_P(array);
char *key;

1
src/php/ext/grpc/call_credentials.c
View File

@ -195,6 +195,7 @@ int plugin_get_metadata(
if (!create_metadata_array(retval, &metadata)) {
*status = GRPC_STATUS_INVALID_ARGUMENT;
should_return = true; // Synchronous return.
grpc_php_metadata_array_destroy_including_entries(&metadata);
}
if (retval != NULL) {