From bfdfc9eabc90effd1c8bbe70235182f7a08673cd Mon Sep 17 00:00:00 2001 From: Esun Kim Date: Thu, 12 Nov 2020 15:15:41 -0800 Subject: [PATCH] Python3 ios_bin/binary_size.py --- tools/profiling/ios_bin/binary_size.py | 4 ++-- tools/profiling/ios_bin/parse_link_map.py | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/profiling/ios_bin/binary_size.py b/tools/profiling/ios_bin/binary_size.py index ed0e89e2fbe..ffb51867366 100755 --- a/tools/profiling/ios_bin/binary_size.py +++ b/tools/profiling/ios_bin/binary_size.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2.7 +#!/usr/bin/env python3 # # Copyright 2018 gRPC authors. # @@ -143,6 +143,6 @@ for frameworks in [False, True]: text += '\n No significant differences in binary sizes\n' text += '\n' -print text +print(text) check_on_pr.check_on_pr('Binary Size', '```\n%s\n```' % text) diff --git a/tools/profiling/ios_bin/parse_link_map.py b/tools/profiling/ios_bin/parse_link_map.py index eaa1d6e0608..95ca153a390 100755 --- a/tools/profiling/ios_bin/parse_link_map.py +++ b/tools/profiling/ios_bin/parse_link_map.py @@ -36,7 +36,7 @@ def parse_link_map(filename): objc_size = 0 protobuf_size = 0 - lines = list(open(filename)) + lines = open(filename, encoding='utf-8', errors='ignore').readlines() for line in lines: line_stripped = line[:-1] if "# Object files:" == line_stripped: @@ -66,6 +66,8 @@ def parse_link_map(filename): if len(line_stripped) == 0 or line_stripped[0] == '#': continue segs = re.search('^.+?\s+(.+?)\s+(\[.+?\]).*', line_stripped) + if not segs: + continue target = table_tag[segs.group(2)] target_stripped = re.search('^(.*?)(\(.+?\))?$', target).group(1) size = int(segs.group(1), 16)