natas_hw
/
grpc
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Fix] new clang -Wthread-safety-analysis warnings (#34614) 

Returning a reference to a GUARDED_BY variable while only holding the
lock in the getter lets callers access the variable without holding the
lock.

See https://github.com/llvm/llvm-project/pull/67776.

This is only used for testing, so just return a copy for simplicity.




<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
This commit is contained in:
Arthur Eubanks 2023-10-31 12:50:21 -07:00 committed by GitHub
parent 652e9093fd
commit 4e34078eaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/lib/security/security_connector/tls/tls_security_connector.h
View File

@ -205,12 +205,12 @@ class TlsServerSecurityConnector final : public grpc_server_security_connector {
return server_handshaker_factory_;
};
const absl::optional<absl::string_view>& RootCertsForTesting() {
absl::optional<absl::string_view> RootCertsForTesting() {
MutexLock lock(&mu_);
return pem_root_certs_;
}
const absl::optional<PemKeyCertPairList>& KeyCertPairListForTesting() {
absl::optional<PemKeyCertPairList> KeyCertPairListForTesting() {
MutexLock lock(&mu_);
return pem_key_cert_pair_list_;
}