[test] delete client_channel_stress_test (#33763)

This test has been disabled for a long time now due to flakiness, but
it's now causing problems with the import. And stress tests don't
provide positive ROI anyway, so let's just get rid of it.

CMakeLists.txt

@@ -898,9 +898,6 @@ if(gRPC_BUILD_TESTS)
   add_dependencies(buildtests_cxx client_authority_filter_test)
   add_dependencies(buildtests_cxx client_callback_end2end_test)
   add_dependencies(buildtests_cxx client_channel_service_config_test)
-  if(_gRPC_PLATFORM_LINUX OR _gRPC_PLATFORM_MAC OR _gRPC_PLATFORM_POSIX)
-    add_dependencies(buildtests_cxx client_channel_stress_test)
-  endif()
   add_dependencies(buildtests_cxx client_channel_test)
   add_dependencies(buildtests_cxx client_context_test_peer_test)
   add_dependencies(buildtests_cxx client_interceptors_end2end_test)
@@ -8997,70 +8994,6 @@ target_link_libraries(client_channel_service_config_test
 )
 
 
-endif()
-if(gRPC_BUILD_TESTS)
-if(_gRPC_PLATFORM_LINUX OR _gRPC_PLATFORM_MAC OR _gRPC_PLATFORM_POSIX)
-
-  add_executable(client_channel_stress_test
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/lb/v1/load_balancer.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/lb/v1/load_balancer.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/lb/v1/load_balancer.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/lb/v1/load_balancer.grpc.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/duplicate/echo_duplicate.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/duplicate/echo_duplicate.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/duplicate/echo_duplicate.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/duplicate/echo_duplicate.grpc.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo.grpc.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo_messages.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo_messages.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo_messages.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/echo_messages.grpc.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/simple_messages.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/simple_messages.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/simple_messages.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/simple_messages.grpc.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/xds/v3/orca_load_report.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/xds/v3/orca_load_report.grpc.pb.cc
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/xds/v3/orca_load_report.pb.h
-    ${_gRPC_PROTO_GENS_DIR}/src/proto/grpc/testing/xds/v3/orca_load_report.grpc.pb.h
-    test/cpp/client/client_channel_stress_test.cc
-    test/cpp/end2end/test_service_impl.cc
-    third_party/googletest/googletest/src/gtest-all.cc
-    third_party/googletest/googlemock/src/gmock-all.cc
-  )
-  target_compile_features(client_channel_stress_test PUBLIC cxx_std_14)
-  target_include_directories(client_channel_stress_test
-    PRIVATE
-      ${CMAKE_CURRENT_SOURCE_DIR}
-      ${CMAKE_CURRENT_SOURCE_DIR}/include
-      ${_gRPC_ADDRESS_SORTING_INCLUDE_DIR}
-      ${_gRPC_RE2_INCLUDE_DIR}
-      ${_gRPC_SSL_INCLUDE_DIR}
-      ${_gRPC_UPB_GENERATED_DIR}
-      ${_gRPC_UPB_GRPC_GENERATED_DIR}
-      ${_gRPC_UPB_INCLUDE_DIR}
-      ${_gRPC_XXHASH_INCLUDE_DIR}
-      ${_gRPC_ZLIB_INCLUDE_DIR}
-      third_party/googletest/googletest/include
-      third_party/googletest/googletest
-      third_party/googletest/googlemock/include
-      third_party/googletest/googlemock
-      ${_gRPC_PROTO_GENS_DIR}
-  )
-
-  target_link_libraries(client_channel_stress_test
-    ${_gRPC_BASELIB_LIBRARIES}
-    ${_gRPC_PROTOBUF_LIBRARIES}
-    ${_gRPC_ZLIB_LIBRARIES}
-    ${_gRPC_ALLTARGETS_LIBRARIES}
-    grpc++_test_util
-  )
-
-
-endif()
 endif()
 if(gRPC_BUILD_TESTS)
 

build_autogenerated.yaml

@@ -6258,28 +6258,6 @@ targets:
   deps:
   - grpc_test_util
   uses_polling: false
-- name: client_channel_stress_test
-  gtest: true
-  build: test
-  run: false
-  language: c++
-  headers:
-  - test/cpp/end2end/test_service_impl.h
-  src:
-  - src/proto/grpc/lb/v1/load_balancer.proto
-  - src/proto/grpc/testing/duplicate/echo_duplicate.proto
-  - src/proto/grpc/testing/echo.proto
-  - src/proto/grpc/testing/echo_messages.proto
-  - src/proto/grpc/testing/simple_messages.proto
-  - src/proto/grpc/testing/xds/v3/orca_load_report.proto
-  - test/cpp/client/client_channel_stress_test.cc
-  - test/cpp/end2end/test_service_impl.cc
-  deps:
-  - grpc++_test_util
-  platforms:
-  - linux
-  - posix
-  - mac
 - name: client_channel_test
   gtest: true
   build: test

test/cpp/client/BUILD

@@ -38,36 +38,6 @@ grpc_cc_test(
     ],
 )
 
-grpc_cc_test(
-    name = "client_channel_stress_test",
-    srcs = ["client_channel_stress_test.cc"],
-    # TODO(jtattermusch): test fails frequently on Win RBE, but passes locally
-    # reenable the tests once it works reliably on Win RBE.
-    # TODO(roth): Test marked as manual for now due to variable duration
-    # problem triggered by https://github.com/grpc/grpc/pull/22481.
-    # Once we figure out the problem, either re-enable or just decide to
-    # remove this test.  Tracked internally in b/153136407.
-    tags = [
-        "manual",
-        "no_test_android",  # fails on android due to "Too many open files".
-        "no_windows",
-    ],
-    deps = [
-        "//:exec_ctx",
-        "//:gpr",
-        "//:grpc",
-        "//:grpc++",
-        "//:grpc_resolver_fake",
-        "//src/proto/grpc/lb/v1:load_balancer_proto",
-        "//src/proto/grpc/testing:echo_messages_proto",
-        "//src/proto/grpc/testing:echo_proto",
-        "//src/proto/grpc/testing/duplicate:echo_duplicate_proto",
-        "//test/core/util:grpc_test_util",
-        "//test/cpp/end2end:test_service_impl",
-        "//test/cpp/util:test_util",
-    ],
-)
-
 grpc_cc_test(
     name = "destroy_grpclb_channel_with_active_connect_stress_test",
     srcs = ["destroy_grpclb_channel_with_active_connect_stress_test.cc"],

test/cpp/client/client_channel_stress_test.cc

@@ -1,351 +0,0 @@
-//
-//
-// Copyright 2017 gRPC authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-//
-
-#include <atomic>
-#include <memory>
-#include <mutex>
-#include <random>
-#include <sstream>
-#include <string>
-#include <thread>
-
-#include "absl/memory/memory.h"
-#include "absl/strings/str_cat.h"
-
-#include <grpc/grpc.h>
-#include <grpc/support/alloc.h>
-#include <grpc/support/log.h>
-#include <grpc/support/time.h>
-#include <grpcpp/channel.h>
-#include <grpcpp/client_context.h>
-#include <grpcpp/create_channel.h>
-#include <grpcpp/impl/sync.h>
-#include <grpcpp/server.h>
-#include <grpcpp/server_builder.h>
-
-#include "src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb_balancer_addresses.h"
-#include "src/core/ext/filters/client_channel/resolver/fake/fake_resolver.h"
-#include "src/core/lib/address_utils/parse_address.h"
-#include "src/core/lib/gprpp/crash.h"
-#include "src/core/lib/gprpp/ref_counted_ptr.h"
-#include "src/core/lib/gprpp/thd.h"
-#include "src/core/lib/iomgr/exec_ctx.h"
-#include "src/core/lib/iomgr/sockaddr.h"
-#include "src/core/lib/resolver/server_address.h"
-#include "src/core/lib/service_config/service_config_impl.h"
-#include "src/proto/grpc/lb/v1/load_balancer.grpc.pb.h"
-#include "src/proto/grpc/testing/echo.grpc.pb.h"
-#include "test/core/util/port.h"
-#include "test/core/util/test_config.h"
-#include "test/cpp/end2end/test_service_impl.h"
-
-using grpc::lb::v1::LoadBalancer;
-using grpc::lb::v1::LoadBalanceRequest;
-using grpc::lb::v1::LoadBalanceResponse;
-
-namespace grpc {
-namespace testing {
-namespace {
-
-const size_t kNumBackends = 10;
-const size_t kNumBalancers = 5;
-const size_t kNumClientThreads = 10;
-const int kResolutionUpdateIntervalMs = 50;
-const int kServerlistUpdateIntervalMs = 10;
-const int kTestDurationSec = 30;
-
-using BackendServiceImpl = TestServiceImpl;
-
-class BalancerServiceImpl : public LoadBalancer::Service {
- public:
-  using Stream = ServerReaderWriter<LoadBalanceResponse, LoadBalanceRequest>;
-
-  explicit BalancerServiceImpl(const std::vector<int>& all_backend_ports)
-      : all_backend_ports_(all_backend_ports) {}
-
-  Status BalanceLoad(ServerContext* /*context*/, Stream* stream) override {
-    gpr_log(GPR_INFO, "LB[%p]: Start BalanceLoad.", this);
-    LoadBalanceRequest request;
-    stream->Read(&request);
-    while (!shutdown_) {
-      stream->Write(BuildRandomResponseForBackends());
-      std::this_thread::sleep_for(
-          std::chrono::milliseconds(kServerlistUpdateIntervalMs));
-    }
-    gpr_log(GPR_INFO, "LB[%p]: Finish BalanceLoad.", this);
-    return Status::OK;
-  }
-
-  void Shutdown() { shutdown_ = true; }
-
- private:
-  std::string Ip4ToPackedString(const char* ip_str) {
-    struct in_addr ip4;
-    GPR_ASSERT(inet_pton(AF_INET, ip_str, &ip4) == 1);
-    return std::string(reinterpret_cast<const char*>(&ip4), sizeof(ip4));
-  }
-
-  LoadBalanceResponse BuildRandomResponseForBackends() {
-    // Generate a random serverlist with varying size (if N =
-    // all_backend_ports_.size(), num_non_drop_entry is in [0, 2N],
-    // num_drop_entry is in [0, N]), order, duplicate, and drop rate.
-    size_t num_non_drop_entry =
-        std::rand() % (all_backend_ports_.size() * 2 + 1);
-    size_t num_drop_entry = std::rand() % (all_backend_ports_.size() + 1);
-    std::vector<int> random_backend_indices;
-    for (size_t i = 0; i < num_non_drop_entry; ++i) {
-      random_backend_indices.push_back(std::rand() % all_backend_ports_.size());
-    }
-    for (size_t i = 0; i < num_drop_entry; ++i) {
-      random_backend_indices.push_back(-1);
-    }
-    std::shuffle(random_backend_indices.begin(), random_backend_indices.end(),
-                 std::mt19937(std::random_device()()));
-    // Build the response according to the random list generated above.
-    LoadBalanceResponse response;
-    for (int index : random_backend_indices) {
-      auto* server = response.mutable_server_list()->add_servers();
-      if (index < 0) {
-        server->set_drop(true);
-        server->set_load_balance_token("load_balancing");
-      } else {
-        server->set_ip_address(Ip4ToPackedString("127.0.0.1"));
-        server->set_port(all_backend_ports_[index]);
-      }
-    }
-    return response;
-  }
-
-  std::atomic_bool shutdown_{false};
-  const std::vector<int> all_backend_ports_;
-};
-
-class ClientChannelStressTest {
- public:
-  void Run() {
-    Start();
-    // Keep updating resolution for the test duration.
-    gpr_log(GPR_INFO, "Start updating resolution.");
-    const auto wait_duration =
-        std::chrono::milliseconds(kResolutionUpdateIntervalMs);
-    std::vector<AddressData> addresses;
-    auto start_time = std::chrono::steady_clock::now();
-    while (true) {
-      if (std::chrono::duration_cast<std::chrono::seconds>(
-              std::chrono::steady_clock::now() - start_time)
-              .count() > kTestDurationSec) {
-        break;
-      }
-      // Generate a random subset of balancers.
-      addresses.clear();
-      for (const auto& balancer_server : balancer_servers_) {
-        // Select each address with probability of 0.8.
-        if (std::rand() % 10 < 8) {
-          addresses.emplace_back(AddressData{balancer_server.port_, ""});
-        }
-      }
-      std::shuffle(addresses.begin(), addresses.end(),
-                   std::mt19937(std::random_device()()));
-      SetNextResolution(addresses);
-      std::this_thread::sleep_for(wait_duration);
-    }
-    gpr_log(GPR_INFO, "Finish updating resolution.");
-    Shutdown();
-  }
-
- private:
-  template <typename T>
-  struct ServerThread {
-    explicit ServerThread(const std::string& type,
-                          const std::string& server_host, T* service)
-        : type_(type), service_(service) {
-      grpc::internal::Mutex mu;
-      // We need to acquire the lock here in order to prevent the notify_one
-      // by ServerThread::Start from firing before the wait below is hit.
-      grpc::internal::MutexLock lock(&mu);
-      port_ = grpc_pick_unused_port_or_die();
-      gpr_log(GPR_INFO, "starting %s server on port %d", type_.c_str(), port_);
-      grpc::internal::CondVar cond;
-      thread_ = std::make_unique<std::thread>(
-          std::bind(&ServerThread::Start, this, server_host, &mu, &cond));
-      cond.Wait(&mu);
-      gpr_log(GPR_INFO, "%s server startup complete", type_.c_str());
-    }
-
-    void Start(const std::string& server_host, grpc::internal::Mutex* mu,
-               grpc::internal::CondVar* cond) {
-      // We need to acquire the lock here in order to prevent the notify_one
-      // below from firing before its corresponding wait is executed.
-      grpc::internal::MutexLock lock(mu);
-      std::ostringstream server_address;
-      server_address << server_host << ":" << port_;
-      ServerBuilder builder;
-      builder.AddListeningPort(server_address.str(),
-                               InsecureServerCredentials());
-      builder.RegisterService(service_);
-      server_ = builder.BuildAndStart();
-      cond->Signal();
-    }
-
-    void Shutdown() {
-      gpr_log(GPR_INFO, "%s about to shutdown", type_.c_str());
-      server_->Shutdown(grpc_timeout_milliseconds_to_deadline(0));
-      thread_->join();
-      gpr_log(GPR_INFO, "%s shutdown completed", type_.c_str());
-    }
-
-    int port_;
-    std::string type_;
-    std::unique_ptr<Server> server_;
-    T* service_;
-    std::unique_ptr<std::thread> thread_;
-  };
-
-  struct AddressData {
-    int port;
-    std::string balancer_name;
-  };
-
-  static grpc_core::ServerAddressList CreateAddressListFromAddressDataList(
-      const std::vector<AddressData>& address_data) {
-    grpc_core::ServerAddressList addresses;
-    for (const auto& addr : address_data) {
-      std::string lb_uri_str = absl::StrCat("ipv4:127.0.0.1:", addr.port);
-      absl::StatusOr<grpc_core::URI> lb_uri = grpc_core::URI::Parse(lb_uri_str);
-      GPR_ASSERT(lb_uri.ok());
-      grpc_resolved_address address;
-      GPR_ASSERT(grpc_parse_uri(*lb_uri, &address));
-      addresses.emplace_back(
-          address, grpc_core::ChannelArgs().Set(GRPC_ARG_DEFAULT_AUTHORITY,
-                                                addr.balancer_name));
-    }
-    return addresses;
-  }
-
-  static grpc_core::Resolver::Result MakeResolverResult(
-      const std::vector<AddressData>& balancer_address_data) {
-    grpc_core::Resolver::Result result;
-    result.service_config = grpc_core::ServiceConfigImpl::Create(
-        grpc_core::ChannelArgs(),
-        "{\"loadBalancingConfig\":[{\"grpclb\":{}}]}");
-    GPR_ASSERT(result.service_config.ok());
-    grpc_core::ServerAddressList balancer_addresses =
-        CreateAddressListFromAddressDataList(balancer_address_data);
-    result.args = grpc_core::SetGrpcLbBalancerAddresses(
-        grpc_core::ChannelArgs(), std::move(balancer_addresses));
-    return result;
-  }
-
-  void SetNextResolution(const std::vector<AddressData>& address_data) {
-    grpc_core::ExecCtx exec_ctx;
-    grpc_core::Resolver::Result result = MakeResolverResult(address_data);
-    response_generator_->SetResponse(std::move(result));
-  }
-
-  void KeepSendingRequests() {
-    gpr_log(GPR_INFO, "Start sending requests.");
-    while (!shutdown_) {
-      ClientContext context;
-      context.set_deadline(grpc_timeout_milliseconds_to_deadline(1000));
-      EchoRequest request;
-      request.set_message("test");
-      EchoResponse response;
-      {
-        std::lock_guard<std::mutex> lock(stub_mutex_);
-        Status status = stub_->Echo(&context, request, &response);
-      }
-    }
-    gpr_log(GPR_INFO, "Finish sending requests.");
-  }
-
-  void CreateStub() {
-    ChannelArguments args;
-    response_generator_ =
-        grpc_core::MakeRefCounted<grpc_core::FakeResolverResponseGenerator>();
-    args.SetPointer(GRPC_ARG_FAKE_RESOLVER_RESPONSE_GENERATOR,
-                    response_generator_.get());
-    std::ostringstream uri;
-    uri << "fake:///servername_not_used";
-    channel_ = grpc::CreateCustomChannel(uri.str(),
-                                         InsecureChannelCredentials(), args);
-    stub_ = grpc::testing::EchoTestService::NewStub(channel_);
-  }
-
-  void Start() {
-    // Start the backends.
-    std::vector<int> backend_ports;
-    for (size_t i = 0; i < kNumBackends; ++i) {
-      backends_.emplace_back(new BackendServiceImpl());
-      backend_servers_.emplace_back(ServerThread<BackendServiceImpl>(
-          "backend", server_host_, backends_.back().get()));
-      backend_ports.push_back(backend_servers_.back().port_);
-    }
-    // Start the load balancers.
-    for (size_t i = 0; i < kNumBalancers; ++i) {
-      balancers_.emplace_back(new BalancerServiceImpl(backend_ports));
-      balancer_servers_.emplace_back(ServerThread<BalancerServiceImpl>(
-          "balancer", server_host_, balancers_.back().get()));
-    }
-    // Start sending RPCs in multiple threads.
-    CreateStub();
-    for (size_t i = 0; i < kNumClientThreads; ++i) {
-      client_threads_.emplace_back(
-          std::thread(&ClientChannelStressTest::KeepSendingRequests, this));
-    }
-  }
-
-  void Shutdown() {
-    shutdown_ = true;
-    for (size_t i = 0; i < client_threads_.size(); ++i) {
-      client_threads_[i].join();
-    }
-    for (size_t i = 0; i < balancers_.size(); ++i) {
-      balancers_[i]->Shutdown();
-      balancer_servers_[i].Shutdown();
-    }
-    for (size_t i = 0; i < backends_.size(); ++i) {
-      backend_servers_[i].Shutdown();
-    }
-  }
-
-  std::atomic_bool shutdown_{false};
-  const std::string server_host_ = "localhost";
-  std::shared_ptr<Channel> channel_;
-  std::unique_ptr<grpc::testing::EchoTestService::Stub> stub_;
-  std::mutex stub_mutex_;
-  std::vector<std::unique_ptr<BackendServiceImpl>> backends_;
-  std::vector<std::unique_ptr<BalancerServiceImpl>> balancers_;
-  std::vector<ServerThread<BackendServiceImpl>> backend_servers_;
-  std::vector<ServerThread<BalancerServiceImpl>> balancer_servers_;
-  grpc_core::RefCountedPtr<grpc_core::FakeResolverResponseGenerator>
-      response_generator_;
-  std::vector<std::thread> client_threads_;
-};
-
-}  // namespace
-}  // namespace testing
-}  // namespace grpc
-
-int main(int argc, char** argv) {
-  grpc::testing::TestEnvironment env(&argc, argv);
-  grpc::testing::ClientChannelStressTest test;
-  grpc_init();
-  test.Run();
-  grpc_shutdown();
-  return 0;
-}