natas_hw
/
grpc
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[EventEngine] rm invalid assert (#35953) (#36068) 

Backports https://github.com/grpc/grpc/pull/35953 to v1.61.x

----

In the case where the timer delay is <= 0, RunAfter will return an
invalid handle since the callback will not be cancellable. The asserting
is invalid in this case. Based on how this handle is used, it seems
there is no need for a check that the handle is set. It would only
matter if `finish_bdp_ping` were called again before
`next_bdp_ping_timer_expired` were called, which I don't think is
possible.
This commit is contained in:
AJ Heller 2024-03-07 10:48:12 -08:00 committed by GitHub
parent c214da38f7
commit 36de3ffc28
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/core/ext/transport/chttp2/transport/chttp2_transport.cc
View File

@ -2897,7 +2897,6 @@ static void next_bdp_ping_timer_expired_locked(
grpc_core::RefCountedPtr<grpc_chttp2_transport> t,
GRPC_UNUSED grpc_error_handle error) {
GPR_DEBUG_ASSERT(error.ok());
GPR_ASSERT(t->next_bdp_ping_timer_handle != TaskHandle::kInvalid);
t->next_bdp_ping_timer_handle = TaskHandle::kInvalid;
if (t->flow_control.bdp_estimator()->accumulator() == 0) {
// Block the bdp ping till we receive more data.