natas_hw
/
dubbo
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

do not invoke test method(#13589) (#13601) 

* do not invoke test method(#13589)

* Fix style check

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
This commit is contained in:
MaruHibiki 2024-01-10 11:27:48 +08:00 committed by GitHub
parent 50612ad3a7
commit 966efaab85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/ExceptionFilter.java
View File

@ -18,6 +18,7 @@ package org.apache.dubbo.rpc.filter;
import org.apache.dubbo.common.constants.CommonConstants;
import org.apache.dubbo.common.extension.Activate;
import org.apache.dubbo.common.extension.DisableInject;
import org.apache.dubbo.common.logger.ErrorTypeAwareLogger;
import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.common.utils.ReflectUtils;
@ -140,7 +141,8 @@ public class ExceptionFilter implements Filter, Filter.Listener {
}
// For test purpose
public void setLogger(ErrorTypeAwareLogger logger) {
@DisableInject
public void mockLogger(ErrorTypeAwareLogger logger) {
this.logger = logger;
}
}

2
dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/ExceptionFilterTest.java
View File

@ -63,7 +63,7 @@ class ExceptionFilterTest {
exceptionFilter.invoke(invoker, invocation);
} catch (RpcException e) {
assertEquals("TestRpcException", e.getMessage());
exceptionFilter.setLogger(failsafeLogger);
exceptionFilter.mockLogger(failsafeLogger);
exceptionFilter.onError(e, invoker, invocation);
}