From 7b92414ef3707d2cd4a69ec6131cc03fd8eed8ab Mon Sep 17 00:00:00 2001 From: Huang YunKun Date: Thu, 5 Mar 2020 07:01:28 -0600 Subject: [PATCH] extracting duplicate code in CountTelnetHandler (#5824) --- .../dubbo/qos/legacy/CountTelnetHandler.java | 28 ++++++++----------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java index 3b79bea345..cab2799b3a 100644 --- a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java +++ b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/CountTelnetHandler.java @@ -130,14 +130,7 @@ public class CountTelnetHandler implements TelnetHandler { if (method == null || method.length() == 0) { for (Method m : invoker.getInterface().getMethods()) { RpcStatus count = RpcStatus.getStatus(url, m.getName()); - List row = new ArrayList(); - row.add(m.getName()); - row.add(String.valueOf(count.getTotal())); - row.add(String.valueOf(count.getFailed())); - row.add(String.valueOf(count.getActive())); - row.add(String.valueOf(count.getSucceededAverageElapsed()) + "ms"); - row.add(String.valueOf(count.getSucceededMaxElapsed()) + "ms"); - table.add(row); + table.add(createRow(m.getName(),count)); } } else { boolean found = false; @@ -149,14 +142,7 @@ public class CountTelnetHandler implements TelnetHandler { } if (found) { RpcStatus count = RpcStatus.getStatus(url, method); - List row = new ArrayList(); - row.add(method); - row.add(String.valueOf(count.getTotal())); - row.add(String.valueOf(count.getFailed())); - row.add(String.valueOf(count.getActive())); - row.add(String.valueOf(count.getSucceededAverageElapsed()) + "ms"); - row.add(String.valueOf(count.getSucceededMaxElapsed()) + "ms"); - table.add(row); + table.add(createRow(method,count)); } else { return "No such method " + method + " in class " + invoker.getInterface().getName(); } @@ -164,4 +150,14 @@ public class CountTelnetHandler implements TelnetHandler { return TelnetUtils.toTable(header, table); } + private List createRow(String methodName,RpcStatus count) { + List row = new ArrayList(); + row.add(methodName); + row.add(String.valueOf(count.getTotal())); + row.add(String.valueOf(count.getFailed())); + row.add(String.valueOf(count.getActive())); + row.add(count.getSucceededAverageElapsed() + "ms"); + row.add(count.getSucceededMaxElapsed() + "ms"); + return row; + } }