natas_hw
/
dolphinscheduler
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Bug-8067][LogServer] fix improper use of StringBuilder (#8365) 

fix code format and fix spelling errors
This commit is contained in:
弘树丶 2022-02-14 13:37:47 +08:00 committed by GitHub
parent 4a4e72b0d2
commit b9406d356c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dolphinscheduler-log-server/src/main/java/org/apache/dolphinscheduler/server/log/LoggerRequestProcessor.java
View File

@ -70,9 +70,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
public void process(Channel channel, Command command) {
logger.info("received command : {}", command);
/**
* reuqest task log command type
*/
//request task log command type
final CommandType commandType = command.getType();
switch (commandType) {
case GET_LOG_BYTES_REQUEST:
@ -96,7 +94,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
rollViewLogRequest.getSkipLineNum(), rollViewLogRequest.getLimit());
StringBuilder builder = new StringBuilder();
for (String line : lines) {
builder.append(line + "\r\n");
builder.append(line).append("\r\n");
}
RollViewLogResponseCommand rollViewLogRequestResponse = new RollViewLogResponseCommand(builder.toString());
channel.writeAndFlush(rollViewLogRequestResponse.convert2Command(command.getOpaque()));
@ -108,7 +106,7 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
String taskLogPath = removeTaskLogRequest.getPath();
File taskLogFile = new File(taskLogPath);
Boolean status = true;
boolean status = true;
try {
if (taskLogFile.exists()) {
status = taskLogFile.delete();
@ -130,11 +128,10 @@ public class LoggerRequestProcessor implements NettyRequestProcessor {
}
/**
* get files content bytes，for down load file
* get files content bytes for download file
*
* @param filePath file path
* @return byte array of file
* @throws Exception exception
*/
private byte[] getFileContentBytes(String filePath) {
try (InputStream in = new FileInputStream(filePath);