natas_hw
/
dolphinscheduler
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Improvement] Fix the git url command injection in pytorch task(#15873) (#15950) 

* fix the git url command injection danger(#15873)

* [Improvement] Fix the git url command injection in pytorch,format code style task(#15873)

---------

Co-authored-by: cntigers <Xiaohu4321@>
Co-authored-by: Rick Cheng <rickchengx@gmail.com>
This commit is contained in:
cntiger 2024-05-09 14:50:27 +08:00 committed by GitHub
parent 5c569b705c
commit 60b019b729
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dolphinscheduler-task-plugin/dolphinscheduler-task-pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/GitProjectManager.java
View File

@ -33,12 +33,12 @@ import lombok.extern.slf4j.Slf4j;
public class GitProjectManager { public class GitProjectManager {
public static final String GIT_PATH_LOCAL = "GIT_PROJECT"; public static final String GIT_PATH_LOCAL = "GIT_PROJECT";
private static final Pattern GIT_CHECK_PATTERN = Pattern.compile("^(git@|https?://)"); private static final Pattern GIT_CHECK_PATTERN = Pattern.compile("^(git@|https?://)(?![&|])[^&|]+$");
private String path; private String path;
private String baseDir = "."; private String baseDir = ".";
public static boolean isGitPath(String path) { public static boolean isGitPath(String path) {
return GIT_CHECK_PATTERN.matcher(path).find(); return GIT_CHECK_PATTERN.matcher(path).matches();
} }
public void prepareProject() throws Exception { public void prepareProject() throws Exception {

6
dolphinscheduler-task-plugin/dolphinscheduler-task-pytorch/src/test/java/org/apache/dolphinscheduler/plugin/task/pytorch/PytorchTaskTest.java
View File

@ -72,6 +72,12 @@ public class PytorchTaskTest {
} }
@Test
public void testGitProjectUrlInjection() {
Assertions.assertFalse(GitProjectManager.isGitPath("git@& cat /etc/passwd >/poc.txt #"));
Assertions.assertFalse(GitProjectManager.isGitPath("git@| cat /etc/passwd >/poc.txt #"));
}
@Test @Test
public void testGitProject() { public void testGitProject() {