ef293c1a6a
return empty lists instead of raising an error where applicable; otherwise, use
...
NotFoundError instead of CassandraException. rely on THRIFT-378 to report internal errors.
also, add field numbers to work around thrift bug generating python code.
patch by jbellis; reviewed by Jun Rao for #66
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768382 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 17:52:25 +00:00
7b250fa261
move CF checking into CassandraServer. begin to expose InvalidRequestException. r/m unused "del" cfmaps from batch methods.
...
patch by jbellis; reviewed by Jun Rao for #66
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768381 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 17:52:07 +00:00
ada8209a3a
fix hostname parsing in cli. patch by Eric Evans; reviewed by jbellis for #100
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768137 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 03:02:18 +00:00
83d24602fd
Simplify default storage-conf.xml. patch by Sandeep Tata; reviewed by jbellis for #99
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768135 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 02:58:24 +00:00
ba7f6907f3
avoid clearing out memtable during flush since it can still be accessed as a
...
'historial' MT. clearing during flush can lead to client seeing old data, if the
clear is done before the sstable is completely written (so the next thing to be
checked will be an old sstable).
patch by Sandeep Tata; reviewed by jbellis for #98 .
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768111 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 00:52:09 +00:00
2ec1b06e5f
use resolve (moved to CF from CFS) rather than duplicating code in repair to do the
...
same thing. this automatically gets us most of the way to handling tombstones in
read repair. the rest is minor tweaks to CF.diff and SC.diff. added tests.
patch by jbellis; reviewed by Jun Rao for #87 .
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768109 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 00:46:32 +00:00
0133ff232f
clean up Read Repair code to use non-deprecated APIs.
...
patch by jbellis; reviewed by Jun Rao for #87 .
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@768108 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 00:46:19 +00:00
3c6fcf8d65
fix get_slice to not ignore the "start" parameter. patch by Sandeep Tata; reviewed by jbellis for #81
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767703 13f79535-47bb-0310-9956-ffa450edef68
2009-04-22 22:54:14 +00:00
99451c730b
replace ArrayList w/ ArrayDeque.
...
patch by jbellis; reviewed by Jun Rao for #14
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767610 13f79535-47bb-0310-9956-ffa450edef68
2009-04-22 18:40:36 +00:00
9292af8860
avoid setting the initial arrival time (and hence the mean arrival time until the
...
next value) to zero.
patch by Zhu Han; reviewed by jbellis for #13
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767609 13f79535-47bb-0310-9956-ffa450edef68
2009-04-22 18:40:33 +00:00
589d72a7f9
fix duration calculation to avoid evicting dead endpoints instantly
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767606 13f79535-47bb-0310-9956-ffa450edef68
2009-04-22 18:38:41 +00:00
478f0bef14
RVH should use RC.getRow for correctness and maintainability (in particular the path for get_columns_since was missing). patch by Jun Rao; reviewed by jbellis for #93
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767315 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 22:18:08 +00:00
0f7e1c3012
raise exception when column is not passed to get_column. patch by Jun Rao; reviewed by jbellis for #92
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767314 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 22:14:36 +00:00
b0dde7139a
configurable ListenAddress setting. allows running multiple instances of Cassandra
...
on a single machine or VM. patch and review by Per Mellqvist, Eric Evans, and
jbellis for #43
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767307 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 21:34:46 +00:00
807b89ed7c
Revert "configurable ListenAddress setting" since it prevents server from starting.
...
This reverts commit 1304a9d9e1f9f85b991d99a1ca96e02505eb430f.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767205 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 16:21:15 +00:00
fb0e28d664
configurable ListenAddress setting. allows running multiple instances of Cassandra on a single machine or VM. patch by Per Mellqvist; reviewed by Eric Evans for #43
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767168 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 14:56:22 +00:00
04010ca15a
fix strange line endings and indentation so we can apply patches sanely.
...
patch by Per Mellqvist; reviewed by Eric Evans for #43
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@767167 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 14:56:16 +00:00
20748a879b
allow SuperColumn.getSubColumn to return null. patch by Sandeep Tata; reviewed by jbellis for #91
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766961 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 03:06:01 +00:00
d14f814667
test and fix get_column regression. patch by Jun Rao; reviewed by jbellis for #90
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766960 13f79535-47bb-0310-9956-ffa450edef68
2009-04-21 02:58:49 +00:00
c0f5fb3bb3
refactor read path: first we make readColumnFamily accept a ReadCommand, and use that to clean out duplicate code in CassandraServer. Then we clean up the duplicate versions of the read methods in StorageService by making them ReadCommand-based, too. [not touching multiget code for now.]
...
patch by jbellis; reviewed by Eric Evans for #88
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766841 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 20:05:26 +00:00
657882579d
rename ReadResponseMessage -> ReadResponse
...
patch by jbellis; reviewed by Eric Evans for #88
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766840 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 20:05:20 +00:00
df95fb88dc
clean up ReadCommand; it's basically a struct so use public final fields
...
patch by jbellis; reviewed by Eric Evans for #88
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766839 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 20:05:29 +00:00
8e72ac4f9f
rename get_cf -> readColumnFamily; ReadMessage -> ReadCommand.
...
[Message message = ReadMessage.readMessage(readMessage) is just plain confusing]
patch by jbellis; reviewed by Eric Evans for #88
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766838 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 20:05:07 +00:00
234d0895ad
fix row size "returned" via bufOut (currently ignored). patch by Jun Rao; reviewed by jbellis for #33
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766744 13f79535-47bb-0310-9956-ffa450edef68
2009-04-20 16:38:32 +00:00
6be087a80a
fix SequenceFile to know about new int in CF serialization. patch by Jun Rao; reviewed by jbellis for #33
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766199 13f79535-47bb-0310-9956-ffa450edef68
2009-04-18 01:33:24 +00:00
0c0c6e5fda
refactor Filter heirarchy, making hash generation easily customizable. Use Murmur
...
hash + combinatorics to generate hashes.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766140 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:17:16 +00:00
674eaf5cf5
rename BloomFilter.fill -> add
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766139 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:17:11 +00:00
04344cbb03
replace JenkinsHash w/ MurmurHash. its hash distribution is just as good, and it's faster
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766138 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:17:05 +00:00
7f256c32cb
r/m unused code, including entire CountingBloomFilter
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766137 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:17:10 +00:00
8eacd24443
change column_t value to binary from string. patch by johano; reviewed by jbellis for #29
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766136 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:08:49 +00:00
200d4937fa
test and fix for CF clone bug during remove. patch by Jun Rao; reviewed by jbellis for #33
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766135 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:08:17 +00:00
fa1f80f40d
make GC_GRACE_IN_SECONDS customizable in storage.conf.
...
patch by jbellis; reviewed by Eric Evans for #33
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766134 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:08:10 +00:00
560dc2a10f
omit tombstones from column_t and supercolumn_t returned to client.
...
patch by jbellis; reviewed by Eric Evans for #33
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766133 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:08:05 +00:00
3705cc4c77
preserve tombstones until a GC grace period has elapsed.
...
patch by jbellis; reviewed by Eric Evans for #33
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@766132 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 20:08:01 +00:00
2b0b61a7b0
waitForFlush -> forceBlockingFlush. ServerTest.cleanup now flushes and cleans out
...
all ColumnFamilyStores and commitlog, allowing remove tests to not step on each
others' toes (all tests pass now).
patch by jbellis; reviewed by Sandeep Tata for #85
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765831 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 01:48:58 +00:00
20dfd0682b
use isSuper instead of DatabaseDescriptor.getColumnType.
...
patch by jbellis; reviewed by Sandeep Tata for #85
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765830 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 01:48:50 +00:00
1e15ccf5c9
refactor CFS constructor to not depend on DatabaseDescriptor.
...
patch by jbellis; reviewed by Sandeep Tata for #85
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765829 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 01:48:39 +00:00
1228ec0c67
add testRemoveColumnFamily, testRemoveSubColumn. (these do not pass yet b/c of
...
cleanup problems.) patch by jbellis; reviewed by Sandeep Tata for #85
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765828 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 01:48:31 +00:00
3cf306a37f
make forceFlush block until the flush action is queued on MemtableManager. That
...
way calling forceFlush; waitForFlush will be guaranteed that the action waitFF puts
on MtM will run after the flush completes, i.e., the wait will actually do what
it's supposed to.
patch by jbellis; reviewed by Eric Evans for #59
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765754 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 20:42:00 +00:00
4ed201b99f
r/m libfb303 as a dependency. (this completes the process begun by Prashant earlier.) patch by Jun Rao; reviewed by jbellis for #86
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765703 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 17:47:25 +00:00
39de2d0d33
expose redone remove to thrift. patch by jbellis; reviewed by Jun Rao for #83
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765680 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 16:23:20 +00:00
cb7cacfea7
generate supercolumn tombstone when a 2-tuple delete is passed to a super CF.
...
patch by jbellis; reviewed by Sandeep Tata for #84
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765451 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 02:09:24 +00:00
040bfd4c29
make remove test code use the same api that the thrift interface does. patch by
...
jbellis; reviewed by Sandeep Tata for #84
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765450 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 02:09:18 +00:00
2b4a0e4266
Move from ExecutorService per ColumnFamily to ES per Memtable. This allows us to
...
wait for the ES to quiesce completely before flushing, preventing the possibility
of ConcurrentModificationException when a get scheduled before the switch executes
concurrently with flush. It also provides a simpler mental model (only one thread
touches memtable at a time, period) which is a valuable property. Finally, it is
slightly more performant since it avoids hashing the CF name for each operation.
Patch by jbellis; reviewed by Todd Lipcon for #9
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765343 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 20:30:43 +00:00
6b2050c1fc
Add MemtableSizeInMB and MemtableObjectCountInMillions to the default config. Uses a more conservative value for MemtableSizeInMB the default. Patch by Eric Evans; reviewed by jbellis for #51
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765269 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 16:56:11 +00:00
5e72feef0e
upgrade to thrift svn r763981. for Java, this should be identical to thrift 0.1. patch by jbellis; reviewed by Eric Evans for #72
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765262 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 16:28:03 +00:00
4c76970c4a
fix ColumnComparatorFactoryTest. patch by Jun Rao; reviewed by jbellis for #82
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@765020 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 00:22:13 +00:00
49b45026bd
RangeFilter that filters by column name so that min <= name <= max. patch by Jun Rao; reviewed by Todd Lipcon for #77
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@764848 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 15:52:49 +00:00
137a28fc07
jmx resource names to reflect the move to apache
...
This is primarily a cosmetic change. If the Facebook folks have existing
tools which use these names, and they can not easily be updated, then
this changeset can safely be omitted.
patch by Eric Evans; reviewed by jbellis for #75
for your changes.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@764842 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 15:47:49 +00:00
31e3033afd
an MBean attribute for displaying a flush counter
...
This changeset adds a new attribute to the ColumnFamilyStore MBean which
displays the number of times the memtable has been "switched". This
attribute (along with the newly added count and size attributes),
should prove useful in tuning thresholds.
patch by Eric Evans; reviewed by jbellis for #75
for your changes.
git-svn-id: https://svn.apache.org/repos/asf/incubator/cassandra/trunk@764841 13f79535-47bb-0310-9956-ffa450edef68
2009-04-14 15:47:44 +00:00
Jonathan Ellis