Commit Graph

18611 Commits

Author SHA1 Message Date
David Capwell 4da92af589 Merge branch 'cassandra-4.0' into cassandra-4.1 2025-01-07 17:40:39 -08:00
Sunil Ramchandra Pawar 4fc8bb29fc IndexOutOfBoundsException when accessing partition where the column was deleted
patch by Sunil Ramchandra Pawar; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-20108
2025-01-07 17:38:20 -08:00
Yifan Cai c44008e9e4 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Enhance CQLSSTableWriter to notify client on sstable production
2024-11-22 14:57:36 -08:00
Yifan Cai 659558c980 Enhance CQLSSTableWriter to notify client on sstable production
Patch by Yifan Cai; Reviewed by Francisco Guerrero for CASSANDRA-19800
2024-11-22 14:49:22 -08:00
Mick Semb Wever 7559e2708a
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  A node should always return back the full information about itself for gossip regardless the asked heartbeat version
2024-11-19 00:38:23 +01:00
Runtian Liu 426eebb513
A node should always return back the full information about itself for gossip regardless the asked heartbeat version
patch by Runtian Liu; reviewed by Brandon Williams, Michael Semb Wever for CASSANDRA-19983
2024-11-19 00:23:45 +01:00
Stefan Miklosovic d6f37a697e
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-11-15 11:53:25 +01:00
Dmitry Konstantinov d0c984fa32
Change the resolution of AbstractCommitLogService#lastSyncedAt to nanos to be aligned with later comparisons
patch by Dmitry Konstantinov; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-20074
2024-11-15 11:37:52 +01:00
Brandon Williams d3ac810b37 Merge branch 'cassandra-4.0' into cassandra-4.1 2024-11-13 12:42:24 -06:00
Brandon Williams 39b42ccd2f Update RMI object marshalling restrictions
Patch by brandonwilliams; reviewed by paulo for CASSANDRA-20076
2024-11-13 12:39:36 -06:00
Mohammad Aburadeh b79f9dca87 Log client address when detecting unknown exception in client networking
Patch by Mohammad Aburadeh, reviewed by brandonwilliams and smiklosovic
for CASSANDRA-20072
2024-11-11 06:24:51 -06:00
Mohammad Aburadeh 0b3c26ab05 Log client address when detecting unknown exception in client networking
Patch by Mohammad Aburadeh, reviewed by brandonwilliams and smiklosovic
for CASSANDRA-20072
2024-11-11 06:21:15 -06:00
Stefan Miklosovic 0f590133f8
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-11-06 22:27:28 +01:00
Josh McKenzie 8ea70cd1f0
Backport of CASSANDRA-17812: Rate-limit new client connection auth setup to avoid overwhelming bcrypt
This backport differs from CASSANDRA-17812 in such a way that by default the number
of auth request threads is set to 0. That will route all requests to request executor as before this change.
The patch in 5.0 and later sets the default number of auth request threads to 4.

patch by Josh McKenzie; reviewed by Chris Lohfink for CASSANDRA-20057

Co-authored-by: Stefan Miklosovic <smiklosovic@apache.org>
2024-11-06 22:23:16 +01:00
Stefan Miklosovic 17418a2ba0
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-11-06 14:33:00 +01:00
Stefan Miklosovic 6093c2d99b
Support UDTs and vectors as clustering keys in descending order
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-20050
2024-11-06 14:28:48 +01:00
Stefan Miklosovic 521891c196
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-11-06 09:47:00 +01:00
Stefan Miklosovic 181ddc0600
Fix CQL in snapshot's schema which did not contained UDTs used as reverse clustering columns
patch by Stefan Miklosovic; reviewed by David Capwell for CASSANDRA-20036
2024-11-06 09:41:45 +01:00
jaydeepkumar1984 e5c919f273
Add nodetool checktokenmetadata command that checks TokenMetadata is insync with Gossip endpointState
patch by Jaydeepkumar Chovatia; reviewed by Brandon Williams, Mick Semb Wever for CASSANDRA-18758
2024-11-05 22:42:28 +01:00
Bereng 94c2a09772 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  CASSANDRA-19986 Prepared statements cache computation improvements
2024-11-04 10:00:03 +01:00
Bereng ff54fd5ffd CASSANDRA-19986 Prepared statements cache computation improvements
patch by Berenguer Blasi; reviewed by Maxwell Guo, Stefan Miklosovic for CASSANDRA-19986
2024-11-04 09:56:32 +01:00
Sam Tunnicliffe 9ff31e8060 Equality check for Paxos.Electorate should not depend on collection types
Patch by Sam Tunnicliffe; reviewed by Marcus Eriksson for CASSANDRA-19935
2024-11-01 18:53:22 +00:00
mck 26bf80706b
Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Add configurable batchlog endpoint strategies
2024-10-15 13:38:12 +02:00
shunsaker b8c5436293
Add configurable batchlog endpoint strategies
Batchlog endpoint strategy was previously only random placements on other racks.  Options now are random_remote, prefer_local, dynamic_remote, and dynamic.

 patch by Shayne Hunsaker; reviewed by Mick Semb Wever, Brandon Williams for CASSANDRA-18120
2024-10-15 13:34:40 +02:00
Stefan Miklosovic dbc87a44d1
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-10-10 09:31:20 -06:00
Dmitry Konstantinov d939e40dfb
Fix flakiness of TopPartitionsTest
patch by Dmitry Konstantinov; reviewed by Stefan Miklosovic, Berenguer Blasi for CASSANDRA-19991
2024-10-10 08:11:11 -06:00
Maxim Muzafarov ad4ad5ef5a Fix race condition in DecayingEstimatedHistogramReservoir during rescale
patch by Maxim Muzafarov; reviewed by Caleb Rackliffe for CASSANDRA-19365

Co-authored-by: Jakub Zytka <jakub.zytka@datastax.com>
2024-10-02 15:14:20 +02:00
Stefan Miklosovic 8ec8dbc752
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-27 14:04:01 +02:00
Stefan Miklosovic 63cad45bfc
Ensure thread-safety for CommitLogArchiver in CommitLog
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-19960
2024-09-27 14:02:48 +02:00
Stefan Miklosovic 2bcd68f8be
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-23 17:07:49 +02:00
Sunil Ramchandra Pawar 06a05ccde5
Fix indexing of a frozen collection that is the clustering key and reversed
patch by Sunil Ramchandra Pawar; reviewed by David Capwell, Stefan Miklosovic for CASSANDRA-19889
2024-09-23 17:06:46 +02:00
Stefan Miklosovic 7b1eb1f0b7
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-18 22:48:54 +02:00
Stefan Miklosovic 39b1c2df89
Emit error when altering a table with non-frozen UDTs with nested non-frozen collections the same way as done upon table creation
patch by Stefan Miklosovic; reviewed by Maxim Muzafarov for CASSANDRA-19925
2024-09-18 22:44:39 +02:00
Bereng 5e37fcde46 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Add extra compaction junit
2024-09-18 08:45:01 +02:00
Bereng 366ee9da6c Add extra compaction junit
patch by Berenguer Blasi; reviewed by Branimir Lambov for CASSANDRA-19863
2024-09-18 08:41:42 +02:00
Caleb Rackliffe 8670d98498 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Safer handling of out-of-range tokens
2024-09-17 17:09:57 -05:00
Caleb Rackliffe b4f1c6d250 Safer handling of out-of-range tokens
patch by Caleb Rackliffe; reviewed by Mick Semb Wever for CASSANDRA-13704

Co-authored-by: Sam Tunnicliffe <sam@beobal.com>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
Co-authored-by: Mick Semb Wever <mck@apache.org>
Co-authored-by: Ariel Weisberg <aweisberg@apple.com>
2024-09-17 17:04:11 -05:00
Brandon Williams a5b4fbc64c Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-16 12:25:02 -05:00
Benedict Elliott Smith 2842c01ce7 Fix BTree.FastBuilder.reset() and test
Patch by benedict; reviewed by blambov for CASSANDRA-19785
2024-09-16 12:24:32 -05:00
Stefan Miklosovic 48eab9afd8
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-15 19:57:53 +02:00
maxwellguo 9f18aab1dc
Fix millisecond and microsecond precision for commit log replay
patch by Maxwell Guo; reviewed by Brandon Williams, Stefan Miklosovic for CASSANDRA-19448
2024-09-13 15:42:20 +02:00
Stefan Miklosovic 6ec8c5bb81
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-09-10 10:00:38 +02:00
Dmitry Konstantinov c56ba3b317
Improve accuracy of memtable heap usage tracking
Fix estimateRowOverhead in Memtable: ByteBuffer in Partition key was not counted
Fix non-counted size of "columns" field in Columns.unsharedHeapSize
BTree.sizeOfStructureOnHeap wrongly reported a non-zero size for EMPTY_LEAF shared constant value
Fix MemtableSizeTest flakeness by not measuring of allocator and ColumnFamilyStore/Keyspace

Patch by Dmitry Konstantinov; reviewed by Branimir Lambov, Stefan Miklosovic for CASSANDRA-17298
2024-09-09 12:00:11 +02:00
Jacek Lewandowski 505aff4517 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Fix rendering UNSET collection types in query tracing
2024-08-30 10:41:39 +02:00
Lukasz Antoniak c53d3ac8c6 Fix rendering UNSET collection types in query tracing
Patch by Lukasz Antoniak reviewed by Jacek Lewandowski for CASSANDRA-19880
2024-08-30 10:41:38 +02:00
Ariel Weisberg 02f38208b1 Merge branch 'cassandra-4.0' into cassandra-4.1 2024-08-21 16:03:51 -04:00
Dmitry Konstantinov 6da9141d3c Fix latency reported by ideal consistency level monitoring
patch by Dmitry Konstantinov; reviewed by Ariel Weisberg for CASSANDRA-19651
2024-08-21 16:01:46 -04:00
Stefan Miklosovic aa7afeabce
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-08-05 12:16:36 +02:00
Stefan Miklosovic b8e08840ee
Do not spam log with SSLExceptions
patch by Stefan Miklosovic; reviewed by Caleb Rackliffe for CASSANDRA-18839

Co-authored-by: James Hu <jhudson15869@gmail.com>
2024-08-05 11:55:50 +02:00
Stefan Miklosovic 31e2edf052
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-07-10 10:42:39 +02:00
Stefan Miklosovic a5767a5834
Fix schema.cql created by a snapshot after dropping more than one column
patch by Stefan Miklosovic; reviewed Benjamin Lerer, Francisco Guerrero for CASSANDRA-19747
2024-07-10 10:34:54 +02:00
Sam Tunnicliffe 1cd0b38214 Revert to localised start time for coordinator read latency measurement
Patch by Sam Tunnicliffe; reviewed by Marcus Ericsson for
CASSANDRA-19755
2024-07-10 09:17:55 +01:00
Stefan Miklosovic a878adfc89
Do not create a role if ALTER ROLE IF EXISTS operates on non-existing role
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-19749
2024-07-09 17:03:25 +02:00
Caleb Rackliffe f378f92030 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  UnsupportedOperationException when reducing scope for LCS compactions
2024-07-02 14:13:30 -05:00
Marcus Eriksson d54646e409 UnsupportedOperationException when reducing scope for LCS compactions
patch by Caleb Rackliffe; reviewed by Zhao Yang, Brandon Williams, and Marcus Eriksson for CASSANDRA-19704

Co-authored-by: Marcus Eriksson <marcuse@apache.org>
Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
2024-07-02 13:35:34 -05:00
Jon Haddad 2112c4c1c0 Use OpOrder in repairIterator to ensure we don't lose memtables mid-paxos repair
Patch by Jon Haddad; Reviewed by Blake Eggleston for CASSANDRA-19668
2024-07-01 10:20:25 -07:00
Benjamin Lerer ef8bc82f1b Merge branch cassandra-4.0 into cassandra-4.1 2024-06-27 12:27:55 +02:00
Benjamin Lerer 90208c0a29 Makes LWT conditions behavior on frozen and non-frozen columns consistent for null column values
Patch by Benjamin Lerer; review by Ekaterina Dimitrova for CASSANDRA-19637
2024-06-27 10:15:03 +02:00
Benedict Elliott Smith 53b06453b7 Refresh stale paxos commit
patch by Benedict Elliott Smith; review by Blake Eggleston for CASSANDRA-19617
2024-06-11 15:24:57 +02:00
tommy stendahl a17e4fc497
Reduce info logging from automatic paxos repair
patch by Tommy Stendahl; reviewed by Stefan Miklosovic, Blake Eggleston for CASSANDRA-19445
2024-06-10 10:46:30 +02:00
Brandon Williams 258a04a361 Ninja remove unused imports 2024-06-04 08:26:10 -05:00
Alex Petrov dc17c29724 Add native transport deadline, an ultimate deadline for all tasks related to a specific request
* Add an ability to base _replica_ side queries on the queue time
      * Use queue time as a base for message timeouts
      * Use native transport deadline for internode messages
      * Make sure that local runnables respect transport timeouts and deadlines
      * Make sure that remote mutation handler respects message expiration times

Patch by Alex Petrov; reviewed by Caleb Rackliffe for CASSANDRA-19534
2024-05-31 11:10:58 +02:00
Brandon Williams c6017aca77 Merge branch 'cassandra-4.0' into cassandra-4.1 2024-05-08 10:28:12 -05:00
Raymond Huffman 057d082e00 Add option to override the FatClient timeout for Bootstrapping nodes
Patch by Raymond Huffman; reviewed by brandonwilliams and dcapwell for
CASSANDRA-15439
2024-05-07 16:32:41 -05:00
Stefan Miklosovic 85039aa8c5
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-05-02 10:39:28 +02:00
Stefan Miklosovic 334ca05730
Make nodetool import congruent with the documentation by not relying on the folder structure of the imported SSTable files
nodetool import requires keyspace and table on the command line to import SSTables to. This
was not always working as specifying keypace and table while having SSTables located in the
directory structure which differed on keyspace and table (dir and parent dir) just
ignored them.

patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-19401
2024-05-02 10:32:55 +02:00
ci worker 7c79d91b6f Merge branch 'cassandra-4.0' into cassandra-4.1 2024-05-01 14:34:02 -07:00
David Capwell c14abb40b2 IR may leak SSTables with pending repair when coming from streaming
patch by David Capwell; reviewed by Blake Eggleston for CASSANDRA-19182
2024-05-01 14:32:07 -07:00
Caleb Rackliffe 428fa1f445 Make queries visible to the "system_views.queries" virtual table at the coordinator level
patch by Caleb Rackliffe; reviewed by David Capwell and Chris Lohfink for CASSANDRA-19577
2024-05-01 14:32:12 -05:00
Chris Lohfink a6e80317de apply schema if schema digest differs
Patch by clohfink; reviewed by brandonwilliams and jwest for
CASSANDRA-19578
2024-04-30 16:59:34 -05:00
Jon Meredith 858a2b2321 Merge branch 'cassandra-4.0' into cassandra-4.1 2024-04-25 14:00:47 -06:00
Jon Meredith 9157d98e4c Streaming exception race creates corrupt transaction log files that prevent restart
patch by Jon Meredith; reviewed by Caleb Rackliffe, David Capwell for CASSANDRA-18736
2024-04-25 13:59:59 -06:00
Stefan Miklosovic e471a57dc2
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-04-23 00:51:18 +02:00
Stefan Miklosovic fba4a85b97
Fix CQL tojson timestamp output on negative timestamp values before Gregorian calendar reform in 1582
patch by Stefan Miklosovic; reviewed by Brandon Williams, Berenguer Blasi for CASSANDRA-19566
2024-04-23 00:44:37 +02:00
Jacek Lewandowski 445ae1a4b1 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Fix few types issues and implement types compatibility tests
2024-04-18 12:33:54 +02:00
Jacek Lewandowski f92998190c Fix few types issues and implement types compatibility tests
Patch by Jacek Lewandowski; reviewed by Stefan Miklosovic for CASSANDRA-19479
2024-04-18 12:33:52 +02:00
Caleb Rackliffe 39bd3c2261 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Optionally avoid hint transfer during decommission
2024-04-08 15:28:06 -05:00
Caleb Rackliffe 0974a3656d Optionally avoid hint transfer during decommission
patch by Paul Chandler; reviewed by Caleb Rackliffe and Brandon Williams for CASSANDRA-19525
2024-04-08 15:22:10 -05:00
Stefan Miklosovic 5fb562d7ef
Fix hints delivery for a node going down repeatedly
patch by Stefan Miklosovic; reviewed by Brandon Williams, Paul Chandler for CASSANDRA-19495
2024-04-05 10:53:54 +02:00
Brandon Williams 659e41db9a Merge branch 'cassandra-4.0' into cassandra-4.1 2024-04-04 11:00:07 -05:00
Mohammad Aburadeh 6a640b0c4e Change logging to TRACE when failing to get peer certificates
Patch by Mohammad Aburadeh; reviewed by brandonwilliams and jonmeredith
for CASSANDRA-19508
2024-04-04 10:58:19 -05:00
Stefan Miklosovic 38408938cc
Do not go to disk for reading hints file sizes
patch by Stefan Miklosovic; reviewed by Aleksey Yeschenko, Jon Haddad, Chris Lohfink for CASSANDRA-19477
2024-03-25 14:08:02 +01:00
Stefan Miklosovic e4ae1f3a4f
Fix system_views.settings to handle array types
patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-19475
2024-03-19 14:55:42 +01:00
Brandon Williams 8502da494c Merge branch 'cassandra-4.0' into cassandra-4.1 2024-03-14 10:26:06 -05:00
arkn98 a2fbb17867 Push LocalSessions info logs to debug
Patch by arkn98; reviewed by bereng and brandonwilliams for CASSANDRA-18335
2024-03-14 10:24:38 -05:00
Stefan Miklosovic e120088d44
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-02-29 11:40:57 +01:00
Stefan Miklosovic a124cfce85
Merge branch 'cassandra-3.11' into cassandra-4.0 2024-02-29 11:38:39 +01:00
Abe Ratnofsky 099fdf2673
Move ClientWarn.State#warnings to a thread-safe list
patch by Abe Ratnofsky; reviewed by Caleb Rackliffe, Stefan Miklosovic for CASSANDRA-19427
2024-02-29 11:33:03 +01:00
Stefan Miklosovic b6b291e3bb
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-02-22 23:56:48 +01:00
Runtian Liu c2041ba45b
Filter remote DC replicas out when constructing the initial replica plan for the local read repair
patch by Runtian Liu; reviewed by Blake Eggleston and Stefan Miklosovic for CASSANDRA-19120
2024-02-22 23:21:16 +01:00
Stefan Miklosovic 5f63b0ade1
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-02-22 09:58:10 +01:00
maoling 8c4a58f035
Remove redundant code in StorageProxy#sendToHintedReplicas
patch by Ling Mao; reviewed by Stefan Miklosovic, Brandon Williams and Maxwell Guo for CASSANDRA-19412
2024-02-22 09:54:08 +01:00
Andrés de la Peña 89a8155916 Merge branch 'cassandra-4.0' into cassandra-4.1 2024-02-08 11:11:07 +00:00
Andrés de la Peña 505f5af645 Ensure that repair doesn't exceed repair_session_space by running limiting validation parallelism
patch by Andrés de la Peña; reviewed by David Capwell for CASSANDRA-19336

Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com>
Co-authored-by: David Capwell <dcapwell@apache.org>
2024-02-08 11:09:21 +00:00
Jacek Lewandowski d9dbd5e1d0 Merge branch 'cassandra-4.0' into cassandra-4.1
* cassandra-4.0:
  Backport CASSANDRA-16418 to 3.x
2024-02-07 15:12:02 +01:00
Jacek Lewandowski 9613af24f3 Merge branch 'cassandra-3.11' into cassandra-4.0
* cassandra-3.11:
  Backport CASSANDRA-16418 to 3.x
2024-02-07 15:12:01 +01:00
Jacek Lewandowski 2170825f0e Merge branch 'cassandra-3.0' into cassandra-3.11
* cassandra-3.0:
  Backport CASSANDRA-16418 to 3.x
2024-02-07 15:12:00 +01:00
Szymon Miężał 5be57829b0 Backport CASSANDRA-16418 to 3.x
When a node is decommissioned, it triggers data transfer to other nodes.
During this transfer process, receiving nodes temporarily hold token ranges in a pending state.
However, the current cleanup process doesn't account for these pending ranges when calculating token ownership,
leading to inadvertent cleanup of data already stored in SSTables.
To address this issue, this patch introduces two changes.
Firstly, it backports CASSANDRA-16418, introducing a preventive check in `StorageService#forceKeyspaceCleanup`.
This check disallows the initiation of cleanup when a node contains any pending ranges for the requested keyspace.
Secondly, it reintroduces a similar condition to test for the existence of pending ranges in `CompactionManager#performCleanup`.
This ensures the safety of this API as well.

Patch by Szymon Miezal; reviewed by Brandon Williams, Jacek Lewandowski for CASSANDRA-18824

Co-authored-by: Szymon Miezal <szymon.miezal@datastax.com>
Co-authored-by: Jacek Lewandowski <lewandowski.jacek@gmail.com>
2024-02-07 15:11:59 +01:00
Stefan Miklosovic fa6e06c933
Merge branch 'cassandra-4.0' into cassandra-4.1 2024-01-11 11:30:25 +01:00
Runtian Liu ee9e418782
Skip version check if an endpoint is dead state in Gossiper#upgradeFromVersionSupplier
patch by Runtian Liu; reviewed by Stefan Miklosovic and Brandon Williams for CASSANDRA-19187
2024-01-11 10:37:11 +01:00