natas_hw
/
cassandra
mirror of https://github.com/apache/cassandra
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Verify compression provider type before initialization

This commit is contained in:
Jeremiah Jordan 2026-07-16 08:30:31 -05:00
parent 13c3d8dee8
commit e94bc8890a
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java/org/apache/cassandra/utils/FBUtilities.java
View File

@ -744,8 +744,9 @@ public class FBUtilities
if (!className.contains("."))
className = "org.apache.cassandra.io.compress." + className;
Class<?> compressionProviderClass = FBUtilities.classForName(className, "compression service provider");
return (AbstractCompressionProvider) compressionProviderClass.getConstructor().newInstance();
Class<? extends AbstractCompressionProvider> compressionProviderClass =
FBUtilities.classForNameWithoutInitialization(className, "compression service provider", AbstractCompressionProvider.class);
return compressionProviderClass.getConstructor().newInstance();
}
catch (ConfigurationException e)
{

12
test/unit/org/apache/cassandra/utils/FBUtilitiesTest.java
View File

@ -61,6 +61,7 @@ import org.apache.cassandra.dht.Murmur3Partitioner;
import org.apache.cassandra.dht.OrderPreservingPartitioner;
import org.apache.cassandra.dht.RandomPartitioner;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.io.compress.AbstractCompressionProvider;
import org.apache.cassandra.security.AbstractCryptoProvider;
import org.apache.cassandra.security.ISslContextFactory;
@ -141,6 +142,17 @@ public class FBUtilitiesTest
assertThat(ClassLoadingTestSupport.wasInitialized(ClassLoadingTestNonAssignable.class)).isFalse();
}
@Test
public void testNewCompressionProviderRejectsWrongTypeWithoutInitializing()
{
ClassLoadingTestSupport.assertNotInitialized(ClassLoadingTestNonAssignable.class);
assertThatThrownBy(() -> FBUtilities.newCompressionProvider(ClassLoadingTestNonAssignable.class.getName()))
.isInstanceOf(ConfigurationException.class)
.hasStackTraceContaining("must extend or implement " + AbstractCompressionProvider.class.getName());
assertThat(ClassLoadingTestSupport.wasInitialized(ClassLoadingTestNonAssignable.class)).isFalse();
}
@Test
public void testCompareByteSubArrays()
{