diff --git a/CHANGES.txt b/CHANGES.txt index 5c9b436ff5..ed818db502 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -31,6 +31,7 @@ * Fix duplicated error messages on directory creation error at startup (CASSANDRA-5818) * reduce garbage on codec flag deserialization (CASSANDRA-7244) * Proper null handle for IF with map element access (CASSANDRA-7155) + * Improve compaction visibility (CASSANDRA-7242) Merged from 1.2: * Add Cloudstack snitch (CASSANDRA-7147) * Update system.peers correctly when relocating tokens (CASSANDRA-7126) diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java index 31b7d8e5b5..2708e4cdc2 100644 --- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java +++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java @@ -35,6 +35,7 @@ import org.slf4j.LoggerFactory; import org.apache.cassandra.cache.AutoSavingCache; import org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor; +import org.apache.cassandra.concurrent.JMXEnabledThreadPoolExecutor; import org.apache.cassandra.concurrent.NamedThreadFactory; import org.apache.cassandra.config.CFMetaData; import org.apache.cassandra.config.DatabaseDescriptor; @@ -927,12 +928,11 @@ public class CompactionManager implements CompactionManagerMBean return CompactionMetrics.getCompactions().size(); } - private static class CompactionExecutor extends ThreadPoolExecutor + private static class CompactionExecutor extends JMXEnabledThreadPoolExecutor { protected CompactionExecutor(int minThreads, int maxThreads, String name, BlockingQueue queue) { - super(minThreads, maxThreads, 60, TimeUnit.SECONDS, queue, new NamedThreadFactory(name, Thread.MIN_PRIORITY)); - allowCoreThreadTimeOut(true); + super(minThreads, maxThreads, 60, TimeUnit.SECONDS, queue, new NamedThreadFactory(name, Thread.MIN_PRIORITY), "internal"); } private CompactionExecutor(int threadCount, String name) diff --git a/src/java/org/apache/cassandra/metrics/ColumnFamilyMetrics.java b/src/java/org/apache/cassandra/metrics/ColumnFamilyMetrics.java index bcff2d09fd..8880485a30 100644 --- a/src/java/org/apache/cassandra/metrics/ColumnFamilyMetrics.java +++ b/src/java/org/apache/cassandra/metrics/ColumnFamilyMetrics.java @@ -56,6 +56,8 @@ public class ColumnFamilyMetrics public final LatencyMetrics writeLatency; /** Estimated number of tasks pending for this column family */ public final Gauge pendingTasks; + /** Estimate of number of pending compactios for this CF */ + public final Gauge pendingCompactions; /** Number of SSTables on disk for this CF */ public final Gauge liveSSTableCount; /** Disk space used by SSTables belonging to this CF */ @@ -175,6 +177,13 @@ public class ColumnFamilyMetrics }); readLatency = new LatencyMetrics(factory, "Read"); writeLatency = new LatencyMetrics(factory, "Write"); + pendingCompactions = Metrics.newGauge(factory.createMetricName("PendingCompactions"), new Gauge() + { + public Integer value() + { + return cfs.getCompactionStrategy().getEstimatedRemainingTasks(); + } + }); pendingTasks = Metrics.newGauge(factory.createMetricName("PendingTasks"), new Gauge() { public Integer value()