Don't increment client metrics on messaging service connection unpause

patch by Edward Chu; reviewed by Aleksey Yeschenko for CASSANDRA-21491
This commit is contained in:
Edward 2026-07-10 18:15:23 +01:00 committed by Aleksey Yeshchenko
parent 3fad760416
commit db0871ce8b
3 changed files with 12 additions and 2 deletions

View File

@ -1,4 +1,5 @@
7.0
* Don't increment client metrics on messaging service connection unpause (CASSANDRA-21491)
* Add nodetool getreplicas (CASSANDRA-17665)
* Implementation of CEP-49: Hardware-accelerated compression (CASSANDRA-20975)
* Avoid using ObjectUtils.getFirstNonNull in Schema (CASSANDRA-21394)

View File

@ -31,7 +31,6 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.cassandra.concurrent.ManyToOneConcurrentLinkedQueue;
import org.apache.cassandra.metrics.ClientMetrics;
import org.apache.cassandra.net.FrameDecoder.CorruptFrame;
import org.apache.cassandra.net.FrameDecoder.Frame;
import org.apache.cassandra.net.FrameDecoder.FrameProcessor;
@ -314,7 +313,7 @@ public abstract class AbstractMessageHandler extends ChannelInboundHandlerAdapte
decoder.reactivate();
if (decoder.isActive())
ClientMetrics.instance.unpauseConnection();
onConnectionUnpaused();
}
}
catch (Throwable t)
@ -323,6 +322,10 @@ public abstract class AbstractMessageHandler extends ChannelInboundHandlerAdapte
}
}
protected void onConnectionUnpaused()
{
}
protected abstract void fatalExceptionCaught(Throwable t);
// return true if the handler should be reactivated - if no new hurdles were encountered,

View File

@ -159,6 +159,12 @@ public class CQLMessageHandler<M extends Message> extends AbstractMessageHandler
return super.process(frame);
}
@Override
protected void onConnectionUnpaused()
{
ClientMetrics.instance.unpauseConnection();
}
/**
* Checks limits on bytes in flight and the request rate limiter (if enabled), then takes one of three actions:
*