From cf5cd158e9ccc24239015b5928f65628c3f5663e Mon Sep 17 00:00:00 2001 From: Yuki Morishita Date: Tue, 20 Sep 2016 16:31:18 -0500 Subject: [PATCH] Fix DatabaseDescriptorRefTest patch by yukim; reviewed by Alex Petrov for CASSANDRA-12677 --- src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 2 -- .../org/apache/cassandra/io/sstable/CQLSSTableWriter.java | 4 +++- .../org/apache/cassandra/test/microbench/MutationBench.java | 3 +++ .../apache/cassandra/config/DatabaseDescriptorRefTest.java | 1 + .../apache/cassandra/io/sstable/StressCQLSSTableWriter.java | 3 +++ 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index 880cb1ec3e..36def7900c 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -44,7 +44,6 @@ import org.apache.cassandra.auth.IRoleManager; import org.apache.cassandra.config.Config.CommitLogSync; import org.apache.cassandra.config.Config.RequestSchedulerId; import org.apache.cassandra.dht.IPartitioner; -import org.apache.cassandra.dht.Murmur3Partitioner; import org.apache.cassandra.exceptions.ConfigurationException; import org.apache.cassandra.io.FSWriteError; import org.apache.cassandra.io.util.DiskOptimizationStrategy; @@ -220,7 +219,6 @@ public class DatabaseDescriptor Config.setClientMode(true); conf = new Config(); diskOptimizationStrategy = new SpinningDiskOptimizationStrategy(); - partitioner = Murmur3Partitioner.instance; } public static boolean isClientInitialized() diff --git a/src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java b/src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java index dd9eb599bd..8a9d01d1fb 100644 --- a/src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java +++ b/src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java @@ -53,7 +53,6 @@ import org.apache.cassandra.exceptions.InvalidRequestException; import org.apache.cassandra.exceptions.RequestValidationException; import org.apache.cassandra.exceptions.SyntaxException; import org.apache.cassandra.io.sstable.format.SSTableFormat; -import org.apache.cassandra.io.util.SpinningDiskOptimizationStrategy; import org.apache.cassandra.schema.KeyspaceMetadata; import org.apache.cassandra.schema.KeyspaceParams; import org.apache.cassandra.schema.Types; @@ -106,6 +105,9 @@ public class CQLSSTableWriter implements Closeable static { DatabaseDescriptor.clientInitialization(false); + // Partitioner is not set in client mode. + if (DatabaseDescriptor.getPartitioner() == null) + DatabaseDescriptor.setPartitionerUnsafe(Murmur3Partitioner.instance); } private final AbstractSSTableSimpleWriter writer; diff --git a/test/microbench/org/apache/cassandra/test/microbench/MutationBench.java b/test/microbench/org/apache/cassandra/test/microbench/MutationBench.java index 20d8ff5a30..8c177cf931 100644 --- a/test/microbench/org/apache/cassandra/test/microbench/MutationBench.java +++ b/test/microbench/org/apache/cassandra/test/microbench/MutationBench.java @@ -65,6 +65,9 @@ public class MutationBench static { DatabaseDescriptor.clientInitialization(false); + // Partitioner is not set in client mode. + if (DatabaseDescriptor.getPartitioner() == null) + DatabaseDescriptor.setPartitionerUnsafe(Murmur3Partitioner.instance); } static String keyspace = "keyspace1"; diff --git a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java index 2dcfbd15f1..421142fa66 100644 --- a/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java +++ b/test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java @@ -99,6 +99,7 @@ public class DatabaseDescriptorRefTest "org.apache.cassandra.io.util.DataOutputStreamPlus", "org.apache.cassandra.io.util.DataOutputPlus", "org.apache.cassandra.io.util.DiskOptimizationStrategy", + "org.apache.cassandra.io.util.SpinningDiskOptimizationStrategy", "org.apache.cassandra.locator.SimpleSeedProvider", "org.apache.cassandra.locator.SeedProvider", "org.apache.cassandra.net.BackPressureStrategy", diff --git a/tools/stress/src/org/apache/cassandra/io/sstable/StressCQLSSTableWriter.java b/tools/stress/src/org/apache/cassandra/io/sstable/StressCQLSSTableWriter.java index d9bf6690de..4fe05a87dc 100644 --- a/tools/stress/src/org/apache/cassandra/io/sstable/StressCQLSSTableWriter.java +++ b/tools/stress/src/org/apache/cassandra/io/sstable/StressCQLSSTableWriter.java @@ -99,6 +99,9 @@ public class StressCQLSSTableWriter implements Closeable static { DatabaseDescriptor.clientInitialization(false); + // Partitioner is not set in client mode. + if (DatabaseDescriptor.getPartitioner() == null) + DatabaseDescriptor.setPartitionerUnsafe(Murmur3Partitioner.instance); } private final AbstractSSTableSimpleWriter writer;