From c43cf8d79b974c8e68938c86f0cc535b700160fa Mon Sep 17 00:00:00 2001 From: Wei Deng Date: Mon, 25 Apr 2016 20:03:27 -0500 Subject: [PATCH] Change order of directory searching for cassandra.in.sh patch by Wei Deng; reviewed by yukim for CASSANDRA-11628 --- CHANGES.txt | 1 + bin/debug-cql | 8 ++++---- bin/nodetool | 9 +++++---- bin/sstablekeys | 9 +++++---- bin/sstableloader | 9 +++++---- bin/sstablescrub | 9 +++++---- bin/sstableupgrade | 9 +++++---- tools/bin/cassandra-stress | 9 +++++---- tools/bin/cassandra-stressd | 9 +++++---- tools/bin/json2sstable | 9 +++++---- tools/bin/sstable2json | 9 +++++---- tools/bin/sstableexpiredblockers | 9 +++++---- tools/bin/sstablelevelreset | 9 +++++---- tools/bin/sstablemetadata | 9 +++++---- tools/bin/sstableofflinerelevel | 9 +++++---- tools/bin/sstablerepairedset | 9 +++++---- tools/bin/sstablesplit | 9 +++++---- 17 files changed, 80 insertions(+), 64 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 53945d6d5b..4f6a4dba0b 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.1.15 + * Change order of directory searching for cassandra.in.sh to favor local one (CASSANDRA-11628) * cqlsh COPY FROM fails with []{} chars in UDT/tuple fields/values (CASSANDRA-11633) * clqsh: COPY FROM throws TypeError with Cython extensions enabled (CASSANDRA-11574) * cqlsh: COPY FROM ignores NULL values in conversion (CASSANDRA-11549) diff --git a/bin/debug-cql b/bin/debug-cql index b4ebb82475..ae9bfe4109 100755 --- a/bin/debug-cql +++ b/bin/debug-cql @@ -17,11 +17,11 @@ if [ "x$CASSANDRA_INCLUDE" = "x" ]; then # Locations (in order) to use when searching for an include file. - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname $0`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/bin/nodetool b/bin/nodetool index 0ea078f040..b6a6fbf69c 100755 --- a/bin/nodetool +++ b/bin/nodetool @@ -23,11 +23,12 @@ if [ "`basename "$0"`" = 'nodeprobe' ]; then fi if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/bin/sstablekeys b/bin/sstablekeys index 55b72d9e3f..c0967ef692 100755 --- a/bin/sstablekeys +++ b/bin/sstablekeys @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/bin/sstableloader b/bin/sstableloader index b6a6d8396b..03ab4f96f1 100755 --- a/bin/sstableloader +++ b/bin/sstableloader @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/bin/sstablescrub b/bin/sstablescrub index 58bd21be3d..366a2b7e3a 100755 --- a/bin/sstablescrub +++ b/bin/sstablescrub @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/bin/sstableupgrade b/bin/sstableupgrade index a722cdc770..7b307eb8e6 100755 --- a/bin/sstableupgrade +++ b/bin/sstableupgrade @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/cassandra-stress b/tools/bin/cassandra-stress index 1ffb598411..82a3eb5d27 100755 --- a/tools/bin/cassandra-stress +++ b/tools/bin/cassandra-stress @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/cassandra-stressd b/tools/bin/cassandra-stressd index 229ba0bc89..48fbef61db 100755 --- a/tools/bin/cassandra-stressd +++ b/tools/bin/cassandra-stressd @@ -18,11 +18,12 @@ DESC="Cassandra Stress Test Daemon" if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/json2sstable b/tools/bin/json2sstable index a58a785e63..1bed544334 100755 --- a/tools/bin/json2sstable +++ b/tools/bin/json2sstable @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstable2json b/tools/bin/sstable2json index 6bbbfc60bd..92ad5c527e 100755 --- a/tools/bin/sstable2json +++ b/tools/bin/sstable2json @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstableexpiredblockers b/tools/bin/sstableexpiredblockers index cefdfe364e..c1c7e41b77 100755 --- a/tools/bin/sstableexpiredblockers +++ b/tools/bin/sstableexpiredblockers @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstablelevelreset b/tools/bin/sstablelevelreset index 8191f3ddca..ec602fd3b2 100755 --- a/tools/bin/sstablelevelreset +++ b/tools/bin/sstablelevelreset @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstablemetadata b/tools/bin/sstablemetadata index 531686919c..addf39b538 100755 --- a/tools/bin/sstablemetadata +++ b/tools/bin/sstablemetadata @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstableofflinerelevel b/tools/bin/sstableofflinerelevel index a4ba6cb3ae..4e34515b9f 100755 --- a/tools/bin/sstableofflinerelevel +++ b/tools/bin/sstableofflinerelevel @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstablerepairedset b/tools/bin/sstablerepairedset index efb8a701ac..225cd11622 100755 --- a/tools/bin/sstablerepairedset +++ b/tools/bin/sstablerepairedset @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break diff --git a/tools/bin/sstablesplit b/tools/bin/sstablesplit index 90d91cea7d..037cb63d8c 100755 --- a/tools/bin/sstablesplit +++ b/tools/bin/sstablesplit @@ -17,11 +17,12 @@ # limitations under the License. if [ "x$CASSANDRA_INCLUDE" = "x" ]; then - for include in /usr/share/cassandra/cassandra.in.sh \ - /usr/local/share/cassandra/cassandra.in.sh \ - /opt/cassandra/cassandra.in.sh \ + # Locations (in order) to use when searching for an include file. + for include in "`dirname "$0"`/cassandra.in.sh" \ "$HOME/.cassandra.in.sh" \ - "`dirname "$0"`/cassandra.in.sh"; do + /usr/share/cassandra/cassandra.in.sh \ + /usr/local/share/cassandra/cassandra.in.sh \ + /opt/cassandra/cassandra.in.sh; do if [ -r "$include" ]; then . "$include" break