diff --git a/src/java/org/apache/cassandra/cql3/CQLStatement.java b/src/java/org/apache/cassandra/cql3/CQLStatement.java index 4828fc7b67..81cd2b27cc 100644 --- a/src/java/org/apache/cassandra/cql3/CQLStatement.java +++ b/src/java/org/apache/cassandra/cql3/CQLStatement.java @@ -27,7 +27,7 @@ public interface CQLStatement /** * Returns the number of bound terms in this statement. */ - public int getBoundsTerms(); + public int getBoundTerms(); /** * Perform any access verification necessary for the statement. diff --git a/src/java/org/apache/cassandra/cql3/QueryProcessor.java b/src/java/org/apache/cassandra/cql3/QueryProcessor.java index ad3c4b4ffe..02361a86b4 100644 --- a/src/java/org/apache/cassandra/cql3/QueryProcessor.java +++ b/src/java/org/apache/cassandra/cql3/QueryProcessor.java @@ -216,7 +216,7 @@ public class QueryProcessor throws RequestExecutionException, RequestValidationException { CQLStatement prepared = getStatement(queryString, queryState.getClientState()).statement; - if (prepared.getBoundsTerms() != options.getValues().size()) + if (prepared.getBoundTerms() != options.getValues().size()) throw new InvalidRequestException("Invalid amount of bind variables"); return processStatement(prepared, queryState, options, queryString); @@ -286,10 +286,10 @@ public class QueryProcessor throws RequestValidationException { ParsedStatement.Prepared prepared = getStatement(queryString, clientState); - int bountTerms = prepared.statement.getBoundsTerms(); - if (bountTerms > FBUtilities.MAX_UNSIGNED_SHORT) - throw new InvalidRequestException(String.format("Too many markers(?). %d markers exceed the allowed maximum of %d", bountTerms, FBUtilities.MAX_UNSIGNED_SHORT)); - assert bountTerms == prepared.boundNames.size(); + int boundTerms = prepared.statement.getBoundTerms(); + if (boundTerms > FBUtilities.MAX_UNSIGNED_SHORT) + throw new InvalidRequestException(String.format("Too many markers(?). %d markers exceed the allowed maximum of %d", boundTerms, FBUtilities.MAX_UNSIGNED_SHORT)); + assert boundTerms == prepared.boundNames.size(); ResultMessage.Prepared msg = storePreparedStatement(queryString, clientState.getRawKeyspace(), prepared, forThrift); @@ -322,7 +322,7 @@ public class QueryProcessor thriftPreparedStatements.put(statementId, prepared.statement); logger.trace(String.format("Stored prepared statement #%d with %d bind markers", statementId, - prepared.statement.getBoundsTerms())); + prepared.statement.getBoundTerms())); return ResultMessage.Prepared.forThrift(statementId, prepared.boundNames); } else @@ -331,7 +331,7 @@ public class QueryProcessor preparedStatements.put(statementId, prepared.statement); logger.trace(String.format("Stored prepared statement %s with %d bind markers", statementId, - prepared.statement.getBoundsTerms())); + prepared.statement.getBoundTerms())); return new ResultMessage.Prepared(statementId, prepared); } } @@ -341,11 +341,11 @@ public class QueryProcessor { List variables = options.getValues(); // Check to see if there are any bound variables to verify - if (!(variables.isEmpty() && (statement.getBoundsTerms() == 0))) + if (!(variables.isEmpty() && (statement.getBoundTerms() == 0))) { - if (variables.size() != statement.getBoundsTerms()) + if (variables.size() != statement.getBoundTerms()) throw new InvalidRequestException(String.format("there were %d markers(?) in CQL but %d bound variables", - statement.getBoundsTerms(), + statement.getBoundTerms(), variables.size())); // at this point there is a match in count between markers and variables that is non-zero diff --git a/src/java/org/apache/cassandra/cql3/statements/AuthenticationStatement.java b/src/java/org/apache/cassandra/cql3/statements/AuthenticationStatement.java index 0e38b661aa..5fcf08500d 100644 --- a/src/java/org/apache/cassandra/cql3/statements/AuthenticationStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/AuthenticationStatement.java @@ -32,7 +32,7 @@ public abstract class AuthenticationStatement extends ParsedStatement implements return new Prepared(this); } - public int getBoundsTerms() + public int getBoundTerms() { return 0; } diff --git a/src/java/org/apache/cassandra/cql3/statements/AuthorizationStatement.java b/src/java/org/apache/cassandra/cql3/statements/AuthorizationStatement.java index 9ea73fa45d..db4581e6e0 100644 --- a/src/java/org/apache/cassandra/cql3/statements/AuthorizationStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/AuthorizationStatement.java @@ -34,7 +34,7 @@ public abstract class AuthorizationStatement extends ParsedStatement implements return new Prepared(this); } - public int getBoundsTerms() + public int getBoundTerms() { return 0; } diff --git a/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java b/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java index 311a3c75ea..25f61fbb3a 100644 --- a/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/BatchStatement.java @@ -72,7 +72,7 @@ public class BatchStatement implements CQLStatement, MeasurableForPreparedCache return size; } - public int getBoundsTerms() + public int getBoundTerms() { return boundTerms; } @@ -206,7 +206,7 @@ public class BatchStatement implements CQLStatement, MeasurableForPreparedCache public ParsedStatement.Prepared prepare() throws InvalidRequestException { - VariableSpecifications boundNames = getBoundsVariables(); + VariableSpecifications boundNames = getBoundVariables(); List statements = new ArrayList(parsedStatements.size()); for (ModificationStatement.Parsed parsed : parsedStatements) diff --git a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java index 8833f342c8..9e0fd62c44 100644 --- a/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java @@ -72,7 +72,7 @@ public abstract class ModificationStatement implements CQLStatement, MeasurableF public abstract boolean requireFullClusteringKey(); public abstract ColumnFamily updateForKey(ByteBuffer key, ColumnNameBuilder builder, UpdateParameters params) throws InvalidRequestException; - public int getBoundsTerms() + public int getBoundTerms() { return boundTerms; } @@ -578,7 +578,7 @@ public abstract class ModificationStatement implements CQLStatement, MeasurableF public ParsedStatement.Prepared prepare() throws InvalidRequestException { - VariableSpecifications boundNames = getBoundsVariables(); + VariableSpecifications boundNames = getBoundVariables(); ModificationStatement statement = prepare(boundNames); return new ParsedStatement.Prepared(statement, boundNames); } diff --git a/src/java/org/apache/cassandra/cql3/statements/ParsedStatement.java b/src/java/org/apache/cassandra/cql3/statements/ParsedStatement.java index ecf8a8a851..d048327f20 100644 --- a/src/java/org/apache/cassandra/cql3/statements/ParsedStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/ParsedStatement.java @@ -27,7 +27,7 @@ public abstract class ParsedStatement { private VariableSpecifications variables; - public VariableSpecifications getBoundsVariables() + public VariableSpecifications getBoundVariables() { return variables; } diff --git a/src/java/org/apache/cassandra/cql3/statements/SchemaAlteringStatement.java b/src/java/org/apache/cassandra/cql3/statements/SchemaAlteringStatement.java index f2904e45fe..337e8dca90 100644 --- a/src/java/org/apache/cassandra/cql3/statements/SchemaAlteringStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/SchemaAlteringStatement.java @@ -44,7 +44,7 @@ public abstract class SchemaAlteringStatement extends CFStatement implements CQL this.isColumnFamilyLevel = true; } - public int getBoundsTerms() + public int getBoundTerms() { return 0; } diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java index b94e54997e..133444a4db 100644 --- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java @@ -115,7 +115,7 @@ public class SelectStatement implements CQLStatement, MeasurableForPreparedCache return meter.measureDeep(this) - meter.measureDeep(cfDef); } - public int getBoundsTerms() + public int getBoundTerms() { return boundTerms; } @@ -1069,7 +1069,7 @@ public class SelectStatement implements CQLStatement, MeasurableForPreparedCache CFDefinition cfDef = cfm.getCfDef(); - VariableSpecifications names = getBoundsVariables(); + VariableSpecifications names = getBoundVariables(); // Select clause if (parameters.isCount && !selectClause.isEmpty()) diff --git a/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java b/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java index d5baedf128..30e57d5fd6 100644 --- a/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/TruncateStatement.java @@ -36,7 +36,7 @@ public class TruncateStatement extends CFStatement implements CQLStatement super(name); } - public int getBoundsTerms() + public int getBoundTerms() { return 0; } diff --git a/src/java/org/apache/cassandra/cql3/statements/UseStatement.java b/src/java/org/apache/cassandra/cql3/statements/UseStatement.java index db2435f1d6..ee70f9df20 100644 --- a/src/java/org/apache/cassandra/cql3/statements/UseStatement.java +++ b/src/java/org/apache/cassandra/cql3/statements/UseStatement.java @@ -34,7 +34,7 @@ public class UseStatement extends ParsedStatement implements CQLStatement this.keyspace = keyspace; } - public int getBoundsTerms() + public int getBoundTerms() { return 0; } diff --git a/src/java/org/apache/cassandra/thrift/CassandraServer.java b/src/java/org/apache/cassandra/thrift/CassandraServer.java index 4e3c372b9d..07c271b2d3 100644 --- a/src/java/org/apache/cassandra/thrift/CassandraServer.java +++ b/src/java/org/apache/cassandra/thrift/CassandraServer.java @@ -2077,7 +2077,7 @@ public class CassandraServer implements Cassandra.Iface " (either the query was not prepared on this host (maybe the host has been restarted?)" + " or you have prepared too many queries and it has been evicted from the internal cache)", itemId)); - logger.trace("Retrieved prepared statement #{} with {} bind markers", itemId, statement.getBoundsTerms()); + logger.trace("Retrieved prepared statement #{} with {} bind markers", itemId, statement.getBoundTerms()); return org.apache.cassandra.cql3.QueryProcessor.processPrepared(statement, cState.getQueryState(), diff --git a/src/java/org/apache/cassandra/transport/messages/BatchMessage.java b/src/java/org/apache/cassandra/transport/messages/BatchMessage.java index bd95ef3242..487e089ebf 100644 --- a/src/java/org/apache/cassandra/transport/messages/BatchMessage.java +++ b/src/java/org/apache/cassandra/transport/messages/BatchMessage.java @@ -24,7 +24,6 @@ import java.util.List; import java.util.UUID; import org.jboss.netty.buffer.ChannelBuffer; -import org.jboss.netty.buffer.ChannelBuffers; import org.apache.cassandra.cql3.Attributes; import org.apache.cassandra.cql3.CQLStatement; @@ -180,9 +179,9 @@ public class BatchMessage extends Message.Request } List queryValues = values.get(i); - if (queryValues.size() != statement.getBoundsTerms()) + if (queryValues.size() != statement.getBoundTerms()) throw new InvalidRequestException(String.format("There were %d markers(?) in CQL but %d bound variables", - statement.getBoundsTerms(), + statement.getBoundTerms(), queryValues.size())); if (!(statement instanceof ModificationStatement)) throw new InvalidRequestException("Invalid statement in batch: only UPDATE, INSERT and DELETE statements are allowed.");