diff --git a/CHANGES.txt b/CHANGES.txt index 256e69a019..69df3de7d2 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 1.1.12 + * Remove buggy thrift max message length option (CASSANDRA-5529) * Add retry mechanism to OTC for non-droppable_verbs (CASSANDRA-5393) * Use allocator information to improve memtable memory usage estimate (CASSANDRA-5497) @@ -6,6 +7,7 @@ * Fix Bound intersection computation (CASSANDRA-5551) * Fix NPE in Pig's widerow mode (CASSANDRA-5488) + 1.1.11 * Fix trying to load deleted row into row cache on startup (CASSANDRA-4463) * Update offline scrub for 1.0 -> 1.1 directory structure (CASSANDRA-5195) diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index 37f41fb587..027479daa8 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -330,15 +330,11 @@ rpc_server_type: sync # rpc_send_buff_size_in_bytes: # rpc_recv_buff_size_in_bytes: -# Frame size for thrift (maximum field length). +# Frame size for thrift (maximum message length). # 0 disables TFramedTransport in favor of TSocket. This option # is deprecated; we strongly recommend using Framed mode. thrift_framed_transport_size_in_mb: 15 -# The max length of a thrift message, including all fields and -# internal thrift overhead. -thrift_max_message_length_in_mb: 16 - # Set to true to have Cassandra create a hard link to each sstable # flushed or streamed locally in a backups/ subdirectory of the # Keyspace data. Removing these links is the operator's diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index a08a6942e5..11beea6b2a 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -77,7 +77,9 @@ public class Config public Integer rpc_send_buff_size_in_bytes; public Integer rpc_recv_buff_size_in_bytes; + @Deprecated public Integer thrift_max_message_length_in_mb = 16; + public Integer thrift_framed_transport_size_in_mb = 15; public Boolean snapshot_before_compaction = false; public Boolean auto_snapshot = true; diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index 0c460dc7b4..f55c89a62a 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -316,11 +316,6 @@ public class DatabaseDescriptor if (conf.thrift_framed_transport_size_in_mb <= 0) throw new ConfigurationException("thrift_framed_transport_size_in_mb must be positive"); - if (conf.thrift_framed_transport_size_in_mb > 0 && conf.thrift_max_message_length_in_mb < conf.thrift_framed_transport_size_in_mb) - { - throw new ConfigurationException("thrift_max_message_length_in_mb must be greater than thrift_framed_transport_size_in_mb when using TFramedTransport"); - } - /* end point snitch */ if (conf.endpoint_snitch == null) { @@ -582,11 +577,6 @@ public class DatabaseDescriptor return authority; } - public static int getThriftMaxMessageLength() - { - return conf.thrift_max_message_length_in_mb * 1024 * 1024; - } - public static int getThriftFramedTransportSize() { return conf.thrift_framed_transport_size_in_mb * 1024 * 1024; diff --git a/src/java/org/apache/cassandra/hadoop/ColumnFamilyOutputFormat.java b/src/java/org/apache/cassandra/hadoop/ColumnFamilyOutputFormat.java index caea616f13..3818e53277 100644 --- a/src/java/org/apache/cassandra/hadoop/ColumnFamilyOutputFormat.java +++ b/src/java/org/apache/cassandra/hadoop/ColumnFamilyOutputFormat.java @@ -118,7 +118,7 @@ public class ColumnFamilyOutputFormat extends OutputFormat 0) - setReadLength(readLength); - } - public TBinaryProtocol(TTransport trans, boolean strictRead, boolean strictWrite) { super(trans); @@ -64,11 +50,6 @@ public class TBinaryProtocol extends org.apache.thrift.protocol.TBinaryProtocol super(strictRead, strictWrite, 0); } - public Factory(boolean strictRead, boolean strictWrite, int readLength) - { - super(strictRead, strictWrite, readLength); - } - public TProtocol getProtocol(TTransport trans) { TBinaryProtocol protocol = new TBinaryProtocol(trans, strictRead_, strictWrite_);