diff --git a/CHANGES.txt b/CHANGES.txt index e24dd19299..b68fbfd58c 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -201,6 +201,7 @@ Merged from 2.2: * Enable repair -pr and -local together (fix regression of CASSANDRA-7450) (CASSANDRA-12522) * Split consistent range movement flag correction (CASSANDRA-12786) Merged from 2.1: + * cqlsh copy-from: sort user type fields in csv (CASSANDRA-12959) * Don't skip sstables based on maxLocalDeletionTime (CASSANDRA-12765) diff --git a/pylib/cqlshlib/copyutil.py b/pylib/cqlshlib/copyutil.py index 711676b9bc..5d6eb43f15 100644 --- a/pylib/cqlshlib/copyutil.py +++ b/pylib/cqlshlib/copyutil.py @@ -1997,10 +1997,15 @@ class ImportConversion(object): an attribute, so we are using named tuples. It must also be hashable, so we cannot use dictionaries. Maybe there is a way to instantiate ct directly but I could not work it out. + Also note that it is possible that the subfield names in the csv are in the + wrong order, so we must sort them according to ct.fieldnames, see CASSANDRA-12959. """ vals = [v for v in [split('{%s}' % vv, sep=':') for vv in split(val)]] - ret_type = namedtuple(ct.typename, [unprotect(v[0]) for v in vals]) - return ret_type(*tuple(convert(t, v[1]) for t, v in zip(ct.subtypes, vals))) + dict_vals = dict((unprotect(v[0]), v[1]) for v in vals) + sorted_converted_vals = [(n, convert(t, dict_vals[n]) if n in dict_vals else self.get_null_val()) + for n, t in zip(ct.fieldnames, ct.subtypes)] + ret_type = namedtuple(ct.typename, [v[0] for v in sorted_converted_vals]) + return ret_type(*tuple(v[1] for v in sorted_converted_vals)) def convert_single_subtype(val, ct=cql_type): return converters.get(ct.subtypes[0].typename, convert_unknown)(val, ct=ct.subtypes[0])