diff --git a/CHANGES.txt b/CHANGES.txt index 520c5a5c71..3bbd75b612 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -6,6 +6,7 @@ Merged from 3.11: * Fix NPE when using udfContext in UDF after a restart of a node (CASSANDRA-18739) * Moved jflex from runtime to build dependencies (CASSANDRA-18664) Merged from 3.0: + * Refactor validation logic in StorageService.rebuild (CASSANDRA-18803) * Make alternation of a user type validate the same way as creation of a user type does (CASSANDRA-18585) * Backport of CASSANDRA-16905 Further restrict schema column drop/recreate conversions (CASSANDRA-18760) * CQLSH emits a warning when the server version doesn't match (CASSANDRA-18745) diff --git a/src/java/org/apache/cassandra/service/StorageService.java b/src/java/org/apache/cassandra/service/StorageService.java index b53467e81b..8308d4eceb 100644 --- a/src/java/org/apache/cassandra/service/StorageService.java +++ b/src/java/org/apache/cassandra/service/StorageService.java @@ -1327,43 +1327,34 @@ public class StorageService extends NotificationBroadcasterSupport implements IE public void rebuild(String sourceDc, String keyspace, String tokens, String specificSources) { - try + if (sourceDc != null) { - // check ongoing rebuild - if (!isRebuilding.compareAndSet(false, true)) + TokenMetadata.Topology topology = getTokenMetadata().cloneOnlyTokenMap().getTopology(); + Set availableDCs = topology.getDatacenterEndpoints().keySet(); + if (!availableDCs.contains(sourceDc)) { - throw new IllegalStateException("Node is still rebuilding. Check nodetool netstats."); - } - - if (sourceDc != null) - { - TokenMetadata.Topology topology = getTokenMetadata().cloneOnlyTokenMap().getTopology(); - Set availableDCs = topology.getDatacenterEndpoints().keySet(); - if (!availableDCs.contains(sourceDc)) - { - throw new IllegalArgumentException(String.format("Provided datacenter '%s' is not a valid datacenter, available datacenters are: %s", - sourceDc, String.join(",", availableDCs))); - } - } - - // check the arguments - if (keyspace == null && tokens != null) - { - throw new IllegalArgumentException("Cannot specify tokens without keyspace."); + throw new IllegalArgumentException(String.format("Provided datacenter '%s' is not a valid datacenter, available datacenters are: %s", + sourceDc, String.join(",", availableDCs))); } } - catch (Throwable ex) + + if (keyspace == null && tokens != null) { - isRebuilding.set(false); - throw ex; + throw new IllegalArgumentException("Cannot specify tokens without keyspace."); } - logger.info("rebuild from dc: {}, {}, {}", sourceDc == null ? "(any dc)" : sourceDc, - keyspace == null ? "(All keyspaces)" : keyspace, - tokens == null ? "(All tokens)" : tokens); + // check ongoing rebuild + if (!isRebuilding.compareAndSet(false, true)) + { + throw new IllegalStateException("Node is still rebuilding. Check nodetool netstats."); + } try { + logger.info("rebuild from dc: {}, {}, {}", sourceDc == null ? "(any dc)" : sourceDc, + keyspace == null ? "(All keyspaces)" : keyspace, + tokens == null ? "(All tokens)" : tokens); + RangeStreamer streamer = new RangeStreamer(tokenMetadata, null, FBUtilities.getBroadcastAddressAndPort(),