From 816d1ac1812cbf9aaf19c133d1d2b6087a2defad Mon Sep 17 00:00:00 2001 From: Ekaterina Dimitrova Date: Tue, 15 Aug 2023 14:02:48 -0400 Subject: [PATCH] Fix UFTest#testSchemaChange patch by Ekaterina Dimitrova; reviewed by Caleb Rackliffe for CASSANDRA-18752 --- .../cassandra/cql3/validation/entities/UFTest.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java b/test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java index 0a247738e4..56795c2dfc 100644 --- a/test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java +++ b/test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java @@ -81,10 +81,10 @@ public class UFTest extends CQLTester registerFunction(f, "double, double"); assertSchemaChange("CREATE OR REPLACE FUNCTION " + f + "(state double, val double)" + - "CALLED ON NULL INPUT " + + "RETURNS NULL ON NULL INPUT " + "RETURNS double " + "LANGUAGE java " + - "AS ' return Double.valueOf(Math.max(state.doubleValue(), val.doubleValue())); ';", + "AS ' return Double.valueOf(Math.max(state, val)); ';", Change.CREATED, Target.FUNCTION, KEYSPACE, functionName, @@ -102,15 +102,15 @@ public class UFTest extends CQLTester KEYSPACE, functionName, "int", "int"); - /*assertSchemaChange("CREATE OR REPLACE FUNCTION " + f + "(state int, val int) " + + assertSchemaChange("CREATE OR REPLACE FUNCTION " + f + "(state int, val int) " + "RETURNS NULL ON NULL INPUT " + "RETURNS int " + "LANGUAGE java " + - "AS ' return Integer.valueOf(Math.max(state, val));';", + "AS ' return Integer.valueOf(Math.min(state, val));';", Change.UPDATED, Target.FUNCTION, KEYSPACE, functionName, - "int", "int");*/ + "int", "int"); assertSchemaChange("DROP FUNCTION " + f + "(double, double)", Change.DROPPED, Target.FUNCTION,