From 79c6ecccc0760c2c19d3e83f5815307690ec0bdf Mon Sep 17 00:00:00 2001 From: Aleksey Yeschenko Date: Thu, 13 Feb 2014 11:44:21 +0300 Subject: [PATCH] Remove CF.resolve() --- src/java/org/apache/cassandra/db/ColumnFamily.java | 8 -------- src/java/org/apache/cassandra/db/Mutation.java | 2 +- .../cassandra/db/index/composites/CompositesSearcher.java | 2 +- test/unit/org/apache/cassandra/db/RowTest.java | 2 +- 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/java/org/apache/cassandra/db/ColumnFamily.java b/src/java/org/apache/cassandra/db/ColumnFamily.java index 66e8e331ba..3437410931 100644 --- a/src/java/org/apache/cassandra/db/ColumnFamily.java +++ b/src/java/org/apache/cassandra/db/ColumnFamily.java @@ -389,14 +389,6 @@ public abstract class ColumnFamily implements Iterable, IRowCacheEntry return cf1.diff(cf2); } - public void resolve(ColumnFamily cf) - { - // Row _does_ allow null CF objects :( seems a necessary evil for efficiency - if (cf == null) - return; - addAll(cf); - } - public ColumnStats getColumnStats() { long minTimestampSeen = deletionInfo().isLive() ? Long.MAX_VALUE : deletionInfo().minTimestamp(); diff --git a/src/java/org/apache/cassandra/db/Mutation.java b/src/java/org/apache/cassandra/db/Mutation.java index bb7dcefefe..3663380868 100644 --- a/src/java/org/apache/cassandra/db/Mutation.java +++ b/src/java/org/apache/cassandra/db/Mutation.java @@ -191,7 +191,7 @@ public class Mutation implements IMutation // not in the case where it wasn't there indeed. ColumnFamily cf = modifications.put(entry.getKey(), entry.getValue()); if (cf != null) - entry.getValue().resolve(cf); + entry.getValue().addAll(cf); } } diff --git a/src/java/org/apache/cassandra/db/index/composites/CompositesSearcher.java b/src/java/org/apache/cassandra/db/index/composites/CompositesSearcher.java index fad3d506e6..41c9f410c9 100644 --- a/src/java/org/apache/cassandra/db/index/composites/CompositesSearcher.java +++ b/src/java/org/apache/cassandra/db/index/composites/CompositesSearcher.java @@ -274,7 +274,7 @@ public class CompositesSearcher extends SecondaryIndexSearcher if (data == null) data = ArrayBackedSortedColumns.factory.create(baseCfs.metadata); - data.resolve(newData); + data.addAll(newData); columnsCount += dataFilter.lastCounted(); } } diff --git a/test/unit/org/apache/cassandra/db/RowTest.java b/test/unit/org/apache/cassandra/db/RowTest.java index 4a686c5f1a..9a912850ec 100644 --- a/test/unit/org/apache/cassandra/db/RowTest.java +++ b/test/unit/org/apache/cassandra/db/RowTest.java @@ -59,7 +59,7 @@ public class RowTest extends SchemaLoader cf2.addColumn(column("one", "B", 1)); cf2.addColumn(column("two", "C", 1)); - cf1.resolve(cf2); + cf1.addAll(cf2); assert Arrays.equals(cf1.getColumn(CellNames.simpleDense(ByteBufferUtil.bytes("one"))).value().array(), "B".getBytes()); assert Arrays.equals(cf1.getColumn(CellNames.simpleDense(ByteBufferUtil.bytes("two"))).value().array(), "C".getBytes()); }