Deprecate and ignore use_deterministic_table_id

patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-19809

CHANGES.txt

@@ -1,4 +1,5 @@
 5.0.1
+ * Deprecate and ignore use_deterministic_table_id (CASSANDRA-19809)
  * Prioritize built indexes in IndexStatusManager (CASSANDRA-19400)
  * Add java.base/java.lang.reflect among opens for jvm11-client.options (CASSANDRA-19780)
 

NEWS.txt

@@ -276,6 +276,7 @@ Deprecation
       in a future release. A single native port can be used for both encrypted and unencrypted traffic; see CASSANDRA-10559.
       Cluster hosts running with dual native ports were not correctly identified in the system.peers tables and server-sent EVENTs,
       causing clients that encrypt traffic to fail to maintain correct connection pools. For more information, see CASSANDRA-19392.
+    - Deprecated `use_deterministic_table_id` in cassandra.yaml. Table IDs may still be supplied explicitly on CREATE.
 
 4.1
 ===

src/java/org/apache/cassandra/config/Config.java

@@ -123,6 +123,7 @@ public class Config
     public DiskFailurePolicy disk_failure_policy = DiskFailurePolicy.ignore;
     public CommitFailurePolicy commit_failure_policy = CommitFailurePolicy.stop;
 
+    @Deprecated(since = "5.0.1")
     public volatile boolean use_deterministic_table_id = false;
 
     /* initial token in the ring */

src/java/org/apache/cassandra/config/DatabaseDescriptor.java

@@ -1001,6 +1001,8 @@ public class DatabaseDescriptor
                                                            conf.native_transport_min_backoff_on_queue_overload,
                                                            conf.native_transport_max_backoff_on_queue_overload));
 
+        if (conf.use_deterministic_table_id)
+            logger.warn("use_deterministic_table_id is deprecated and will be ignored in a future release.");
     }
 
     @VisibleForTesting