natas_hw
/
cassandra
mirror of https://github.com/apache/cassandra
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Resolve the trigger constructor once when loading trigger classes

This commit is contained in:
Jeremiah Jordan 2026-07-16 07:23:32 -05:00
parent a94e4c5192
commit 69c103e399
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/java/org/apache/cassandra/triggers/TriggerExecutor.java
View File

@ -292,13 +292,20 @@ public class TriggerExecutor
// CreateTriggerStatement#apply.
// Check that triggerClass is available on the classpath, but do not initialize the class since that would
// execute static blocks.
Class<? extends ITrigger> trigger;
Class<? extends ITrigger> trigger = loadTriggerClassWithoutInitialization(triggerClass);
// Validate that the class exposes a public no-argument constructor before it is accepted.
trigger.getConstructor();
return trigger;
}
private Class<? extends ITrigger> loadTriggerClassWithoutInitialization(String triggerClass) throws Exception
{
try
{
trigger = FBUtilities.classForNameWithoutInitialization(triggerClass,
"trigger",
ITrigger.class,
customClassLoader);
return FBUtilities.classForNameWithoutInitialization(triggerClass,
"trigger",
ITrigger.class,
customClassLoader);
}
catch (ConfigurationException e)
{
@ -306,8 +313,6 @@ public class TriggerExecutor
throw (ClassNotFoundException) e.getCause();
throw e;
}
trigger.getConstructor();
return trigger;
}
public synchronized ITrigger loadTriggerInstance(String triggerClass) throws Exception
@ -321,6 +326,6 @@ public class TriggerExecutor
// double check.
if (cachedTriggers.get(triggerClass) != null)
return cachedTriggers.get(triggerClass);
return loadTriggerClass(triggerClass).getConstructor().newInstance();
return loadTriggerClassWithoutInitialization(triggerClass).getConstructor().newInstance();
}
}